roster-server 2.3.2 → 2.3.6

package/docs/generated/git-greenlock-notify-fallback-v2-3-4.md

@@ -0,0 +1,7 @@
+---
+id: oyzcq7vmk6
+type: work-log
+title: Committed and pushed greenlock notify fix
+created: '2026-03-16 15:55:18'
+---
+Created commit bfdb456 on master and pushed to origin/master. Changes: improved notify() detail-to-message normalization in index.js to handle Error objects, undefined/non-serializable inputs, and fallback to `[event] (no details)`; bumped package version to 2.3.4; added docs/generated/greenlock-notify-empty-details.md.

package/docs/generated/greenlock-notify-domain-context.md

@@ -0,0 +1,12 @@
+---
+id: blpic0aj8a
+type: bugfix
+title: 'Bugfix: Include domain in Greenlock notify logs'
+created: '2026-03-16 16:25:57'
+---
+# Bug: Greenlock notify errors lacked domain context
+
+**Symptom**: Timeout/certificate errors in `notify` logs did not clearly indicate which domain triggered the failure.
+**Root cause**: `notify` logged only the normalized message and omitted available domain fields from Greenlock/ACME details.
+**Solution**: Added domain extraction in `notify` from `subject`, `servername`, `domain`, `hostname`, `host`, `altnames`, `domains`, and `identifier.value`; prepends `[domain:<value>]` to log messages.
+**Location**: index.js Greenlock `notify` callback.

package/docs/generated/greenlock-notify-empty-details.md

@@ -0,0 +1,12 @@
+---
+id: zskjlbshg2
+type: bugfix
+title: 'Bugfix: Harden Greenlock notify logging fallback'
+created: '2026-03-16 15:54:09'
+---
+# Bug: Greenlock notify emitted unhelpful error logs
+
+**Symptom**: Log lines such as `roster:error ----` appeared, indicating error events with missing/invalid details.
+**Root cause**: `notify` used `details?.message ?? JSON.stringify(details)`, which could produce `undefined` (or throw on non-serializable data), resulting in low-signal logger output.
+**Solution**: Added robust message normalization in `notify` to handle strings, `Error` instances, plain objects, and serialization failures, then fallback to `[{event}] (no details)` when empty.
+**Location**: index.js notify callback inside Greenlock options.

package/index.js

@@ -736,7 +736,51 @@ class Roster {
             cluster: this.cluster,
             staging: this.staging,
             notify: (event, details) => {
-                const msg = typeof details === 'string' ? details : (details?.message ?? JSON.stringify(details));
+                const eventDomain = (() => {
+                    if (!details || typeof details !== 'object') return null;
+
+                    const directKeys = ['subject', 'servername', 'domain', 'hostname', 'host'];
+                    for (const key of directKeys) {
+                        if (typeof details[key] === 'string' && details[key].trim()) {
+                            return details[key].trim().toLowerCase();
+                        }
+                    }
+
+                    if (Array.isArray(details.altnames) && details.altnames.length > 0) {
+                        const alt = details.altnames.find(name => typeof name === 'string' && name.trim());
+                        if (alt) return alt.trim().toLowerCase();
+                    }
+
+                    if (Array.isArray(details.domains) && details.domains.length > 0) {
+                        const domain = details.domains.find(name => typeof name === 'string' && name.trim());
+                        if (domain) return domain.trim().toLowerCase();
+                    }
+
+                    if (details.identifier && typeof details.identifier.value === 'string' && details.identifier.value.trim()) {
+                        return details.identifier.value.trim().toLowerCase();
+                    }
+
+                    return null;
+                })();
+
+                let msg;
+                if (typeof details === 'string') {
+                    msg = details;
+                } else if (details instanceof Error) {
+                    msg = details.stack || details.message;
+                } else if (details && typeof details === 'object' && typeof details.message === 'string') {
+                    msg = details.message;
+                } else {
+                    try {
+                        msg = JSON.stringify(details);
+                    } catch {
+                        msg = String(details);
+                    }
+                }
+                if (!msg || msg === 'undefined') msg = `[${event}] (no details)`;
+                if (eventDomain && !msg.includes(`[domain:${eventDomain}]`)) {
+                    msg = `[domain:${eventDomain}] ${msg}`;
+                }
                 // Suppress known benign warnings from ACME when using acme-dns-01-cli
                 if (event === 'warning' && typeof msg === 'string') {
                     if (/acme-dns-01-cli.*(incorrect function signatures|deprecated use of callbacks)/i.test(msg)) return;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "roster-server",
-    "version": "2.3.2",
+    "version": "2.3.6",
     "description": "👾 RosterServer - A domain host router to host multiple HTTPS.",
     "main": "index.js",
     "scripts": {