roster-server 2.3.0 → 2.3.4

package/docs/generated/greenlock-notify-empty-details.md

@@ -0,0 +1,12 @@
+---
+id: zskjlbshg2
+type: bugfix
+title: 'Bugfix: Harden Greenlock notify logging fallback'
+created: '2026-03-16 15:54:09'
+---
+# Bug: Greenlock notify emitted unhelpful error logs
+
+**Symptom**: Log lines such as `roster:error ----` appeared, indicating error events with missing/invalid details.
+**Root cause**: `notify` used `details?.message ?? JSON.stringify(details)`, which could produce `undefined` (or throw on non-serializable data), resulting in low-signal logger output.
+**Solution**: Added robust message normalization in `notify` to handle strings, `Error` instances, plain objects, and serialization failures, then fallback to `[{event}] (no details)` when empty.
+**Location**: index.js notify callback inside Greenlock options.

package/index.js

@@ -736,7 +736,21 @@ class Roster {
             cluster: this.cluster,
             staging: this.staging,
             notify: (event, details) => {
-                const msg = typeof details === 'string' ? details : (details?.message ?? JSON.stringify(details));
+                let msg;
+                if (typeof details === 'string') {
+                    msg = details;
+                } else if (details instanceof Error) {
+                    msg = details.stack || details.message;
+                } else if (details && typeof details === 'object' && typeof details.message === 'string') {
+                    msg = details.message;
+                } else {
+                    try {
+                        msg = JSON.stringify(details);
+                    } catch {
+                        msg = String(details);
+                    }
+                }
+                if (!msg || msg === 'undefined') msg = `[${event}] (no details)`;
                 // Suppress known benign warnings from ACME when using acme-dns-01-cli
                 if (event === 'warning' && typeof msg === 'string') {
                     if (/acme-dns-01-cli.*(incorrect function signatures|deprecated use of callbacks)/i.test(msg)) return;

package/lib/static-site-handler.js

@@ -97,14 +97,24 @@ function createStaticHandler(rootPath) {
             }
 
             const stat = fs.statSync(filePath);
+            let servePath = filePath;
             if (!stat.isFile()) {
-                res.writeHead(404, { 'Content-Type': 'text/plain' });
-                res.end('Not Found');
-                return;
+                if (!stat.isDirectory()) {
+                    res.writeHead(404, { 'Content-Type': 'text/plain' });
+                    res.end('Not Found');
+                    return;
+                }
+                const indexInDir = path.join(filePath, 'index.html');
+                if (!fs.existsSync(indexInDir) || !fs.statSync(indexInDir).isFile()) {
+                    res.writeHead(404, { 'Content-Type': 'text/plain' });
+                    res.end('Not Found');
+                    return;
+                }
+                servePath = indexInDir;
             }
 
-            const contentType = getContentType(filePath);
-            const content = fs.readFileSync(filePath);
+            const contentType = getContentType(servePath);
+            const content = fs.readFileSync(servePath);
 
             res.writeHead(200, {
                 'Content-Type': contentType,

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "roster-server",
-    "version": "2.3.0",
+    "version": "2.3.4",
     "description": "👾 RosterServer - A domain host router to host multiple HTTPS.",
     "main": "index.js",
     "scripts": {

package/test/roster-server.test.js

@@ -626,6 +626,33 @@ describe('Roster loadSites', () => {
             fs.rmSync(tmpDir, { recursive: true, force: true });
         }
     });
+
+    it('static site serves index.html for subpath directory (/en/)', async () => {
+        const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'roster-test-'));
+        const wwwPath = path.join(tmpDir, 'www');
+        const siteDir = path.join(wwwPath, 'subpath.example');
+        fs.mkdirSync(siteDir, { recursive: true });
+        fs.writeFileSync(path.join(siteDir, 'index.html'), '<html>root</html>', 'utf8');
+        const enDir = path.join(siteDir, 'en');
+        fs.mkdirSync(enDir, { recursive: true });
+        fs.writeFileSync(path.join(enDir, 'index.html'), '<html><body>en page</body></html>', 'utf8');
+        const roster = new Roster({ wwwPath, local: true, minLocalPort: 19220, maxLocalPort: 19229 });
+        try {
+            await roster.start();
+            const port = roster.domainPorts['subpath.example'];
+            assert.ok(typeof port === 'number');
+            await new Promise((r) => setTimeout(r, 50));
+            const resultSlash = await httpGet('localhost', port, '/en/');
+            assert.strictEqual(resultSlash.statusCode, 200);
+            assert.ok(resultSlash.body.includes('en page'));
+            const resultNoSlash = await httpGet('localhost', port, '/en');
+            assert.strictEqual(resultNoSlash.statusCode, 200);
+            assert.ok(resultNoSlash.body.includes('en page'));
+        } finally {
+            closePortServers(roster);
+            fs.rmSync(tmpDir, { recursive: true, force: true });
+        }
+    });
 });
 
 describe('Roster generateConfigJson', () => {