roqa 0.0.3 → 0.0.4

package/CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.0.4] - 2026-01-10
+
+### Fixed
+
+- Fixed `set()` calls not notifying subscribers when using cleanup-captured `bind()` calls inside `<For>` and `<Show>` blocks
+  - The `findBindCallbacks` function in the inliner now correctly detects `bind()` calls in variable declarations (`const _cleanup_N = bind(...)`) in addition to expression statements
+  - This ensures the effect loop is generated for cells with non-inlined bind callbacks
+
 ## [0.0.3] - 2026-01-10
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "roqa",
-  "version": "0.0.3",
+  "version": "0.0.4",
   "description": "Roqa is a reactive UI framework",
   "keywords": [
     "UI",

package/src/compiler/transforms/inline-get.js

@@ -463,61 +463,79 @@ function findBindCallbacks(ast, code) {
 	// Track ref numbers per cell
 	const refCounters = new Map();
 
-	traverse(ast, {
-		ExpressionStatement(path) {
-			const expr = path.node.expression;
-			if (!isBindCall(expr)) return;
+	/**
+	 * Process a bind() call expression and add to bindCallbacks
+	 * @param {object} bindExpr - The bind() CallExpression node
+	 * @param {number} stmtStart - Start position of containing statement
+	 * @param {number} stmtEnd - End position of containing statement
+	 */
+	function processBindCall(bindExpr, stmtStart, stmtEnd) {
+		const cellArg = bindExpr.arguments[0];
+		const callbackArg = bindExpr.arguments[1];
+		if (!cellArg || !callbackArg) return;
+
+		// Get callback info
+		if (
+			callbackArg.type !== "ArrowFunctionExpression" &&
+			callbackArg.type !== "FunctionExpression"
+		) {
+			return;
+		}
 
-			const cellArg = expr.arguments[0];
-			const callbackArg = expr.arguments[1];
-			if (!cellArg || !callbackArg) return;
+		const cellCode = code.slice(cellArg.start, cellArg.end);
+		const paramName = callbackArg.params[0]?.name || "v";
 
-			// Get callback info
-			if (
-				callbackArg.type !== "ArrowFunctionExpression" &&
-				callbackArg.type !== "FunctionExpression"
-			) {
-				return;
-			}
+		// Get the callback body
+		const body = callbackArg.body;
+		let bodyCode;
+		if (body.type === "BlockStatement") {
+			// Extract statements from block, removing braces
+			bodyCode = code.slice(body.start + 1, body.end - 1).trim();
+		} else {
+			// Expression body
+			bodyCode = code.slice(body.start, body.end);
+		}
 
-			const cellCode = code.slice(cellArg.start, cellArg.end);
-			const paramName = callbackArg.params[0]?.name || "v";
+		// Find element variables used in the callback (e.g., p_1_text, tr_1)
+		// Also detect closure variables that would prevent inlining
+		const { elementVars, closureVars } = findElementVariables(body, code, paramName, cellCode);
+		const hasClosureVars = closureVars.size > 0;
 
-			// Get the callback body
-			const body = callbackArg.body;
-			let bodyCode;
-			if (body.type === "BlockStatement") {
-				// Extract statements from block, removing braces
-				bodyCode = code.slice(body.start + 1, body.end - 1).trim();
-			} else {
-				// Expression body
-				bodyCode = code.slice(body.start, body.end);
-			}
+		// Get or create ref number for this cell
+		const currentRef = refCounters.get(cellCode) || 0;
+		const refNum = currentRef + 1;
+		refCounters.set(cellCode, refNum);
 
-			// Find element variables used in the callback (e.g., p_1_text, tr_1)
-			// Also detect closure variables that would prevent inlining
-			const { elementVars, closureVars } = findElementVariables(body, code, paramName, cellCode);
-			const hasClosureVars = closureVars.size > 0;
+		// Store bind callback info
+		if (!bindCallbacks.has(cellCode)) {
+			bindCallbacks.set(cellCode, []);
+		}
 
-			// Get or create ref number for this cell
-			const currentRef = refCounters.get(cellCode) || 0;
-			const refNum = currentRef + 1;
-			refCounters.set(cellCode, refNum);
+		bindCallbacks.get(cellCode).push({
+			callbackBody: bodyCode,
+			elementVars,
+			refNum,
+			paramName,
+			statementStart: stmtStart,
+			statementEnd: stmtEnd,
+			hasClosureVars,
+		});
+	}
 
-			// Store bind callback info
-			if (!bindCallbacks.has(cellCode)) {
-				bindCallbacks.set(cellCode, []);
+	traverse(ast, {
+		// Handle: bind(cell, callback);
+		ExpressionStatement(path) {
+			const expr = path.node.expression;
+			if (!isBindCall(expr)) return;
+			processBindCall(expr, path.node.start, path.node.end);
+		},
+		// Handle: const _cleanup_N = bind(cell, callback);
+		VariableDeclaration(path) {
+			for (const decl of path.node.declarations) {
+				if (decl.init && isBindCall(decl.init)) {
+					processBindCall(decl.init, path.node.start, path.node.end);
+				}
 			}
-
-			bindCallbacks.get(cellCode).push({
-				callbackBody: bodyCode,
-				elementVars,
-				refNum,
-				paramName,
-				statementStart: path.node.start,
-				statementEnd: path.node.end,
-				hasClosureVars,
-			});
 		},
 		noScope: true,
 	});