rollbridge 0.1.10 → 0.1.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "rollbridge",
-  "version": "0.1.10",
+  "version": "0.1.11",
   "description": "Zero-downtime process supervisor and local traffic switcher for deploy-managed apps.",
   "keywords": [
     "deploy",
@@ -27,10 +27,11 @@
   },
   "scripts": {
     "all-checks": "npm run typecheck && npm run lint && npm test",
-    "lint": "eslint",
+    "lint": "npm run eslint && npm run typecheck",
     "release:patch": "release-patch",
     "test": "node --test test/*.test.js",
-    "typecheck": "tsc --noEmit"
+    "typecheck": "tsc --noEmit",
+    "eslint": "eslint"
   },
   "engines": {
     "node": ">=20"

package/src/release-group.js

@@ -91,8 +91,9 @@ export default class ReleaseGroup extends EventEmitter {
       }
     } catch (error) {
       this.state = "failed"
-      this.logStartupFailure(error instanceof Error ? error : String(error))
+      this.logStartupFailure(error instanceof Error ? error : String(error), {phase: "before cleanup"})
       await this.stop()
+      this.logStartupFailure(error instanceof Error ? error : String(error), {phase: "after cleanup"})
       throw error
     }
   }
@@ -125,13 +126,15 @@ export default class ReleaseGroup extends EventEmitter {
   }
 
   /**
-   * Logs process diagnostics before failed startup cleanup stops and removes the release processes.
+   * Logs process diagnostics around failed startup cleanup.
    * @param {Error | string} error - Startup failure.
+   * @param {{phase: string}} options - Diagnostic phase.
    * @returns {void}
    */
-  logStartupFailure(error) {
+  logStartupFailure(error, {phase}) {
     this.logger("release startup failed", {
       error: error instanceof Error ? error.message : error,
+      phase,
       releaseId: this.releaseId
     })
 
@@ -143,6 +146,7 @@ export default class ReleaseGroup extends EventEmitter {
         exitCode: status.exitCode ?? null,
         exitSignal: status.exitSignal ?? null,
         logs: status.logs,
+        phase,
         pid: status.pid ?? null,
         processId: status.id,
         releaseId: this.releaseId,

package/test/rollbridge.test.js

@@ -123,8 +123,8 @@ test("wildcard proxy bind host targets release processes through loopback", asyn
   }
 })
 
-test("failed release startup logs process output before cleanup", async () => {
-  const fixture = await createFixture({webCommand: `${JSON.stringify(process.execPath)} -e "console.log('startup stdout'); console.error('startup stderr'); const http = require('node:http'); http.createServer((_request, response) => { response.writeHead(500); response.end('bad') }).listen(Number(process.env.ROLLBRIDGE_PORT), '127.0.0.1')"`, webHealthTimeoutMs: 500})
+test("failed release startup logs process output and cleanup status", async () => {
+  const fixture = await createFixture({handoffService: true, webCommand: `${JSON.stringify(process.execPath)} -e "console.log('startup stdout'); console.error('startup stderr'); const http = require('node:http'); http.createServer((_request, response) => { response.writeHead(500); response.end('bad') }).listen(Number(process.env.ROLLBRIDGE_PORT), '127.0.0.1')"`, webHealthTimeoutMs: 500})
   /** @type {Array<{data?: Record<string, import("../src/json.js").JsonValue>, message: string}>} */
   const logs = []
   const daemon = new RollbridgeDaemon({
@@ -140,13 +140,22 @@ test("failed release startup logs process output before cleanup", async () => {
       /Health check failed/
     )
 
-    const processStatusLog = logs.find((entry) => entry.message === "release startup process status" && entry.data?.processId === "web")
+    const processStatusLog = logs.find((entry) => entry.message === "release startup process status" && entry.data?.phase === "before cleanup" && entry.data?.processId === "web")
+    const cleanupProcessStatusLog = logs.find((entry) => entry.message === "release startup process status" && entry.data?.phase === "after cleanup" && entry.data?.processId === "web")
+    const handoffServiceStatusLog = logs.find((entry) => entry.message === "release startup process status" && entry.data?.phase === "after cleanup" && entry.data?.processId === "beacon")
 
     assert.ok(processStatusLog, "expected failed web process diagnostics to be logged")
     assert.ok(processStatusLog.data, "expected diagnostic data")
     assert.ok(Array.isArray(processStatusLog.data.logs), "expected retained process output in diagnostics")
     assert.ok(processStatusLog.data.logs.some((entry) => typeof entry === "object" && entry && "line" in entry && entry.line === "startup stdout"))
     assert.ok(processStatusLog.data.logs.some((entry) => typeof entry === "object" && entry && "line" in entry && entry.line === "startup stderr"))
+    assert.equal(processStatusLog.data.state, "running")
+    assert.ok(cleanupProcessStatusLog, "expected failed web cleanup diagnostics to be logged")
+    assert.equal(cleanupProcessStatusLog.data?.state, "stopped")
+    assert.equal(cleanupProcessStatusLog.data?.exitSignal, "SIGTERM")
+    assert.ok(handoffServiceStatusLog, "expected handoff service cleanup diagnostics to be logged")
+    assert.equal(handoffServiceStatusLog.data?.state, "stopped")
+    assert.equal(handoffServiceStatusLog.data?.exitSignal, "SIGTERM")
   } finally {
     await daemon.shutdown()
     await fs.rm(fixture.root, {force: true, recursive: true})