rollbar 2.23.0 → 2.25.0

package/test/server.transforms.test.js

@@ -21,15 +21,31 @@ async function wait(ms) {
   });
 }
 
-async function throwInTypescriptFile(rollbar, callback) {
+async function throwInScriptFile(rollbar, filepath, callback) {
   setTimeout(function () {
-    var error = require('../examples/node-typescript/dist/index');
+    var error = require(filepath);
     error();
   }, 10);
   await wait(500);
   callback(rollbar);
 }
 
+var nodeVersion = function () {
+  var version = process.versions.node.split('.');
+
+  return [
+    parseInt(version[0]),
+    parseInt(version[1]),
+    parseInt(version[2]),
+  ];
+}();
+
+var isMinNodeVersion = function(major, minor) {
+  return (
+    nodeVersion[0] > major || (nodeVersion[0] === major && nodeVersion[1] >= minor)
+  );
+}
+
 vows.describe('transforms')
   .addBatch({
     'baseData': {
@@ -256,8 +272,8 @@ vows.describe('transforms')
     }
   })
   .addBatch({
-    'handleItemWithError': {
-      'nodeSourceMaps': {
+    'nodeSourceMaps': {
+      'with original source present': {
         topic: function() {
           var Rollbar = new rollbar({
             accessToken: 'abc123',
@@ -267,9 +283,10 @@ vows.describe('transforms')
           var queue = Rollbar.client.notifier.queue;
           Rollbar.addItemStub = sinon.stub(queue, 'addItem');
 
-          throwInTypescriptFile(Rollbar, this.callback);
+          throwInScriptFile(Rollbar, '../examples/node-typescript/dist/index',
+            this.callback);
         },
-        'should map the stack': function(r) {
+        'should map the stack with context': function(r) {
           var addItem = r.addItemStub;
 
           assert.isTrue(addItem.called);
@@ -279,8 +296,15 @@ vows.describe('transforms')
             assert.equal(frame.lineno, 10);
             assert.equal(frame.colno, 22);
             assert.equal(frame.code, "  var error = <Error> new CustomError('foo');");
+            assert.equal(frame.context.pre[0], '    }');
+            assert.equal(frame.context.pre[1], '  }');
+            assert.equal(frame.context.pre[2],
+              '  // TypeScript code snippet will include `<Error>`');
+            assert.equal(frame.context.post[0], '  throw error;');
+            assert.equal(frame.context.post[1], '}');
 
-            var sourceMappingURLs = addItem.getCall(0).args[0].notifier.diagnostic.node_source_maps.source_mapping_urls;
+            var sourceMappingURLs = addItem.getCall(0).args[0].notifier.diagnostic
+              .node_source_maps.source_mapping_urls;
             var urls = Object.keys(sourceMappingURLs);
             assert.ok(urls[0].includes('index.js'));
             assert.ok(sourceMappingURLs[urls[0]].includes('index.js.map'));
@@ -295,8 +319,55 @@ vows.describe('transforms')
             assert.ok(sourceMappingURLs[urls[2]].includes('not found'));
           }
           addItem.reset();
+        }
+      }
+    }
+  })
+  .addBatch({
+    'nodeSourceMaps': {
+      'using sourcesContent': {
+        topic: function() {
+          var Rollbar = new rollbar({
+            accessToken: 'abc123',
+            captureUncaught: true,
+            nodeSourceMaps: true
+          });
+          var queue = Rollbar.client.notifier.queue;
+          Rollbar.addItemStub = sinon.stub(queue, 'addItem');
+
+          throwInScriptFile(Rollbar, '../examples/node-dist/index', this.callback);
         },
-      },
+        'should map the stack with context': function(r) {
+          var addItem = r.addItemStub;
+
+          assert.isTrue(addItem.called);
+          if (addItem.called) {
+            var frame = addItem.getCall(0).args[0].body.trace_chain[0].frames.pop();
+            assert.ok(frame.filename.includes('src/index.ts'));
+            assert.equal(frame.lineno, 10);
+            assert.equal(frame.colno, 22);
+            assert.equal(frame.code, "  var error = <Error> new CustomError('foo');");
+            assert.equal(frame.context.pre[0], '    }');
+            assert.equal(frame.context.pre[1], '  }');
+            assert.equal(frame.context.pre[2],
+              '  // TypeScript code snippet will include `<Error>`');
+            assert.equal(frame.context.post[0], '  throw error;');
+            assert.equal(frame.context.post[1], '}');
+
+            var sourceMappingURLs = addItem.getCall(0).args[0].notifier.diagnostic
+              .node_source_maps.source_mapping_urls;
+            var urls = Object.keys(sourceMappingURLs);
+            assert.ok(urls.length === 1);
+            assert.ok(urls[0].includes('index.js'));
+            assert.ok(sourceMappingURLs[urls[0]].includes('index.js.map'));
+          }
+          addItem.reset();
+        }
+      }
+    }
+  })
+  .addBatch({
+    'handleItemWithError': {
       'options': {
         'anything': {
           topic: function() {
@@ -439,7 +510,42 @@ vows.describe('transforms')
                 assert.equal(item.data.custom.err1, 'nested context');
                 assert.equal(item.data.custom.err2, 'error context');
               }
-            }
+            },
+            'with an error cause': {
+              topic: function (options) {
+                var test = function() {
+                  var x = thisVariableIsNotDefined;
+                };
+                var err;
+                try {
+                  test();
+                } catch (e) {
+                  err = new Error('cause message', { cause: e });
+                  e.rollbarContext = { err1: 'cause context' };
+                  err.rollbarContext = { err2: 'error context' };
+                }
+                var item = {
+                  data: {body: {}},
+                  err: err
+                };
+                t.handleItemWithError(item, options, this.callback);
+              },
+              'should not error': function(err, item) {
+                assert.ifError(err);
+              },
+              'should have the right data in the trace_chain': function(err, item) {
+                // Error cause was introduced in Node 16.9.
+                if (!isMinNodeVersion(16, 9)) return;
+
+                var trace_chain = item.stackInfo;
+                assert.lengthOf(trace_chain, 2);
+                assert.equal(trace_chain[0].exception.class, 'Error');
+                assert.equal(trace_chain[0].exception.message, 'cause message');
+                assert.equal(trace_chain[1].exception.class, 'ReferenceError');
+                assert.equal(item.data.custom.err1, 'cause context');
+                assert.equal(item.data.custom.err2, 'error context');
+              }
+            },
           }
         }
       }