roku-debug 0.23.10 → 0.23.12

package/dist/debugProtocol/events/requests/ThreadsRequest.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ThreadsRequest = void 0;
+exports.ThreadRequestFlags = exports.ThreadsRequest = void 0;
+/* eslint-disable no-bitwise */
 const smart_buffer_1 = require("smart-buffer");
 const Constants_1 = require("../../Constants");
 const ProtocolUtil_1 = require("../../ProtocolUtil");
@@ -12,29 +13,50 @@ class ThreadsRequest {
          */
         this.readOffset = undefined;
         this.data = {
-            //common props
             packetLength: undefined,
             requestId: undefined,
             command: Constants_1.Command.Threads
         };
     }
     static fromJson(data) {
+        var _a;
+        var _b;
         const request = new ThreadsRequest();
         ProtocolUtil_1.protocolUtil.loadJson(request, data);
+        //default any missing value to false
+        (_a = (_b = request.data).includeIdentityInfo) !== null && _a !== void 0 ? _a : (_b.includeIdentityInfo = false);
         return request;
     }
     static fromBuffer(buffer) {
         const request = new ThreadsRequest();
         ProtocolUtil_1.protocolUtil.bufferLoaderHelper(request, buffer, 12, (smartBuffer) => {
             ProtocolUtil_1.protocolUtil.loadCommonRequestFields(request, smartBuffer);
+            //the flags field is only present on firmware that supports it; older firmware omits it entirely
+            if (smartBuffer.remaining() >= 4) {
+                const threadsRequestFlags = smartBuffer.readUInt32LE(); // threads_request_flags
+                request.data.includeIdentityInfo = !!(threadsRequestFlags & ThreadRequestFlags.includeIdentityInfo);
+            }
+            else {
+                request.data.includeIdentityInfo = false;
+            }
         });
         return request;
     }
     toBuffer() {
         const smartBuffer = new smart_buffer_1.SmartBuffer();
+        //older firmware doesn't expect the flags field at all, so we only include it when configured.
+        if (this.data.includeIdentityInfo) {
+            let threadsRequestFlags = 0;
+            threadsRequestFlags |= this.data.includeIdentityInfo ? ThreadRequestFlags.includeIdentityInfo : 0;
+            smartBuffer.writeUInt32LE(threadsRequestFlags); // threads_request_flags
+        }
         ProtocolUtil_1.protocolUtil.insertCommonRequestFields(this, smartBuffer);
         return smartBuffer.toBuffer();
     }
 }
 exports.ThreadsRequest = ThreadsRequest;
+var ThreadRequestFlags;
+(function (ThreadRequestFlags) {
+    ThreadRequestFlags[ThreadRequestFlags["includeIdentityInfo"] = 1] = "includeIdentityInfo";
+})(ThreadRequestFlags = exports.ThreadRequestFlags || (exports.ThreadRequestFlags = {}));
 //# sourceMappingURL=ThreadsRequest.js.map

package/dist/debugProtocol/events/requests/ThreadsRequest.js.map

@@ -1 +1 @@
-{"version":3,"file":"ThreadsRequest.js","sourceRoot":"","sources":["../../../../src/debugProtocol/events/requests/ThreadsRequest.ts"],"names":[],"mappings":";;;AAAA,+CAA2C;AAC3C,+CAA0C;AAC1C,qDAAkD;AAGlD,MAAa,cAAc;IAA3B;QAsBW,YAAO,GAAG,KAAK,CAAC;QACvB;;WAEG;QACI,eAAU,GAAW,SAAS,CAAC;QAE/B,SAAI,GAAG;YACV,cAAc;YACd,YAAY,EAAE,SAAmB;YACjC,SAAS,EAAE,SAAmB;YAC9B,OAAO,EAAE,mBAAO,CAAC,OAAO;SAC3B,CAAC;IACN,CAAC;IAhCU,MAAM,CAAC,QAAQ,CAAC,IAA2B;QAC9C,MAAM,OAAO,GAAG,IAAI,cAAc,EAAE,CAAC;QACrC,2BAAY,CAAC,QAAQ,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;QACrC,OAAO,OAAO,CAAC;IACnB,CAAC;IAEM,MAAM,CAAC,UAAU,CAAC,MAAc;QACnC,MAAM,OAAO,GAAG,IAAI,cAAc,EAAE,CAAC;QACrC,2BAAY,CAAC,kBAAkB,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE,EAAE,CAAC,WAAW,EAAE,EAAE;YACjE,2BAAY,CAAC,uBAAuB,CAAC,OAAO,EAAE,WAAW,CAAC,CAAC;QAC/D,CAAC,CAAC,CAAC;QACH,OAAO,OAAO,CAAC;IACnB,CAAC;IAEM,QAAQ;QACX,MAAM,WAAW,GAAG,IAAI,0BAAW,EAAE,CAAC;QACtC,2BAAY,CAAC,yBAAyB,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;QAC1D,OAAO,WAAW,CAAC,QAAQ,EAAE,CAAC;IAClC,CAAC;CAcJ;AAlCD,wCAkCC"}
+{"version":3,"file":"ThreadsRequest.js","sourceRoot":"","sources":["../../../../src/debugProtocol/events/requests/ThreadsRequest.ts"],"names":[],"mappings":";;;AAAA,+BAA+B;AAC/B,+CAA2C;AAC3C,+CAA0C;AAC1C,qDAAkD;AAGlD,MAAa,cAAc;IAA3B;QAqCW,YAAO,GAAG,KAAK,CAAC;QACvB;;WAEG;QACI,eAAU,GAAW,SAAS,CAAC;QAE/B,SAAI,GASP;YACI,YAAY,EAAE,SAAmB;YACjC,SAAS,EAAE,SAAmB;YAC9B,OAAO,EAAE,mBAAO,CAAC,OAAO;SAC3B,CAAC;IACV,CAAC;IAvDU,MAAM,CAAC,QAAQ,CAAC,IAA0D;;;QAC7E,MAAM,OAAO,GAAG,IAAI,cAAc,EAAE,CAAC;QACrC,2BAAY,CAAC,QAAQ,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;QACrC,oCAAoC;QACpC,YAAA,OAAO,CAAC,IAAI,EAAC,mBAAmB,uCAAnB,mBAAmB,GAAK,KAAK,EAAC;QAC3C,OAAO,OAAO,CAAC;IACnB,CAAC;IAEM,MAAM,CAAC,UAAU,CAAC,MAAc;QACnC,MAAM,OAAO,GAAG,IAAI,cAAc,EAAE,CAAC;QACrC,2BAAY,CAAC,kBAAkB,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE,EAAE,CAAC,WAAW,EAAE,EAAE;YACjE,2BAAY,CAAC,uBAAuB,CAAC,OAAO,EAAE,WAAW,CAAC,CAAC;YAC3D,gGAAgG;YAChG,IAAI,WAAW,CAAC,SAAS,EAAE,IAAI,CAAC,EAAE;gBAC9B,MAAM,mBAAmB,GAAG,WAAW,CAAC,YAAY,EAAE,CAAC,CAAC,wBAAwB;gBAChF,OAAO,CAAC,IAAI,CAAC,mBAAmB,GAAG,CAAC,CAAC,CAAC,mBAAmB,GAAG,kBAAkB,CAAC,mBAAmB,CAAC,CAAC;aACvG;iBAAM;gBACH,OAAO,CAAC,IAAI,CAAC,mBAAmB,GAAG,KAAK,CAAC;aAC5C;QACL,CAAC,CAAC,CAAC;QACH,OAAO,OAAO,CAAC;IACnB,CAAC;IAEM,QAAQ;QACX,MAAM,WAAW,GAAG,IAAI,0BAAW,EAAE,CAAC;QACtC,8FAA8F;QAC9F,IAAI,IAAI,CAAC,IAAI,CAAC,mBAAmB,EAAE;YAC/B,IAAI,mBAAmB,GAAG,CAAC,CAAC;YAC5B,mBAAmB,IAAI,IAAI,CAAC,IAAI,CAAC,mBAAmB,CAAC,CAAC,CAAC,kBAAkB,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAC,CAAC;YAClG,WAAW,CAAC,aAAa,CAAC,mBAAmB,CAAC,CAAC,CAAC,wBAAwB;SAC3E;QACD,2BAAY,CAAC,yBAAyB,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;QAC1D,OAAO,WAAW,CAAC,QAAQ,EAAE,CAAC;IAClC,CAAC;CAsBJ;AAzDD,wCAyDC;AAED,IAAY,kBAEX;AAFD,WAAY,kBAAkB;IAC1B,yFAA4B,CAAA;AAChC,CAAC,EAFW,kBAAkB,GAAlB,0BAAkB,KAAlB,0BAAkB,QAE7B"}

package/dist/debugProtocol/events/responses/ThreadsResponse.d.ts

@@ -56,4 +56,16 @@ export interface ThreadInfo {
      * The code causing the stop or failure.
      */
     codeSnippet: string;
+    /**
+     * The ID of the thread (optional for debug protocol version ).
+     */
+    osThreadId?: string;
+    /**
+     * The name of the thread (optional).
+     */
+    name?: string;
+    /**
+     * The type of the thread (optional).
+     */
+    type?: string;
 }

package/dist/debugProtocol/events/responses/ThreadsResponse.js

@@ -42,25 +42,33 @@ class ThreadsResponse {
                 const flags = smartBuffer.readUInt8();
                 thread.isPrimary = (flags & ThreadInfoFlags.isPrimary) > 0;
                 thread.isDetached = (flags & ThreadInfoFlags.isDetached) > 0;
+                const includesIdentityInfo = (flags & ThreadInfoFlags.includesIdentityInfo) > 0;
                 thread.stopReason = Constants_1.StopReasonCode[smartBuffer.readUInt32LE()]; // stop_reason
                 thread.stopReasonDetail = ProtocolUtil_1.protocolUtil.readStringNT(smartBuffer); // stop_reason_detail
                 thread.lineNumber = smartBuffer.readUInt32LE(); // line_number
                 thread.functionName = ProtocolUtil_1.protocolUtil.readStringNT(smartBuffer); // function_name
                 thread.filePath = ProtocolUtil_1.protocolUtil.readStringNT(smartBuffer); // file_path
                 thread.codeSnippet = ProtocolUtil_1.protocolUtil.readStringNT(smartBuffer); // code_snippet
+                if (includesIdentityInfo) {
+                    thread.osThreadId = ProtocolUtil_1.protocolUtil.readStringNT(smartBuffer); // id
+                    thread.name = ProtocolUtil_1.protocolUtil.readStringNT(smartBuffer); // name
+                    thread.type = ProtocolUtil_1.protocolUtil.readStringNT(smartBuffer); // type
+                }
                 response.data.threads.push(thread);
             }
         });
         return response;
     }
     toBuffer() {
-        var _a, _b, _c;
+        var _a, _b, _c, _d, _e, _f, _g, _h;
         const smartBuffer = new smart_buffer_1.SmartBuffer();
         smartBuffer.writeUInt32LE((_b = (_a = this.data.threads) === null || _a === void 0 ? void 0 : _a.length) !== null && _b !== void 0 ? _b : 0); // threads_count
-        for (const thread of (_c = this.data.threads) !== null && _c !== void 0 ? _c : []) {
+        const includesIdentityInfo = (_d = (_c = this.data.threads) === null || _c === void 0 ? void 0 : _c.some(t => t.osThreadId || t.name || t.type)) !== null && _d !== void 0 ? _d : false;
+        for (const thread of (_e = this.data.threads) !== null && _e !== void 0 ? _e : []) {
             let flags = 0;
-            flags |= thread.isPrimary ? 1 : 0;
-            flags |= thread.isDetached ? 2 : 0;
+            flags |= thread.isPrimary ? ThreadInfoFlags.isPrimary : 0;
+            flags |= thread.isDetached ? ThreadInfoFlags.isDetached : 0;
+            flags |= includesIdentityInfo ? ThreadInfoFlags.includesIdentityInfo : 0;
             smartBuffer.writeUInt8(flags); //flags
             //stop_reason is an 8-bit value (same as the other locations in this protocol); however, it is sent in this response as a 32bit value for historical purposes
             smartBuffer.writeUInt32LE(Constants_1.StopReasonCode[thread.stopReason]); // stop_reason
@@ -69,6 +77,11 @@ class ThreadsResponse {
             smartBuffer.writeStringNT(thread.functionName); // function_name
             smartBuffer.writeStringNT(thread.filePath); // file_path
             smartBuffer.writeStringNT(thread.codeSnippet); // code_snippet
+            if (includesIdentityInfo) {
+                smartBuffer.writeStringNT((_f = thread.osThreadId) !== null && _f !== void 0 ? _f : '');
+                smartBuffer.writeStringNT((_g = thread.name) !== null && _g !== void 0 ? _g : '');
+                smartBuffer.writeStringNT((_h = thread.type) !== null && _h !== void 0 ? _h : '');
+            }
         }
         ProtocolUtil_1.protocolUtil.insertCommonResponseFields(this, smartBuffer);
         return smartBuffer.toBuffer();
@@ -79,5 +92,9 @@ var ThreadInfoFlags;
 (function (ThreadInfoFlags) {
     ThreadInfoFlags[ThreadInfoFlags["isPrimary"] = 1] = "isPrimary";
     ThreadInfoFlags[ThreadInfoFlags["isDetached"] = 2] = "isDetached";
+    /**
+     * Does the response include the optional identity info fields (id, name, type)?
+     */
+    ThreadInfoFlags[ThreadInfoFlags["includesIdentityInfo"] = 4] = "includesIdentityInfo";
 })(ThreadInfoFlags || (ThreadInfoFlags = {}));
 //# sourceMappingURL=ThreadsResponse.js.map

package/dist/debugProtocol/events/responses/ThreadsResponse.js.map

@@ -1 +1 @@
-{"version":3,"file":"ThreadsResponse.js","sourceRoot":"","sources":["../../../../src/debugProtocol/events/responses/ThreadsResponse.ts"],"names":[],"mappings":";;;AAAA,+BAA+B;AAC/B,+CAA2C;AAE3C,+CAA4D;AAC5D,qDAAkD;AAElD,MAAa,eAAe;IAA5B;QA2DW,YAAO,GAAG,KAAK,CAAC;QAEhB,eAAU,GAAG,CAAC,CAAC;QAEf,SAAI,GAAG;YACV;;;;eAIG;YACH,OAAO,EAAE,SAAyB;YAElC,kBAAkB;YAClB,YAAY,EAAE,SAAmB;YACjC,SAAS,EAAE,SAAmB;YAC9B,SAAS,EAAE,qBAAS,CAAC,EAAE;SAC1B,CAAC;IACN,CAAC;IA3EU,MAAM,CAAC,QAAQ,CAAC,IAGtB;;;QACG,MAAM,QAAQ,GAAG,IAAI,eAAe,EAAE,CAAC;QACvC,2BAAY,CAAC,QAAQ,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;QACtC,YAAA,QAAQ,CAAC,IAAI,EAAC,OAAO,uCAAP,OAAO,GAAK,EAAE,EAAC;QAC7B,OAAO,QAAQ,CAAC;IACpB,CAAC;IAEM,MAAM,CAAC,UAAU,CAAC,MAAc;QACnC,MAAM,QAAQ,GAAG,IAAI,eAAe,EAAE,CAAC;QACvC,2BAAY,CAAC,kBAAkB,CAAC,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,CAAC,WAAwB,EAAE,EAAE;YAC/E,2BAAY,CAAC,wBAAwB,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;YAE7D,MAAM,YAAY,GAAG,WAAW,CAAC,YAAY,EAAE,CAAC,CAAC,gBAAgB;YAEjE,QAAQ,CAAC,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;YAE3B,4BAA4B;YAC5B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,YAAY,EAAE,CAAC,EAAE,EAAE;gBACnC,MAAM,MAAM,GAAG,EAAgB,CAAC;gBAChC,MAAM,KAAK,GAAG,WAAW,CAAC,SAAS,EAAE,CAAC;gBACtC,MAAM,CAAC,SAAS,GAAG,CAAC,KAAK,GAAG,eAAe,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC;gBAC3D,MAAM,CAAC,UAAU,GAAG,CAAC,KAAK,GAAG,eAAe,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC;gBAC7D,MAAM,CAAC,UAAU,GAAG,0BAAc,CAAC,WAAW,CAAC,YAAY,EAAE,CAAe,CAAC,CAAC,cAAc;gBAC5F,MAAM,CAAC,gBAAgB,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,qBAAqB;gBACvF,MAAM,CAAC,UAAU,GAAG,WAAW,CAAC,YAAY,EAAE,CAAC,CAAC,cAAc;gBAC9D,MAAM,CAAC,YAAY,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,gBAAgB;gBAC9E,MAAM,CAAC,QAAQ,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,YAAY;gBACtE,MAAM,CAAC,WAAW,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,eAAe;gBAE5E,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;aACtC;QACL,CAAC,CAAC,CAAC;QACH,OAAO,QAAQ,CAAC;IACpB,CAAC;IAEM,QAAQ;;QACX,MAAM,WAAW,GAAG,IAAI,0BAAW,EAAE,CAAC;QACtC,WAAW,CAAC,aAAa,CAAC,MAAA,MAAA,IAAI,CAAC,IAAI,CAAC,OAAO,0CAAE,MAAM,mCAAI,CAAC,CAAC,CAAC,CAAC,gBAAgB;QAC3E,KAAK,MAAM,MAAM,IAAI,MAAA,IAAI,CAAC,IAAI,CAAC,OAAO,mCAAI,EAAE,EAAE;YAC1C,IAAI,KAAK,GAAG,CAAC,CAAC;YACd,KAAK,IAAI,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;YAClC,KAAK,IAAI,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;YACnC,WAAW,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO;YACtC,6JAA6J;YAC7J,WAAW,CAAC,aAAa,CAAC,0BAAc,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,cAAc;YAC5E,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,CAAC,qBAAqB;YACzE,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,cAAc;YAC5D,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC,CAAC,gBAAgB;YAChE,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,YAAY;YACxD,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,eAAe;SACjE;QACD,2BAAY,CAAC,0BAA0B,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;QAC3D,OAAO,WAAW,CAAC,QAAQ,EAAE,CAAC;IAClC,CAAC;CAmBJ;AA5ED,0CA4EC;AAqCD,IAAK,eAGJ;AAHD,WAAK,eAAe;IAChB,+DAAgB,CAAA;IAChB,iEAAiB,CAAA;AACrB,CAAC,EAHI,eAAe,KAAf,eAAe,QAGnB"}
+{"version":3,"file":"ThreadsResponse.js","sourceRoot":"","sources":["../../../../src/debugProtocol/events/responses/ThreadsResponse.ts"],"names":[],"mappings":";;;AAAA,+BAA+B;AAC/B,+CAA2C;AAE3C,+CAA4D;AAC5D,qDAAkD;AAElD,MAAa,eAAe;IAA5B;QA2EW,YAAO,GAAG,KAAK,CAAC;QAEhB,eAAU,GAAG,CAAC,CAAC;QAEf,SAAI,GAAG;YACV;;;;eAIG;YACH,OAAO,EAAE,SAAyB;YAElC,kBAAkB;YAClB,YAAY,EAAE,SAAmB;YACjC,SAAS,EAAE,SAAmB;YAC9B,SAAS,EAAE,qBAAS,CAAC,EAAE;SAC1B,CAAC;IACN,CAAC;IA3FU,MAAM,CAAC,QAAQ,CAAC,IAGtB;;;QACG,MAAM,QAAQ,GAAG,IAAI,eAAe,EAAE,CAAC;QACvC,2BAAY,CAAC,QAAQ,CAAC,QAAQ,EAAE,IAAI,CAAC,CAAC;QACtC,YAAA,QAAQ,CAAC,IAAI,EAAC,OAAO,uCAAP,OAAO,GAAK,EAAE,EAAC;QAC7B,OAAO,QAAQ,CAAC;IACpB,CAAC;IAEM,MAAM,CAAC,UAAU,CAAC,MAAc;QACnC,MAAM,QAAQ,GAAG,IAAI,eAAe,EAAE,CAAC;QACvC,2BAAY,CAAC,kBAAkB,CAAC,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,CAAC,WAAwB,EAAE,EAAE;YAC/E,2BAAY,CAAC,wBAAwB,CAAC,QAAQ,EAAE,WAAW,CAAC,CAAC;YAE7D,MAAM,YAAY,GAAG,WAAW,CAAC,YAAY,EAAE,CAAC,CAAC,gBAAgB;YAEjE,QAAQ,CAAC,IAAI,CAAC,OAAO,GAAG,EAAE,CAAC;YAE3B,4BAA4B;YAC5B,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,YAAY,EAAE,CAAC,EAAE,EAAE;gBACnC,MAAM,MAAM,GAAG,EAAgB,CAAC;gBAChC,MAAM,KAAK,GAAG,WAAW,CAAC,SAAS,EAAE,CAAC;gBACtC,MAAM,CAAC,SAAS,GAAG,CAAC,KAAK,GAAG,eAAe,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC;gBAC3D,MAAM,CAAC,UAAU,GAAG,CAAC,KAAK,GAAG,eAAe,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC;gBAC7D,MAAM,oBAAoB,GAAG,CAAC,KAAK,GAAG,eAAe,CAAC,oBAAoB,CAAC,GAAG,CAAC,CAAC;gBAChF,MAAM,CAAC,UAAU,GAAG,0BAAc,CAAC,WAAW,CAAC,YAAY,EAAE,CAAe,CAAC,CAAC,cAAc;gBAC5F,MAAM,CAAC,gBAAgB,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,qBAAqB;gBACvF,MAAM,CAAC,UAAU,GAAG,WAAW,CAAC,YAAY,EAAE,CAAC,CAAC,cAAc;gBAC9D,MAAM,CAAC,YAAY,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,gBAAgB;gBAC9E,MAAM,CAAC,QAAQ,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,YAAY;gBACtE,MAAM,CAAC,WAAW,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,eAAe;gBAE5E,IAAI,oBAAoB,EAAE;oBACtB,MAAM,CAAC,UAAU,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,KAAK;oBACjE,MAAM,CAAC,IAAI,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,OAAO;oBAC7D,MAAM,CAAC,IAAI,GAAG,2BAAY,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,CAAC,OAAO;iBAChE;gBAED,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;aACtC;QACL,CAAC,CAAC,CAAC;QACH,OAAO,QAAQ,CAAC;IACpB,CAAC;IAEM,QAAQ;;QACX,MAAM,WAAW,GAAG,IAAI,0BAAW,EAAE,CAAC;QACtC,WAAW,CAAC,aAAa,CAAC,MAAA,MAAA,IAAI,CAAC,IAAI,CAAC,OAAO,0CAAE,MAAM,mCAAI,CAAC,CAAC,CAAC,CAAC,gBAAgB;QAE3E,MAAM,oBAAoB,GAAG,MAAA,MAAA,IAAI,CAAC,IAAI,CAAC,OAAO,0CAAE,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,UAAU,IAAI,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,IAAI,CAAC,mCAAI,KAAK,CAAC;QACrG,KAAK,MAAM,MAAM,IAAI,MAAA,IAAI,CAAC,IAAI,CAAC,OAAO,mCAAI,EAAE,EAAE;YAC1C,IAAI,KAAK,GAAG,CAAC,CAAC;YACd,KAAK,IAAI,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,eAAe,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC;YAC1D,KAAK,IAAI,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,eAAe,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC;YAC5D,KAAK,IAAI,oBAAoB,CAAC,CAAC,CAAC,eAAe,CAAC,oBAAoB,CAAC,CAAC,CAAC,CAAC,CAAC;YACzE,WAAW,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,OAAO;YACtC,6JAA6J;YAC7J,WAAW,CAAC,aAAa,CAAC,0BAAc,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,cAAc;YAC5E,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,gBAAgB,CAAC,CAAC,CAAC,qBAAqB;YACzE,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,CAAC,cAAc;YAC5D,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC,CAAC,gBAAgB;YAChE,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,YAAY;YACxD,WAAW,CAAC,aAAa,CAAC,MAAM,CAAC,WAAW,CAAC,CAAC,CAAC,eAAe;YAE9D,IAAI,oBAAoB,EAAE;gBACtB,WAAW,CAAC,aAAa,CAAC,MAAA,MAAM,CAAC,UAAU,mCAAI,EAAE,CAAC,CAAC;gBACnD,WAAW,CAAC,aAAa,CAAC,MAAA,MAAM,CAAC,IAAI,mCAAI,EAAE,CAAC,CAAC;gBAC7C,WAAW,CAAC,aAAa,CAAC,MAAA,MAAM,CAAC,IAAI,mCAAI,EAAE,CAAC,CAAC;aAChD;SACJ;QACD,2BAAY,CAAC,0BAA0B,CAAC,IAAI,EAAE,WAAW,CAAC,CAAC;QAC3D,OAAO,WAAW,CAAC,QAAQ,EAAE,CAAC;IAClC,CAAC;CAmBJ;AA5FD,0CA4FC;AAiDD,IAAK,eAOJ;AAPD,WAAK,eAAe;IAChB,+DAAgB,CAAA;IAChB,iEAAiB,CAAA;IACjB;;OAEG;IACH,qFAA2B,CAAA;AAC/B,CAAC,EAPI,eAAe,KAAf,eAAe,QAOnB"}

package/dist/debugSession/BrightScriptDebugSession.d.ts

@@ -178,6 +178,13 @@ export declare class BrightScriptDebugSession extends LoggingDebugSession {
     setBreakPointsRequest(response: DebugProtocol.SetBreakpointsResponse, args: DebugProtocol.SetBreakpointsArguments): Promise<void>;
     protected exceptionInfoRequest(response: DebugProtocol.ExceptionInfoResponse, args: DebugProtocol.ExceptionInfoArguments): void;
     protected threadsRequest(response: DebugProtocol.ThreadsResponse): Promise<void>;
+    /**
+     * Get the thread name to display in the UI based on the thread info we have.
+     * This is what displays in the `call stack` region in vscode
+     * @param thread
+     * @returns
+     */
+    private getThreadName;
     protected stackTraceRequest(response: DebugProtocol.StackTraceResponse, args: DebugProtocol.StackTraceArguments): Promise<void>;
     protected scopesRequest(response: DebugProtocol.ScopesResponse, args: DebugProtocol.ScopesArguments): Promise<void>;
     protected continueRequest(response: DebugProtocol.ContinueResponse, args: DebugProtocol.ContinueArguments): Promise<void>;

package/dist/debugSession/BrightScriptDebugSession.js

@@ -680,7 +680,7 @@ class BrightScriptDebugSession extends debugadapter_1.LoggingDebugSession {
      * Activate all required functionality for profiling
      */
     async initializeProfiling() {
-        var _a, _b, _c, _d, _e;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j;
         // Initialize PerfettoManager
         this.perfettoManager = new PerfettoManager_1.PerfettoManager({
             host: this.launchConfiguration.host,
@@ -724,6 +724,13 @@ class BrightScriptDebugSession extends debugadapter_1.LoggingDebugSession {
         else if (((_e = (_d = this.launchConfiguration.profiling) === null || _d === void 0 ? void 0 : _d.tracing) === null || _e === void 0 ? void 0 : _e.enable) === false && this.supportsPerfettoTracing) {
             this.logger.info('Disabling perfetto tracing because it is disabled in the launch configuration');
             //TODO implement a way to disable perfetto tracing on the device
+            //tracing was requested but the device firmware does not meet the minimum requirement
+        }
+        else if (((_g = (_f = this.launchConfiguration.profiling) === null || _f === void 0 ? void 0 : _f.tracing) === null || _g === void 0 ? void 0 : _g.enable) && !this.supportsPerfettoTracing) {
+            const firmwareVersion = (_j = (_h = this.deviceInfo) === null || _h === void 0 ? void 0 : _h.softwareVersion) !== null && _j !== void 0 ? _j : 'unknown';
+            const message = `Perfetto profiling is not available: device firmware ${firmwareVersion} is below the minimum required version (15.2). The Perfetto profiling buttons will not be available during this session.`;
+            this.logger.warn(message);
+            this.showPopupMessage(message, 'warn').catch(e => this.logger.error('Failed to show Perfetto unavailable notification', e));
             //profiling.tracing.enabled is set to `undefined`, which means we should do nothing
         }
         else {
@@ -734,7 +741,7 @@ class BrightScriptDebugSession extends debugadapter_1.LoggingDebugSession {
      * If profiling was marked "connectOnStart", try connecting right away
      */
     async tryProfilingConnectOnStart() {
-        var _a, _b;
+        var _a, _b, _c, _d, _e, _f;
         if (((_b = (_a = this.launchConfiguration.profiling) === null || _a === void 0 ? void 0 : _a.tracing) === null || _b === void 0 ? void 0 : _b.connectOnStart) && this.supportsPerfettoTracing) {
             try {
                 await this.perfettoManager.startTracing();
@@ -743,6 +750,12 @@ class BrightScriptDebugSession extends debugadapter_1.LoggingDebugSession {
                 this.logger.error('Failed to start perfetto tracing on start', e);
             }
         }
+        else if (((_d = (_c = this.launchConfiguration.profiling) === null || _c === void 0 ? void 0 : _c.tracing) === null || _d === void 0 ? void 0 : _d.connectOnStart) && !this.supportsPerfettoTracing) {
+            const firmwareVersion = (_f = (_e = this.deviceInfo) === null || _e === void 0 ? void 0 : _e.softwareVersion) !== null && _f !== void 0 ? _f : 'unknown';
+            const message = `Perfetto profiling is not available: device firmware ${firmwareVersion} is below the minimum required version (15.2). Tracing will not start automatically.`;
+            this.logger.warn(message);
+            this.showPopupMessage(message, 'warn').catch(e => this.logger.error('Failed to show Perfetto unavailable notification', e));
+        }
     }
     /**
      * Clear certain properties that need reset whenever a debug session is restarted (via vscode or launched from the Roku home screen)
@@ -751,7 +764,9 @@ class BrightScriptDebugSession extends debugadapter_1.LoggingDebugSession {
         // launchRequest gets invoked by our restart session flow.
         // We need to clear/reset some state to avoid issues.
         this.entryBreakpointWasHandled = false;
-        this.breakpointManager.clearBreakpointLastState();
+        //reset all per-session breakpoint state (diff baseline + cached parsed ASTs) since a restart
+        //re-stages the project
+        this.breakpointManager.reset();
     }
     /**
      * Activate rendezvous tracking (IF enabled in the LaunchConfig)
@@ -1095,10 +1110,8 @@ class BrightScriptDebugSession extends debugadapter_1.LoggingDebugSession {
         var _a;
         //add breakpoint lines to source files and then publish
         util_1.util.log('Adding stop statements for active breakpoints');
-        //write the `stop` statements to every file that has breakpoints (do for telnet, skip for debug protocol)
-        if (!this.enableDebugProtocol) {
-            await this.breakpointManager.writeBreakpointsForProject(this.projectManager.mainProject);
-        }
+        //validate breakpoints for all debugger types (and write `stop` statements for telnet — decided internally)
+        await this.breakpointManager.validateAndWriteBreakpointsForProject(this.projectManager.mainProject);
         if (this.launchConfiguration.packageTask) {
             util_1.util.log(`Executing task '${this.launchConfiguration.packageTask}' to assemble the app`);
             await this.sendCustomRequest('executeTask', { task: this.launchConfiguration.packageTask });
@@ -1205,11 +1218,9 @@ class BrightScriptDebugSession extends debugadapter_1.LoggingDebugSession {
         const componentLibrariesOutDir = (0, FileUtils_1.standardizePath) `${this.launchConfiguration.outDir}/component-libraries`;
         // Add breakpoint lines to the staging files and before publishing
         util_1.util.log('Adding stop statements for active breakpoints in Component Libraries');
-        //write STOPs (telnet only), postfix, and zip each complib in parallel — each targets distinct files
+        //validate breakpoints (and write STOPs for telnet), postfix, and zip each complib in parallel — each targets distinct files
         const packagePromises = this.projectManager.componentLibraryProjects.map(async (compLibProject) => {
-            if (!this.enableDebugProtocol) {
-                await this.breakpointManager.writeBreakpointsForProject(compLibProject);
-            }
+            await this.breakpointManager.validateAndWriteBreakpointsForProject(compLibProject);
             await compLibProject.postfixFiles();
             await compLibProject.zipPackage({ retainStagingFolder: true });
         });
@@ -1304,9 +1315,7 @@ class BrightScriptDebugSession extends debugadapter_1.LoggingDebugSession {
             if (this.rokuAdapter.isAtDebuggerPrompt) {
                 let rokuThreads = await this.rokuAdapter.getThreads();
                 for (let thread of rokuThreads) {
-                    const threadName = thread.isDetached
-                        ? `Thread ${thread.threadId} [detached]`
-                        : `Thread ${thread.threadId}`;
+                    const threadName = this.getThreadName(thread);
                     threads.push(new debugadapter_1.Thread(thread.threadId, threadName));
                 }
                 if (threads.length === 0) {
@@ -1326,6 +1335,40 @@ class BrightScriptDebugSession extends debugadapter_1.LoggingDebugSession {
         };
         this.sendResponse(response);
     }
+    /**
+     * Get the thread name to display in the UI based on the thread info we have.
+     * This is what displays in the `call stack` region in vscode
+     * @param thread
+     * @returns
+     */
+    getThreadName(thread) {
+        let threadName = '';
+        if (thread.type || thread.name || thread.osThreadId) {
+            //build the name from only the parts that are present, so missing values don't leak into the name
+            const parts = [];
+            if (thread.type) {
+                parts.push(`[${thread.type}]`);
+            }
+            if (thread.name) {
+                parts.push(thread.name);
+            }
+            if (thread.osThreadId) {
+                parts.push(thread.osThreadId);
+            }
+            threadName = parts.join(' ');
+        }
+        //remove any extraneous whitespace to deal with missing values
+        threadName = threadName.replace(/\s+/g, ' ').trim();
+        if (threadName === '') {
+            threadName = `Thread ${thread.threadId}`;
+        }
+        if (thread.isDetached) {
+            threadName += ' [detached]';
+        }
+        //remove any extraneous whitespace to deal with missing values
+        threadName = threadName.replace(/\s+/g, ' ').trim();
+        return threadName;
+    }
     async stackTraceRequest(response, args) {
         var _a, _b;
         try {