roger-roger 0.1.0 → 0.1.1

package/README.md

@@ -6,18 +6,15 @@ It works with any agent that supports [Agent Skills](https://skills.sh), such as
 
 ## Install
 
-```sh
-npm install -g roger-roger
-roger-roger install
-```
-
-Or, without installing anything permanently:
+One command, in any shell on Windows, macOS or Linux:
 
 ```sh
-npx roger-roger install
+npx roger-roger@latest install
 ```
 
-`install` asks a few questions in the terminal and does the rest: it links the skill into every agent's skills folder it finds (Claude Code, Codex, OpenCode, Cursor, Gemini CLI, Copilot, and `~/.agents/skills`), registers with [Herdr](https://herdr.dev) as a plugin when it's installed, connects Slack, lets you hear the sounds and the voices before you choose, and installs the terminal-question hooks and the tray icon. Run it again whenever you want to change something.
+It asks a few questions in the terminal and does the rest. First it offers to put the `roger-roger` command on your PATH (`npm install -g`), then it links the skill into every agent's skills folder it finds (Claude Code, Codex, OpenCode, Cursor, Gemini CLI, Copilot, and `~/.agents/skills`), registers with [Herdr](https://herdr.dev) as a plugin when it's installed, connects Slack, lets you hear the sounds and the voices before you choose, and installs the terminal-question hooks and the tray icon. Once it's on your PATH, `roger-roger install` runs the same setup again whenever you want to change something.
+
+If you'd rather install first and set up after, that works too: `npm install -g roger-roger`, then `roger-roger install`.
 
 Other ways in:
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "roger-roger",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Bring yourself back to the conversation: your coding agents reach you by Slack, a sound or a spoken line when they finish, get stuck, or need a decision, and you answer from your phone.",
   "type": "module",
   "bin": {

package/skills/roger-roger/SKILL.md

@@ -34,10 +34,10 @@ Every command prints a single JSON object.
 Run `status` first. If `configured` is `false`, don't set things up in the conversation. Ask the user to run the setup in a terminal, and wait for them:
 
 ```
-roger-roger install          (or, with nothing installed: npx roger-roger install)
+npx roger-roger@latest install
 ```
 
-It asks everything in one sitting, with previews: how to be reached (Slack, sound, speech), connecting Slack (it creates the roger-roger Slack app; nobody copies tokens), which sound and which voice (space plays them), how much to say out loud, when to notify, the terminal-question hooks (`hooks`, under *Other commands*), and the tray. It also links the skill into every agent's skills folder and registers with Herdr when it's there. When the user says it's done, run `status` again and carry on.
+That one line works in every shell (`roger-roger install` does the same once the command is on their PATH, which the setup offers first). It asks everything in one sitting, with previews: how to be reached (Slack, sound, speech), connecting Slack (it creates the roger-roger Slack app; nobody copies tokens), which sound and which voice (space plays them), how much to say out loud, when to notify, the terminal-question hooks (`hooks`, under *Other commands*), and the tray. It also links the skill into every agent's skills folder and registers with Herdr when it's there. When the user says it's done, run `status` again and carry on.
 
 Only if they can't get to a terminal: `setup` takes every setting as a flag (below), and `slack-setup` does the Slack steps one at a time (`slack-setup` prints `next`: `install-cli`, `login` — it returns a `/slackauthticket …` command for the user to paste into Slack and you pass back the code they get with `--challenge CODE --ticket TICKET` — `create`, then `done`, with the user's member ID as `userId` for `--slack-target`).
 

package/skills/roger-roger/herdr-plugin.toml

@@ -6,7 +6,7 @@
 
 id = "roger-roger"
 name = "roger-roger"
-version = "0.1.0"
+version = "0.1.1"
 min_herdr_version = "0.9.0"
 description = "Slack, a sound or a spoken line from the agents in your panes, and questions you answer from your phone"
 platforms = ["linux", "macos", "windows"]

package/skills/roger-roger/scripts/install.mjs

@@ -103,6 +103,52 @@ export function applyLink(link, target, plan, fsx = fs, now = new Date()) {
   return { ...plan, done: true };
 }
 
+// ---------------------------------------------------------------- the global copy
+
+/**
+ * Run npm with fixed arguments (never anything typed). On Windows npm is a .cmd, which Node only
+ * runs through a shell, and a shell wants one command line rather than an argument list.
+ */
+function npmSync(argv, env, timeout) {
+  const options = { encoding: "utf8", windowsHide: true, timeout, env };
+  return process.platform === "win32"
+    ? spawnSync(["npm", ...argv].join(" "), { ...options, shell: true })
+    : spawnSync("npm", argv, options);
+}
+
+/** Where npm keeps global packages, and whether roger-roger is among them. Null when npm isn't around. */
+export function globalCopy(env = process.env) {
+  try {
+    const r = npmSync(["root", "-g"], env, 20_000);
+    const root = (r.stdout ?? "").trim();
+    if (r.status !== 0 || !root) return null;
+    const pkg = path.join(root, "roger-roger");
+    return { root, dir: path.join(pkg, "skills", "roger-roger"), present: fs.existsSync(path.join(pkg, "package.json")) };
+  } catch {
+    return null;
+  }
+}
+
+/**
+ * Which copy of the skill everything should point at, and whether to offer a global install:
+ * the copy this runs from, unless that is a passing one (npx's cache, say) and there is no global
+ * copy yet. A global copy that exists beside a checkout or a skills.sh copy is left alone: whoever
+ * runs this copy meant this copy.
+ */
+export function pickTarget(running, global) {
+  if (!global) return { target: running, offer: false, reason: "npm was not found" };
+  if (norm(running) === norm(global.dir)) return { target: running, offer: false, reason: "global" };
+  if (global.present) return { target: running, offer: false, reason: "a global copy exists, but this one was run" };
+  return { target: running, offer: true, reason: "no global copy yet" };
+}
+
+/** `npm install -g roger-roger@latest`. Throws with npm's last words when it fails. */
+export function installGlobally(env = process.env) {
+  const r = npmSync(["install", "-g", "roger-roger@latest", "--no-audit", "--no-fund", "--loglevel", "error"], env, 300_000);
+  if (r.status !== 0) throw new Error((r.stderr || r.stdout || r.error?.message || `npm exited with ${r.status}`).trim().split(/\r?\n/).slice(-3).join(" "));
+  return r.stdout.trim();
+}
+
 // ---------------------------------------------------------------- herdr
 
 /** The `herdr` binary, from the pane's environment or PATH: `{ command, version }`, or null. */
@@ -357,13 +403,34 @@ export async function runInstall(args, { script, hooks, input = process.stdin, o
       config ? "Settings from an earlier setup are the defaults below" : "First setup",
     ]);
 
+    // ---- the copy everything points at: the global one, if there is or is about to be one
+    let target = SKILL_DIR;
+    let hookScript = script;
+    const global = globalCopy(env);
+    const pick = pickTarget(SKILL_DIR, global);
+    if (pick.reason === "global") {
+      ui.done("The roger-roger command is on your PATH", global.dir);
+    } else if (pick.offer) {
+      const yes = await ui.confirm({ message: "Put the roger-roger command on your PATH?", hint: "npm install -g roger-roger, so you and your agents can run it from anywhere" });
+      if (yes) {
+        const done = await attempt(ui, "Installing globally", () => ui.run("Installing roger-roger with npm", () => installGlobally(env), { done: () => ({ text: "The roger-roger command is on your PATH", detail: global.dir }) }), { skipLabel: "Carry on with this copy" });
+        if (done !== null && fs.existsSync(path.join(global.dir, "scripts", "roger-roger.mjs"))) {
+          target = global.dir;
+          hookScript = path.join(global.dir, "scripts", "roger-roger.mjs");
+          // The daemon should come from the copy that stays, not from the one npx will throw away.
+          await daemon("stop").catch(() => {});
+          spawnSync(process.execPath, [hookScript, "daemon", "start"], { encoding: "utf8", windowsHide: true, timeout: 30_000, env });
+        }
+      }
+    }
+
     // ---- the skill, where agents look for it
     const wanted = await ui.multiselect({
       message: "Which agents should have the skill?",
       choices: agents.map((a) => ({ value: a.id, label: a.label, hint: a.hint ?? `~/${a.dir.join("/")}/skills`, checked: true })),
     });
     for (const a of agents.filter((x) => wanted.includes(x.id))) {
-      const plan = planLink(a.link, SKILL_DIR);
+      const plan = planLink(a.link, target);
       if (plan.action === "replace") {
         const yes = await ui.confirm({ message: `${a.label} has its own copy of the skill. Replace it with a link?`, hint: "the copy is moved aside, not deleted" });
         if (!yes) {
@@ -376,7 +443,7 @@ export async function runInstall(args, { script, hooks, input = process.stdin, o
         continue;
       }
       try {
-        const done = applyLink(a.link, SKILL_DIR, plan);
+        const done = applyLink(a.link, target, plan);
         ui.done(`${a.label}: ${plan.action === "none" ? plan.note : "linked"}`, `${a.link}${done.movedTo ? ` (the copy is at ${done.movedTo})` : ""}`);
         summary.push(a.label);
       } catch (e) {
@@ -389,7 +456,7 @@ export async function runInstall(args, { script, hooks, input = process.stdin, o
     if (herdr) {
       const yes = await ui.confirm({ message: "Register with Herdr as a plugin?", hint: "starts the daemon with Herdr, adds snooze to its actions" });
       if (yes) {
-        const r = herdrLink(herdr, SKILL_DIR);
+        const r = herdrLink(herdr, target);
         if (r.ok) {
           ui.done("Registered with Herdr", r.note ?? "herdr plugin list shows it");
           herdrDone = true;
@@ -469,7 +536,7 @@ export async function runInstall(args, { script, hooks, input = process.stdin, o
     if (hookAgents.length && methods.includes("slack")) {
       const labels = { claude: "Claude Code", opencode: "OpenCode", codex: "Codex" };
       const installed = hookAgents.every(([, a]) => {
-        const s = a.status({ script });
+        const s = a.status({ script: hookScript });
         return s.installed && !s.note;
       });
       if (installed) {
@@ -482,7 +549,7 @@ export async function runInstall(args, { script, hooks, input = process.stdin, o
         if (yes) {
           for (const [name, a] of hookAgents) {
             try {
-              a.install({ script });
+              a.install({ script: hookScript });
               ui.done(`${labels[name] ?? name}: hooks installed`, name === "codex" ? "open /hooks in Codex once and trust the three roger-roger hooks" : name === "opencode" ? "restart OpenCode to load the plugin" : "");
               summary.push(`hooks: ${labels[name] ?? name}`);
             } catch (e) {

package/skills/roger-roger/scripts/slackcli.mjs

@@ -9,18 +9,24 @@ import { spawn } from "node:child_process";
 const METADATA_URL = "https://docs.slack.dev/tools/metadata.json";
 const DOWNLOADS = "https://downloads.slack-edge.com/slack-cli";
 
+/**
+ * On Windows the Slack CLI hangs for ever when it shares the caller's console (seen from agent
+ * shells) and runs normally without one, so it is started detached. Nothing else is: a detached
+ * PowerShell comes back at once with exit code 0 and no output, before it has done anything, which
+ * is how an install once "succeeded" into an empty folder.
+ */
+export const detachOnWindows = (cmd) => process.platform === "win32" && /^slack(cli)?(\.exe|\.cmd)?$/i.test(path.basename(String(cmd)));
+
 /** Run a command and collect its output. Never rejects; `code` is null if it couldn't start. */
-export function capture(cmd, args, { input, env, cwd, timeout = 120_000 } = {}) {
+export function capture(cmd, args, { input, env, cwd, timeout = 120_000, detached = detachOnWindows(cmd) } = {}) {
   return new Promise((resolve) => {
     let child;
     try {
-      // Detached: on Windows the Slack CLI can hang indefinitely when it shares the caller's console
-      // (seen from agent shells); without a console it runs normally. Output is still piped back.
       child = spawn(cmd, args, {
         env: env ?? process.env,
         cwd,
         timeout,
-        detached: process.platform === "win32",
+        detached,
         windowsHide: true,
         stdio: [input === undefined ? "ignore" : "pipe", "pipe", "pipe"],
       });