robot-resources 1.9.3 → 1.9.5

package/lib/wizard.js

@@ -1,6 +1,6 @@
 import { readFileSync, writeFileSync, mkdirSync } from 'node:fs';
 import { join } from 'node:path';
-import { homedir, hostname } from 'node:os';
+import { homedir, hostname, release as osRelease } from 'node:os';
 import { readConfig, writeConfig } from '@robot-resources/cli-core/config.mjs';
 import { findPython, isPortAvailable, isHeadless, isOpenClawInstalled } from './detect.js';
 import { getOrCreateMachineId } from './machine-id.js';
@@ -19,12 +19,25 @@ import { header, step, success, warn, error, info, blank, summary } from './ui.j
  */
 function classifyRouterError(err) {
   const msg = (err?.message || String(err)).toLowerCase();
+  const stderr = (err?.stderr || '').toString().toLowerCase();
+  const combined = msg + '\n' + stderr;
   let reason = 'unknown';
 
-  if (msg.includes('python 3.10+') || msg.includes('python is required')) {
+  // Order matters — check specific patterns before generic ones.
+  // python_venv_missing is specific (Debian/Ubuntu ships python3 without
+  // the venv module) — previously showed up as 'unknown' in telemetry.
+  if (/python venv module|ensurepip.*not (installed|available)|python\d*-venv/.test(combined)) {
+    reason = 'python_venv_missing';
+  } else if (msg.includes('python 3.10+') || msg.includes('python is required')) {
     reason = 'python_not_found';
   } else if (err?.code === 'ENOENT' || msg.includes('enoent')) {
     reason = 'spawn_enoent';
+  } else if (/failed building wheel|metadata-generation-failed|cargo|rust compiler|subprocess-exited-with-error/.test(combined)) {
+    // Wheel-build failures: pip tried to compile a native dep from source
+    // because no binary wheel was available for the user's platform. This
+    // was silently categorized as 'pip_install_failed' before — surfacing
+    // it separately lets us see affected packages in aggregate.
+    reason = 'wheel_build_failed';
   } else if (msg.includes('timeout') || msg.includes('timed out') || err?.code === 'ETIMEDOUT') {
     reason = 'timeout';
   } else if (msg.includes('exited with code') || msg.includes('pip install')) {
@@ -56,6 +69,8 @@ function classifyRouterError(err) {
 export async function runWizard({ nonInteractive = false } = {}) {
   header();
 
+  const wizardStartMs = Date.now();
+
   const results = {
     auth: false,
     authMethod: null, // 'config' | 'apikey' | 'github'
@@ -63,6 +78,16 @@ export async function runWizard({ nonInteractive = false } = {}) {
     routerError: null,
     providerKeys: false,
     service: false,
+    // Diagnostic fields populated as the wizard progresses. All are sent
+    // in install_complete (success AND failure) so we can distinguish
+    // "pip installed but router never served a request" from a real
+    // working setup in post-hoc telemetry.
+    serviceType: null,
+    pluginInstalled: false,
+    openclawDetected: false,
+    openclawConfigPatched: false,
+    scraperMcpRegistered: false,
+    healthCheck: { attempted: false },
   };
 
   // ── Step 0: Provision API key (before anything else) ────────────────────
@@ -209,6 +234,7 @@ export async function runWizard({ nonInteractive = false } = {}) {
 
       try {
         const svc = installService(getVenvPythonPath());
+        results.serviceType = svc.type || null;
         if (svc.type === 'skipped') {
           warn(svc.reason);
           results.service = false;
@@ -234,6 +260,15 @@ export async function runWizard({ nonInteractive = false } = {}) {
     const toolResults = configureToolRouting();
     results.tools = toolResults;
 
+    // Surface OC-specific signals for install_complete diagnostics.
+    results.openclawDetected = isOpenClawInstalled();
+    const ocResult = toolResults.find((r) => r.name === 'OpenClaw');
+    if (ocResult) {
+      results.pluginInstalled =
+        ocResult.action === 'installed' || ocResult.action === 'already_configured';
+      results.openclawConfigPatched = Boolean(ocResult.configActivated);
+    }
+
     if (toolResults.length === 0) {
       info('No supported AI tools detected');
       info('Point your tool at http://localhost:3838 to enable cost optimization');
@@ -276,6 +311,7 @@ export async function runWizard({ nonInteractive = false } = {}) {
   if (scraperRegistered) {
     success('Scraper MCP registered in OpenClaw — scraper_compress_url(url) available');
     results.scraper = true;
+    results.scraperMcpRegistered = true;
   } else {
     // Either already registered, or no openclaw.json
     try {
@@ -283,6 +319,7 @@ export async function runWizard({ nonInteractive = false } = {}) {
       if (ocConfig?.mcp?.servers?.['robot-resources-scraper']) {
         success('Scraper MCP already registered in OpenClaw');
         results.scraper = true;
+        results.scraperMcpRegistered = true;
       }
     } catch {
       // No openclaw.json — not on OC, skip
@@ -290,13 +327,25 @@ export async function runWizard({ nonInteractive = false } = {}) {
   }
 
   // ── Step 4.5: Router Healthcheck ──────────────────────────────────────
+  //
+  // Verify the router is actually serving /health — not just that pip
+  // exited 0. Runs regardless of whether service registration succeeded:
+  // a router started by the wizard's spawn (or by a running OC) still
+  // deserves to be probed, and a router that pip-installed but fails to
+  // respond means the install is NOT actually complete.
+  //
+  // If we declared router=true from Step 1 (pip success) but /health
+  // won't answer, downgrade router→false with a dedicated error reason.
+  // This closes the "install looks green but nothing works" gap that
+  // produced 34 silent-after-install real users with no diagnostics.
 
-  // Router: verify it's responding on localhost:3838
-  if (results.service) {
+  if (results.router) {
     blank();
     step('Verifying Router is responding...');
 
-    let healthy = false;
+    const checkStart = Date.now();
+    let healthData = null;
+    let lastErr = null;
     // Retry a few times — the service may need a moment to start
     for (let attempt = 0; attempt < 3; attempt++) {
       try {
@@ -306,20 +355,38 @@ export async function runWizard({ nonInteractive = false } = {}) {
         if (res.ok) {
           const data = await res.json();
           if (data.status === 'healthy' || data.status === 'degraded') {
-            success(`Router healthy (v${data.version || 'unknown'})`);
-            healthy = true;
+            healthData = data;
             break;
           }
         }
-      } catch {
-        // Wait before retrying
-        await new Promise((r) => setTimeout(r, 2000));
+      } catch (err) {
+        lastErr = err?.message || String(err);
       }
+      if (attempt < 2) await new Promise((r) => setTimeout(r, 2000));
     }
 
-    if (!healthy) {
-      warn('Router not responding yet — it may need a few more seconds to start');
+    results.healthCheck = {
+      attempted: true,
+      passed: Boolean(healthData),
+      version: healthData?.version ?? null,
+      status: healthData?.status ?? null,
+      latencyMs: Date.now() - checkStart,
+      error: healthData ? null : lastErr,
+    };
+
+    if (healthData) {
+      success(`Router healthy (v${healthData.version || 'unknown'})`);
+    } else {
+      warn('Router not responding — marking install as failed.');
       info('Check manually: curl http://localhost:3838/health');
+      // Bug fix: previously we left router=true here. Now we downgrade
+      // so install_complete reflects reality and the error is classified.
+      results.router = false;
+      results.routerError = {
+        reason: 'health_check_failed',
+        detail: (lastErr || 'no response').slice(-500),
+        exitCode: null,
+      };
     }
   }
 
@@ -336,22 +403,31 @@ export async function runWizard({ nonInteractive = false } = {}) {
     try {
       const config = readConfig();
       const platformUrl = process.env.RR_PLATFORM_URL || 'https://api.robotresources.ai';
+      // Everything populated unconditionally so success installs carry
+      // the same diagnostic weight as failures. Prior versions only
+      // captured routerError+platform on failure, leaving 34 "successful"
+      // installs with no post-hoc signal to explain why they never emit
+      // another event.
       const installPayload = {
+        source: 'wizard',
         router: results.router || false,
         service: results.service || false,
         scraper: results.scraper || false,
-        source: 'wizard',
+        platform: process.platform,
+        os_release: osRelease(),
+        node_version: process.version,
+        install_duration_ms: Date.now() - wizardStartMs,
+        python_source: results.pythonSource ?? null,
+        service_type: results.serviceType ?? null,
+        health_check: results.healthCheck,
+        plugin_installed: results.pluginInstalled,
+        openclaw_detected: results.openclawDetected,
+        openclaw_config_patched: results.openclawConfigPatched,
+        scraper_mcp_registered: results.scraperMcpRegistered,
       };
-      if (results.pythonSource) {
-        // 'system' when the user had Python installed, 'uv' when we
-        // auto-bootstrapped one. Lets us measure how many installs were
-        // rescued by the uv fallback.
-        installPayload.pythonSource = results.pythonSource;
-      }
       if (results.routerError && typeof results.routerError === 'object') {
         installPayload.routerError = results.routerError.reason;
         installPayload.routerErrorDetail = results.routerError.detail;
-        installPayload.platform = process.platform;
       }
       const body = JSON.stringify({
         product: 'cli',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "robot-resources",
-  "version": "1.9.3",
+  "version": "1.9.5",
   "description": "Robot Resources — AI agent tools. One command to install everything.",
   "type": "module",
   "bin": {