robot-resources 1.15.2 → 1.15.3

package/lib/uninstall.js

@@ -1,208 +0,0 @@
-import { existsSync, readFileSync, writeFileSync, rmSync } from 'node:fs';
-import { homedir } from 'node:os';
-import { join } from 'node:path';
-import { stripJson5 } from './json5.js';
-import { removeShellLine } from './shell-config.js';
-import { detectVenv } from './venv-detect.js';
-import { spawnSync } from 'node:child_process';
-import { removePersistedNodeOptions } from './windows-env.js';
-import { findAgentSourceFile, hasSourceMarker, removeSourceMarker } from './source-edit-attach.js';
-
-/**
- * Single source of truth for `npx robot-resources --uninstall`.
- *
- * Reverses every install path the wizard might have taken:
- *   1. OC plugin directories under ~/.openclaw/extensions/ (Phase 0)
- *   2. Our entries in openclaw.json (plugins.entries + plugins.allow +
- *      mcp.servers) (Phase 0)
- *   3. NODE_OPTIONS marker block in shell rc files (Phase 3 — Node shim)
- *   4. `robot-resources` PyPI package in the resolved venv (Phase 3 —
- *      Python shim)
- *   5. With --purge: ~/.robot-resources/ config dir (api_key + claim_url)
- *
- * `~/.robot-resources/config.json` is preserved by default so a subsequent
- * re-install reuses the same api_key (and the user's claim_url stays valid).
- *
- * Returns { components_removed: string[], errors: { component, message }[] }
- * for telemetry. Failure to remove one component never aborts the others —
- * a partial uninstall is still progress, and we want to record what worked.
- */
-export function runUninstall({ purge = false } = {}) {
-  const components_removed = [];
-  const errors = [];
-
-  // 1. Plugin directories under ~/.openclaw/extensions/
-  const pluginDirs = [
-    { id: 'robot-resources-router', label: 'router_plugin_dir' },
-    { id: 'robot-resources-scraper-oc-plugin', label: 'scraper_plugin_dir' },
-  ];
-  for (const { id, label } of pluginDirs) {
-    const path = join(homedir(), '.openclaw', 'extensions', id);
-    if (!existsSync(path)) continue;
-    try {
-      rmSync(path, { recursive: true, force: true });
-      components_removed.push(label);
-    } catch (err) {
-      errors.push({ component: label, message: err.message });
-    }
-  }
-
-  // 2. openclaw.json — strip our entries from plugins.entries, plugins.allow,
-  //    and mcp.servers. Leave everything else (other plugins, user config) alone.
-  //    Idempotent: if openclaw.json is missing or malformed, skip silently —
-  //    that's the right behavior for "cleanup what you can find."
-  const ocConfigPath = join(homedir(), '.openclaw', 'openclaw.json');
-  if (existsSync(ocConfigPath)) {
-    try {
-      const config = JSON.parse(stripJson5(readFileSync(ocConfigPath, 'utf-8')));
-      let mutated = false;
-
-      if (config?.plugins?.entries) {
-        for (const id of ['robot-resources-router', 'robot-resources-scraper-oc-plugin']) {
-          if (config.plugins.entries[id]) {
-            delete config.plugins.entries[id];
-            mutated = true;
-          }
-        }
-      }
-
-      if (Array.isArray(config?.plugins?.allow)) {
-        const before = config.plugins.allow.length;
-        config.plugins.allow = config.plugins.allow.filter(
-          (id) => id !== 'robot-resources-router' && id !== 'robot-resources-scraper-oc-plugin',
-        );
-        if (config.plugins.allow.length !== before) mutated = true;
-      }
-
-      if (config?.mcp?.servers?.['robot-resources-scraper']) {
-        delete config.mcp.servers['robot-resources-scraper'];
-        mutated = true;
-      }
-
-      if (mutated) {
-        writeFileSync(ocConfigPath, JSON.stringify(config, null, 2) + '\n', 'utf-8');
-        components_removed.push('openclaw_config_entries');
-      }
-    } catch (err) {
-      errors.push({ component: 'openclaw_config_entries', message: err.message });
-    }
-  }
-
-  // 3. Shell config / Windows registry — remove the NODE_OPTIONS line
-  //    Phase 3's wizard wrote to. Idempotent: no-op if not present.
-  if (process.platform === 'win32') {
-    // Phase 9: restore from backup or clear HKCU\Environment\NODE_OPTIONS.
-    try {
-      const result = removePersistedNodeOptions();
-      if (result.ok && result.action !== 'noop') {
-        components_removed.push(`win_node_options_${result.action}`);
-      } else if (!result.ok) {
-        errors.push({ component: 'win_node_options', message: 'reg_restore_failed' });
-      }
-    } catch (err) {
-      errors.push({ component: 'win_node_options', message: err.message });
-    }
-  } else {
-    try {
-      const result = removeShellLine();
-      if (result.removed.length > 0) {
-        components_removed.push('shell_config_node_options');
-      }
-      for (const e of result.errors) {
-        errors.push({ component: 'shell_config_node_options', message: `${e.path}: ${e.message}` });
-      }
-    } catch (err) {
-      errors.push({ component: 'shell_config_node_options', message: err.message });
-    }
-  }
-
-  // 3a. Phase 11 — source-edit auto-attach line. If the wizard injected
-  //     `require('@robot-resources/router/auto')` at the top of the user's
-  //     entry file, peel the marker block out (or restore from .rr-backup
-  //     when --purge). Idempotent: no-op when no entry detected or marker
-  //     not present. Runs against cwd, so users who --uninstall from a
-  //     different repo won't accidentally wipe the wrong file.
-  try {
-    // Phase 11.1: detector renamed to findAgentSourceFile, returns
-    // { winner, candidates, ... }. Adapt to the same `path` field name
-    // so the rest of the block reads naturally.
-    const scan = findAgentSourceFile();
-    const detection = { path: scan.winner };
-    if (detection.path && hasSourceMarker(detection.path)) {
-      const r = removeSourceMarker(detection.path, { restoreFromBackup: !!purge });
-      if (r.ok && (r.removed || r.restored)) {
-        components_removed.push(r.restored ? 'node_entry_restored_from_backup' : 'node_entry_marker_removed');
-      } else if (!r.ok) {
-        errors.push({ component: 'node_entry_source_edit', message: r.error || 'unknown' });
-      }
-    }
-    // --purge also wipes any leftover .rr-backup (covers the case where the
-    // user manually deleted the marker but kept the backup file around).
-    if (purge && detection.path && existsSync(`${detection.path}.rr-backup`)) {
-      try {
-        rmSync(`${detection.path}.rr-backup`, { force: true });
-        components_removed.push('node_entry_backup_purged');
-      } catch (err) {
-        errors.push({ component: 'node_entry_backup_purged', message: err.message });
-      }
-    }
-  } catch (err) {
-    errors.push({ component: 'node_entry_source_edit', message: err.message });
-  }
-
-  // 3b. Copied router dir at ~/.robot-resources/router/ (Phase 8). The shell
-  //     line points at this absolute path — once the line is gone, the
-  //     copied files are dead weight. Remove them.
-  const routerDir = join(homedir(), '.robot-resources', 'router');
-  if (existsSync(routerDir)) {
-    try {
-      rmSync(routerDir, { recursive: true, force: true });
-      components_removed.push('node_shim_router_dir');
-    } catch (err) {
-      errors.push({ component: 'node_shim_router_dir', message: err.message });
-    }
-  }
-
-  // 4. Python shim — `pip uninstall -y robot-resources` against the resolved
-  //    venv. Skip silently if no venv detected (the user may have installed
-  //    via the wizard but already deleted the venv themselves).
-  try {
-    const venv = detectVenv();
-    if (venv.python) {
-      const result = spawnSync(venv.python, ['-m', 'pip', 'uninstall', '-y', 'robot-resources'], {
-        encoding: 'utf-8',
-        timeout: 60_000,
-        stdio: ['ignore', 'pipe', 'pipe'],
-      });
-      // pip exits 0 if removed, non-zero if package wasn't installed (also acceptable)
-      if (result.status === 0) {
-        components_removed.push('pip_robot_resources');
-      } else if (result.stderr && /not installed|skipping/i.test(result.stderr)) {
-        // Already gone — count as success silently.
-      } else if (result.status !== null) {
-        // Some other failure; record but don't abort
-        errors.push({
-          component: 'pip_robot_resources',
-          message: `pip exit ${result.status}: ${(result.stderr || '').slice(-200)}`,
-        });
-      }
-    }
-  } catch (err) {
-    errors.push({ component: 'pip_robot_resources', message: err.message });
-  }
-
-  // 5. Optionally wipe ~/.robot-resources/config.json (and any siblings)
-  if (purge) {
-    const rrDir = join(homedir(), '.robot-resources');
-    if (existsSync(rrDir)) {
-      try {
-        rmSync(rrDir, { recursive: true, force: true });
-        components_removed.push('rr_config_dir');
-      } catch (err) {
-        errors.push({ component: 'rr_config_dir', message: err.message });
-      }
-    }
-  }
-
-  return { components_removed, errors };
-}

package/lib/venv-detect.js

@@ -1,85 +0,0 @@
-import { existsSync } from 'node:fs';
-import { spawnSync } from 'node:child_process';
-import { join } from 'node:path';
-
-/**
- * Resolve the Python interpreter we'll use for `pip install robot-resources`.
- *
- * Resolution order (decided in the plan; never silently install into system
- * Python — that can break OS Python on Linux):
- *
- *   1. $VIRTUAL_ENV — currently-active venv. Strongest signal.
- *   2. ./.venv/bin/python — common cwd venv (uv, hatch, plain venv default).
- *   3. ./venv/bin/python — alternative cwd venv name.
- *   4. pyproject.toml [tool.uv]/[tool.poetry] hint — best effort.
- *   5. Bail with confidence='low'. Caller prompts user or errors out with
- *      a `--python=/path/to/python` instruction in non-interactive mode.
- *
- * Returns:
- *   { python: string, kind: 'active'|'cwd-venv'|'pyproject', confidence: 'high' }
- *   OR
- *   { python: null,   kind: 'none',                          confidence: 'low' }
- */
-export function detectVenv(cwd = process.cwd()) {
-  // 1. Active venv — strongest signal.
-  const activeVenv = process.env.VIRTUAL_ENV;
-  if (activeVenv) {
-    const candidate = join(activeVenv, binSubdir(), 'python');
-    const candidate3 = join(activeVenv, binSubdir(), 'python3');
-    if (existsSync(candidate)) {
-      return { python: candidate, kind: 'active', confidence: 'high' };
-    }
-    if (existsSync(candidate3)) {
-      return { python: candidate3, kind: 'active', confidence: 'high' };
-    }
-  }
-
-  // 2. ./.venv (uv default, hatch default, plain venv default)
-  for (const dirname of ['.venv', 'venv']) {
-    const venvDir = join(cwd, dirname);
-    const cands = [
-      join(venvDir, binSubdir(), 'python'),
-      join(venvDir, binSubdir(), 'python3'),
-    ];
-    for (const c of cands) {
-      if (existsSync(c)) {
-        return { python: c, kind: 'cwd-venv', confidence: 'high' };
-      }
-    }
-  }
-
-  // 4. Bail. Never silently install into system Python.
-  return { python: null, kind: 'none', confidence: 'low' };
-}
-
-function binSubdir() {
-  return process.platform === 'win32' ? 'Scripts' : 'bin';
-}
-
-/**
- * Run `python -m pip install <package>` against the resolved interpreter.
- * Captures exit code + stderr tail for telemetry. Never throws.
- *
- * Phase 3 ships with `--upgrade` so existing 0.1.0 installs migrate to
- * the auto-attach-capable 0.2.0 transparently.
- */
-export function runPipInstall({ python, packageSpec, timeoutMs = 120_000 }) {
-  if (!python) {
-    return { ok: false, code: -1, stderr: 'no python interpreter resolved' };
-  }
-  const args = ['-m', 'pip', 'install', '--upgrade', packageSpec];
-  const result = spawnSync(python, args, {
-    encoding: 'utf-8',
-    timeout: timeoutMs,
-    stdio: ['ignore', 'pipe', 'pipe'],
-  });
-
-  // Trim stderr to a sane size for telemetry — pip's full output is huge.
-  const stderr = (result.stderr || '').slice(-500);
-
-  return {
-    ok: result.status === 0,
-    code: result.status,
-    stderr,
-  };
-}

package/lib/windows-env.js

@@ -1,202 +0,0 @@
-import { spawnSync } from 'node:child_process';
-import { existsSync, readFileSync, writeFileSync, mkdirSync, unlinkSync } from 'node:fs';
-import { homedir } from 'node:os';
-import { join } from 'node:path';
-
-/**
- * Windows NODE_OPTIONS persistence (Phase 9).
- *
- * The POSIX path uses a marker block in `~/.bashrc` / `~/.zshrc`. Windows
- * has no equivalent shell rc that all Node-launched processes read — cmd,
- * PowerShell, and Win+R-launched .exe all draw env vars from the user
- * registry under HKCU\Environment.
- *
- * `setx NODE_OPTIONS "value"` writes there. New processes pick it up.
- * The current shell does NOT see the change — user has to open a new
- * terminal. Same UX caveat as POSIX.
- *
- * Why not edit PowerShell `$PROFILE`: ExecutionPolicy on locked-down
- * corporate fleets often blocks unsigned `.ps1`. cmd-launched Node
- * processes also miss it. setx is universal across both.
- *
- * Idempotency: we read the persisted NODE_OPTIONS via `reg query` (not
- * `process.env.NODE_OPTIONS`, which is the current-shell value, not the
- * persistent one). If our `--require <auto>` is already present, no-op.
- *
- * Uninstall: backup the user's PRE-modification value to
- * `~/.robot-resources/windows-prior-node-options.txt`. On `--uninstall`,
- * restore from backup; if the backup is missing or empty, clear the var.
- *
- * Truncation note: `setx` truncates values at 1024 chars. If a user
- * already has a long NODE_OPTIONS plus other dev tooling, we may be
- * close to the limit. We surface the merged length in telemetry so we
- * can spot truncation in Supabase.
- */
-
-const REG_PATH = 'HKCU\\Environment';
-const VAR_NAME = 'NODE_OPTIONS';
-const SETX_LIMIT = 1024;
-
-function backupFilePath(home = homedir()) {
-  return join(home, '.robot-resources', 'windows-prior-node-options.txt');
-}
-
-/**
- * Read the persisted NODE_OPTIONS value from HKCU\Environment.
- * Returns the string (possibly empty) or null if reading failed.
- */
-export function readPersistedNodeOptions() {
-  const res = spawnSync(
-    'reg.exe',
-    ['query', REG_PATH, '/v', VAR_NAME],
-    { stdio: 'pipe', encoding: 'utf-8' },
-  );
-  if (res.status !== 0) {
-    // `reg query` returns non-zero when the value doesn't exist. That's a
-    // valid state — empty NODE_OPTIONS — not an error.
-    const stderr = (res.stderr || '').toLowerCase();
-    if (stderr.includes('unable to find') || stderr.includes('not exist')) {
-      return '';
-    }
-    return null;
-  }
-  // Output looks like:
-  //   HKEY_CURRENT_USER\Environment
-  //       NODE_OPTIONS    REG_SZ    --require ...
-  // We extract the value after REG_SZ. The value can contain spaces; take
-  // everything after the last "REG_SZ" occurrence on its line.
-  const lines = (res.stdout || '').split(/\r?\n/);
-  for (const line of lines) {
-    const m = line.match(/^\s*NODE_OPTIONS\s+REG_(?:SZ|EXPAND_SZ)\s+(.*)$/);
-    if (m) return m[1].trim();
-  }
-  return '';
-}
-
-/**
- * Set NODE_OPTIONS in HKCU\Environment to the given value (idempotent
- * append of `--require <autoPath>` to whatever was there).
- *
- * Returns:
- *   { ok: true,  already: boolean, prior: string, written: string, length: number }
- *   { ok: false, reason, error_message? }
- */
-export function writePersistedNodeOptions({ autoPath, home = homedir() }) {
-  if (!autoPath) {
-    return { ok: false, reason: 'missing_auto_path' };
-  }
-
-  const prior = readPersistedNodeOptions();
-  if (prior === null) {
-    return { ok: false, reason: 'reg_query_failed' };
-  }
-
-  // Quote the path so a path with spaces survives Node's --require parser.
-  // Node accepts both quoted and unquoted forms; quoting is safer.
-  const ourArg = `--require "${autoPath}"`;
-
-  if (prior.includes(ourArg) || prior.includes(`--require ${autoPath}`)) {
-    return {
-      ok: true,
-      already: true,
-      prior,
-      written: prior,
-      length: prior.length,
-    };
-  }
-
-  const merged = prior ? `${prior} ${ourArg}` : ourArg;
-
-  if (merged.length > SETX_LIMIT) {
-    // setx truncates silently at 1024 chars. Refuse rather than write a
-    // broken value. User must shorten their existing NODE_OPTIONS first.
-    return {
-      ok: false,
-      reason: 'setx_limit_exceeded',
-      error_message: `merged value is ${merged.length} chars; setx truncates at ${SETX_LIMIT}`,
-      length: merged.length,
-    };
-  }
-
-  // Backup the prior value BEFORE writing, so --uninstall can restore.
-  // Even if backup write fails (disk full, permissions), we still proceed —
-  // the registry-level setx is the source of truth, the backup is just a
-  // convenience for restore.
-  try {
-    const backup = backupFilePath(home);
-    mkdirSync(join(home, '.robot-resources'), { recursive: true });
-    writeFileSync(backup, prior, { encoding: 'utf-8' });
-  } catch {
-    // Best-effort backup; continue.
-  }
-
-  const setxRes = spawnSync(
-    'setx.exe',
-    [VAR_NAME, merged],
-    { stdio: 'pipe', encoding: 'utf-8' },
-  );
-  if (setxRes.status !== 0) {
-    const stderr = (setxRes.stderr || '').toString().trim();
-    return {
-      ok: false,
-      reason: 'setx_failed',
-      error_message: stderr.slice(0, 200) || `exit ${setxRes.status}`,
-      length: merged.length,
-    };
-  }
-
-  return {
-    ok: true,
-    already: false,
-    prior,
-    written: merged,
-    length: merged.length,
-  };
-}
-
-/**
- * Reverse `writePersistedNodeOptions`. Reads the backup file (if present)
- * and restores that value via setx. If no backup is present or the backup
- * is empty, clears the registry value entirely (`reg delete`).
- *
- * Returns { ok, restored_to: string, action: 'restored'|'cleared'|'noop' }
- */
-export function removePersistedNodeOptions({ home = homedir() } = {}) {
-  const current = readPersistedNodeOptions();
-  if (current === null) return { ok: false, action: 'noop' };
-  if (current === '') return { ok: true, restored_to: '', action: 'noop' };
-
-  const backupPath = backupFilePath(home);
-  let priorValue = '';
-  if (existsSync(backupPath)) {
-    try { priorValue = readFileSync(backupPath, 'utf-8'); } catch { /* */ }
-  }
-
-  if (priorValue === '') {
-    // No prior value to restore — clear the var entirely.
-    const res = spawnSync(
-      'reg.exe',
-      ['delete', REG_PATH, '/v', VAR_NAME, '/f'],
-      { stdio: 'pipe', encoding: 'utf-8' },
-    );
-    if (existsSync(backupPath)) try { unlinkSync(backupPath); } catch { /* */ }
-    return {
-      ok: res.status === 0,
-      restored_to: '',
-      action: 'cleared',
-    };
-  }
-
-  // Restore the prior value.
-  const res = spawnSync(
-    'setx.exe',
-    [VAR_NAME, priorValue],
-    { stdio: 'pipe', encoding: 'utf-8' },
-  );
-  if (existsSync(backupPath)) try { unlinkSync(backupPath); } catch { /* */ }
-  return {
-    ok: res.status === 0,
-    restored_to: priorValue,
-    action: 'restored',
-  };
-}