robot-resources 1.12.4 → 1.13.0

package/lib/install-node-shim.js

@@ -1,6 +1,7 @@
 import { writeShellLine, hasShellLine } from './shell-config.js';
 import { readConfig } from './config.mjs';
 import { detectNodeAgent } from './detect.js';
+import { installRouterFiles } from './install-router-files.js';
 
 const PLATFORM_URL = process.env.RR_PLATFORM_URL || 'https://api.robotresources.ai';
 
@@ -9,16 +10,20 @@ const PLATFORM_URL = process.env.RR_PLATFORM_URL || 'https://api.robotresources.
  * the non-OC Node path.
  *
  * Steps:
- *   1. Append the marker block to detected rc files (zsh / bash / fish)
- *      via shell-config.writeShellLine. Idempotent: re-running does nothing
- *      if the block is already present.
- *   2. Emit `node_shim_installed` telemetry with the shell list, sdks
- *      detected, dry-run flag, plus per-file errors.
+ *   1. Copy the bundled `@robot-resources/router` files to a stable absolute
+ *      path under `~/.robot-resources/router/` (mirrors the OC plugin pattern
+ *      at `~/.openclaw/extensions/`). Phase 8 fix: previously NODE_OPTIONS
+ *      used the bare module name `@robot-resources/router/auto` which only
+ *      resolved when the user was cd'd inside a project that had the
+ *      package in its node_modules. From any other cwd, EVERY `node`
+ *      command crashed with "Cannot find module".
+ *   2. Append the marker block to detected rc files (zsh / bash / fish)
+ *      with the ABSOLUTE PATH to the copied auto.cjs.
+ *   3. Emit `node_shim_installed` telemetry.
  *
  * The user has to start a new shell (or `source` the file) for the
  * NODE_OPTIONS to take effect — we tell them this in the wizard's
- * post-install message. For Phase 3 we don't try to mutate the running
- * shell; that's a Phase 6 nice-to-have.
+ * post-install message.
  *
  * Windows: shell-config.writeShellLine returns no rc files on Windows
  * (we only support POSIX in P3). The wizard prints manual instructions
@@ -40,8 +45,8 @@ export async function installNodeShim({ cwd = process.cwd(), dryRun = false } =
       reason: 'windows_not_supported_yet',
       message:
         'Windows shell-config writing is not yet supported. Set ' +
-        'NODE_OPTIONS=--require @robot-resources/router/auto manually in your ' +
-        'system environment variables, or wait for Phase 6.',
+        'NODE_OPTIONS to point at ~/.robot-resources/router/auto.cjs manually ' +
+        'in your system environment variables, or wait for Phase 6.',
     };
   }
 
@@ -58,8 +63,29 @@ export async function installNodeShim({ cwd = process.cwd(), dryRun = false } =
     return { ok: true, message: 'Dry-run: would have written NODE_OPTIONS to shell rc.' };
   }
 
+  // Phase 8: copy router to an absolute path under ~/.robot-resources/router/
+  // before we wire the shell config. If the copy fails, we don't write a
+  // broken NODE_OPTIONS line.
+  let autoPath;
+  try {
+    autoPath = installRouterFiles();
+  } catch (err) {
+    await emit({
+      shell: 'unknown',
+      shell_config_path: null,
+      sdks_detected: sdks,
+      dry_run: false,
+      reason: 'router_copy_failed',
+      error_messages: [err.message],
+    });
+    return {
+      ok: false,
+      message: `Could not copy router files to ~/.robot-resources/router/: ${err.message}`,
+    };
+  }
+
   const alreadyInstalled = hasShellLine();
-  const result = writeShellLine();
+  const result = writeShellLine({ autoPath });
 
   // Single shell value for the funnel even though we may have written to
   // multiple rc files. Pick the dominant one for telemetry.
@@ -74,6 +100,7 @@ export async function installNodeShim({ cwd = process.cwd(), dryRun = false } =
     files_written: result.written.length,
     files_with_errors: result.errors.length,
     error_messages: result.errors.map((e) => `${e.path}: ${e.message}`).slice(0, 3),
+    auto_path: autoPath,
   });
 
   if (alreadyInstalled && result.written.length === 0) {

package/lib/install-router-files.js

@@ -0,0 +1,48 @@
+import { existsSync, mkdirSync, copyFileSync, cpSync, rmSync } from 'node:fs';
+import { homedir } from 'node:os';
+import { join, dirname } from 'node:path';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+
+/**
+ * Copy `@robot-resources/router` to ~/.robot-resources/router/ and return
+ * the absolute path to its auto.cjs.
+ *
+ * Phase 8 fix. Mirrors `installPluginFiles()` in tool-config.js (the OC
+ * plugin path that's worked since Phase 0). The destination is a stable
+ * user-scoped location that survives npm/npx cache cleanups, so the
+ * NODE_OPTIONS line we write to shell rc doesn't break when caches expire.
+ *
+ * Files copied: auto.cjs, index.js, package.json, lib/ (recursive).
+ * Each call wipes lib/ first so files removed in newer router versions
+ * don't linger from a previous install.
+ *
+ * Why this is its own module: extracted from install-node-shim.js for
+ * testability — vitest can mock the whole module without us mocking
+ * node:fs / node:module manually in every install-shim test case.
+ */
+export function installRouterFiles({ home = homedir() } = {}) {
+  const pkgPath = require.resolve('@robot-resources/router/package.json');
+  const pkgDir = dirname(pkgPath);
+  const targetDir = join(home, '.robot-resources', 'router');
+  mkdirSync(targetDir, { recursive: true });
+
+  for (const file of ['auto.cjs', 'index.js', 'package.json']) {
+    const src = join(pkgDir, file);
+    if (existsSync(src)) {
+      copyFileSync(src, join(targetDir, file));
+    }
+  }
+
+  // Refresh lib/ — wipe + recopy so we don't accumulate stale files across
+  // router upgrades. Same pattern as tool-config.js installPluginFiles().
+  const srcLib = join(pkgDir, 'lib');
+  const dstLib = join(targetDir, 'lib');
+  if (existsSync(srcLib)) {
+    rmSync(dstLib, { recursive: true, force: true });
+    cpSync(srcLib, dstLib, { recursive: true });
+  }
+
+  return join(targetDir, 'auto.cjs');
+}

package/lib/shell-config.js

@@ -11,10 +11,19 @@ import { join } from 'node:path';
  * regex-matching against the user's actual shell content:
  *
  *     # >>> robot-resources: NODE_OPTIONS auto-attach >>>
- *     export NODE_OPTIONS="${NODE_OPTIONS:-} --require @robot-resources/router/auto"
+ *     export NODE_OPTIONS="${NODE_OPTIONS:-} --require /Users/x/.robot-resources/router/auto.cjs"
  *     # <<< robot-resources <<<
  *
- * Behavior decisions (see plan):
+ * Phase 8 fix: NODE_OPTIONS now uses an ABSOLUTE PATH to the auto.cjs the
+ * wizard copied to ~/.robot-resources/router/. The previous bare-module
+ * form `--require @robot-resources/router/auto` only resolved when the user
+ * was cd'd inside a project that had `@robot-resources/router` in its
+ * node_modules — and broke EVERY Node command from any other cwd with
+ * `Cannot find module`. Result: every wizard-success Node user pre-Phase-8
+ * had a NODE_OPTIONS line that crashed `node`/`npm`/etc. Symptom in
+ * Supabase: `node_shim_installed: 8` but `adapter_attached: 0`.
+ *
+ * Behavior decisions (preserved from Phase 3):
  *   - If NODE_OPTIONS is already set with a different --require (rare; e.g.
  *     dd-trace), append ours after theirs. Both load. The user keeps their
  *     existing tooling. The shell expansion `${NODE_OPTIONS:-} ...` handles
@@ -27,12 +36,14 @@ import { join } from 'node:path';
 const MARK_BEGIN = '# >>> robot-resources: NODE_OPTIONS auto-attach >>>';
 const MARK_END = '# <<< robot-resources <<<';
 
-const POSIX_LINE =
-  'export NODE_OPTIONS="${NODE_OPTIONS:-} --require @robot-resources/router/auto"';
+function buildPosixLine(autoPath) {
+  return `export NODE_OPTIONS="\${NODE_OPTIONS:-} --require ${autoPath}"`;
+}
 
-// Fish has different syntax (no `export`, uses `set -x`). Detected separately.
-const FISH_LINE =
-  'set -x NODE_OPTIONS "$NODE_OPTIONS --require @robot-resources/router/auto"';
+function buildFishLine(autoPath) {
+  // Fish has different syntax (no `export`, uses `set -x`).
+  return `set -x NODE_OPTIONS "$NODE_OPTIONS --require ${autoPath}"`;
+}
 
 /**
  * Discover which rc files are present for this user. Returns a list of
@@ -73,7 +84,11 @@ export function hasShellLine(home = homedir()) {
  * others on one failure. Per-file errors are returned as warnings the
  * caller can surface.
  */
-export function writeShellLine(home = homedir()) {
+export function writeShellLine({ autoPath, home = homedir() }) {
+  if (!autoPath) {
+    throw new Error('writeShellLine requires { autoPath } — absolute path to auto.cjs');
+  }
+
   const rcs = listShellRcFiles(home);
   const written = [];
   const errors = [];
@@ -97,7 +112,7 @@ export function writeShellLine(home = homedir()) {
         continue;
       }
 
-      const line = rc.kind === 'fish' ? FISH_LINE : POSIX_LINE;
+      const line = rc.kind === 'fish' ? buildFishLine(autoPath) : buildPosixLine(autoPath);
       const block =
         (text && !text.endsWith('\n') ? '\n' : '') +
         '\n' + MARK_BEGIN + '\n' + line + '\n' + MARK_END + '\n';
@@ -165,4 +180,4 @@ function getMode(path) {
 }
 
 // Exported for tests + telemetry payloads.
-export { MARK_BEGIN, MARK_END, POSIX_LINE, FISH_LINE };
+export { MARK_BEGIN, MARK_END, buildPosixLine, buildFishLine };

package/lib/uninstall.js

@@ -100,6 +100,19 @@ export function runUninstall({ purge = false } = {}) {
     errors.push({ component: 'shell_config_node_options', message: err.message });
   }
 
+  // 3b. Copied router dir at ~/.robot-resources/router/ (Phase 8). The shell
+  //     line points at this absolute path — once the line is gone, the
+  //     copied files are dead weight. Remove them.
+  const routerDir = join(homedir(), '.robot-resources', 'router');
+  if (existsSync(routerDir)) {
+    try {
+      rmSync(routerDir, { recursive: true, force: true });
+      components_removed.push('node_shim_router_dir');
+    } catch (err) {
+      errors.push({ component: 'node_shim_router_dir', message: err.message });
+    }
+  }
+
   // 4. Python shim — `pip uninstall -y robot-resources` against the resolved
   //    venv. Skip silently if no venv detected (the user may have installed
   //    via the wizard but already deleted the venv themselves).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "robot-resources",
-  "version": "1.12.4",
+  "version": "1.13.0",
   "description": "Robot Resources — AI agent tools. One command to install everything.",
   "type": "module",
   "bin": {