robobyte-front-builder 1.0.17 → 1.0.21

package/src/views/genericTable/convertStringFunctions.js

@@ -0,0 +1,336 @@
+/**
+ * Convert string-based functions to executable functions
+ * Used for extraCols and columnsConfig that come from JSON configuration.
+ *
+ * ─────────────────────────────────────────────────────────────────────────────
+ * INJECTED VARIABLES (available inside every column function)
+ * ─────────────────────────────────────────────────────────────────────────────
+ *
+ *  rowData    {object}  — The current row's data object (params.data). Injected
+ *                         per-call into the second-argument scope so column functions
+ *                         can destructure it directly:
+ *                           (params, { rowData }) => rowData.Status === 'Active'
+ *
+ *  nodeName   {string}  — The builder node ID of the ReportViewer that owns this
+ *                         table. Use it to target this table's ref from outside,
+ *                         or pass it to node-aware helpers below.
+ *
+ *  reportRefs {object}  — The live registry of all ReportViewer refs on the page.
+ *                         Shape: { [nodeId]: React.MutableRefObject<updateRow[]> }
+ *                         Access any table's ref: reportRefs.current['someNodeId']
+ *
+ * ─────────────────────────────────────────────────────────────────────────────
+ * HELPER FUNCTIONS (also injected — no imports needed)
+ * ─────────────────────────────────────────────────────────────────────────────
+ *
+ *  All original helpers from updateRefHelpers are available:
+ *    setUpdateRefValue, setUpdateRefRow, getUpdateRefValue, hasUpdateRefValue,
+ *    removeUpdateRefByRowId, clearUpdateRefRow, clearAllUpdateRef,
+ *    cloneUpdateRefToOriginal, restoreUpdateRefFromOriginal
+ *
+ *  PLUS node-aware wrappers — these accept an optional last `node` argument:
+ *    - If node is omitted → uses params.context.updateRef (direct, backward compat)
+ *    - If node is a string → uses reportRefs.current[node] (targets another table)
+ *    - Pass the special constant `THIS_NODE` to target THIS table by nodeName
+ *
+ *    setRefValue(updateRef, rowData, rowUniqueId, fieldPath, newValue, node?)
+ *    setRefRow(updateRef, rowData, rowUniqueId, updates, node?)
+ *    getRefValue(updateRef, rowData, rowUniqueId, fieldPath, node?)
+ *    hasRefValue(updateRef, rowData, rowUniqueId, fieldPath, node?)
+ *    clearRefRow(updateRef, rowData, rowUniqueId, node?)
+ *    clearAllRef(updateRef, node?)
+ *
+ *  Convenience: resolve a ref without specifying updateRef at all
+ *    getNodeRef(nodeId?)  — returns the updateRef for nodeId (or nodeName if omitted)
+ *
+ * ─────────────────────────────────────────────────────────────────────────────
+ * USAGE EXAMPLES
+ * ─────────────────────────────────────────────────────────────────────────────
+ *
+ * // valueSetter — using rowData from the second-argument scope:
+ * (params, { rowData, setRefValue, getNodeRef }) => {
+ *   const { newValue } = params
+ *   rowData.IsPublic = newValue
+ *   setRefValue(params.context.updateRef, rowData, 'Id', 'IsPublic', newValue)
+ *   return true
+ * }
+ *
+ * // valueSetter — same table, using getNodeRef shortcut:
+ * (params, { rowData }) => {
+ *   const { newValue } = params
+ *   rowData.IsPublic = newValue
+ *   setUpdateRefValue(getNodeRef(), rowData, 'Id', 'IsPublic', newValue)
+ *   return true
+ * }
+ *
+ * // valueSetter — update a DIFFERENT table's ref by its builder node ID:
+ * (params) => {
+ *   const { newValue, data, context } = params
+ *   data.Amount = newValue
+ *   setRefValue(context.updateRef, data, 'Id', 'Amount', newValue, 'report-node-abc')
+ *   return true
+ * }
+ *
+ * // valueGetter — read from ref, fall back to raw data:
+ * (params) => {
+ *   return getRefValue(params.context.updateRef, params.data, 'Id', 'IsPublic')
+ *     ?? params.data?.IsPublic
+ * }
+ *
+ * // Directly access any report's ref (e.g. from a button action):
+ * const ref = reportRefs.current['some-node-id']
+ * const changes = ref?.current ?? []
+ *
+ * ─────────────────────────────────────────────────────────────────────────────
+ */
+
+import {
+  setUpdateRefValue,
+  setUpdateRefRow,
+  getUpdateRefValue,
+  hasUpdateRefValue,
+  removeUpdateRefByRowId,
+  clearUpdateRefRow,
+  clearAllUpdateRef,
+  cloneUpdateRefToOriginal,
+  restoreUpdateRefFromOriginal,
+} from './updateRefHelpers'
+import fetchReportDataByPageId from 'services/reportData/fetchReportData'
+
+// ─── Sentinel constant ────────────────────────────────────────────────────────
+// Pass THIS_NODE as the `node` arg to target the current table's nodeName.
+export const THIS_NODE = '__THIS__'
+
+// ─── Helper factory ───────────────────────────────────────────────────────────
+
+/**
+ * Resolve the effective updateRef for a given node identifier.
+ * - node === undefined/null  → use the passed directRef (backward compat)
+ * - node === THIS_NODE       → use reportRefs.current[nodeName]
+ * - node === string          → use reportRefs.current[node]
+ *
+ * Exported so other execution contexts (e.g. RowActionsCell) can reuse it.
+ */
+export function makeNodeAwareHelpers(reportRefs, nodeName) {
+  function resolveRef(directRef, node) {
+    if (!node) return directRef
+    const id = node === THIS_NODE ? nodeName : node
+    return (reportRefs?.current?.[id]) ?? directRef
+  }
+
+  return {
+    /** Resolve a ref without needing directRef — returns the updateRef for nodeId (or nodeName) */
+    getNodeRef: (nodeId) => {
+      const id = nodeId ?? nodeName
+      return reportRefs?.current?.[id] ?? null
+    },
+
+    setRefValue: (directRef, rowData, rowUniqueId, fieldPath, newValue, node) =>
+      setUpdateRefValue(resolveRef(directRef, node), rowData, rowUniqueId, fieldPath, newValue),
+
+    setRefRow: (directRef, rowData, rowUniqueId, updates, node) =>
+      setUpdateRefRow(resolveRef(directRef, node), rowData, rowUniqueId, updates),
+
+    getRefValue: (directRef, rowData, rowUniqueId, fieldPath, node) =>
+      getUpdateRefValue(resolveRef(directRef, node), rowData, rowUniqueId, fieldPath),
+
+    hasRefValue: (directRef, rowData, rowUniqueId, fieldPath, node) =>
+      hasUpdateRefValue(resolveRef(directRef, node), rowData, rowUniqueId, fieldPath),
+
+    clearRefRow: (directRef, rowData, rowUniqueId, node) =>
+      clearUpdateRefRow(resolveRef(directRef, node), rowData, rowUniqueId),
+
+    clearAllRef: (directRef, node) =>
+      clearAllUpdateRef(resolveRef(directRef, node)),
+  }
+}
+
+// ─── Core converter ───────────────────────────────────────────────────────────
+
+/**
+ * Convert a string function to an executable function.
+ * Injects updateRef helpers + node-aware utilities into scope.
+ *
+ * @param {string} funcString          - The function as a string
+ * @param {object} [ctx]               - Optional context for node-aware helpers
+ * @param {object} [ctx.reportRefs]    - The live reportRefs registry (useRef)
+ * @param {string} [ctx.nodeName]      - The builder node ID for this table
+ * @returns {Function|string}
+ */
+export const convertStringToFunction = (funcString, ctx = {}) => {
+  if (typeof funcString !== 'string' || !funcString.trim()) return funcString
+
+  const { reportRefs = null, nodeName = '', data = {}, dataRef = {}, setData = null, openDialog = null, closeDialog = null } = ctx
+  const nodeHelpers = makeNodeAwareHelpers(reportRefs, nodeName)
+
+  // ── Scope object ─────────────────────────────────────────────────────────────
+  // Passed explicitly as the second argument: (params, { data, setData, ... }) => {}
+  // Also injected into the lexical scope via new Function for backward compatibility
+  // with old single-argument functions that reference helpers directly by name.
+  const scope = {
+    // Viewer state
+    data,
+    setData:        setData ?? (() => {}),
+    dataRef,
+    fetchReportData: fetchReportDataByPageId,
+    openDialog:     openDialog  ?? (() => {}),
+    closeDialog:    closeDialog ?? (() => {}),
+    // Node-aware ref wrappers
+    setRefValue:    nodeHelpers.setRefValue,
+    setRefRow:      nodeHelpers.setRefRow,
+    getRefValue:    nodeHelpers.getRefValue,
+    hasRefValue:    nodeHelpers.hasRefValue,
+    clearRefRow:    nodeHelpers.clearRefRow,
+    clearAllRef:    nodeHelpers.clearAllRef,
+    getNodeRef:     nodeHelpers.getNodeRef,
+    // Low-level ref helpers
+    setUpdateRefValue, setUpdateRefRow, getUpdateRefValue, hasUpdateRefValue,
+    removeUpdateRefByRowId, clearUpdateRefRow, clearAllUpdateRef,
+    cloneUpdateRefToOriginal, restoreUpdateRefFromOriginal,
+    // Context constants
+    reportRefs, nodeName, THIS_NODE,
+  }
+
+  const scopeNames  = Object.keys(scope)
+  const scopeValues = Object.values(scope)
+
+  try {
+    const trimmed = funcString.trim()
+
+    // Strip leading block comments (/** ... */ or /* ... */) and line comments (// ...)
+    // so the pattern check below works even when the user writes JSDoc above the function.
+    const stripped = trimmed
+      .replace(/^(\s*(\/\*[\s\S]*?\*\/|\/\/[^\n]*)\s*)+/, '')
+      .trim()
+
+    let bodyTemplate
+
+    if (stripped.startsWith('(') && trimmed.includes('=>')) {
+      bodyTemplate = `"use strict"; const userFunc = ${trimmed}; return userFunc;`
+    } else if (stripped.startsWith('function') || stripped.startsWith('async function')) {
+      bodyTemplate = `"use strict"; const userFunc = ${trimmed}; return userFunc;`
+    } else if (stripped.startsWith('async (') || stripped.startsWith('async(')) {
+      bodyTemplate = `"use strict"; const userFunc = ${trimmed}; return userFunc;`
+    } else if (stripped.startsWith('return ')) {
+      bodyTemplate = `"use strict"; return function(params) { ${trimmed} };`
+    } else {
+      return funcString
+    }
+
+    // eslint-disable-next-line no-new-func
+    const userFunc = new Function(...scopeNames, bodyTemplate)(...scopeValues)
+
+    // Return an AG Grid-compatible 1-arg wrapper that passes `scope` as the
+    // explicit second argument — (params, { data, setData, rowData, ... }) => {}
+    // rowData is the current row's data object (agParams.data), injected per-call
+    // so column functions can destructure it directly without going through params.
+    return (agParams) => userFunc(agParams, { ...scope, rowData: agParams?.data })
+  } catch (e) {
+    console.error('Failed to convert string to function:', e)
+    console.error('Function string:', funcString)
+    return funcString
+  }
+}
+
+// ─── Column definition processors ────────────────────────────────────────────
+
+const FUNCTION_PROPERTIES = [
+  'valueSetter', 'valueGetter', 'valueFormatter', 'valueParser',
+  'cellRenderer', 'cellEditor', 'cellClass', 'cellStyle', 'editable',
+  'comparator', 'equals', 'keyCreator', 'filterValueGetter', 'filterParams',
+  'cellEditorParams', 'cellRendererParams', 'headerValueGetter',
+  'tooltipValueGetter', 'aggFunc', 'getQuickFilterText',
+  'suppressKeyboardEvent', 'suppressPaste', 'cellClassRules',
+]
+
+/**
+ * Process a single column definition — convert all string functions.
+ *
+ * @param {object} colDef
+ * @param {object} [ctx]           - { reportRefs, nodeName }
+ * @returns {object}
+ */
+export const processColumnDefinition = (colDef, ctx = {}) => {
+  if (!colDef || typeof colDef !== 'object') return colDef
+
+  const processed = { ...colDef }
+
+  FUNCTION_PROPERTIES.forEach(prop => {
+    if (prop in processed && typeof processed[prop] === 'string') {
+      const converted = convertStringToFunction(processed[prop], ctx)
+      if (converted !== processed[prop]) {
+        if (prop === 'valueSetter' || prop === 'valueGetter') {
+          console.log(`[processColumnDef] ✅ "${prop}" on field "${processed.field}" converted to function`)
+        }
+        processed[prop] = converted
+      } else {
+        if (prop === 'valueSetter' || prop === 'valueGetter') {
+          console.warn(`[processColumnDef] ⚠️ "${prop}" on field "${processed.field}" was NOT converted — string returned as-is:`, processed[prop])
+        }
+      }
+    }
+  })
+
+  // Special handling for cellEditorParams — can be a function string or plain JSON object.
+  if ('cellEditorParams' in processed && typeof processed.cellEditorParams === 'string') {
+    const converted = convertStringToFunction(processed.cellEditorParams, ctx)
+    if (converted !== processed.cellEditorParams) {
+      // Was recognised as a function string → use the converted function
+      console.log(`[processColumnDef] ✅ cellEditorParams on field "${processed.field}" converted to function`)
+      processed.cellEditorParams = converted
+    } else {
+      // Not a function — try JSON.parse so editors receive a plain object, not a string
+      try {
+        processed.cellEditorParams = JSON.parse(processed.cellEditorParams)
+        console.log(`[processColumnDef] ✅ cellEditorParams on field "${processed.field}" parsed as JSON object`)
+      } catch { /* leave as-is */ }
+    }
+  } else if ('cellEditorParams' in processed) {
+    console.log(`[processColumnDef] ℹ️ cellEditorParams on field "${processed.field}" is already type "${typeof processed.cellEditorParams}" — skipped conversion`)
+  }
+
+  // Ensure MultiSelectEditor always runs as a popup — required for AG Grid v33+.
+  // cellEditorPopup on the colDef is the authoritative way; isPopup() on the
+  // component instance alone is not reliable in modern AG Grid React.
+  if (processed.cellEditor === 'MultiSelectEditor') {
+    processed.cellEditorPopup = true
+    console.log(`[processColumnDef] ✅ cellEditorPopup=true injected for field "${processed.field}"`, {
+      cellEditorParamsType: typeof processed.cellEditorParams,
+      hasValueSetter: typeof processed.valueSetter === 'function',
+      hasValueGetter: typeof processed.valueGetter === 'function',
+    })
+  }
+
+  return processed
+}
+
+/**
+ * Process an array of column definitions.
+ *
+ * @param {Array}  colDefs
+ * @param {object} [ctx]   - { reportRefs, nodeName }
+ * @returns {Array}
+ */
+export const processColumnDefinitions = (colDefs, ctx = {}) => {
+  if (!Array.isArray(colDefs)) return colDefs
+  return colDefs.map(colDef => processColumnDefinition(colDef, ctx))
+}
+
+/**
+ * Process columnsConfig array — [{ field, config }] format.
+ *
+ * @param {Array}  columnsConfig
+ * @param {object} [ctx]          - { reportRefs, nodeName }
+ * @returns {Array}
+ */
+export const processColumnsConfig = (columnsConfig, ctx = {}) => {
+  if (!Array.isArray(columnsConfig)) return columnsConfig
+
+  return columnsConfig.map(item => {
+    if (!item || !item.config) return item
+    return {
+      ...item,
+      config: processColumnDefinition(item.config, ctx),
+    }
+  })
+}

package/src/views/genericTable/statusBar/rowCountStatusBar.js

@@ -10,7 +10,9 @@ const CustomStatusBar = ({ api }) => {
 
     const updateStatus = () => {
       setTotalRows(api.getDisplayedRowCount());
-      setSelectedRows(api.getSelectedRows().length);
+      // getSelectedRows() can return undefined when row selection is not configured
+      const selected = api.getSelectedRows?.() ?? []
+      setSelectedRows(Array.isArray(selected) ? selected.length : 0);
     };
 
     // Listen to row changes