robloxstudio-mcp 2.7.0-next.3 → 2.7.0-next.5

package/dist/index.js

@@ -158,7 +158,7 @@ var TOOL_HANDLERS = {
   }),
   get_script_source: (tools, body) => tools.getScriptSource(body.instancePath, body.startLine, body.endLine),
   set_script_source: (tools, body) => tools.setScriptSource(body.instancePath, body.source),
-  edit_script_lines: (tools, body) => tools.editScriptLines(body.instancePath, body.old_string, body.new_string),
+  edit_script_lines: (tools, body) => tools.editScriptLines(body.instancePath, body.old_string, body.new_string, body.startLine),
   insert_script_lines: (tools, body) => tools.insertScriptLines(body.instancePath, body.afterLine, body.newContent),
   delete_script_lines: (tools, body) => tools.deleteScriptLines(body.instancePath, body.startLine, body.endLine),
   get_attribute: (tools, body) => tools.getAttribute(body.instancePath, body.attributeName),
@@ -1629,11 +1629,14 @@ ${code}`
       ]
     };
   }
-  async editScriptLines(instancePath, oldString, newString) {
+  async editScriptLines(instancePath, oldString, newString, startLine) {
     if (!instancePath || typeof oldString !== "string" || typeof newString !== "string") {
       throw new Error("Instance path, old_string, and new_string are required for edit_script_lines");
     }
-    const response = await this.client.request("/api/edit-script-lines", { instancePath, old_string: oldString, new_string: newString });
+    const payload = { instancePath, old_string: oldString, new_string: newString };
+    if (startLine !== void 0)
+      payload.startLine = startLine;
+    const response = await this.client.request("/api/edit-script-lines", payload);
     return {
       content: [
         {
@@ -2496,6 +2499,18 @@ ${code}`
       }]
     };
   }
+  async resolveImageId(decalAssetId) {
+    try {
+      const resp = await fetch(`https://economy.roblox.com/v2/assets/${decalAssetId}/details`);
+      if (!resp.ok)
+        return decalAssetId;
+      const details = await resp.json();
+      if (details.TextureId)
+        return String(details.TextureId);
+    } catch {
+    }
+    return decalAssetId;
+  }
   async uploadDecal(filePath, displayName, description, userId, groupId) {
     if (!fs.existsSync(filePath)) {
       throw new Error(`File not found: ${filePath}`);
@@ -2517,10 +2532,15 @@ ${code}`
         description: description || "",
         creationContext: { creator }
       }, fileContent, fileName);
+      const decalId = result.response?.assetId;
+      const imageId = decalId ? await this.resolveImageId(decalId) : void 0;
       return {
         content: [{
           type: "text",
-          text: JSON.stringify(result)
+          text: JSON.stringify({
+            ...result,
+            imageId
+          })
         }]
       };
     }
@@ -2535,7 +2555,8 @@ ${code}`
               assetId: String(result.assetId),
               displayName,
               assetType: "Decal",
-              backingAssetId: String(result.backingAssetId)
+              backingAssetId: String(result.backingAssetId),
+              imageId: String(result.backingAssetId)
             }
           })
         }]
@@ -3013,7 +3034,7 @@ var RobloxStudioMCPServer = class {
           case "set_script_source":
             return await this.tools.setScriptSource(args?.instancePath, args?.source);
           case "edit_script_lines":
-            return await this.tools.editScriptLines(args?.instancePath, args?.old_string, args?.new_string);
+            return await this.tools.editScriptLines(args?.instancePath, args?.old_string, args?.new_string, args?.startLine);
           case "insert_script_lines":
             return await this.tools.insertScriptLines(args?.instancePath, args?.afterLine, args?.newContent);
           case "delete_script_lines":
@@ -3766,7 +3787,7 @@ var TOOL_DEFINITIONS = [
   {
     name: "edit_script_lines",
     category: "write",
-    description: "Replace exact text in a script. old_string must match exactly once in the script (whitespace-sensitive). Use get_script_source first to see current content.",
+    description: "Replace exact text in a script. Without startLine, old_string must match exactly once in the script. Pass startLine (1-indexed, from get_script_source) to anchor the edit to a specific line when old_string is ambiguous (e.g. repeated closing braces).",
     inputSchema: {
       type: "object",
       properties: {
@@ -3776,11 +3797,15 @@ var TOOL_DEFINITIONS = [
         },
         old_string: {
           type: "string",
-          description: "Exact text to find and replace (must be unique in the script)"
+          description: "Exact text to find and replace. Must be unique in the script unless startLine is provided."
         },
         new_string: {
           type: "string",
           description: "Replacement text"
+        },
+        startLine: {
+          type: "number",
+          description: "Optional 1-indexed line where old_string begins. When provided, skips uniqueness check and requires old_string to match starting at that exact line."
         }
       },
       required: ["instancePath", "old_string", "new_string"]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "robloxstudio-mcp",
-  "version": "2.7.0-next.3",
+  "version": "2.7.0-next.5",
   "description": "MCP Server for Roblox Studio Integration - Access Studio data, scripts, and objects through AI tools",
   "main": "dist/index.js",
   "type": "module",

package/studio-plugin/MCPPlugin.rbxmx

@@ -4429,11 +4429,11 @@ local function setScriptSource(requestData)
 		error = `Failed to set script source. UpdateSourceAsync failed: {updateResult}. Direct assignment failed: {directResult}. Replace method failed: {replaceResult}`,
 	}
 end
-local escapeLuaPattern, escapeLuaReplacement
 local function editScriptLines(requestData)
 	local instancePath = requestData.instancePath
 	local oldString = requestData.old_string
 	local newString = requestData.new_string
+	local startLine = requestData.startLine
 	if not (instancePath ~= "" and instancePath) or oldString == nil or newString == nil then
 		return {
 			error = "Instance path, old_string, and new_string are required",
@@ -4455,31 +4455,55 @@ local function editScriptLines(requestData)
 	local recordingId = beginRecording(`Edit script: {instance.Name}`)
 	local success, result = pcall(function()
 		local source = readScriptSource(instance)
-		-- Count occurrences to ensure uniqueness
-		local count = 0
-		local searchPos = 1
 		local searchLen = #oldString
-		while true do
-			local foundStart = string.find(source, oldString, searchPos, true)
-			if foundStart == nil then
-				break
+		local matchStart
+		if startLine ~= nil then
+			if startLine < 1 then
+				error(`startLine must be >= 1 (got {startLine})`)
+			end
+			local lineStartByte = 1
+			local currentLine = 1
+			while currentLine < startLine do
+				local nlPos = string.find(source, "\n", lineStartByte, true)
+				if nlPos == nil then
+					error(`startLine {startLine} is past end of script ({currentLine} lines)`)
+				end
+				lineStartByte = nlPos + 1
+				currentLine += 1
+			end
+			local candidate = string.sub(source, lineStartByte, lineStartByte + searchLen - 1)
+			if candidate ~= oldString then
+				error(`old_string does not match at line {startLine}. Use get_script_source to verify the exact text at that line.`)
+			end
+			matchStart = lineStartByte
+		else
+			local count = 0
+			local searchPos = 1
+			local firstMatch
+			while true do
+				local foundStart = string.find(source, oldString, searchPos, true)
+				if foundStart == nil then
+					break
+				end
+				if firstMatch == nil then
+					firstMatch = foundStart
+				end
+				count += 1
+				if count > 1 then
+					break
+				end
+				searchPos = foundStart + searchLen
+			end
+			if count == 0 then
+				error("old_string not found in script. If old_string contains repeated patterns (e.g. closing braces), pass startLine to anchor the edit.")
 			end
-			count += 1
 			if count > 1 then
-				break
+				error("old_string matches multiple locations. Provide more surrounding context, or pass startLine to anchor the edit to a specific line.")
 			end
-			searchPos = foundStart + searchLen
-		end
-		if count == 0 then
-			error("old_string not found in script")
-		end
-		if count > 1 then
-			error("old_string matches multiple locations. Provide more surrounding context to make it unique")
+			matchStart = firstMatch
 		end
-		-- Perform the replacement (plain literal find + replace)
-		local escaped = escapeLuaPattern(oldString)
-		local escapedRepl = escapeLuaReplacement(newString)
-		local newSource = string.gsub(source, escaped, escapedRepl, 1)
+		-- Byte-slice replacement avoids Lua pattern escaping (safe for multi-byte chars like em dashes).
+		local newSource = string.sub(source, 1, matchStart - 1) .. newString .. string.sub(source, matchStart + searchLen)
 		ScriptEditorService:UpdateSourceAsync(instance, function()
 			return newSource
 		end)
@@ -4677,10 +4701,10 @@ local function deleteScriptLines(requestData)
 		error = `Failed to delete script lines: {result}`,
 	}
 end
-function escapeLuaPattern(s)
+local function escapeLuaPattern(s)
 	return (string.gsub(s, "([%(%)%.%%%+%-%*%?%[%]%^%$])", "%%%1"))
 end
-function escapeLuaReplacement(s)
+local function escapeLuaReplacement(s)
 	return (string.gsub(s, "%%", "%%%%"))
 end
 local function caseInsensitiveLiteralReplace(src, searchStr, repl)
@@ -5273,7 +5297,7 @@ return {
         <Properties>
           <string name="Name">State</string>
           <string name="Source"><![CDATA[-- Compiled with roblox-ts v3.0.0
-local CURRENT_VERSION = "2.7.0-next.2"
+local CURRENT_VERSION = "2.7.0-next.5"
 local MAX_CONNECTIONS = 5
 local BASE_PORT = 58741
 local activeTabIndex = 0

package/studio-plugin/src/modules/handlers/ScriptHandlers.ts

@@ -203,6 +203,7 @@ function editScriptLines(requestData: Record<string, unknown>) {
 	const instancePath = requestData.instancePath as string;
 	let oldString = requestData.old_string as string;
 	let newString = requestData.new_string as string;
+	const startLine = requestData.startLine as number | undefined;
 
 	if (!instancePath || oldString === undefined || newString === undefined) {
 		return { error: "Instance path, old_string, and new_string are required" };
@@ -221,27 +222,47 @@ function editScriptLines(requestData: Record<string, unknown>) {
 
 	const [success, result] = pcall(() => {
 		const source = readScriptSource(instance);
-
-		// Count occurrences to ensure uniqueness
-		let count = 0;
-		let searchPos = 1;
 		const searchLen = oldString.size();
+		let matchStart: number;
 
-		while (true) {
-			const [foundStart] = string.find(source, oldString, searchPos, true);
-			if (foundStart === undefined) break;
-			count++;
-			if (count > 1) break;
-			searchPos = foundStart + searchLen;
-		}
+		if (startLine !== undefined) {
+			if (startLine < 1) error(`startLine must be >= 1 (got ${startLine})`);
 
-		if (count === 0) error("old_string not found in script");
-		if (count > 1) error("old_string matches multiple locations. Provide more surrounding context to make it unique");
+			let lineStartByte = 1;
+			let currentLine = 1;
+			while (currentLine < startLine) {
+				const [nlPos] = string.find(source, "\n", lineStartByte, true);
+				if (nlPos === undefined) {
+					error(`startLine ${startLine} is past end of script (${currentLine} lines)`);
+				}
+				lineStartByte = (nlPos as number) + 1;
+				currentLine++;
+			}
+
+			const candidate = string.sub(source, lineStartByte, lineStartByte + searchLen - 1);
+			if (candidate !== oldString) {
+				error(`old_string does not match at line ${startLine}. Use get_script_source to verify the exact text at that line.`);
+			}
+			matchStart = lineStartByte;
+		} else {
+			let count = 0;
+			let searchPos = 1;
+			let firstMatch: number | undefined;
+			while (true) {
+				const [foundStart] = string.find(source, oldString, searchPos, true);
+				if (foundStart === undefined) break;
+				if (firstMatch === undefined) firstMatch = foundStart;
+				count++;
+				if (count > 1) break;
+				searchPos = foundStart + searchLen;
+			}
+			if (count === 0) error("old_string not found in script. If old_string contains repeated patterns (e.g. closing braces), pass startLine to anchor the edit.");
+			if (count > 1) error("old_string matches multiple locations. Provide more surrounding context, or pass startLine to anchor the edit to a specific line.");
+			matchStart = firstMatch as number;
+		}
 
-		// Perform the replacement (plain literal find + replace)
-		const escaped = escapeLuaPattern(oldString);
-		const escapedRepl = escapeLuaReplacement(newString);
-		const [newSource] = string.gsub(source, escaped, escapedRepl, 1);
+		// Byte-slice replacement avoids Lua pattern escaping (safe for multi-byte chars like em dashes).
+		const newSource = string.sub(source, 1, matchStart - 1) + newString + string.sub(source, matchStart + searchLen);
 
 		ScriptEditorService.UpdateSourceAsync(instance, () => newSource);