roast-my-design-system 9.3.0 → 9.3.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "roast-my-design-system",
-  "version": "9.3.0",
+  "version": "9.3.2",
   "mcpName": "io.github.gregkozakiewicz/roast-my-design-system",
   "description": "Your AI can write the UI. This makes sure it writes your UI. A deterministic scanner scores your design system 0-100 against 112 public repos, reads React and web components (Stencil, Lit), hands you a copy-paste fix prompt for each top finding, writes rules for Claude, Cursor, Copilot and Windsurf with --apply, and runs as a local MCP server with --mcp.",
   "keywords": [

package/skills/roast-my-design-system/scripts/harvest/paint.mjs

@@ -50,7 +50,12 @@ const DOOR_TYPO_RE = /(?<![\w-])(?:[\w-]+:)*(?:font-(?:thin|extralight|light|nor
 export const blankComments = (s) => s
   .replace(/\/\*[\s\S]*?\*\//g, (m) => m.replace(/[^\n]/g, ' '))
   .replace(/(^|[^:'"`\\])(\/\/[^\n]*)/g, (m, pre, c) => pre + ' '.repeat(c.length));
-export const DEMO_PATH_RE = /(^|\/)(stories|storybook|__stories__|examples?|demos?|templates?|playground|fixtures?|__tests__|__mocks__|e2e|cypress)\//i;
+// Not templates: in a product a templates folder is usually a screen
+// (teable's admin templates, documenso's and formbricks' template pickers),
+// and hiding it hid their colours from the report and the live checks. A
+// project generator's templates are left out by the walk instead, and email
+// templates by the email rule (2026-09-30).
+export const DEMO_PATH_RE = /(^|\/)(stories|storybook|__stories__|examples?|demos?|playground|fixtures?|__tests__|__mocks__|e2e|cypress)\//i;
 
 /**
  * @param root repo root

package/skills/roast-my-design-system/scripts/harvest/tokens.mjs

@@ -573,6 +573,9 @@ export function harvestTokens(root, styleFiles, codeFiles, { email = null } = {}
     // triggered the "every single one is hardcoded" banner on it.
     const renderToImage = RENDER_TO_IMAGE_RE.test(src) || OG_ROUTE_RE.test(f);
     if (renderToImage) { skip(f, src); continue; }
+    // a page a headless browser prints to a PDF (rybbit's reports), found by
+    // the walk from the file that prints it (lib/exempt.mjs printedFilesOf)
+    if (email?.printed?.includes(f)) { skip(f, src); continue; }
     // an email written with an email kit, wherever it lives (react-email)
     if (EMAIL_KIT_RE.test(src)) { skip(f, src); continue; }
 

package/skills/roast-my-design-system/scripts/harvest/walk.mjs

@@ -4,7 +4,7 @@
  * stylesheets of any flavor, and config — not just a happy-path shadcn layout.
  */
 import { CATALOGUE } from '../profiles/shadcn-data.mjs';
-import { emailContextOf } from '../lib/exempt.mjs';
+import { emailContextOf, printedFilesOf } from '../lib/exempt.mjs';
 import { readFileSync, readdirSync, existsSync, statSync } from 'node:fs';
 import { join, relative, extname } from 'node:path';
 
@@ -80,12 +80,13 @@ const LEGACY_DIR_RE = /^(?:old|legacy|deprecated|archive|archived)$|[-_](?:old|l
 
 // Scaffolding: the code a project generator copies into someone else's new
 // repo, not the product. A starters/ folder, or a templates folder kept by a
-// generator (create-app, a cli), a script or a dev tool: backstage's
-// create-app/templates, the dashboard starter's scripts/cleanup-templates,
-// BuilderIO's starters (133 duplicate copies). The name alone is not enough:
-// backstage's scaffolder form templates, OpenCTI's case templates and
-// nocobase's block templates are screens of the product (2026-09-30).
-const SCAFFOLD_DIR_RE = /(^|\/)starters$|(^|\/)(?:create-[\w-]+|cli|scripts|dev|generators?)\/(?:[^/]+\/)*[\w-]*templates?$/i;
+// generator (create-app, a cli, a command-line tool's commands), a script or
+// a dev tool: backstage's create-app/templates, the dashboard starter's
+// scripts/cleanup-templates, BuilderIO's starters (133 duplicate copies),
+// novu's commands/init/templates. The name alone is not enough: backstage's
+// scaffolder form templates, OpenCTI's case templates and nocobase's block
+// templates are screens of the product (2026-09-30).
+const SCAFFOLD_DIR_RE = /(^|\/)starters$|(^|\/)(?:create-[\w-]+|cli|commands|scripts|dev|generators?)\/(?:[^/]+\/)*[\w-]*templates?$/i;
 
 export function walkRepo(root, maxDepth = 14, exclusions = null, readAnyway = new Set()) {
   const files = { code: [], styles: [], other: [] };
@@ -182,6 +183,9 @@ export function walkRepo(root, maxDepth = 14, exclusions = null, readAnyway = ne
   // where the repo keeps its emails, read once here so every checker that
   // is handed the walk judges an email the same way (lib/exempt.mjs)
   files.email = emailContextOf(files, (f) => readSource(join(root, f)));
+  // and the files a headless browser prints to a PDF, which ride in the same
+  // context so every checker that honours the email rule honours this too
+  files.email.printed = printedFilesOf(files, (f) => readSource(join(root, f)));
   return files;
 }
 

package/skills/roast-my-design-system/scripts/lib/exempt.mjs

@@ -116,6 +116,73 @@ export const ARTWORK_DIR_RE = /(^|\/)(icons?|logos?|illustrations?)\//i;
 // medium: the tool reads the styling off the element (2026-09-17).
 export const RENDER_TO_IMAGE_RE = /ImageResponse|from ['"]satori['"]|from ['"]@react-pdf|next\/og|from ['"](?:html-to-image|html2canvas(?:-pro)?|dom-to-image(?:-more)?|modern-screenshot)['"]/;
 export const OG_ROUTE_RE = /(^|\/)api\/og\//;
+
+// Printed by a headless browser: React turned into HTML (renderToStaticMarkup)
+// and handed to puppeteer or playwright for a PDF or a screenshot. The page
+// loads none of the app's stylesheets, so its styling is written inline, like
+// an email's. The templates carry no marker of their own; the file that
+// prints them does (rybbit's PDF reports: 31 of its 52 inline styles, score
+// 40 against 50 without them). Found in 1 of 205 repos (2026-09-30), and
+// nothing else has that shape: a file that renders React to HTML and drives
+// a headless browser is always making a picture or a PDF.
+const HEADLESS_DEP_RE = /^(?:puppeteer(?:-core)?|playwright(?:-core)?|@sparticuz\/chromium|chrome-aws-lambda)$/;
+const HEADLESS_IMPORT_RE = /(?:from\s+|require\(\s*|import\(\s*)['"](?:puppeteer(?:-core)?|playwright(?:-core)?|@sparticuz\/chromium|chrome-aws-lambda)['"]/;
+const SSR_RENDER_RE = /\brenderTo(?:StaticMarkup|String|StaticNodeStream)\s*\(/;
+const REL_IMPORT_RE = /(?:from\s+|import\(\s*)['"](\.{1,2}\/[^'"]+)['"]/g;
+
+/** A relative import, resolved against the walk's files, or null. */
+function resolveRelative(fromDir, spec, code) {
+  const parts = fromDir ? fromDir.split('/') : [];
+  for (const s of spec.split('/')) {
+    if (s === '.' || s === '') continue;
+    if (s === '..') parts.pop(); else parts.push(s);
+  }
+  const p = parts.join('/');
+  const stem = p.replace(/\.[cm]?[jt]sx?$/, '');
+  const exts = ['.tsx', '.ts', '.jsx', '.js'];
+  for (const c of [p, ...exts.map((e) => stem + e), ...exts.map((e) => `${stem}/index${e}`)]) if (code.has(c)) return c;
+  return null;
+}
+
+/**
+ * The component files a headless browser prints, for the exemption context.
+ * Only packages with a headless browser among their runtime dependencies are
+ * read (a test setup lists it as a devDependency), and only the printer's own
+ * folder is followed: a shared Button it imports from elsewhere stays judged.
+ * @param files  the walk's { code, other } (repo-relative paths)
+ * @param read   (file) => text or null
+ */
+export function printedFilesOf(files, read) {
+  const homes = [];
+  for (const f of (files.other ?? []).filter((x) => base(x) === 'package.json')) {
+    let pkg; try { pkg = JSON.parse(read(f) ?? ''); } catch { continue; }
+    if (Object.keys(pkg?.dependencies ?? {}).some((d) => HEADLESS_DEP_RE.test(d))) homes.push(dir(f));
+  }
+  if (!homes.length) return [];
+  const code = new Set(files.code ?? []);
+  const under = (f, h) => h === '' || f.startsWith(`${h}/`);
+  const printed = new Set();
+  for (const f of files.code ?? []) {
+    if (!/\.[cm]?[jt]sx?$/.test(f) || !homes.some((h) => under(f, h))) continue;
+    const text = read(f) ?? '';
+    if (!HEADLESS_IMPORT_RE.test(text) || !SSR_RENDER_RE.test(text)) continue;
+    if (/\.(tsx|jsx)$/.test(f)) printed.add(f);
+    const home = dir(f);
+    const seen = new Set([f]);
+    const queue = [[f, text]];
+    while (queue.length) {
+      const [from, src] = queue.shift();
+      for (const m of src.matchAll(REL_IMPORT_RE)) {
+        const target = resolveRelative(dir(from), m[1], code);
+        if (!target || seen.has(target) || !under(target, home)) continue;
+        seen.add(target);
+        if (/\.(tsx|jsx)$/.test(target)) printed.add(target);
+        queue.push([target, read(target) ?? '']);
+      }
+    }
+  }
+  return [...printed].sort();
+}
 export const RENDERER_PATH_RE = /(^|\/)(renderers?|scene|canvas)\/|renderElement|DebugCanvas/i;
 
 /** Mostly drawing rather than styling, whatever the file is called. */
@@ -144,6 +211,7 @@ export function exemptReason(file, text = '', { email = null } = {}) {
   if (CRASH_PAGE_RE.test(file)) return 'the crash page replaces the root layout, so the stylesheet never loads there and its styling has to be inline';
   if (RENDERER_PATH_RE.test(file)) return 'a renderer draws pixels, so its colours are the picture rather than the interface';
   if (OG_ROUTE_RE.test(file) || RENDER_TO_IMAGE_RE.test(text)) return 'a render-to-image surface accepts nothing but inline styling, so there is no on-system way to write one';
+  if (email?.printed?.includes(file)) return 'pages a headless browser prints to a PDF or an image load none of the app\'s stylesheets, so their styling has to be inline';
   if (svgHeavy(text)) return 'the file is mostly drawing rather than styling';
   if ((ARTWORK_NAME_RE.test(file) || ARTWORK_DIR_RE.test(file)) && SVG_MARKUP_RE.test(text)) return 'the colours belong to the artwork, not to the interface';
   return null;

package/skills/roast-my-design-system/scripts/lib/guard-api.mjs

@@ -17,7 +17,7 @@ export { designGaps } from './gaps.mjs';
 import { decideProfile, profileOf, installedDirs } from '../profiles/index.mjs';
 import { KITS } from '../profiles/kit-common.mjs';
 import { kitPaintFindings } from './kitpaint.mjs';
-import { PALETTE_CLASS_RE, blankComments } from '../harvest/paint.mjs';
+import { PALETTE_CLASS_RE, DEMO_PATH_RE, blankComments } from '../harvest/paint.mjs';
 import { harvestTokens, extractStyling, normalizeHex, isGrey } from '../harvest/tokens.mjs';
 import { harvestComponents, definedComponents, tsconfigAliases } from '../harvest/components.mjs';
 import { findDuplicates } from '../harvest/duplicates.mjs';
@@ -63,7 +63,10 @@ export { WIDGET_CSS_RE, WIDGET_CONFIG_RE, LIBRARY_CLASS_RE, isLibraryClass } fro
 // blankComments (8.4.5) is what the report and the live checks run on a file
 // before matching, so a class named in a comment paints nothing; a guard that
 // matches the raw text counts it, and disagrees with the report.
-export { PALETTE_CLASS_RE, blankComments };
+// DEMO_PATH_RE (9.3.2) is the folders the palette count leaves out, stories,
+// examples and demos: a guard that skips them flags palette classes in the
+// same files the report counts.
+export { PALETTE_CLASS_RE, DEMO_PATH_RE, blankComments };
 // A product built on a kit (MUI, Mantine, Chakra UI, Ant Design), 8.4.6: a
 // colour or a pixel size written onto a kit component where the theme has a
 // value. kitPaintFindings(fileText, system.profile.kit, { file }) returns the

package/skills/roast-my-design-system/scripts/lib/version.mjs

@@ -1,7 +1,7 @@
 // Single version constant for the engine — imported by diagnose (report
 // footer) and rules (generated-by line). This is the bump spot that used to
 // live as a const inside diagnose/index.mjs.
-export const VERSION = '9.3.0';
+export const VERSION = '9.3.2';
 // The shape of harvest.json and summary.json. Bumped only when a field is
 // renamed, removed or changes meaning; a new field is not a new schema. A
 // tool comparing two scans compares like with like by this number, not by VERSION.

package/skills/roast-my-design-system/scripts/mcp/engine.mjs

@@ -188,8 +188,11 @@ export function validateContent(content, k) {
   // (editing them is the intended use) and a demo folder is not own code,
   // exactly the files the tile leaves out.
   const inShadcnDoors = (f) => !!f && k.shadcn.doors.some((d) => f === d || f.startsWith(`${d}/`));
-  const paletteRule = k.tailwind ? 'tailwind'
-    : k.shadcn && !(file && (inShadcnDoors(file) || DEMO_PATH_RE.test(file))) ? 'shadcn'
+  // A demo folder is left out on a Tailwind theme too: the report's tile never
+  // counted one, and the live check flagged it (2026-09-30).
+  const demo = !!file && DEMO_PATH_RE.test(file);
+  const paletteRule = k.tailwind ? (demo ? null : 'tailwind')
+    : k.shadcn && !(file && (inShadcnDoors(file) || demo)) ? 'shadcn'
     : null;
   if (paletteRule && !css) {
     const tw = k.tailwind ?? {};