roast-my-design-system 9.2.3 → 9.2.4

package/README.md

@@ -142,11 +142,11 @@ Eleven reports, hosted exactly as the tool writes them. Every number determinist
 
 The full report for vercel/ai-chatbot. The verdict answers what the agent will learn here, the gap section comes first, then "What the repo teaches the agent", Claude's read of the scan:
 
-![The full diagnosis report for vercel/ai-chatbot in dark mode: a fixed side panel with the health score and what it measures, the stack, how the repo was read as a shadcn install, an index of every section and what is not the team's and not counted; then where the agent will have to guess, the fixes you can make right now, each with what it is worth and its copy-the-fix-prompt button, the wrapped present with the agent rules, an agent trap callout, 3-yardstick tiles including the 2 shadcn tiles, the adoption map treemap, palette forensics, the shadcn theme variable by variable, spacing receipts, typography specimens, offenders, duplicates, and the component usage ledger](assets/report-full-dark.png?v=9.2.2)
+![The full diagnosis report for vercel/ai-chatbot in dark mode: a fixed side panel with the health score and what it measures, the stack, how the repo was read as a shadcn install, an index of every section and what is not the team's and not counted; then where the agent will have to guess, the fixes you can make right now, each with what it is worth and its copy-the-fix-prompt button, the wrapped present with the agent rules, an agent trap callout, 3-yardstick tiles including the 2 shadcn tiles, the adoption map treemap, palette forensics, the shadcn theme variable by variable, spacing receipts, typography specimens, offenders, duplicates, and the component usage ledger](assets/report-full-dark.png?v=9.2.4)
 
 The same report in light mode (one file, built-in toggle):
 
-![The diagnosis report in light mode](assets/report-light-hero.png?v=9.2.2)
+![The diagnosis report in light mode](assets/report-light-hero.png?v=9.2.4)
 
 ## Why the numbers hold
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "roast-my-design-system",
-  "version": "9.2.3",
+  "version": "9.2.4",
   "mcpName": "io.github.gregkozakiewicz/roast-my-design-system",
   "description": "Your AI can write the UI. This makes sure it writes your UI. A deterministic scanner scores your design system 0-100 against 112 public repos, reads React and web components (Stencil, Lit), hands you a copy-paste fix prompt for each top finding, writes rules for Claude, Cursor, Copilot and Windsurf with --apply, and runs as a local MCP server with --mcp.",
   "keywords": [

package/skills/roast-my-design-system/scripts/diagnose/index.mjs

@@ -1066,8 +1066,9 @@ function whereToStartSection() {
     c.push({ score: 40, metric: null, title: `Delete the ${dead.length} theme variable${dead.length === 1 ? '' : 's'} nothing uses`,
       sub: `${dead.slice(0, 3).map((r) => `--${esc(r)}`).join(', ')}${dead.length > 3 ? ' and more' : ''} sit in ${esc(P.shadcn.sheet.file)} next to the real theme, and nothing in the repo reads them. An agent opening that file sees 2 colour systems and can not tell which one is dead. ${dead.length * 2} lines to delete; the cheapest fix on this page.` });
   }
-  if (agentFiles.length === 0) c.push({ score: 60, metric: null, title: 'Write the agent rules file',
-    sub: `No CLAUDE.md, no AGENTS.md. One page naming the canonical components and the tokens file stops your agent guessing on every UI change. Cheapest fix on this list.` });
+  // The agent rules file is not a fix here: it has its own section ("Give the
+  // agent the answers") and must not compete with fixes for the three places
+  // (Greg, 2026-09-30).
   if (componentsMeasured && hardDupes.length > 0) {
     // Pick the pair with the strongest copy-paste evidence: sibling files in
     // app code (same basename, neither in a shared package) are true
@@ -1206,6 +1207,9 @@ function whereToStartSection() {
   // already green, or the move lands inside the band it started in.
   for (const item of c) {
     item.delta = 0; item.target = null; item.why = 'not part of the score';
+    // No score, no points: an unscored report promised "+10" and "raises the
+    // score, by 5" on commerce, strapi and three more (2026-09-30).
+    if (healthScore === null) { item.why = 'no score here'; continue; }
     if (!item.metric) continue;
     const tile = bigStats.find((st) => st.metric === item.metric);
     const now = tile?.healthValue;
@@ -1218,7 +1222,12 @@ function whereToStartSection() {
     if (nb && nb.gain > 0) item.target = nb;
     else item.why = healthOf(item.metric, now) === 'good' ? 'already green' : 'no points on its own';
   }
-  const top3 = c.sort((a, b) => (b.delta - a.delta) || (b.score - a.score)).slice(0, 3);
+  // A fix that pays only once finished still outranks one that never pays:
+  // sorting on delta alone put shadcn-admin's one paying fix second, behind a
+  // fix worth nothing (2026-09-30).
+  const tier = (item) => (item.delta > 0 ? 2 : item.target ? 1 : 0);
+  const top3 = c.sort((a, b) => (tier(b) - tier(a)) || (b.delta - a.delta)
+    || ((b.target?.gain ?? 0) - (a.target?.gain ?? 0)) || (b.score - a.score)).slice(0, 3);
   if (!top3.length) return '';
   // The headline is the score with every move applied together, not the sum of
   // the parts: two moves on the same tile must not be counted twice.
@@ -1244,7 +1253,9 @@ function whereToStartSection() {
     ? `${ofThese(paying.length)} could raise the design system health score from <b class="proj">${healthScore} to ${after}</b>.${later.length ? ` ${cap(COUNT[later.length - 1])} more ${later.length === 1 ? 'pays' : 'pay'} ${inFull(later.length)}.` : ''}${rest}`
     : later.length
       ? `${ofThese(later.length)} ${later.length === 1 ? `raises the score, by ${later[0].target.gain},` : 'raise the score'} ${inFull(later.length)}.${rest}`
-      : `${total === 1 ? 'It does' : 'They do'} not move the score. ${total === 1 ? 'It is' : 'They are'} here because ${total === 1 ? 'it stops' : 'each one stops'} the agent guessing.`;
+      : healthScore === null
+        ? `This repo gets no score, so there is no score to raise. ${total === 1 ? 'This fix is' : 'These fixes are'} here because ${total === 1 ? 'it stops' : 'each one stops'} the agent guessing.`
+        : `${total === 1 ? 'It does' : 'They do'} not move the score. ${total === 1 ? 'It is' : 'They are'} here because ${total === 1 ? 'it stops' : 'each one stops'} the agent guessing.`;
   const title = paying.length || later.length ? 'Fixes you can make right now to increase the health score' : 'Fixes you can make right now';
   const chip = (item) => item.delta > 0
     ? `<span class="delta" title="once all of them are done">+${item.delta}</span>`

package/skills/roast-my-design-system/scripts/lib/version.mjs

@@ -1,7 +1,7 @@
 // Single version constant for the engine — imported by diagnose (report
 // footer) and rules (generated-by line). This is the bump spot that used to
 // live as a const inside diagnose/index.mjs.
-export const VERSION = '9.2.3';
+export const VERSION = '9.2.4';
 // The shape of harvest.json and summary.json. Bumped only when a field is
 // renamed, removed or changes meaning; a new field is not a new schema. A
 // tool comparing two scans compares like with like by this number, not by VERSION.