roast-my-design-system 8.6.0 → 8.6.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "roast-my-design-system",
-  "version": "8.6.0",
+  "version": "8.6.2",
   "mcpName": "io.github.gregkozakiewicz/roast-my-design-system",
   "description": "Your AI can write the UI. This makes sure it writes your UI. A deterministic scanner scores your design system 0-100 against 112 public repos, reads React and web components (Stencil, Lit), hands you a copy-paste fix prompt for each top finding, writes rules for Claude, Cursor, Copilot and Windsurf with --apply, and runs as a local MCP server with --mcp.",
   "keywords": [

package/skills/roast-my-design-system/scripts/lib/avoidedimports.mjs

@@ -11,6 +11,7 @@
  * use have no wrong pick, and saying otherwise would be inventing one.
  */
 import { posix } from 'node:path';
+import { extractStyling } from '../harvest/tokens.mjs';
 
 const CODE_EXT_RE = /\.(?:tsx|ts|jsx|js|mjs|cjs|vue|svelte)$/;
 const stem = (f) => f.replace(CODE_EXT_RE, '').replace(/\/index$/, '');
@@ -57,6 +58,32 @@ export function canonicalCopy(copies) {
   return top;
 }
 
+/**
+ * The copies of each duplicated name, with their usage and the colours each
+ * non-canonical copy hard-codes: the `dupes` map avoidedImportFindings reads.
+ * `hardDupes` is findDuplicates' exactDuplicates minus wrapped pairs;
+ * `components` the harvested ledger; `read(file)` a file's text or null.
+ * Shared by the MCP knowledge and the guard doorway.
+ */
+export function dupeCopiesOf(hardDupes, components, read) {
+  const dupes = new Map();
+  for (const d of hardDupes) {
+    const paths = d.files.map((f) => (typeof f === 'string' ? f : f.file));
+    const copies = paths.map((file) => ({
+      file, usageCount: components.find((c) => c.name === d.name && c.file === file)?.usageCount ?? 0,
+    }));
+    const canon = canonicalCopy(copies);
+    const strays = new Map();
+    for (const file of paths) {
+      if (file === canon?.file) continue;
+      const text = read(file);
+      if (text) strays.set(file, [...new Set(extractStyling(text).colors.map((c) => c.value))]);
+    }
+    dupes.set(d.name, { copies, strays });
+  }
+  return dupes;
+}
+
 /**
  * Findings for imports of a non-canonical duplicate that the change ADDS.
  * @param dupes  Map<name, { copies: [{ file, usageCount }], strays?: Map<file, [colour]> }>

package/skills/roast-my-design-system/scripts/lib/exempt.mjs

@@ -71,6 +71,11 @@ export const CONTENT_CSS_NAME_RE = /(^|\/)_?(?:highlight(?:-\w+)?|hljs(?:-theme)
 export const EXTENSION_CSS_PATH_RE = /(^|\/)(?:chrome-extension|browser-extension|webextension)\/[\s\S]*\/(?:content|inject)[\w-]*\.(?:css|scss|less)$|(^|\/)content[_-]?script[\w-]*\.(?:css|scss|less)$/i;
 // minified: one very long line, whoever shipped it
 export const minifiedCss = (text) => text.split('\n').some((l) => l.length > 2000);
+// Tailwind's own build output, committed: it opens with the licence banner and
+// restates every --tw-* internal. Cal.com keeps a 343 KB one, pretty-printed so
+// the minified test misses it, and until 8.6.2 the twin check paired a new
+// theme token with --tw-ring-offset-color from it (benchmark, 2026-09-25).
+export const COMPILED_TAILWIND_RE = /^\s*\/\*!\s*tailwindcss v\d/;
 
 /** Why this stylesheet is not the product's own, or null. */
 export function foreignStylesheet(file, text = '') {
@@ -78,6 +83,7 @@ export function foreignStylesheet(file, text = '') {
   if (/\.module\.(?:css|scss|less)$/i.test(file)) return null;
   if (VENDOR_CSS_NAME_RE.test(file)) return "a library's stylesheet kept in the repo";
   if (minifiedCss(text)) return 'a minified stylesheet, shipped rather than written here';
+  if (COMPILED_TAILWIND_RE.test(text)) return "Tailwind's compiled output, generated from the source rather than written here";
   if (CONTENT_CSS_NAME_RE.test(file)) return 'a code or markdown theme: it styles content, not the interface';
   if (EXTENSION_CSS_PATH_RE.test(file)) return "CSS injected into other people's pages by a browser extension";
   return null;

package/skills/roast-my-design-system/scripts/lib/guard-api.mjs

@@ -17,6 +17,9 @@ import { kitPaintFindings } from './kitpaint.mjs';
 import { PALETTE_CLASS_RE, blankComments } from '../harvest/paint.mjs';
 import { harvestTokens, extractStyling, normalizeHex, isGrey } from '../harvest/tokens.mjs';
 import { harvestComponents, definedComponents } from '../harvest/components.mjs';
+import { findDuplicates } from '../harvest/duplicates.mjs';
+import { repoTokenDefs } from './tokentwins.mjs';
+import { dupeCopiesOf } from './avoidedimports.mjs';
 import { loadExclusions } from './exclusions.mjs';
 import { WIDGET_CONFIG_RE } from './exempt.mjs';
 import { hexRgb } from './nearpairs.mjs';
@@ -86,6 +89,8 @@ export const isStyleFile = (p) => STYLE_EXTS.has(extname(p));
  *   fontFamilies,     // [{ value, count, files }] every family declared
  *   tailwind,         // { colors, spacing, radii, textSizes, arbitrary }
  *   components,       // [{ name, file, usageCount, isPage }] the ledger
+ *   tokenDefs,        // [{ name, file, value, canon, darkValue?, darkCanon? }] colour tokens
+ *   duplicates,       // Map<name, { copies: [{ file, usageCount }], strays }>
  *   files,            // { styles: n, code: n } — how much was read
  * }
  */
@@ -93,10 +98,14 @@ export function learnSystem(repoRoot, { exclude = [] } = {}) {
   const exclusions = loadExclusions(repoRoot, exclude);
   const files = walkRepo(repoRoot, 14, exclusions);
   const t = harvestTokens(repoRoot, files.styles, files.code);
-  const components = harvestComponents(repoRoot, files.code).components
-    .map(({ name, file, usageCount, isPage }) => ({ name, file, usageCount, isPage }));
+  const ledger = harvestComponents(repoRoot, files.code).components;
+  const components = ledger.map(({ name, file, usageCount, isPage }) => ({ name, file, usageCount, isPage }));
   const profile = profileRepo(repoRoot, files);
   decideProfile(profile, components, files, repoRoot);
+  // the same two lists the MCP knowledge builds (mcp/knowledge.mjs), from the
+  // same helpers, for tokenTwinFindings and avoidedImportFindings (8.6.1)
+  const read = (f) => readSource(join(repoRoot, f));
+  const hardDupes = (findDuplicates(ledger, profile.uiDir, repoRoot).exactDuplicates ?? []).filter((d) => !d.wrapped);
   const P = profileOf(profile);
   // the kit the product is built on, with its definition attached, the way
   // the MCP knowledge reads it (mcp/knowledge.mjs): the theme's colours are
@@ -140,6 +149,12 @@ export function learnSystem(repoRoot, { exclude = [] } = {}) {
     // it lives, how much the repo leans on it, and whether it is a page (pages
     // are routes, not reusable parts, so two of a name is not a duplicate).
     components,
+    // every colour token each stylesheet defines, light and dark: the
+    // `others` tokenTwinFindings compares a new token with (8.6.1)
+    tokenDefs: repoTokenDefs(files.styles, read),
+    // each duplicated name's copies, their usage and the colours each
+    // non-canonical copy hard-codes: the `dupes` avoidedImportFindings reads
+    duplicates: dupeCopiesOf(hardDupes, ledger, read),
     files: { styles: files.styles.length, code: files.code.length },
     // How the repo was read (7.1 to 7.7), decided once by the same profiles
     // the report uses, so a guard treats installed code, a registry's

package/skills/roast-my-design-system/scripts/lib/tokentwins.mjs

@@ -21,6 +21,7 @@
  */
 import { canonical, oklab } from './color.mjs';
 import { KNOWN_ROWS } from '../profiles/shadcn-data.mjs';
+import { foreignStylesheet } from './exempt.mjs';
 
 export const TWIN_STEPS = 8;
 // Two tokens are deliberate, so a pair of them must also be closer than the
@@ -102,6 +103,9 @@ export function tokenDefsOf(raw) {
   const defs = new Map();
   for (const m of text.matchAll(/(--[\w-]+)\s*:\s*([^;{}]+)[;}]/g)) {
     const [, name, rawValue] = m;
+    // Tailwind's internals (--tw-ring-offset-color, --tw-prose-*) are its
+    // plumbing, set per element; no one picks them as a design decision
+    if (/^--tw-/.test(name)) continue;
     const value = rawValue.trim();
     const canon = canonical(value);
     if (!canon) continue;
@@ -116,6 +120,24 @@ export function tokenDefsOf(raw) {
   return defs;
 }
 
+/**
+ * Every colour token the repo's stylesheets define, one entry per name per
+ * file: [{ name, file, value, canon, darkValue?, darkCanon? }]. `read(file)`
+ * returns a file's text or null. Shared by the MCP knowledge and the guard
+ * doorway, so both compare a new token with the same list.
+ */
+export function repoTokenDefs(styleFiles, read) {
+  const out = [];
+  for (const file of styleFiles) {
+    const text = read(file);
+    if (!text || !text.includes('--')) continue;
+    // a library's CSS or a compiled build: the report leaves it out, so does this
+    if (foreignStylesheet(file, text)) continue;
+    for (const [name, e] of tokenDefsOf(text)) out.push({ name, file, ...e });
+  }
+  return out;
+}
+
 /**
  * The existing token a token is a twin of, or null. `pool` is
  * [{ name, canon, value, darkCanon?, darkValue?, file? }].

package/skills/roast-my-design-system/scripts/lib/version.mjs

@@ -1,7 +1,7 @@
 // Single version constant for the engine — imported by diagnose (report
 // footer) and rules (generated-by line). This is the bump spot that used to
 // live as a const inside diagnose/index.mjs.
-export const VERSION = '8.6.0';
+export const VERSION = '8.6.2';
 // The shape of harvest.json and summary.json. Bumped only when a field is
 // renamed, removed or changes meaning; a new field is not a new schema. A
 // tool comparing two scans compares like with like by this number, not by VERSION.

package/skills/roast-my-design-system/scripts/mcp/knowledge.mjs

@@ -14,7 +14,7 @@ import { statSync } from 'node:fs';
 import { join } from 'node:path';
 import { walkRepo, profileRepo, readSource } from '../harvest/walk.mjs';
 import { harvestComponents } from '../harvest/components.mjs';
-import { harvestTokens, extractStyling } from '../harvest/tokens.mjs';
+import { harvestTokens } from '../harvest/tokens.mjs';
 import { findDuplicates } from '../harvest/duplicates.mjs';
 import { harvestContext } from '../harvest/context.mjs';
 import { loadExclusions } from '../lib/exclusions.mjs';
@@ -24,8 +24,8 @@ import { typefaceOf } from '../lib/typefaces.mjs';
 import { hexRgb } from '../lib/nearpairs.mjs';
 import { decideProfile, profileOf } from '../profiles/index.mjs';
 import { KITS } from '../profiles/kit-common.mjs';
-import { tokenDefsOf } from '../lib/tokentwins.mjs';
-import { canonicalCopy } from '../lib/avoidedimports.mjs';
+import { repoTokenDefs } from '../lib/tokentwins.mjs';
+import { dupeCopiesOf } from '../lib/avoidedimports.mjs';
 
 const MAX_DEPTH = 14; // same ruler as the harvest CLI
 
@@ -123,28 +123,11 @@ export function loadKnowledge(root) {
 
   // The copies of each duplicated name with their usage, and the colours each
   // copy hard-codes: what the avoided-import check names (lib/avoidedimports).
-  const dupeCopies = new Map();
-  for (const d of hardDupes) {
-    const paths = d.files.map((f) => (typeof f === 'string' ? f : f.file));
-    const copies = paths.map((file) => ({ file, usageCount: (byName.get(d.name) ?? []).find((c) => c.file === file)?.usageCount ?? 0 }));
-    const canon = canonicalCopy(copies);
-    const strays = new Map();
-    for (const file of paths) {
-      if (file === canon?.file) continue;
-      const text = readSource(join(root, file));
-      if (text) strays.set(file, [...new Set(extractStyling(text).colors.map((c) => c.value))]);
-    }
-    dupeCopies.set(d.name, { copies, strays });
-  }
-
+  const read = (file) => readSource(join(root, file));
+  const dupeCopies = dupeCopiesOf(hardDupes, components, read);
   // Every colour token each stylesheet defines, light and dark, so a new one
   // can be compared with the ones already there (lib/tokentwins).
-  const tokenDefs = [];
-  for (const file of files.styles) {
-    const text = readSource(join(root, file));
-    if (!text || !text.includes('--')) continue;
-    for (const [name, e] of tokenDefsOf(text)) tokenDefs.push({ name, file, ...e });
-  }
+  const tokenDefs = repoTokenDefs(files.styles, read);
 
   return {
     root,