roast-my-design-system 8.4.2 → 8.4.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "roast-my-design-system",
-  "version": "8.4.2",
+  "version": "8.4.4",
   "mcpName": "io.github.gregkozakiewicz/roast-my-design-system",
   "description": "Your AI can write the UI. This makes sure it writes your UI. A deterministic scanner scores your design system 0-100 against 112 public repos, reads React and web components (Stencil, Lit), hands you a copy-paste fix prompt for each top finding, writes rules for Claude, Cursor, Copilot and Windsurf with --apply, and runs as a local MCP server with --mcp.",
   "keywords": [

package/skills/roast-my-design-system/scripts/harvest/paint.mjs

@@ -43,6 +43,13 @@ const DOOR_COLOR_RE = new RegExp(`(?<![\\w-])(?:[\\w-]+:)*(?:bg|text|border)-(?:
 const DOOR_TYPO_RE = /(?<![\w-])(?:[\w-]+:)*(?:font-(?:thin|extralight|light|normal|medium|semibold|bold|extrabold|black)|text-(?:xs|sm|base|lg|xl|[2-9]xl))(?![\w-])/g;
 
 // exported for the checkers: a demo folder is not own code there either
+// A comment is not paint (2026-09-20: an agent's note `{/* border-green-500
+// is deliberate */}` counted as a second use). Block and line comments are
+// blanked to spaces, never cut, so every index still points at its line.
+// The `//` guard keeps `https://` inside a string intact, as kitpaint does.
+export const blankComments = (s) => s
+  .replace(/\/\*[\s\S]*?\*\//g, (m) => m.replace(/[^\n]/g, ' '))
+  .replace(/(^|[^:'"`\\])(\/\/[^\n]*)/g, (m, pre, c) => pre + ' '.repeat(c.length));
 export const DEMO_PATH_RE = /(^|\/)(stories|storybook|__stories__|examples?|demos?|templates?|playground|fixtures?|__tests__|__mocks__|e2e|cypress)\//i;
 
 /**
@@ -71,9 +78,10 @@ export function countPaint(root, codeFiles, { uiDirs = [], kitNames = new Set(),
 
   for (const f of codeFiles) {
     if (!/\.(tsx|jsx)$/.test(f) || inCatalogue(f) || DEMO_PATH_RE.test(f)) continue;
-    const src = readSource(join(root, f));
-    if (src === null || exemptReason(f, src)) continue;
+    const raw = readSource(join(root, f));
+    if (raw === null || exemptReason(f, raw)) continue;
     ownFiles += 1;
+    const src = blankComments(raw);
 
     // a palette name the theme gave its own colour is the theme, not drift
     // and a palette grey is only drift where the theme has a grey of its own

package/skills/roast-my-design-system/scripts/lib/version.mjs

@@ -1,7 +1,7 @@
 // Single version constant for the engine — imported by diagnose (report
 // footer) and rules (generated-by line). This is the bump spot that used to
 // live as a const inside diagnose/index.mjs.
-export const VERSION = '8.4.2';
+export const VERSION = '8.4.4';
 // The shape of harvest.json and summary.json. Bumped only when a field is
 // renamed, removed or changes meaning; a new field is not a new schema. A
 // tool comparing two scans compares like with like by this number, not by VERSION.

package/skills/roast-my-design-system/scripts/mcp/engine.mjs

@@ -17,7 +17,7 @@ import { exemptReason } from '../lib/exempt.mjs';
 import { extraDeclarations, fontDeclarations } from '../lib/declarations.mjs';
 import { typefaceOf, GENERIC_FONTS } from '../lib/typefaces.mjs';
 import { kitPaintInSource } from '../lib/kitpaint.mjs';
-import { PALETTE_CLASS_RE, GREY_HUE_RE, DARK_WB_RE, DEMO_PATH_RE } from '../harvest/paint.mjs';
+import { PALETTE_CLASS_RE, GREY_HUE_RE, DARK_WB_RE, DEMO_PATH_RE, blankComments } from '../harvest/paint.mjs';
 
 // What this engine measures — shipped with every result, clean or not.
 export const CHECKS = [
@@ -164,10 +164,13 @@ export function validateContent(content, k) {
     // foreground name, a bg- class a surface or background name
     const names = paletteRule === 'tailwind' ? (tw.names ?? []) : ['primary', 'foreground', 'muted-foreground', 'background', 'border'];
     const pick = (re) => names.find((n) => re.test(n)) ?? names[0] ?? 'brand';
-    const hits = [...text.matchAll(PALETTE_CLASS_RE)];
+    // a class named in a comment paints nothing; blanked, not cut, so the
+    // line numbers below still hold
+    const code = blankComments(text);
+    const hits = [...code.matchAll(PALETTE_CLASS_RE)];
     // the evening override painted by hand (dark:bg-black) is the same sin
     // on a shadcn sheet, which always has a dark row of its own
-    if (paletteRule === 'shadcn') hits.push(...text.matchAll(DARK_WB_RE));
+    if (paletteRule === 'shadcn') hits.push(...code.matchAll(DARK_WB_RE));
     for (const m of hits.sort((a, b) => a.index - b.index)) {
       const cls = m[0];
       const util = cls.replace(/^((?:[\w-]+:)*[a-z]+)-.*$/, '$1');
@@ -176,7 +179,7 @@ export function validateContent(content, k) {
       if (!hasFamily(cls)) continue;
       add('palette-class', 'violation', m.index,
         `Palette class ${cls} where the theme names its colours (${themeFile}).`,
-        `Use a theme name as the class (${util}-${example}); if the colour is missing, add it to the theme once.`);
+        `Use a theme token as the class (${util}-${example}). If no token fits, add one to the theme once, for example success, and use ${util}-success.`);
     }
   }
 

package/skills/roast-my-design-system/scripts/mcp/tools.mjs

@@ -60,7 +60,15 @@ export function getContext(k, { path = null } = {}) {
   const canon = k.canonical.filter((c) => inPkg(c.file)).slice(0, 5)
     .map((c) => `  <${c.name}> from ${c.file} (${c.usageCount}x)`);
   const dupes = [...k.dupeByName.values()].filter((d) => d.files.some((f) => inPkg(typeof f === 'string' ? f : f.file))).slice(0, 3)
-    .map((d) => `  <${d.name}> exists in ${d.files.length} places; match what the surrounding code imports, never create another.`);
+    // Name the places (2026-09-20): an agent given a count and no paths goes
+    // looking in src/, finds one copy and calls the scan wrong; the second
+    // copy was under a templates folder it never opened. A receipt ends the
+    // argument and tells the agent which copy not to import.
+    .map((d) => {
+      const paths = d.files.map((f) => (typeof f === 'string' ? f : f.file));
+      const shown = paths.slice(0, 3).join(', ') + (paths.length > 3 ? `, +${paths.length - 3} more` : '');
+      return `  <${d.name}> exists in ${d.files.length} places (${shown}); match what the surrounding code imports, never create another.`;
+    });
   const LISTS = Symbol('lists');
   L.push(LISTS);