roast-my-design-system 7.3.2 → 7.3.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "roast-my-design-system",
-  "version": "7.3.2",
+  "version": "7.3.3",
   "mcpName": "io.github.gregkozakiewicz/roast-my-design-system",
   "description": "Your AI can write the UI. This makes sure it writes your UI. A deterministic scanner scores your design system 0-100 against 34 public repos, reads React and web components (Stencil, Lit), hands you a copy-paste fix prompt for each top finding, writes rules for Claude, Cursor, Copilot and Windsurf with --apply, and runs as a local MCP server with --mcp.",
   "keywords": [

package/skills/roast-my-design-system/scripts/benchmark/benchmark.json

@@ -1852,8 +1852,8 @@
   },
   "slices": {
     "shadcn": {
-      "builtAt": "2026-09-12T00:06:00.881Z",
-      "repoCount": 17,
+      "builtAt": "2026-09-12T19:02:27.297Z",
+      "repoCount": 16,
       "note": "every repo in the fleet the scanner reads as shadcn; the \"cleaner than\" line on a shadcn repo reads against these",
       "stats": {
         "colors": {
@@ -1867,7 +1867,6 @@
             56,
             66,
             115,
-            118,
             132,
             174,
             187,
@@ -1876,10 +1875,10 @@
             310,
             1030
           ],
-          "p25": 41,
-          "median": 115,
-          "p75": 187,
-          "p90": 283
+          "p25": 39,
+          "median": 91,
+          "p75": 204,
+          "p90": 288
         },
         "greys": {
           "values": [
@@ -1893,7 +1892,6 @@
             12,
             14,
             16,
-            22,
             33,
             38,
             51,
@@ -1902,9 +1900,9 @@
             111
           ],
           "p25": 4,
-          "median": 14,
-          "p75": 38,
-          "p90": 58
+          "median": 13,
+          "p75": 41,
+          "p90": 59
         },
         "spacing": {
           "values": [
@@ -1920,16 +1918,15 @@
             34,
             40,
             45,
-            49,
             59,
             66,
             120,
             220
           ],
           "p25": 11,
-          "median": 32,
+          "median": 29,
           "p75": 49,
-          "p90": 88
+          "p90": 93
         },
         "typefaces": {
           "values": [
@@ -1945,7 +1942,6 @@
             3,
             3,
             3,
-            3,
             5,
             6,
             8,
@@ -1953,7 +1949,7 @@
           ],
           "p25": 2,
           "median": 3,
-          "p75": 3,
+          "p75": 4,
           "p90": 7
         },
         "fontSizes": {
@@ -1971,14 +1967,13 @@
             27,
             27,
             42,
-            43,
             49,
             49,
             79
           ],
           "p25": 12,
           "median": 21,
-          "p75": 42,
+          "p75": 31,
           "p90": 49
         },
         "radii": {
@@ -1997,13 +1992,12 @@
             20,
             21,
             26,
-            28,
             34,
             50
           ],
           "p25": 11,
           "median": 14,
-          "p75": 21,
+          "p75": 20,
           "p90": 30
         },
         "shadows": {
@@ -2015,7 +2009,6 @@
             0,
             0,
             0,
-            0,
             1,
             1,
             2,
@@ -2028,7 +2021,7 @@
           ],
           "p25": 0,
           "median": 1,
-          "p75": 4,
+          "p75": 5,
           "p90": 10
         },
         "exactDuplicates": {
@@ -2042,7 +2035,6 @@
             17,
             20,
             21,
-            23,
             25,
             61,
             65,
@@ -2051,10 +2043,10 @@
             134,
             288
           ],
-          "p25": 14,
+          "p25": 11,
           "median": 21,
-          "p75": 65,
-          "p90": 116
+          "p75": 74,
+          "p90": 119
         },
         "inlineStyles": {
           "values": [
@@ -2068,7 +2060,6 @@
             42,
             47,
             47,
-            49,
             58,
             74,
             79,
@@ -2076,10 +2067,10 @@
             120,
             263
           ],
-          "p25": 11,
-          "median": 47,
-          "p75": 74,
-          "p90": 118
+          "p25": 10,
+          "median": 45,
+          "p75": 75,
+          "p90": 119
         },
         "arbitrary": {
           "values": [
@@ -2097,14 +2088,13 @@
             385,
             386,
             614,
-            622,
             1625,
             1673
           ],
           "p25": 101,
-          "median": 169,
-          "p75": 386,
-          "p90": 1023
+          "median": 166,
+          "p75": 385,
+          "p90": 1120
         },
         "nearPairs": {
           "values": [
@@ -2118,7 +2108,6 @@
             8,
             10,
             11,
-            15,
             16,
             18,
             18,
@@ -2127,7 +2116,7 @@
             59
           ],
           "p25": 1,
-          "median": 10,
+          "median": 9,
           "p75": 18,
           "p90": 21
         },
@@ -2140,7 +2129,6 @@
             0,
             0,
             1,
-            1,
             2,
             9,
             9,
@@ -2152,9 +2140,9 @@
             157
           ],
           "p25": 0,
-          "median": 2,
+          "median": 6,
           "p75": 42,
-          "p90": 70
+          "p90": 74
         },
         "neverImported": {
           "values": [
@@ -2166,7 +2154,6 @@
             2,
             5,
             13,
-            16,
             19,
             23,
             26,
@@ -2178,8 +2165,8 @@
           ],
           "p25": 1,
           "median": 16,
-          "p75": 30,
-          "p90": 96
+          "p75": 34,
+          "p90": 97
         },
         "components": {
           "values": [
@@ -2198,13 +2185,12 @@
             1204,
             1453,
             1494,
-            1594,
             3630
           ],
-          "p25": 316,
-          "median": 911,
-          "p75": 1204,
-          "p90": 1534
+          "p25": 305,
+          "median": 861,
+          "p75": 1154,
+          "p90": 1474
         },
         "paintTin": {
           "values": [
@@ -2223,13 +2209,12 @@
             100,
             183,
             296,
-            491,
-            658
+            491
           ],
           "p25": 22,
-          "median": 57,
-          "p75": 100,
-          "p90": 374
+          "median": 50,
+          "p75": 75,
+          "p90": 240
         },
         "doorOverrides": {
           "values": [
@@ -2247,14 +2232,13 @@
             26,
             28,
             31,
-            40,
             44,
             55
           ],
           "p25": 13,
           "median": 17,
-          "p75": 28,
-          "p90": 42
+          "p75": 27,
+          "p90": 38
         }
       },
       "repos": [
@@ -2420,33 +2404,6 @@
             "doorOverrides": 22
           }
         },
-        {
-          "repo": "dubinc/dub",
-          "confidence": "medium",
-          "style": null,
-          "baseColor": null,
-          "tailwind": null,
-          "codeFiles": 4160,
-          "ownFiles": 1389,
-          "metrics": {
-            "colors": 118,
-            "greys": 22,
-            "spacing": 49,
-            "typefaces": 3,
-            "fontSizes": 43,
-            "radii": 28,
-            "shadows": 0,
-            "exactDuplicates": 23,
-            "inlineStyles": 49,
-            "arbitrary": 622,
-            "nearPairs": 15,
-            "important": 1,
-            "neverImported": 16,
-            "components": 1594,
-            "paintTin": 658,
-            "doorOverrides": 40
-          }
-        },
         {
           "repo": "formbricks/formbricks",
           "confidence": "high",

package/skills/roast-my-design-system/scripts/lib/version.mjs

@@ -1,7 +1,7 @@
 // Single version constant for the engine — imported by diagnose (report
 // footer) and rules (generated-by line). This is the bump spot that used to
 // live as a const inside diagnose/index.mjs.
-export const VERSION = '7.3.2';
+export const VERSION = '7.3.3';
 // The shape of harvest.json and summary.json. Bumped only when a field is
 // renamed, removed or changes meaning; a new field is not a new schema. A
 // tool comparing two scans compares like with like by this number, not by VERSION.

package/skills/roast-my-design-system/scripts/profiles/shadcn.mjs

@@ -93,6 +93,25 @@ function resolveAlias(root, wsRoot, alias) {
   return null;
 }
 
+/**
+ * The theme contract is the real signature of a shadcn install: the named
+ * variables (background, foreground, primary, muted, border, ring...) defined
+ * in a stylesheet. Door names and Radix imports are not enough. dubinc/dub
+ * has 12 catalogue-named files on Radix and cva, no components.json and 0 of
+ * these variables: its own token system, a shadcn ancestry, not a shadcn
+ * install. It was read as one from 7.2.0 to 7.3.2 (2026-09-13).
+ */
+const CONTRACT_ROWS = ['background', 'foreground', 'primary', 'muted', 'border', 'ring', 'accent', 'card', 'popover', 'destructive'];
+function themeContract(root, files) {
+  const seen = new Set();
+  for (const f of (files.styles ?? []).slice(0, 60)) {
+    const css = read(join(root, f));
+    for (const r of CONTRACT_ROWS) if (!seen.has(r) && new RegExp(`--${r}\\s*:`).test(css)) seen.add(r);
+    if (seen.size === CONTRACT_ROWS.length) break;
+  }
+  return seen.size;
+}
+
 /** Rows declared under a selector in a CSS text: name -> value. */
 function rowsUnder(css, selector) {
   const out = new Map();
@@ -209,11 +228,14 @@ export default {
       else { const i = installs.find((x) => x.uiDir === s.dir); i.catalogueNames = Math.max(i.catalogueNames, s.catalogueNames); }
     }
 
-    // 3. the decision: a marker plus a folder, or a folder that is plainly the
-    // catalogue by name (8+). Same bar the profiler used for vendoredUi.
+    // 3. the decision. With components.json: the CLI's own marker plus a
+    // catalogue folder. Without it: a catalogue by name AND the theme contract
+    // in a stylesheet (5 or more of shadcn's named variables); names and
+    // Radix alone describe half the React world.
+    const contract = themeContract(root, files);
     const withConfigAndDir = installs.filter((i) => i.config && i.uiDir);
     const byName = installs.filter((i) => i.catalogueNames >= 8);
-    if (!withConfigAndDir.length && !byName.length) return null;
+    if (!withConfigAndDir.length && !(byName.length && contract >= 5)) return null;
 
     installs.sort((a, b) => b.catalogueNames - a.catalogueNames || (b.config ? 1 : 0) - (a.config ? 1 : 0));
     const primary = installs[0];
@@ -229,6 +251,7 @@ export default {
       if (i.config) evidence.push(`components.json in ${dirname(i.config) === '.' ? 'the root' : dirname(i.config)}${i.uiDir ? `, ${i.catalogueNames} catalogue component${i.catalogueNames === 1 ? '' : 's'} in ${i.uiDir}` : ', no catalogue folder found through its alias'}`);
       else evidence.push(`${i.catalogueNames} catalogue components in ${i.uiDir}, no components.json`);
     }
+    evidence.push(contract ? `${contract} of shadcn's ${CONTRACT_ROWS.length} theme variables defined` : 'no shadcn theme variables found in any stylesheet');
     if (kit?.style) evidence.push(`style ${kit.style}${kit.baseColor ? `, base colour ${kit.baseColor}` : ''}${kit.tailwind ? `, Tailwind ${kit.tailwind}` : ''}`);
 
     // 4. write the facts every consumer reads