roast-my-design-system 7.0.0 → 7.1.0

package/README.md

@@ -1,4 +1,4 @@
-<img src="https://raw.githubusercontent.com/gregkozakiewicz/roast-my-design-system/main/assets/roaster_logo_300px.png?v=7.0.0" width="72" alt="roast-my-design-system">
+<img src="https://raw.githubusercontent.com/gregkozakiewicz/roast-my-design-system/main/assets/roaster_logo_300px.png?v=7.1.0" width="72" alt="roast-my-design-system">
 
 # roast-my-design-system
 
@@ -73,11 +73,11 @@ Not to be confused with each other: **"Why this matters"** is generic, ships wit
 
 The full report for vercel/ai-chatbot, top to bottom, including "What the numbers mean", Claude's read of the scan, embedded right under the verdict:
 
-![The full diagnosis report for vercel/ai-chatbot in dark mode: health score, the What the numbers mean analysis written by Claude, priced Where to start moves each with its copy-the-fix-prompt button, the wrapped present with the agent rules, an agent trap callout, 3-yardstick tiles, the adoption map treemap, palette forensics, spacing receipts, typography specimens, offenders, duplicates, and the component usage ledger](https://raw.githubusercontent.com/gregkozakiewicz/roast-my-design-system/main/assets/report-full-dark.png?v=7.0.0)
+![The full diagnosis report for vercel/ai-chatbot in dark mode: health score, the What the numbers mean analysis written by Claude, priced Where to start moves each with its copy-the-fix-prompt button, the wrapped present with the agent rules, an agent trap callout, 3-yardstick tiles, the adoption map treemap, palette forensics, spacing receipts, typography specimens, offenders, duplicates, and the component usage ledger](https://raw.githubusercontent.com/gregkozakiewicz/roast-my-design-system/main/assets/report-full-dark.png?v=7.1.0)
 
 The same report in light mode (one file, built-in toggle):
 
-![The diagnosis report in light mode](https://raw.githubusercontent.com/gregkozakiewicz/roast-my-design-system/main/assets/report-light-hero.png?v=7.0.0)
+![The diagnosis report in light mode](https://raw.githubusercontent.com/gregkozakiewicz/roast-my-design-system/main/assets/report-light-hero.png?v=7.1.0)
 
 ## What makes the numbers trustworthy
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "roast-my-design-system",
-  "version": "7.0.0",
+  "version": "7.1.0",
   "mcpName": "io.github.gregkozakiewicz/roast-my-design-system",
   "description": "Your AI can write the UI. This makes sure it writes your UI. A deterministic scanner scores your design system 0-100 against 34 public repos, reads React and web components (Stencil, Lit), hands you a copy-paste fix prompt for each top finding, writes rules for Claude, Cursor, Copilot and Windsurf with --apply, and runs as a local MCP server with --mcp.",
   "keywords": [

package/skills/roast-my-design-system/scripts/diagnose/index.mjs

@@ -32,6 +32,7 @@ import { fixPrompt } from '../lib/fixprompt.mjs';
 import { WHY } from './why.mjs';
 import { parseColor, luminance, isGrey } from '../lib/color.mjs';
 import { loadBenchmark, benchHelpers, makeHealthOf, coreMetrics, tileHealths, scoreOfTiles, scorePackage as scorePackageOf, ZERO_IDEAL, WARN_TOLERANCE, SCORE_OF, SCHEMA_VERSION } from './score.mjs';
+import { profileOf } from '../profiles/index.mjs';
 
 // The benchmark and every judgement made against it live in score.mjs; this
 // file only draws. The same numbers reach summary.json through scoreHarvest.
@@ -243,15 +244,16 @@ const nearPairs = nearColorPairs(colors);
 // rather than wallpaper. Theme variants are not in here; those are the system.
 const collisions = h.tokens.tokenCollisions ?? [];
 
-const neverImported = neverImportedComponents(h.components, h.profile?.uiDir);
+const P = profileOf(h);
+const neverImported = neverImportedComponents(h.components, P.uiDir);
 
-// Measurability and role, decided by the harvest (telekom/scale, 2026-09-01):
+// Measurability and kind, decided once in profiles/ (telekom/scale, 2026-09-01):
 // when the component detector could not read this repo's stack, the component
 // metrics say so and take no score credit; when the repo is a published
 // library, usage means composition (how the system uses itself), never
 // adoption, and every accusation about orphans is softened to match.
 const { componentsMeasured, isLibrary, vendoredUi } = M;
-const notMeasuredReason = h.profile?.componentDetection?.reason ?? 'an unrecognised component pattern';
+const notMeasuredReason = P.notMeasuredReason;
 // A shadcn ui folder is a vendored catalogue: `shadcn add` copies the source
 // in, people take the whole set at once, and an unused component there is
 // stock on a shelf rather than something a team built and abandoned. It is
@@ -1767,7 +1769,7 @@ if (summaryPath) {
     score: healthScore,
     noSystemLikely,
     verdict,
-    role: h.profile?.role ?? 'product',
+    role: P.kind,
     componentsMeasured,
     metrics: (({ colors, colorTokens, colorStrays, greys, greyStrays, spacing, exactDuplicates, inlineStyles, nearPairs, important, neverImported, arbitrary, tokenLed }) =>
       ({ colors, colorTokens, colorStrays, greys, greyStrays, spacing, exactDuplicates, inlineStyles, nearPairs, important, neverImported, arbitrary, tokenLed }))(M),

package/skills/roast-my-design-system/scripts/diagnose/score.mjs

@@ -26,6 +26,7 @@ import { isGrey } from '../lib/color.mjs';
 import { nearColorPairs } from '../lib/nearpairs.mjs';
 import { neverImportedComponents } from '../lib/neverimported.mjs';
 import { SCHEMA_VERSION } from '../lib/version.mjs';
+import { profileOf } from '../profiles/index.mjs';
 
 export { SCHEMA_VERSION };
 
@@ -131,14 +132,14 @@ export function coreMetrics(h) {
     inlineStyles: h.tokens?.inlineStyles?.count ?? 0,
     nearPairs: nearColorPairs(colors).length,
     important: h.tokens?.important?.count ?? 0,
-    neverImported: neverImportedComponents(h.components, h.profile?.uiDir).length,
+    neverImported: neverImportedComponents(h.components, profileOf(h).uiDir).length,
     arbitrary: (h.tokens?.tailwind?.arbitrary ?? []).reduce((sum, a) => sum + a.count, 0),
-    // Measurability and role, decided by the harvest: an unreadable stack
+    // Measurability and kind, decided once in profiles/: an unreadable stack
     // takes no score credit; a library's orphans are shown, not judged; a
     // vendored shadcn catalogue is stock on a shelf, not abandonment.
-    componentsMeasured: h.profile?.componentDetection?.measured !== false,
-    isLibrary: h.profile?.role === 'library',
-    vendoredUi: h.profile?.vendoredUi === true,
+    componentsMeasured: profileOf(h).componentsMeasured,
+    isLibrary: profileOf(h).isLibrary,
+    vendoredUi: profileOf(h).vendoredUi,
   };
 }
 

package/skills/roast-my-design-system/scripts/harvest/index.mjs

@@ -27,6 +27,7 @@ import { ruleStaleness } from '../lib/staleness.mjs';
 import { neverImportedComponents } from '../lib/neverimported.mjs';
 import { lastTouchedDates } from '../lib/lasttouched.mjs';
 import { SCHEMA_VERSION } from '../lib/version.mjs';
+import { decideProfile } from '../profiles/index.mjs';
 
 function arg(name, fallback) {
   const i = process.argv.indexOf(`--${name}`);
@@ -63,37 +64,11 @@ const staleRules = ruleStaleness(target, components,
   new Set(neverImportedComponents(components, profile.uiDir).map((c) => c.name)),
   [...files.code, ...files.styles, ...files.other]);
 
-// Repo role and measurability, decided from what the scan actually found.
-// A published components package with no app pages is a LIBRARY: its real
-// consumers live in other repos, so usage counts mean composition, not
-// adoption, and the report's language follows. And when a component stack
-// the detector cannot read is present while it found almost nothing, the
-// component metrics are declared NOT MEASURED instead of scoring zeros as
-// discipline (the telekom/scale lesson, 2026-09-01).
-{
-  const reusableCount = components.filter((c) => !c.isPage).length;
-  // A web-components repo with many tag-registered components and no pages
-  // is a library by construction, whatever its packages are named (Ionic's
-  // @ionic/core and Material Web both dodge the name rule).
-  // A handful of pages next to hundreds of components is a demo or test app
-  // riding in the library's monorepo (Siemens iX ships two), not a product.
-  const pageCount = components.length - reusableCount;
-  const fewPages = pageCount <= reusableCount * 0.05;
-  profile.role = (profile.libraryPkg && fewPages && reusableCount >= 5)
-    || (String(profile.framework).startsWith('web components') && fewPages && reusableCount >= 10)
-    ? 'library' : 'product';
-  // The gate fires on the situation, never a list of known frameworks: a
-  // repo with real code volume where the detector found almost nothing is a
-  // repo we could not read, whatever it is written in (the Shoelace lesson:
-  // its .define() idiom was invisible and the named-framework gate stayed
-  // silent, which would have shipped blind zeros as discipline again).
-  // Either trigger suffices: a named unreadable stack (Vue/Angular/Svelte
-  // markers, however small the repo), or sheer volume the detector saw
-  // nothing in (the Shoelace near-miss: unknown idiom, no marker).
-  profile.componentDetection = reusableCount < 3 && (profile.unreadableComponentStack || files.code.length >= 40)
-    ? { measured: false, reason: profile.unreadableComponentStack ?? 'a component pattern this scan cannot read' }
-    : { measured: true };
-}
+// Repo kind and measurability, decided once in profiles/ and read everywhere
+// (a published components package with no app pages is a LIBRARY; a stack the
+// detector cannot read is NOT MEASURED, never scored as zeros). The decision
+// lands on the profile with its evidence, so the JSON says why.
+decideProfile(profile, components, files);
 
 // Orphans carry a receipt: the last time git saw anyone touch the file.
 // Only never-imported components are dated (the adoption map's evidence);

package/skills/roast-my-design-system/scripts/lib/version.mjs

@@ -1,7 +1,7 @@
 // Single version constant for the engine — imported by diagnose (report
 // footer) and rules (generated-by line). This is the bump spot that used to
 // live as a const inside diagnose/index.mjs.
-export const VERSION = '7.0.0';
+export const VERSION = '7.1.0';
 // The shape of harvest.json and summary.json. Bumped only when a field is
 // renamed, removed or changes meaning; a new field is not a new schema. A
 // tool comparing two scans compares like with like by this number, not by VERSION.

package/skills/roast-my-design-system/scripts/mcp/knowledge.mjs

@@ -22,6 +22,7 @@ import { resolveWorkspaces } from '../lib/workspaces.mjs';
 import { neverImportedComponents } from '../lib/neverimported.mjs';
 import { typefaceOf } from '../lib/typefaces.mjs';
 import { hexRgb } from '../lib/nearpairs.mjs';
+import { decideProfile, profileOf } from '../profiles/index.mjs';
 
 const MAX_DEPTH = 14; // same ruler as the harvest CLI
 
@@ -45,6 +46,9 @@ export function loadKnowledge(root) {
   const files = walkRepo(root, MAX_DEPTH, exclusions);
   const profile = profileRepo(root, files);
   const { components } = harvestComponents(root, files.code);
+  // The MCP path used to skip the kind decision the CLI harvest makes, so a
+  // library read as a product here. Same call, same answer, both doors.
+  decideProfile(profile, components, files);
   const tokens = harvestTokens(root, files.styles, files.code);
   const duplicates = findDuplicates(components, profile.uiDir, root);
   const context = harvestContext(root);
@@ -120,8 +124,8 @@ export function loadKnowledge(root) {
     canonical,
     dupeByName,
     neverImported,
-    // stock, not debt: see harvest profile.vendoredUi
-    vendoredUi: profile.vendoredUi === true,
+    // stock, not debt: see profiles/index.mjs
+    vendoredUi: profileOf(profile).vendoredUi,
     agentFiles: (context ?? []).filter((c) => c.kind === 'agent-rules'),
   };
 }

package/skills/roast-my-design-system/scripts/profiles/index.mjs

@@ -0,0 +1,90 @@
+/**
+ * Profiles — what kind of repo is this, decided once and read everywhere.
+ *
+ * The scanner used to answer "is this a library?", "is this a vendored
+ * catalogue?", "can I measure components here?" in three separate places:
+ * the profiler in harvest/walk.mjs, a block inside harvest/index.mjs, and
+ * every consumer re-deriving flags from the raw profile. The MCP path never
+ * ran the harvest block at all, so it had no role. Each new kind of repo
+ * would have meant one more "unless" clause in each counter, and that is how
+ * a scanner stops meaning one thing.
+ *
+ * The shape now: one file per kind under profiles/, each answering the same
+ * questions in the same order. `decideProfile` picks the first kind that
+ * recognises the repo (product is the fallback and always matches), records
+ * how sure it is and why, and writes the decision onto the harvest profile.
+ * `profileOf` is the one accessor consumers read. No counter, report or rules
+ * builder asks the raw flags any more.
+ *
+ * Step 2 of the shadcn-profile plan: this move changes no number. Every
+ * fixture's expected output is byte-identical before and after.
+ */
+import library from './library.mjs';
+import product from './product.mjs';
+
+// Specific kinds first; product is the fallback and must stay last.
+export const PROFILES = [library, product];
+
+/**
+ * Decide the repo's kind from the profiler's facts and what the scan found.
+ * Mutates `profile` (the harvest.profile object) so the JSON on disk carries
+ * the decision: `role` (the field consumers and summary.json already read),
+ * `componentDetection` (measurability), and the new `kind`, `kindConfidence`
+ * and `kindEvidence` (the receipt: why this kind, in words).
+ */
+export function decideProfile(profile, components, files) {
+  const reusable = components.filter((c) => !c.isPage);
+  const counts = {
+    reusable: reusable.length,
+    pages: components.length - reusable.length,
+    codeFiles: files.code.length,
+  };
+  // A handful of pages next to hundreds of components is a demo or test app
+  // riding in a library's monorepo (Siemens iX ships two), not a product.
+  counts.fewPages = counts.pages <= counts.reusable * 0.05;
+
+  let picked = product, decision = null;
+  for (const p of PROFILES) {
+    const d = p.recognise(profile, counts);
+    if (d) { picked = p; decision = d; break; }
+  }
+  profile.role = picked.kind;
+  profile.kind = picked.kind;
+  profile.kindConfidence = decision.confidence;
+  profile.kindEvidence = decision.evidence;
+
+  // Measurability. The gate fires on the situation, never a list of known
+  // frameworks: a repo with real code volume where the detector found almost
+  // nothing is a repo we could not read, whatever it is written in (the
+  // Shoelace lesson: its .define() idiom was invisible and the named-framework
+  // gate stayed silent, which would have shipped blind zeros as discipline).
+  // Either trigger suffices: a named unreadable stack (Vue/Angular/Svelte
+  // markers, however small the repo), or sheer volume the detector saw
+  // nothing in (the Shoelace near-miss: unknown idiom, no marker).
+  profile.componentDetection = counts.reusable < 3 && (profile.unreadableComponentStack || counts.codeFiles >= 40)
+    ? { measured: false, reason: profile.unreadableComponentStack ?? 'a component pattern this scan cannot read' }
+    : { measured: true };
+  return profile;
+}
+
+/**
+ * The one accessor. Consumers read these fields and nothing else about the
+ * repo's kind. Works on a harvest (h.profile) or a bare profile object, and
+ * on harvests written before the profile layer existed (no `kind` field).
+ */
+export function profileOf(h) {
+  const p = h?.profile ?? h ?? {};
+  const kind = p.kind ?? p.role ?? 'product';
+  return {
+    kind,
+    confidence: p.kindConfidence ?? null,
+    evidence: p.kindEvidence ?? [],
+    isLibrary: kind === 'library',
+    // A vendored shadcn catalogue is stock on a shelf, not abandonment.
+    vendoredUi: p.vendoredUi === true,
+    uiDir: p.uiDir ?? null,
+    componentsMeasured: p.componentDetection?.measured !== false,
+    notMeasuredReason: p.componentDetection?.reason ?? 'an unrecognised component pattern',
+    designSystem: p.designSystem ?? { kind: 'none' },
+  };
+}

package/skills/roast-my-design-system/scripts/profiles/library.mjs

@@ -0,0 +1,29 @@
+/**
+ * Library — a repo whose consumers live in other repos entirely.
+ *
+ * A published components package with no app pages: usage counts mean
+ * composition, not adoption, orphans are showroom stock rather than dead
+ * weight, and the report's language follows. Two ways in, either sufficient:
+ *
+ * 1. A publishable package with a components-ish name (or the root package
+ *    itself being publishable), found by the profiler as `libraryPkg`, next
+ *    to at least 5 reusable components and almost no pages.
+ * 2. A web-components repo with many tag-registered components and no pages,
+ *    whatever its packages are named (Ionic's @ionic/core and Material Web
+ *    both dodge the name rule).
+ */
+export default {
+  kind: 'library',
+
+  /** @returns {{ confidence: string, evidence: string[] } | null} */
+  recognise(profile, counts) {
+    const evidence = [];
+    if (profile.libraryPkg && counts.fewPages && counts.reusable >= 5) {
+      evidence.push(`publishable package ${profile.libraryPkg} with ${counts.reusable} reusable components and ${counts.pages} page${counts.pages === 1 ? '' : 's'}`);
+    }
+    if (String(profile.framework).startsWith('web components') && counts.fewPages && counts.reusable >= 10) {
+      evidence.push(`${counts.reusable} registered web components and ${counts.pages} page${counts.pages === 1 ? '' : 's'}`);
+    }
+    return evidence.length ? { confidence: 'high', evidence } : null;
+  },
+};

package/skills/roast-my-design-system/scripts/profiles/product.mjs

@@ -0,0 +1,21 @@
+/**
+ * Product — the default. An app, a site, a monorepo of apps: the components
+ * are used where they are defined, so usage means adoption, an orphan is a
+ * wrong answer waiting to be picked, and every tile scores as written.
+ *
+ * Always matches. It is the fallback, and it must stay the last entry in
+ * profiles/index.mjs. It carries no special knowledge on purpose: anything a
+ * kind of repo needs read differently belongs in that kind's own file.
+ */
+export default {
+  kind: 'product',
+
+  recognise(profile) {
+    return {
+      confidence: 'high',
+      evidence: [profile.libraryPkg
+        ? `publishable package ${profile.libraryPkg} present, but the repo has app pages next to its components`
+        : 'no publishable components package; components are used where they are defined'],
+    };
+  },
+};

package/skills/roast-my-design-system/scripts/rules/build.mjs

@@ -8,6 +8,7 @@ import { distinctTypefaces } from '../lib/typefaces.mjs';
 import { nearColorPairs } from './../lib/nearpairs.mjs';
 import { neverImportedComponents } from '../lib/neverimported.mjs';
 import { VERSION } from '../lib/version.mjs';
+import { profileOf } from '../profiles/index.mjs';
 
 export function rulesMarkdown(h, opts = {}) {
   // compact: the size-aware variant for agent files with tight practical
@@ -75,7 +76,7 @@ const repoName = h.profile?.name ?? 'this repo';
     if (near.length) rule(`Never eyeball a colour from memory: the scan found ${near.length} nearly identical pair${near.length === 1 ? '' : 's'} (like ${near[0].a.value} next to ${near[0].b.value}). Look the exact value up, or better, use its token.`);
     const ds = h.profile?.designSystem;
     if (ds?.kind && !['none', 'custom'].includes(ds.kind) && ds.confidence !== 'low') {
-      rule(`This repo uses ${ds.name ?? ds.kind}${h.profile.uiDir ? `; its components live in \`${h.profile.uiDir}\`` : ''}. Prefer extending it over building parallel pieces.`);
+      rule(`This repo uses ${ds.name ?? ds.kind}${profileOf(h).uiDir ? `; its components live in \`${profileOf(h).uiDir}\`` : ''}. Prefer extending it over building parallel pieces.`);
     }
   }
   
@@ -130,14 +131,14 @@ const repoName = h.profile?.name ?? 'this repo';
   }
   
   // ---------- never-imported components ----------
-const neverImported = neverImportedComponents(h.components, h.profile?.uiDir);
+const neverImported = neverImportedComponents(h.components, profileOf(h).uiDir);
 if (neverImported.length >= 3) {
   // A vendored catalogue is stock, not debt: the rule points the agent AT it
   // rather than telling it to prune. An unused Calendar beats a hand-rolled
   // date picker written under time pressure.
-  if (h.profile?.vendoredUi) {
+  if (profileOf(h).vendoredUi) {
     section('Catalogue components already installed');
-    rule(`${neverImported.length} components sit installed and unused in \`${h.profile.uiDir}\` (${neverImported.slice(0, 3).map((c) => `\`<${c.name}>\``).join(', ')}…). Reach for one of these before building your own version of the same thing. Do not delete them to tidy up.`);
+    rule(`${neverImported.length} components sit installed and unused in \`${profileOf(h).uiDir}\` (${neverImported.slice(0, 3).map((c) => `\`<${c.name}>\``).join(', ')}…). Reach for one of these before building your own version of the same thing. Do not delete them to tidy up.`);
   } else {
     section('Components nobody imports');
     rule(`${neverImported.length} components are defined but never imported (${neverImported.slice(0, 3).map((c) => `\`<${c.name}>\``).join(', ')}…). Before writing any new component, check this list first; adopt one or flag it for deletion instead of adding another.`);

package/skills/roast-my-design-system/scripts/sarif/index.mjs

@@ -12,6 +12,7 @@ import { resolve } from 'node:path';
 import { VERSION } from '../lib/version.mjs';
 import { nearColorPairs } from '../lib/nearpairs.mjs';
 import { neverImportedComponents } from '../lib/neverimported.mjs';
+import { profileOf } from '../profiles/index.mjs';
 
 function arg(name, fallback) {
   const i = process.argv.indexOf(`--${name}`);
@@ -46,8 +47,8 @@ for (const d of (h.duplicates?.exactDuplicates ?? [])) {
 }
 // A vendored shadcn catalogue is stock, not a defect: nothing to annotate in
 // code scanning, and a finding per component would bury the real ones.
-if (!h.profile?.vendoredUi) {
-  for (const c of neverImportedComponents(h.components ?? [], h.profile?.uiDir ?? null)) {
+if (!profileOf(h).vendoredUi) {
+  for (const c of neverImportedComponents(h.components ?? [], profileOf(h).uiDir)) {
     push('never-imported-component', 'note', `<${c.name}> is defined here and imported by nothing.`, c.file);
   }
 }