rnxsim 0.1.432 → 0.1.434

package/README.md

@@ -373,59 +373,29 @@ const { withRNX } = require('rnxsim/metro')
 
 const config = getDefaultConfig(__dirname)
 
-module.exports = withRNX(config, { open: { appName: 'My App' } })
+module.exports = withRNX(config)
 ```
 
-The `open` option serves the RNX shell and opens the app in its own named
-Electron window. `open: true` derives the name from `package.json`; use the
-object form when the display name differs. Run `rnx desktop install` once before
-enabling it. The macOS desktop download is about 109 MiB and the installed app
-uses about 267 MiB, so the browser remains the recommended first-run path and
-Electron is an opt-in desktop upgrade. The notarized CLI install did not produce
-a Gatekeeper prompt on a clean profile. A Mac that previously ran an unsigned
-development Electron build against the same user-data directory may ask for
-one-time Keychain approval. `RNX_NO_OPEN=1` keeps the server headless. The
-Metro wrapper also has three independent non-window opt-ins.
-`devServer` serves the RNX shell from the Metro process. `productionBundles`
-appends Metro's exact module identity to every production bundle, as a trailing
-`globalThis.__sootsimModulePaths = { ... }` assignment. The versioned value
-contains the module-ID-to-source-path map and the incoming bare logical
-specifiers Metro resolved for each module. Logical specifiers keep identity
-exact when a custom resolver maps a host package such as `react` outside
-`node_modules`. `developmentBundles` appends the same identity to every
-ordinary development bundle while keeping `__DEV__`, verbose module names, and
-the source map.
-
-That footer is the only change. Metro drops the fourth `__d` argument when
-`dev` is false, so a production bundle names none of its modules, and RNX needs
-those names to recognize React, React Native, and native compatibility seams at
-load time. Resolution, transforms, minification, and the source map stay the
-app's own, so the annotated bundle is the bundle you ship: the footer assigns
-one unused global on a device, and Hermes drops it during bytecode compilation.
-
-RNX also accepts an ordinary, unannotated Metro production JavaScript bundle.
-That path reports identity as `inferred` and matches package graph fingerprints
-from a separately updated, integrity-checked registry. It is deliberately less
-strong than the plugin path: ambiguous packages stay unknown, every unknown
-module receives a nonmatching synthetic name, and React must be identified
-exactly or the load stops before app code runs. Hermes bytecode is not a
-supported input; pass RNX the JavaScript bundle produced before Hermes
-compilation. Use `productionBundles: true` when exact identity is required.
+rnx works directly with regular, unannotated Metro production JavaScript bundles
+out of the box. It identifies modules by matching package graph fingerprints
+against a separately updated, integrity-checked registry. Hermes bytecode is not
+a supported input; pass rnx the JavaScript bundle produced before Hermes
+compilation.
 
-```js
-module.exports = withRNX(config, { productionBundles: true })
-
-// enable any combination when one Metro process should provide them
-module.exports = withRNX(config, {
-  devServer: true,
-  productionBundles: true,
-  developmentBundles: true,
-})
-```
+If an app has unusual dependencies or fingerprint inference fails, you can
+optionally wrap your Metro configuration with `withRNX(config)`. It takes no
+options and enables two integrations:
+
+1. **Deterministic module identity:** appends Metro's exact module identity map
+   as a trailing `globalThis.__sootsimModulePaths = { ... }` footer to every
+   bundle. Resolution, transforms, minification, and source maps stay the app's
+   own, so the annotated bundle is the exact bundle you ship: the footer assigns
+   one unused global on a device, and Hermes drops it during bytecode compilation.
+2. **In-browser dev shell:** serves the rnx simulator shell at `/__soot/` on
+   the Metro dev server.
 
-Calling `withRNX(config)` changes nothing. The URL helpers request ordinary
-Metro graphs: `dev=false&minify=true` for production and
-`dev=true&minify=false` for development.
+The URL helpers request ordinary Metro graphs: `dev=false&minify=true` for
+production and `dev=true&minify=false` for development.
 
 ```js
 const {
@@ -514,7 +484,7 @@ For plan-driven app-store exports, use `rnx screenshot appstore`:
 
 ```yaml
 app: 8081
-device: iphone-14
+device: iphone-16
 
 capture:
   flow: .maestro/capture-app-store-screenshots.yaml

package/cli/auth.ts

@@ -8,7 +8,10 @@
 //
 // callers wanting an auth header: `authHeaderOrExit('upload')`.
 
-import { readSharedDesktopAuthSession } from '../src/auth/shared-session'
+import {
+  readSharedDesktopAuthSession,
+  sharedDesktopAuthAccounts,
+} from '../src/auth/shared-session'
 import { rnxExit } from './run-rnx'
 
 export type CliApiKeyEnvName = 'RNX_API_KEY'
@@ -27,7 +30,15 @@ export type CliAuth =
       installationId: string | null
       source: 'contrast-runner' | 'github-actions'
     }
-  | { kind: 'session'; token: string; origin: string }
+  | {
+      kind: 'session'
+      token: string
+      origin: string
+      // the account this sign-in bills cloud sessions to. null when the person
+      // belongs to several accounts and has not chosen one with `rnx login
+      // --account`; a person with exactly one account never has to choose.
+      accountId: string | null
+    }
 
 export type GitHubUploadIdentity = {
   repoId: string
@@ -116,11 +127,30 @@ export function resolveCliAuth(): CliAuth | null {
   if (githubAuth) return githubAuth
   const session = readSharedDesktopAuthSession()
   if (session?.token) {
-    return { kind: 'session', token: session.token, origin: session.origin }
+    const accounts = sharedDesktopAuthAccounts(session.user)
+    return {
+      kind: 'session',
+      token: session.token,
+      origin: session.origin,
+      accountId:
+        session.accountId ?? (accounts.length === 1 ? (accounts[0]?.id ?? null) : null),
+    }
   }
   return null
 }
 
+export const CHOOSE_ACCOUNT_HINT =
+  'this sign-in belongs to several accounts; run `rnx login --account <name>` to choose the one to bill'
+
+// the account a request that opens a paid cloud session names. an api key
+// names its own account, so it sends none; a session token has to say.
+export function cloudAccountIdOrExit(auth: CliAuth): string | null {
+  if (auth.kind !== 'session') return null
+  if (auth.accountId) return auth.accountId
+  process.stderr.write(`\n  ${CHOOSE_ACCOUNT_HINT}\n\n`)
+  rnxExit(1)
+}
+
 export function authHeaderValue(auth: CliAuth): string {
   return auth.kind === 'api-key' ? `Bearer ${auth.secret}` : `Bearer ${auth.token}`
 }