rnxsim 0.1.419 → 0.1.420

package/scripts/dev-server-scanner.ts

@@ -53,7 +53,7 @@ const EXEC_EXIT_GRACE_MS = 2_000
  *  `/__server-scan` stops answering at all instead of answering "could not
  *  look". so we race the child against a real wall-clock deadline and reject
  *  with `killed`, which callers already read as could-not-look. */
-function execGuarded(
+async function execGuarded(
   command: string,
   timeout: number,
   extra: { maxBuffer?: number } = {},
@@ -65,8 +65,9 @@ function execGuarded(
       else resolve({ stdout })
     })
   })
+  let deadlineTimer: ReturnType<typeof setTimeout> | undefined
   const deadline = new Promise<never>((_resolve, reject) => {
-    const timer = setTimeout(() => {
+    deadlineTimer = setTimeout(() => {
       child?.kill('SIGKILL')
       const err = new Error(`\`${command}\` did not exit within ${timeout}ms`)
       // matches the shape `wasKilledByTimeout` reads off a real exec timeout, so
@@ -74,9 +75,13 @@ function execGuarded(
       Object.assign(err, { killed: true })
       reject(err)
     }, timeout + EXEC_EXIT_GRACE_MS)
-    timer.unref?.()
   })
-  return Promise.race([ran, deadline])
+  try {
+    return await Promise.race([ran, deadline])
+  } finally {
+    // the race is settled, so drop the deadline rather than leaving it pending.
+    clearTimeout(deadlineTimer)
+  }
 }
 
 export interface DiscoveredServer {
@@ -234,7 +239,6 @@ function httpGet(
     // the only thing that ever destroys a connection here. by BODY_TIMEOUT_MS a
     // server has long since answered or died, so there is no live write to cut.
     const abandon = setTimeout(() => req.destroy(), BODY_TIMEOUT_MS)
-    abandon.unref?.()
     req.on('close', () => {
       clearTimeout(giveUp)
       clearTimeout(abandon)

package/src/dev-bundle-resolution.ts

@@ -179,12 +179,15 @@ async function probeExpoManifest(
     async (res) => (res.ok ? { ok: true as const, body: await res.text() } : null),
     () => undefined,
   )
+  let probeDeadline: ReturnType<typeof setTimeout> | undefined
   const answered = await Promise.race([
     pending,
-    new Promise<'timeout'>((resolve) =>
-      setTimeout(() => resolve('timeout'), MANIFEST_PROBE_TIMEOUT_MS).unref?.(),
-    ),
+    new Promise<'timeout'>((resolve) => {
+      probeDeadline = setTimeout(() => resolve('timeout'), MANIFEST_PROBE_TIMEOUT_MS)
+    }),
   ])
+  // the race is settled, so drop the deadline rather than leaving it pending.
+  clearTimeout(probeDeadline)
   if (answered === 'timeout' || answered === undefined) return { state: 'no-answer' }
   if (answered === null) return { state: 'no-manifest' }
   body = answered.body

package/src/dev-server-open.ts

@@ -129,9 +129,11 @@ export function openRnxDesktopWhenMetroIsReady({
 
   return new Promise((resolve) => {
     let finished = false
+    let retryTimer: ReturnType<typeof setTimeout> | undefined
     const finish = (opened: boolean) => {
       if (finished) return
       finished = true
+      clearTimeout(retryTimer)
       scheduledMetroOpens.delete(key)
       resolve(opened)
     }
@@ -144,8 +146,7 @@ export function openRnxDesktopWhenMetroIsReady({
         finish(false)
         return
       }
-      const timer = setTimeout(check, intervalMs)
-      timer.unref()
+      retryTimer = setTimeout(check, intervalMs)
     }
     const check = () => {
       const request = http.get(