rman 2.21.0 → 2.21.1

package/builtins/platforms/node/services/clean.service.js

@@ -119,7 +119,9 @@ async function remove(file, dryRun) {
 function pruneEmptyDirs(dir, includeSelf, dryRun) {
     if (dryRun || !fs.existsSync(dir))
         return;
-    const entries = fg.sync('**', { cwd: dir, onlyDirectories: true, dot: true });
+    /** Not through a link: a link to a directory is not a directory of this one to prune - removing
+     *  it as one is `ENOTDIR`, and walking into it reaches somewhere else entirely. */
+    const entries = fg.sync('**', { cwd: dir, onlyDirectories: true, dot: true, followSymbolicLinks: false });
     entries.sort((a, b) => b.split(path.sep).length - a.split(path.sep).length);
     for (const rel of entries) {
         const abs = path.join(dir, rel);
@@ -140,23 +142,48 @@ function pruneEmptyDirs(dir, includeSelf, dryRun) {
  * matching files *inside* an otherwise-deleted directory, leaving the rest of it gone and the
  * protected files (and their now non-empty parent) in place.
  */
+/* **A symbolic link is removed as a link, and never followed.** A build directory routinely holds
+ * one - `build/node_modules/@scope/sibling` pointing at another package's own build - and walking
+ * through it deleted *that* package's output, then failed `rmdir` on the link with `ENOTDIR`.
+ * Measured on `panates/syncbridge`: cleaning `syncbuild` emptied `common/build`, and the run
+ * reported only `0 succeeded, 1 failed`. fast-glob follows links by default, so every glob here
+ * says `followSymbolicLinks: false`. */
 async function cleanGlobs(dirname, include, exclude, dryRun) {
     if (!include.length)
         return [];
-    const matches = await fg(include, { cwd: dirname, ignore: exclude, onlyFiles: false, dot: true, absolute: true });
+    const matches = await fg(include, {
+        cwd: dirname,
+        ignore: exclude,
+        onlyFiles: false,
+        dot: true,
+        absolute: true,
+        followSymbolicLinks: false,
+    });
     const protectedFiles = exclude.length
-        ? new Set(await fg(exclude, { cwd: dirname, onlyFiles: true, dot: true, absolute: true }))
+        ? new Set(await fg(exclude, { cwd: dirname, onlyFiles: true, dot: true, absolute: true, followSymbolicLinks: false }))
         : new Set();
     const removed = [];
     for (const m of matches) {
-        const stat = await fs.promises.stat(m).catch(() => undefined);
+        /** `lstat`, not `stat`: a link is removed as the link it is, and never read as the thing it
+         *  points at. */
+        const stat = await fs.promises.lstat(m).catch(() => undefined);
         if (!stat)
             continue;
         if (stat.isDirectory()) {
-            const filesInside = await fg('**', { cwd: m, onlyFiles: true, dot: true, absolute: true });
-            for (const f of filesInside) {
+            /** Files *and* links inside, and a link never entered - see `cleanGlobs`' own note. */
+            const inside = await fg('**', {
+                cwd: m,
+                onlyFiles: false,
+                dot: true,
+                absolute: true,
+                followSymbolicLinks: false,
+            });
+            for (const f of inside) {
                 if (protectedFiles.has(f))
                     continue;
+                const entry = await fs.promises.lstat(f).catch(() => undefined);
+                if (!entry || entry.isDirectory())
+                    continue;
                 await remove(f, dryRun);
                 removed.push(path.relative(dirname, f));
             }
@@ -208,6 +235,8 @@ async function cleanTsArtifacts(pkg, dryRun) {
         onlyFiles: true,
         dot: true,
         absolute: true,
+        /** A link to a directory elsewhere is not this package's source to sweep. */
+        followSymbolicLinks: false,
     });
     const removed = [];
     for (const f of files) {
@@ -277,6 +306,7 @@ async function cleanTsBuildInfo(dirname, dryRun) {
         onlyFiles: true,
         dot: true,
         absolute: true,
+        followSymbolicLinks: false,
     });
     for (const f of files)
         await remove(f, dryRun);
@@ -310,7 +340,12 @@ async function cleanPackage(pkg, item, panelEnabled, dryRun, logger) {
     }
     catch (e) {
         item.status = 'failed';
-        item.log.push(e?.message ?? String(e));
+        const message = e?.message ?? String(e);
+        item.log.push(message);
+        /** The panel replays `log` in its recap; with no panel nothing does, and the run said only
+         *  `0 succeeded, 1 failed` - which is how the link bug above went unexplained. */
+        if (!panelEnabled)
+            logger.error(colors.red('clean'), colors.cyan(item.name), message);
         throw e;
     }
     finally {

package/constants.js

@@ -1 +1 @@
-export const version = '2.21.0';
+export const version = '2.21.1';

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "rman",
   "description": "Repository manager",
-  "version": "2.21.0",
+  "version": "2.21.1",
   "author": "Panates",
   "license": "MIT",
   "dependencies": {