rman 2.10.0 → 2.10.1

package/commands/version.command.js

@@ -5,6 +5,7 @@ import { registerCommand } from '../interfaces/rman-config.interface.js';
 import { VersionPlanService } from '../services/version-plan.service.js';
 import { assertAllowedBranch, branchGuardOptions, readBranchGuardOptions } from '../utils/branch-guard.js';
 import { packageFilterOptions, readPackageFilterOptions } from '../utils/package-filter.js';
+import { isSoloGroupKey } from '../utils/version-group.js';
 /**
  * Hoisted out of the metadata literal so the handler can be annotated against them - see
  * `RmanConfig.ArgsOf` for why an inferred `argv` and the metadata's own typo checking cannot both
@@ -344,13 +345,21 @@ function planBlocks(entries) {
         else
             byGroup.set(e.groupKey, [e]);
     }
+    /**
+     * **Classified by the key, not by how many members a group has.** This was `group.length > 1`,
+     * which stands in for "is this a group" and is wrong in exactly one case: a group the repository
+     * *named* that happens to have a single member. Reported on a real repository - a package alone in
+     * `group: "abisena-iomt"` landed among the ungrouped and printed an empty Group cell, reading
+     * exactly like a package that had opted out. Its name decides its changelog file and its tag, so
+     * it is a line of its own whatever its size.
+     */
     const shared = [];
     const solo = [];
-    for (const group of byGroup.values()) {
-        if (group.length > 1)
-            shared.push({ members: group, shared: true });
+    for (const [key, group] of byGroup) {
+        if (isSoloGroupKey(key))
+            solo.push(...group);
         else
-            solo.push(group[0]);
+            shared.push({ members: group, shared: true });
     }
     return [
         ...(root.length ? [{ members: root, shared: false }] : []),

package/constants.js

@@ -1 +1 @@
-export const version = '2.10.0';
+export const version = '2.10.1';

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "rman",
   "description": "Repository manager",
-  "version": "2.10.0",
+  "version": "2.10.1",
   "author": "Panates",
   "license": "MIT",
   "dependencies": {

package/utils/version-group.d.ts

@@ -16,6 +16,16 @@ import type { Package } from '../core/classes/package.js';
  * batching; what it cannot do is leave the tag pattern behind, which is the point.
  */
 export declare function groupKeyOf(pkg: Package): string;
+/**
+ * Whether a group key belongs to a package that is in **no** group - `group: false`, a line of its
+ * own that nobody named.
+ *
+ * Here beside `groupKeyOf` so the key's shape is known in one place. The plan table asks it to decide
+ * whether the Group column is worth printing, and it has to ask *this* rather than count members: a
+ * group the repository named is a version line of its own whatever its size, while a package that
+ * opted out of grouping has no group to name.
+ */
+export declare function isSoloGroupKey(key: string): boolean;
 /**
  * How many distinct version lines this package's repository releases along - 1 when every package
  * moves together, more once anything is grouped apart.

package/utils/version-group.js

@@ -22,6 +22,18 @@ export function groupKeyOf(pkg) {
         return `named:${assertGroupName(g, pkg)}`;
     return 'default';
 }
+/**
+ * Whether a group key belongs to a package that is in **no** group - `group: false`, a line of its
+ * own that nobody named.
+ *
+ * Here beside `groupKeyOf` so the key's shape is known in one place. The plan table asks it to decide
+ * whether the Group column is worth printing, and it has to ask *this* rather than count members: a
+ * group the repository named is a version line of its own whatever its size, while a package that
+ * opted out of grouping has no group to name.
+ */
+export function isSoloGroupKey(key) {
+    return key.startsWith('solo:');
+}
 /**
  * How many distinct version lines this package's repository releases along - 1 when every package
  * moves together, more once anything is grouped apart.