rivet-design 0.26.2 → 0.27.0

package/dist/agent-variants/PreviewRuntime.js

@@ -14,12 +14,14 @@ const logger_1 = require("../utils/logger");
 const variantWorkspaceFiles_1 = require("./variantWorkspaceFiles");
 const variantsTelemetry_1 = require("./variantsTelemetry");
 const errorMessage_1 = require("../utils/errorMessage");
+const failureReason_1 = require("../utils/failureReason");
 const pathContainment_1 = require("../utils/pathContainment");
 const log = (0, logger_1.createLogger)('PreviewRuntime');
 const FRESH_DEV_SERVER_HOST = '127.0.0.1';
 const FRESH_DEV_SERVER_DEFAULT_PORT = 5173;
 const DEV_SERVER_START_MAX_ATTEMPTS = 3;
 const DEV_SERVER_MAX_AUTO_RESTARTS = 2;
+const REPORTED_FAILURE_REASONS = new Set(['dependency_install_failed', 'spawn_error']);
 class PreviewRuntime {
     deps;
     sessions = new Map();
@@ -180,9 +182,11 @@ class PreviewRuntime {
             }).catch((error) => {
                 throw new devServerError_1.DevServerStartError({
                     message: (0, errorMessage_1.errorMessage)(error),
+                    summary: (0, errorMessage_1.errorMessage)(error),
                     detail: '',
                     reason: 'dependency_install_failed',
                     portInUse: false,
+                    reasonCode: (0, failureReason_1.failureReasonCode)(error),
                 });
             })
             : null;
@@ -305,13 +309,13 @@ class PreviewRuntime {
                                 reason: 'dependency_install_failed',
                                 portInUse: false,
                                 detail: (0, errorMessage_1.errorMessage)(installError),
-                            }, startedAt, (0, devServerError_1.isDevServerStartError)(installError) ? installError : undefined, missingDepsOutput);
+                            }, startedAt, installError, missingDepsOutput);
                             return undefined;
                         }
                     }
                     continue;
                 }
-                this.failVariant(args, { reason, portInUse }, startedAt, devError, missingDepsOutput);
+                this.failVariant(args, { reason, portInUse }, startedAt, error, missingDepsOutput);
                 return undefined;
             }
             finally {
@@ -356,9 +360,13 @@ class PreviewRuntime {
         });
     }
     failVariant(args, failure, startedAt, error, missingDeps) {
+        const devError = (0, devServerError_1.isDevServerStartError)(error) ? error : undefined;
+        const detail = devError?.detail ||
+            failure.detail ||
+            (error === undefined ? '' : (0, errorMessage_1.errorMessage)(error));
         this.requireSession(args.sessionId).failures.set(args.workItemId, {
             ...failure,
-            ...(error?.detail ? { detail: error.detail } : {}),
+            ...(detail ? { detail } : {}),
         });
         let errorCode = 'DEV_SERVER_START_FAILED';
         if (failure.reason === 'dependency_install_failed') {
@@ -366,15 +374,19 @@ class PreviewRuntime {
         }
         if (failure.reason === 'missing_dev_script')
             errorCode = 'DEV_SCRIPT_MISSING';
+        const reportedError = REPORTED_FAILURE_REASONS.has(failure.reason)
+            ? error
+            : undefined;
         (0, variantsTelemetry_1.trackFreshDevServerFailed)(this.deps.telemetry, {
             sessionId: args.sessionId,
             variantId: args.workItemId,
             errorCode,
             reason: failure.reason,
             portInUse: failure.portInUse,
-            exitCode: error?.exitCode,
-            signal: error?.signal,
+            exitCode: devError?.exitCode,
+            signal: devError?.signal,
             missingDeps,
+            error: reportedError,
         });
         (0, variantsTelemetry_1.trackPreviewFailed)(this.deps.telemetry, {
             sessionId: args.sessionId,
@@ -385,9 +397,10 @@ class PreviewRuntime {
             reason: failure.reason,
             portInUse: failure.portInUse,
             durationMs: Date.now() - startedAt,
-            exitCode: error?.exitCode,
-            signal: error?.signal,
+            exitCode: devError?.exitCode,
+            signal: devError?.signal,
             missingDeps,
+            error: reportedError,
         });
         this.deps.changed();
     }