riskrails 4.1.0 → 4.3.0

package/hooks/guard/paths_shell.py

@@ -0,0 +1,288 @@
+"""The awk segmenter of the retired shell guard: shell_segments cuts a command into its segments,
+words and redirections, with the keyword, flag and redirection tables it reads.
+
+R16: every name here is core (no file, clock or subprocess access).
+Moved from paths.py in WP5 (small-oop-modules), unchanged.
+"""
+import re
+from guard.common import chomp_all
+
+
+_KEYWORDS = {"if", "then", "else", "elif", "do", "while", "until", "!", "{", "}", "time", "exec",
+             "command", "nohup", "builtin", "env", "sudo"}
+_FLAGGED = {"time", "exec", "command", "env", "sudo"}
+_ASSIGN = re.compile(r"[A-Za-z_][A-Za-z0-9_]*\+?=")
+_SPECIAL_OUT = re.compile(r"""['$"#<(\n`)&;|\\]""")
+_SPECIAL_D = re.compile(r'["$`\n\\]')
+_SPECIAL_A = re.compile(r"['\n\\]")
+
+
+def shell_segments(cmd):
+    """The awk segmenter of shell_segments, character for character: the
+    simple commands of a shell line, verb first, one per output line."""
+    src = cmd + "\n"
+    n = len(src)
+    out = []
+    cur = []
+    stk, qst = [], []
+    q = ""
+    nh = 0
+    hd, hs = [], []
+    i = 0
+
+    def emit():
+        s = "".join(cur)
+        cur.clear()
+        while True:
+            s = s.lstrip(" \t")
+            if s == "":
+                return
+            qq = ""
+            k = 0
+            ln = len(s)
+            while k < ln:
+                c = s[k]
+                if qq:
+                    if c == qq:
+                        qq = ""
+                elif c in "\"'":
+                    qq = c
+                elif c in " \t":
+                    break
+                k += 1
+            w = s[:k]
+            if w in _KEYWORDS:
+                s = s[k:]
+                if w in _FLAGGED:
+                    while True:
+                        s = s.lstrip(" \t")
+                        if not s.startswith("-"):
+                            break
+                        j = 0
+                        while j < len(s) and s[j] not in " \t":
+                            j += 1
+                        s = s[j:]
+                continue
+            if _ASSIGN.match(w):
+                s = s[k:]
+                continue
+            break
+        out.append(s)
+
+    def cur_ends(chars):
+        return bool(cur) and cur[-1][-1:] in chars and cur[-1][-1:] != ""
+
+    while i < n:
+        c = src[i]
+        d = src[i + 1] if i + 1 < n else ""
+        if q == "s":
+            j = src.find("'", i)
+            k = src.find("\n", i)
+            if j < 0:
+                j = n
+            if 0 <= k < j:
+                cur.append(src[i:k] + " ")
+                i = k + 1
+                continue
+            cur.append(src[i:j + 1])
+            i = j + 1
+            if j < n:
+                q = ""
+            continue
+        if q == "a":
+            m = _SPECIAL_A.search(src, i)
+            j = m.start() if m else n
+            if j > i:
+                cur.append(src[i:j])
+                i = j
+                continue
+            if c == "\\":
+                cur.append(c + d)
+                i += 2
+                continue
+            if c == "'":
+                q = ""
+            cur.append(" " if c == "\n" else c)
+            i += 1
+            continue
+        if c == "\\":
+            if d == "\n":
+                i += 2
+                continue
+            cur.append(c + d)
+            i += 2
+            continue
+        if q == "d":
+            m = _SPECIAL_D.search(src, i)
+            j = m.start() if m else n
+            if j > i:
+                cur.append(src[i:j])
+                i = j
+                continue
+            if c == '"':
+                q = ""
+                cur.append(c)
+                i += 1
+                continue
+            if c == "$" and d == "(":
+                stk.append("p")
+                qst.append(q)
+                q = ""
+                emit()
+                i += 2
+                continue
+            if c == "`":
+                stk.append("b")
+                qst.append(q)
+                q = ""
+                emit()
+                i += 1
+                continue
+            if c == "$":
+                cur.append(c)
+                i += 1
+                continue
+            cur.append(" " if c == "\n" else c)
+            i += 1
+            continue
+        # outside quotes
+        m = _SPECIAL_OUT.search(src, i)
+        j = m.start() if m else n
+        if j > i:
+            cur.append(src[i:j])
+            i = j
+            continue
+        if c == "'":
+            q = "s"
+            cur.append(c)
+            i += 1
+            continue
+        if c == "$" and d == "'":
+            q = "a"
+            cur.append(c + d)
+            i += 2
+            continue
+        if c == '"':
+            q = "d"
+            cur.append(c)
+            i += 1
+            continue
+        if c == "#" and (not cur or "".join(cur) == "" or cur_ends(" \t")):
+            k = src.find("\n", i)
+            i = k if k >= 0 else n
+            continue
+        if c == "<" and d == "<" and src[i + 2:i + 3] == "<":
+            cur.append("<<<")
+            i += 3
+            continue
+        if (c == "$" and d == "(" and src[i + 2:i + 3] == "(") or (c == "(" and d == "("):
+            j = i + (3 if c == "$" else 2)
+            depth = 2
+            while j < n and depth > 0:
+                e = src[j]
+                if e == "(":
+                    depth += 1
+                elif e == ")":
+                    depth -= 1
+                j += 1
+            cur.append(src[i:j])
+            i = j
+            continue
+        if c == "<" and d == "<":
+            j = i + 2
+            strip = 0
+            if src[j:j + 1] == "-":
+                strip = 1
+                j += 1
+            while src[j:j + 1] in (" ", "\t") and j < n:
+                j += 1
+            w = []
+            wq = ""
+            while j < n:
+                e = src[j]
+                if wq:
+                    if e == wq:
+                        wq = ""
+                    else:
+                        w.append(e)
+                    j += 1
+                    continue
+                if e in "'\"":
+                    wq = e
+                    j += 1
+                    continue
+                if e == "\\":
+                    w.append(src[j + 1:j + 2])
+                    j += 2
+                    continue
+                if e in " \t\n;&|<>()":
+                    break
+                w.append(e)
+                j += 1
+            word = "".join(w)
+            if word:
+                nh += 1
+                hd.append(word)
+                hs.append(strip)
+            i = j
+            continue
+        if c == "\n":
+            emit()
+            i += 1
+            for h in range(nh):
+                while i < n:
+                    e = src.find("\n", i)
+                    line = src[i:e] if e >= 0 else src[i:]
+                    i = e + 1 if e >= 0 else n
+                    if hs[h]:
+                        line = line.lstrip("\t")
+                    if line == hd[h]:
+                        break
+            nh = 0
+            hd, hs = [], []
+            continue
+        if c == "$" and d == "(":
+            stk.append("p")
+            qst.append(q)
+            emit()
+            i += 2
+            continue
+        if c == "$":
+            cur.append(c)
+            i += 1
+            continue
+        if c == "`":
+            if stk and stk[-1] == "b":
+                stk.pop()
+                q = qst.pop()
+            else:
+                stk.append("b")
+                qst.append(q)
+            emit()
+            i += 1
+            continue
+        if c == "(":
+            stk.append("p")
+            qst.append(q)
+            emit()
+            i += 1
+            continue
+        if c == ")":
+            if stk and stk[-1] == "p":
+                stk.pop()
+                q = qst.pop()
+            emit()
+            i += 1
+            continue
+        if c == "&" and (cur_ends("<>") or d == ">"):
+            cur.append(c)
+            i += 1
+            continue
+        if c in ";|&":
+            emit()
+            i += 1
+            continue
+        cur.append(c)
+        i += 1
+    emit()
+    return chomp_all("".join(s + "\n" for s in out))

package/hooks/runtime-gate.py

@@ -1160,6 +1160,90 @@ def git_branch(cwd):
     return ""
 
 
+def read_json_file(path):
+    """The parsed JSON file, or None when it is missing, unreadable or not JSON."""
+    try:
+        with open(path, encoding="utf-8") as fh:
+            return json.load(fh)
+    except (OSError, ValueError, RecursionError):
+        return None
+
+
+def still_waiting(decisions, path):
+    """The decisions guard/dialog.py `pending` keeps, from the consent ledger at path: not
+    settled, and not every command pick of the latest dialog call used. A missing or
+    torn ledger leaves them all."""
+    used, settled, rounds = set(), set(), {}
+    try:
+        with open(path, encoding="utf-8") as fh:
+            for raw in fh:
+                try:
+                    entry = json.loads(raw)
+                except (ValueError, RecursionError):
+                    continue
+                kind = entry.get("type") if isinstance(entry, dict) and entry.get("v") == 1 else None
+                if kind == "use":
+                    used.add(entry.get("id"))
+                elif kind == "settle":
+                    settled.add(entry.get("decision"))
+                elif kind == "pick" and isinstance(entry.get("order"), int) and not isinstance(entry["order"], bool):
+                    call, chain = rounds.get(entry.get("decision"), (None, []))
+                    if chain and call == entry.get("tool_use_id"):
+                        chain.append(entry)
+                    else:
+                        rounds[entry.get("decision")] = (entry.get("tool_use_id"), [entry])
+    except OSError:
+        return decisions
+    out = []
+    for decision in decisions:
+        options = decision.get("options")
+        commands = {o.get("n") for o in options if isinstance(o, dict) and o.get("kind") == "command"} \
+            if isinstance(options, list) else set()
+        picks = [p for p in rounds.get(decision.get("id"), (None, []))[1] if p.get("option") in commands]
+        if decision.get("id") not in settled and not (picks and all(p.get("id") in used for p in picks)):
+            out.append(decision)
+    return out
+
+
+def waiting_ids(decisions, state):
+    """The ids that wait on the human, `D3 D4 Q2 G1`: at most three per kind, then `+n`."""
+    state = state or {}
+    asked, approval = state.get("questions"), state.get("human_approval")
+    questions = asked.get("pending") if isinstance(asked, dict) else None
+    approval = approval if isinstance(approval, dict) else {}
+    kinds = ([d.get("id") for d in decisions],
+             [q for q in questions if not str(q).startswith("G")] if isinstance(questions, list) else [],
+             [approval["gate_id"]] if approval.get("requested_at") and approval.get("gate_id") else [])
+    out = []
+    for ids in kinds:
+        ids = [str(i) for i in ids if i]
+        out += ids[:3] + (["+%d" % (len(ids) - 3)] if len(ids) > 3 else [])
+    return " ".join(out)
+
+
+def task_segment(cwd):
+    """`<task> · <mode> · <stage> waiting on you: D3 Q2`, or `riskrails · waiting on you: D3`
+    with no task, read from the .ai/state files at or above cwd; "" when nothing is in flight
+    or waits."""
+    here = os.path.abspath(cwd)
+    while not os.path.isdir(os.path.join(here, ".ai", "state")):
+        parent = os.path.dirname(here)
+        if parent == here:
+            return ""
+        here = parent
+    folder = os.path.join(here, ".ai", "state")
+    state = read_json_file(os.path.join(folder, "state.json"))
+    state = state if isinstance(state, dict) and state.get("task_id") else None
+    decisions = read_json_file(os.path.join(folder, "decision.json"))
+    opened = decisions.get("open") if isinstance(decisions, dict) else None
+    opened = [d for d in opened if isinstance(d, dict)] if isinstance(opened, list) else []
+    waiting = waiting_ids(still_waiting(opened, os.path.join(folder, "consent.jsonl")) if opened else [], state)
+    if not state:
+        return "riskrails · waiting on you: " + waiting if waiting else ""
+    return " · ".join(str(state.get(k)) for k in ("task_id", "mode", "stage")) \
+        + (" waiting on you: " + waiting if waiting else "")
+
+
 def second_line(payload):
     """`user@host:cwd | branch | 5h:12% (↻14:00) 7d:41% (↻Fri 03:04) | $1.23`, the
     colours of a Debian colour PS1; each part after the prompt is skipped when its
@@ -1180,6 +1264,9 @@ def second_line(payload):
     branch = git_branch(cwd) if os.path.isdir(cwd) else ""
     if branch:
         out += "%s\033[35m%s%s" % (SL_SEP, branch, SL_RESET)
+    segment = task_segment(cwd)
+    if segment:
+        out += "%s\033[36m%s%s" % (SL_SEP, segment, SL_RESET)
     limits = payload.get("rate_limits")
     limits = limits if isinstance(limits, dict) else {}
     parts = []

package/hooks/update_notice.py

@@ -80,8 +80,9 @@ def spawn_refresh(path):
         pass
 
 
-def notice(runtime, home, plugin_root, now):
-    """(systemMessage, additionalContext) when the cache knows a newer release, else ("", "")."""
+def notice(runtime, home, plugin_root, now, dialog=False):
+    """(systemMessage, additionalContext) when the cache knows a newer release, else ("", "").
+    dialog: the caller's answer to "is the dialog on"; the message then names the dialog first."""
     if disabled():
         return "", ""
     riskrails = os.path.join(home, "riskrails")
@@ -95,12 +96,26 @@ def notice(runtime, home, plugin_root, now):
     have, new = parse(installed), parse(latest)
     if not have or not new or new <= have:
         return "", ""
-    message = (f"RiskRails {latest} is available (installed {installed}). Update: {COMMAND} "
-               f"— inside Claude Code or Codex CLI: ! {COMMAND} — then /rr-setup --update in each project.")
-    context = (f"RiskRails {latest} is available on npm; {installed} is installed. The user updates it "
-               f"with `{COMMAND}` in a terminal, or `! {COMMAND}` inside Claude Code or Codex CLI, "
-               "then `/rr-setup --update` in each project. Mention this once to the user if it is "
-               "relevant; never run the update yourself — installing is the user's act.")
+    if dialog:
+        message = (f'RiskRails {latest} is available (installed {installed}). Say "update RiskRails" and the '
+                   f"session asks you in the dialog — or run {COMMAND} in a terminal; "
+                   "then /rr-setup --update in each project.")
+    else:
+        message = (f"RiskRails {latest} is available (installed {installed}). Update: {COMMAND} "
+                   f"— inside Claude Code or Codex CLI: ! {COMMAND} — then /rr-setup --update in each project.")
+    if dialog:
+        context = (f"RiskRails {latest} is available on npm; {installed} is installed. When the user asks to "
+                   "update, open the install decision — state.py decision open --kind install "
+                   f'--command "npx riskrails@{latest} --yes" — send the dialog it prints and run the '
+                   "command the user picks, verbatim, once; never run the update without that pick — "
+                   "installing is the user's act. A task in flight refuses it (INSTALL_DURING_TASK): close "
+                   "the task first. Afterwards the user starts a new session and runs /rr-setup --update "
+                   "in each project. Mention this once to the user if it is relevant.")
+    else:
+        context = (f"RiskRails {latest} is available on npm; {installed} is installed. The user updates it "
+                   f"with `{COMMAND}` in a terminal, or `! {COMMAND}` inside Claude Code or Codex CLI, "
+                   "then `/rr-setup --update` in each project. Mention this once to the user if it is "
+                   "relevant; never run the update yourself — installing is the user's act.")
     return message, context
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "riskrails",
-  "version": "4.1.0",
+  "version": "4.3.0",
   "description": "RiskRails: a weight-based engineering pipeline for Claude Code and Codex — scoped steps, enforcement hooks, adversarial review, model routing.",
   "keywords": ["claude-code", "codex", "sdlc", "agents", "guardrails", "code-review"],
   "homepage": "https://github.com/vanssata/claude-agentic-sdlc-module#readme",

package/skills/AGENTS.md

@@ -1,6 +0,0 @@
-<!-- riskrails:rule:skills:start -->
-# Skills rules
-- Weigh a change by what it does to a user project's decisions, never by the skill being a process (constitution C6). The mode is what W gives (`state.py weight`); the rows below set the behaviour axis.
-- behaviour 0: skill or agent text, `usage-report`, no `state.py` refusal moves. behaviour 1: adds a `state.py` check, a sensor or a refusal. behaviour 2: weakens a refusal, changes the approval path (`approve`, `questions --sync`, `AI_UNATTENDED`, the review verdict transitions) or changes install and migration (the `project-update` merge; a migration also raises reversibility through its hint) — declare it, `--declare behaviour=2:"<the effect>"`. Start such a task with `start --mode full --by <name>`: its weight lands in guarded, and these effects keep a STRONG review and the gate.
-- A change to a shipped template or to `ai/` runs `tools/build-template-history.py` in the same task, or `tests/test_project_update.py` (`test_history_covers_every_template`) goes red.
-<!-- riskrails:rule:skills:end -->

package/skills/CLAUDE.md

@@ -1,6 +0,0 @@
-<!-- riskrails:rule:skills:start -->
-# Skills rules
-- Weigh a change by what it does to a user project's decisions, never by the skill being a process (constitution C6). The mode is what W gives (`state.py weight`); the rows below set the behaviour axis.
-- behaviour 0: skill or agent text, `usage-report`, no `state.py` refusal moves. behaviour 1: adds a `state.py` check, a sensor or a refusal. behaviour 2: weakens a refusal, changes the approval path (`approve`, `questions --sync`, `AI_UNATTENDED`, the review verdict transitions) or changes install and migration (the `project-update` merge; a migration also raises reversibility through its hint) — declare it, `--declare behaviour=2:"<the effect>"`. Start such a task with `start --mode full --by <name>`: its weight lands in guarded, and these effects keep a STRONG review and the gate.
-- A change to a shipped template or to `ai/` runs `tools/build-template-history.py` in the same task, or `tests/test_project_update.py` (`test_history_covers_every_template`) goes red.
-<!-- riskrails:rule:skills:end -->

package/skills/ai-init/templates/.ai/policies/coding.md

@@ -18,6 +18,15 @@
   install and reviewable in git.
 - Dead code is deleted only in a task that is about deleting it, with evidence
   that it is dead.
+- A function does one thing and its name says which. When the name needs
+  "and", split it.
+- Inputs come in as parameters and the result goes out as the return value;
+  files, the network and the clock stay at the edge, in the caller.
+- An error message says what failed, what was expected, what was found, and
+  the way out.
+
+In existing code the file's conventions win; the last three lines hold for the
+functions you add.
 
 ## Comments
 

package/skills/ai-init/templates/gitignore.snippet

@@ -4,3 +4,5 @@
 .ai/state/*.tmp
 .ai/state/*.jsonl
 .ai/local/
+.ai/memory/
+.ai/reports/