riskrails 3.0.1 → 3.1.0

package/skills/rr-build-all/SKILL.md

@@ -146,8 +146,8 @@ EOF
 - **pass** → §6.
 - **pass_with_findings** → the in-scope HIGHs, grouped by file, one fixer per group in
   parallel; `$STATE verify --scope all --after-fix "H1,H2: …"`; `$STATE review --closes "H1,H2"`
-  → §6. Each MEDIUM and LOW is one `$STATE memory risk add`, not a fix; only a BLOCKER, a HIGH
-  or a regression buys an `--after-fix` run.
+  → §6. MEDIUM and LOW: `memory risk add` as `/rr-review` §4 says, for every verdict; only a
+  BLOCKER, a HIGH or a regression buys an `--after-fix` run.
 - **blockers_open** → every in-scope BLOCKER and HIGH, grouped by file, one fixer per group in
   parallel; `$STATE verify --scope all --after-fix "B1,H1: …"` (red: §4's batch); then
   **§5 again, a full pass** — a fix batch across many files is a new change, not a scoped one.

package/skills/rr-plan/SKILL.md

@@ -24,7 +24,9 @@ first: a task already in flight is finished or abandoned before another starts.
 
 When `$ARGUMENTS` is a spec (default: the newest `docs/sdlc/specs/*.md`):
 
-1. `docs/sdlc/plans/TEMPLATE.md` exists, else `/rr-setup`. If the spec's
+1. `docs/sdlc/constitution.md` exists, else `/rr-setup`. The template is
+   `docs/sdlc/plans/TEMPLATE.md` when the project overrides it, else
+   `$AI_HOME/skills/project-init/templates/plan.md`. If the spec's
    **Flagged concerns** holds unresolved items, list them and have the human
    resolve or explicitly accept each one before planning.
 2. If `superpowers:writing-plans` is available, use it for the step

package/skills/rr-review/SKILL.md

@@ -60,7 +60,10 @@ guarded, about 80 in full, then FINDINGS and VERDICT.
 
 Before you delegate, probe the change yourself for a minute: the few inputs its
 own threat model makes interesting, through the real code, and hand the
-reviewer what you saw — it starts where you stopped.
+reviewer what you saw — it starts where you stopped. When the change touches a
+guard regex's running time, run the timed probe yourself (`/usr/bin/grep -E`,
+or Python `timeit` on inputs of at most 4096 chars) and hand over the
+measurement: the bounded reviewer may not run timing loops.
 
 ## 3. Record the verdict
 
@@ -81,16 +84,18 @@ task's record (`task.md`), so there is no separate report to write.
 
 ## 4. After the verdict
 
-- **pass:** `/rr-ship`; the record and the close are one call,
-  `$STATE review --verdict pass … <<'EOF' && $STATE close`. `review` exits 0 for every
-  verdict, so the chain is for `pass` only.
+Continue from the verdict §3 recorded; do not record it again. Whatever the
+verdict, each MEDIUM and LOW is one `$STATE memory risk add`
+(`.ai/project/known-risks.md` amended into the task if missing), not a fix.
+
+- **pass:** `/rr-ship`, i.e. `$STATE close` directly: the verdict is already
+  recorded. (To record and close in one call, §3's `review --verdict pass … <<'EOF' && $STATE close`;
+  `review` exits 0 for every verdict, so that chain is for `pass` only.)
 - **pass_with_findings:** fix every in-scope HIGH in one batch, then
   `$STATE verify --scope all --after-fix "H1,H2: <one line>"` and
   `$STATE review --closes "H1,H2"`. The findings close on that green run, on a
-  tree the fix changed — no second review. Each MEDIUM and LOW is one
-  `$STATE memory risk add` (`.ai/project/known-risks.md` amended into the task
-  if missing), not a fix; only a BLOCKER, a HIGH or a regression buys an
-  `--after-fix` run.
+  tree the fix changed — no second review. MEDIUM and LOW: `memory risk add`
+  as above; only a BLOCKER, a HIGH or a regression buys an `--after-fix` run.
 - **blockers_open:** fix every BLOCKER and HIGH together, `verify --scope all
   --after-fix "…"`, then **one scoped re-review** (`/rr-review B1,H1`): brief a fresh `ai-reviewer`
   with the named findings and the fix's diff only — do they close, and what did

package/skills/rr-setup/SKILL.md

@@ -133,12 +133,25 @@ it cannot.
    each in one plain sentence and ask, unless `$ARGUMENTS` holds `--apply`.
 4. `$UPDATE --apply`. Exit 3 stopped on a changed, non-regular or unwritable
    file and names it; nothing after it was written — run the dry run again.
-   **A `delete?` is the human's.** Never pass `--confirm-delete`, not even with
+   **A `delete?` is the human's.** Never pass `--confirm-delete` or `--confirm-cleanup`, not even with
    `--apply`. Give them, with `$AI_HOME` and `$PWD` substituted, for their own
    terminal (the `!` prefix is refused):
    `python3 "<home>/skills/project-update/update.py" "<project>" --apply --confirm-delete "<your name>"`.
    The schema stays put until it is settled — that command, or deleting the
-   file by hand; there is no third way. For 0006 (shared files) the order is:
+   file by hand; there is no third way. Two kinds are housekeeping, not
+   migrations: `[sdlc]` — an unedited `docs/sdlc/*/TEMPLATE.md`, which the plugin
+   now supplies (an edited one stays as the project's override); `[cleanup]` —
+   the `*.log` files of closed tasks, and the report and log files of an
+   abandoned task (its `state.json` stays) or of one unclosed for more than seven
+   days (never the task in flight; and none when `.ai/state/state.json` is unreadable).
+   `--confirm-delete` does not settle `[cleanup]` rows, and the rows differ by kind:
+   files under `.ai/state/logs/` are git-ignored and git cannot restore them; files
+   under `.ai/reports/` are usually tracked, and the row says "tracked: git can restore
+   a committed copy" or, when git holds no committed copy, "uncommitted" — then
+   commit `.ai/` first (the hint says so), and an `original/` copy is kept as for any
+   other deletion. They have their own command, the human's too, never passed by the agent:
+   `python3 "<home>/skills/project-update/update.py" "<project>" --apply --confirm-cleanup "<your name>"`.
+   Show both groups as printed. For 0006 (shared files) the order is:
    `install.sh` for every runtime used, commit `.ai/`, read the `delete?` list,
    then the command with no task in flight. Rollback is git:
    `git restore --source=<commit before> --staged --worktree -- .ai`, before

package/skills/rr-setup/setup.py

@@ -182,7 +182,11 @@ def comment_purpose(lines):
 
 
 def purpose_of(root, rel):
-    text = read_text(os.path.join(root, rel))
+    full = os.path.join(root, rel)
+    real, base = os.path.realpath(full), os.path.realpath(root)
+    if os.path.commonpath([real, base]) != base:
+        return None  # a link out of the project: listed UNKNOWN, never read into toolbox.md
+    text = read_text(full)
     if text is None:
         return None
     lines = text.splitlines()
@@ -225,6 +229,8 @@ def inventory(root, table):
         for rel in paths:
             if rel in seen or not pattern.match(rel):
                 continue
+            if "/hooks/" in rel and os.path.basename(rel).startswith("."):
+                continue
             seen.add(rel)
             if row["kind"] == "make":
                 for n, target, purpose in make_targets(root, rel):

package/skills/rr-spec/SKILL.md

@@ -19,7 +19,9 @@ STATE="python3 $AI_HOME/skills/ai-task/state.py"
 
 ## 1. Prerequisites
 
-`docs/sdlc/specs/TEMPLATE.md` exists, else run `/rr-setup` first. Derive
+`docs/sdlc/constitution.md` exists, else run `/rr-setup` first. The template is
+`docs/sdlc/specs/TEMPLATE.md` when the project overrides it, else
+`$AI_HOME/skills/project-init/templates/spec.md`. Derive
 `<slug>` from the topic (kebab-case, at most five words). If
 `docs/sdlc/specs/<slug>.md` exists, offer to refine it instead of starting over.
 When `$ARGUMENTS` is a path to an intent file, read it fully — it is small by
@@ -75,7 +77,7 @@ decision — moves this to the top tier.
 
 ## 5. Write
 
-Copy `docs/sdlc/specs/TEMPLATE.md` to `docs/sdlc/specs/<slug>.md`, replace
+Copy the template (§1) to `docs/sdlc/specs/<slug>.md`, creating the folder, replace
 `{{TITLE}}` and `{{SLUG}}`. Replace the template's `Intent:` line with:
 
 ```markdown

package/skills/usage-report/usage-report.py

@@ -690,7 +690,8 @@ def task_report(args) -> int:
         return 1
     start = min(stamps)
     closed = [parse_ts(e.get("ts")) for e in events if e.get("event") == "task_closed"]
-    end = max(c for c in closed if c) if any(closed) else dt.datetime.now(dt.timezone.utc)
+    unclosed = not any(closed)
+    end = max(stamps) if unclosed else max(c for c in closed if c)   # unclosed: the last event, not now
     tier, mode = "untiered", None
     involved = []
     for e in events:
@@ -729,7 +730,8 @@ def task_report(args) -> int:
 
     label = f"mode {mode} (tier {tier})" if mode else f"tier {tier}"
     print(f"task {args.task} {label} window {start.isoformat(timespec='seconds')}"
-          f"..{end.isoformat(timespec='seconds')}")
+          f"..{end.isoformat(timespec='seconds')}"
+          + (" (unclosed: window ends at the last event)" if unclosed else ""))
     print("  (by time window: any other session in this project inside it is counted too)")
     for rt in involved or sorted(used):
         inp, cache, out = used.get(rt, [0, 0, 0])