ripple 0.3.6 → 0.3.8

package/CHANGELOG.md

@@ -1,5 +1,48 @@
 # ripple
 
+## 0.3.8
+
+### Patch Changes
+
+- Updated dependencies []:
+  - ripple@0.3.8
+
+## 0.3.7
+
+### Patch Changes
+
+- [#832](https://github.com/Ripple-TS/ripple/pull/832)
+  [`9ca9310`](https://github.com/Ripple-TS/ripple/commit/9ca9310550a800f4435821ed84b24bdd4f243117)
+  Thanks [@trueadm](https://github.com/trueadm)! - Fix lazy array rest
+  destructuring for tracked and array-like values by routing rest extraction
+  through a shared `array_slice` helper instead of calling `.slice()` directly on
+  the source.
+
+- [#832](https://github.com/Ripple-TS/ripple/pull/832)
+  [`9ca9310`](https://github.com/Ripple-TS/ripple/commit/9ca9310550a800f4435821ed84b24bdd4f243117)
+  Thanks [@trueadm](https://github.com/trueadm)! - Allow tracked tuple `.length`
+  member access in compiler analysis and simplify tracked direct-access validation
+  into a single combined condition.
+
+- [#832](https://github.com/Ripple-TS/ripple/pull/832)
+  [`9ca9310`](https://github.com/Ripple-TS/ripple/commit/9ca9310550a800f4435821ed84b24bdd4f243117)
+  Thanks [@trueadm](https://github.com/trueadm)! - Fix `to_ts` output for lazy
+  array destructuring so it keeps direct destructuring syntax for `track()` and
+  `trackSplit()` instead of expanding through an intermediate `lazy` variable.
+
+- [#832](https://github.com/Ripple-TS/ripple/pull/832)
+  [`9ca9310`](https://github.com/Ripple-TS/ripple/commit/9ca9310550a800f4435821ed84b24bdd4f243117)
+  Thanks [@trueadm](https://github.com/trueadm)! - Replace tracked `get()`/`set()`
+  APIs with a `value` getter/setter across runtime, types, analyzer tracked-access
+  rules, and lazy destructuring tests.
+
+- Updated dependencies
+  [[`9ca9310`](https://github.com/Ripple-TS/ripple/commit/9ca9310550a800f4435821ed84b24bdd4f243117),
+  [`9ca9310`](https://github.com/Ripple-TS/ripple/commit/9ca9310550a800f4435821ed84b24bdd4f243117),
+  [`9ca9310`](https://github.com/Ripple-TS/ripple/commit/9ca9310550a800f4435821ed84b24bdd4f243117),
+  [`9ca9310`](https://github.com/Ripple-TS/ripple/commit/9ca9310550a800f4435821ed84b24bdd4f243117)]:
+  - ripple@0.3.7
+
 ## 0.3.6
 
 ### Patch Changes

package/package.json

@@ -3,7 +3,7 @@
   "description": "Ripple is an elegant TypeScript UI framework",
   "license": "MIT",
   "author": "Dominic Gannaway",
-  "version": "0.3.6",
+  "version": "0.3.8",
   "type": "module",
   "module": "src/runtime/index-client.js",
   "main": "src/runtime/index-client.js",
@@ -105,6 +105,6 @@
     "vscode-languageserver-types": "^3.17.5"
   },
   "peerDependencies": {
-    "ripple": "0.3.6"
+    "ripple": "0.3.8"
   }
 }

package/src/compiler/phases/1-parse/index.js

@@ -52,16 +52,6 @@ function DestructuringErrors() {
 	return this;
 }
 
-/**
- * @param {AST.Identifier | ESTreeJSX.JSXIdentifier} node
- * @param {string} name
- */
-function set_tracked_name(node, name) {
-	node.name = name.slice(1);
-	node.metadata ??= { path: [] };
-	node.metadata.source_name = name;
-}
-
 /**
  * Convert JSX node types to regular JavaScript node types
  * @param {ESTreeJSX.JSXIdentifier | ESTreeJSX.JSXMemberExpression | AST.Node} node - The JSX node to convert
@@ -678,7 +668,7 @@ function RipplePlugin(config) {
 				}
 				if (code === 64) {
 					// @ character
-					// Look ahead to see if this is followed by a valid identifier character or opening paren
+					// Look ahead to see if this is followed by an opening paren
 					if (this.pos + 1 < this.input.length) {
 						const nextChar = this.input.charCodeAt(this.pos + 1);
 
@@ -688,114 +678,11 @@ function RipplePlugin(config) {
 							this.pos += 2; // skip '@('
 							return this.finishToken(tt.parenL, '@(');
 						}
-
-						// Check if the next character can start an identifier
-						if (
-							(nextChar >= 65 && nextChar <= 90) || // A-Z
-							(nextChar >= 97 && nextChar <= 122) || // a-z
-							nextChar === 95 ||
-							nextChar === 36
-						) {
-							// _ or $
-
-							// Check if we're in an expression context
-							// In JSX expressions, inside parentheses, assignments, etc.
-							// we want to treat @ as an identifier prefix rather than decorator
-							const currentType = this.type;
-							/**
-							 * @param {Parse.TokenType} type
-							 * @param {Parse.Parser} parser
-							 * @param {Parse.TokTypes} tt
-							 * @returns {boolean}
-							 */
-							function inExpression(type, parser, tt) {
-								return (
-									parser.exprAllowed ||
-									type === tt.braceL || // Inside { }
-									type === tt.parenL || // Inside ( )
-									type === tt.eq || // After =
-									type === tt.comma || // After ,
-									type === tt.colon || // After :
-									type === tt.question || // After ?
-									type === tt.logicalOR || // After ||
-									type === tt.logicalAND || // After &&
-									type === tt.dot || // After . (for member expressions like obj.@prop)
-									type === tt.questionDot // After ?. (for optional chaining like obj?.@prop)
-								);
-							}
-
-							/**
-							 * @param {Parse.Parser} parser
-							 * @param {Parse.TokTypes} tt
-							 * @returns {boolean}
-							 */
-							function inAwait(parser, tt) {
-								return currentType === tt.name &&
-									parser.value === 'await' &&
-									parser.canAwait &&
-									parser.preToken
-									? inExpression(parser.preToken, parser, tt)
-									: false;
-							}
-
-							if (inExpression(currentType, this, tt) || inAwait(this, tt)) {
-								return this.readAtIdentifier();
-							}
-						}
 					}
 				}
 				return super.getTokenFromCode(code);
 			}
 
-			/**
-			 * Read an @ prefixed identifier
-			 * @type {Parse.Parser['readAtIdentifier']}
-			 */
-			readAtIdentifier() {
-				const start = this.pos;
-				this.pos++; // skip '@'
-
-				// Read the identifier part manually
-				let word = '';
-				while (this.pos < this.input.length) {
-					const ch = this.input.charCodeAt(this.pos);
-					if (
-						(ch >= 65 && ch <= 90) || // A-Z
-						(ch >= 97 && ch <= 122) || // a-z
-						(ch >= 48 && ch <= 57) || // 0-9
-						ch === 95 ||
-						ch === 36
-					) {
-						// _ or $
-						word += this.input[this.pos++];
-					} else {
-						break;
-					}
-				}
-
-				if (word === '') {
-					this.raise(start, 'Invalid @ identifier');
-				}
-
-				// Return the full identifier including @
-				return this.finishToken(tt.name, '@' + word);
-			}
-
-			/**
-			 * Override parseIdent to mark @ identifiers as tracked
-			 * @type {Parse.Parser['parseIdent']}
-			 */
-			parseIdent(liberal) {
-				const node = /** @type {AST.Identifier &AST.NodeWithLocation} */ (
-					super.parseIdent(liberal)
-				);
-				if (node.name && node.name.startsWith('@')) {
-					set_tracked_name(node, node.name);
-					node.tracked = true;
-				}
-				return node;
-			}
-
 			/**
 			 * Override parseSubscripts to handle `.@[expression]` syntax for reactive computed member access
 			 * @type {Parse.Parser['parseSubscripts']}
@@ -1342,7 +1229,6 @@ function RipplePlugin(config) {
 			jsx_parseExpressionContainer() {
 				let node = /** @type {ESTreeJSX.JSXExpressionContainer} */ (this.startNode());
 				this.next();
-				let tracked = false;
 
 				if (this.value === 'html') {
 					node.html = true;
@@ -1353,20 +1239,12 @@ function RipplePlugin(config) {
 							'"html" is a Ripple keyword and must be used in the form {html some_content}',
 						);
 					}
-					if (this.type.label === '@') {
-						this.next(); // consume @
-						tracked = true;
-					}
 				}
 
 				node.expression =
 					this.type === tt.braceR ? this.jsx_parseEmptyExpression() : this.parseExpression();
 				this.expect(tt.braceR);
 
-				if (tracked && node.expression.type === 'Identifier') {
-					node.expression.tracked = true;
-				}
-
 				return this.finishNode(node, 'JSXExpressionContainer');
 			}
 
@@ -1429,10 +1307,6 @@ function RipplePlugin(config) {
 					} else {
 						const id = /** @type {AST.Identifier} */ (this.parseIdentNode());
 						id.tracked = false;
-						if (id.name.startsWith('@')) {
-							set_tracked_name(id, id.name);
-							id.tracked = true;
-						}
 						this.finishNode(id, 'Identifier');
 						/** @type {AST.Attribute} */ (node).name = id;
 						/** @type {AST.Attribute} */ (node).value = id;
@@ -1484,14 +1358,6 @@ function RipplePlugin(config) {
 						// Unexpected token after @
 						this.unexpected();
 					}
-				} else if (
-					(this.type === tt.name || this.type === tstt.jsxName) &&
-					this.value &&
-					/** @type {string} */ (this.value).startsWith('@')
-				) {
-					set_tracked_name(node, /** @type {string} */ (this.value));
-					node.tracked = true;
-					this.next();
 				} else if (this.type === tt.name || this.type.keyword || this.type === tstt.jsxName) {
 					node.name = /** @type {string} */ (this.value);
 					node.tracked = false; // Explicitly mark as not tracked
@@ -1550,15 +1416,14 @@ function RipplePlugin(config) {
 							// Expect closing bracket
 							this.expect(tt.bracketR);
 						} else {
-							// @ not followed by [, treat as regular tracked identifier
-							memberExpr.property = this.jsx_parseIdentifier();
-							memberExpr.computed = false;
+							this.unexpected();
 						}
 					} else {
 						// Regular dot notation
 						memberExpr.property = this.jsx_parseIdentifier();
 						memberExpr.computed = false;
 					}
+					memberExpr = this.finishNode(memberExpr, 'JSXMemberExpression');
 					while (this.eat(tt.dot)) {
 						let newMemberExpr = /** @type {ESTreeJSX.JSXMemberExpression} */ (
 							this.startNodeAt(
@@ -1571,7 +1436,7 @@ function RipplePlugin(config) {
 						newMemberExpr.computed = false;
 						memberExpr = this.finishNode(newMemberExpr, 'JSXMemberExpression');
 					}
-					return this.finishNode(memberExpr, 'JSXMemberExpression');
+					return memberExpr;
 				}
 				return node;
 			}
@@ -2355,53 +2220,6 @@ function RipplePlugin(config) {
 					this.awaitPos = 0;
 					return this.parseComponent({ requireName: true, declareName: true });
 				}
-				if (this.type.label === '@') {
-					// Try to parse as an expression statement first using tryParse
-					// This allows us to handle Ripple @ syntax like @count++ without
-					// interfering with legitimate decorator syntax
-					this.skip_decorator = true;
-					const expressionResult = this.tryParse(() => {
-						const node = /** @type {AST.ExpressionStatement} */ (this.startNode());
-						this.next();
-						// Force expression context to ensure @ is tokenized correctly
-						const old_expr_allowed = this.exprAllowed;
-						this.exprAllowed = true;
-						node.expression = this.parseExpression();
-
-						if (node.expression.type === 'UpdateExpression') {
-							/** @type {AST.Expression} */
-							let object = node.expression.argument;
-							while (object.type === 'MemberExpression') {
-								object = /** @type {AST.Expression} */ (object.object);
-							}
-							if (object.type === 'Identifier') {
-								object.tracked = true;
-							}
-						} else if (node.expression.type === 'AssignmentExpression') {
-							/** @type {AST.Expression | AST.Pattern | AST.Identifier} */
-							let object = node.expression.left;
-							while (object.type === 'MemberExpression') {
-								object = /** @type {AST.Expression} */ (object.object);
-							}
-							if (object.type === 'Identifier') {
-								object.tracked = true;
-							}
-						} else if (node.expression.type === 'Identifier') {
-							node.expression.tracked = true;
-						} else {
-							// TODO?
-						}
-
-						this.exprAllowed = old_expr_allowed;
-						return this.finishNode(node, 'ExpressionStatement');
-					});
-					this.skip_decorator = false;
-
-					// If parsing as expression statement succeeded, use that result
-					if (expressionResult.node) {
-						return expressionResult.node;
-					}
-				}
 
 				if (this.type === tstt.jsxTagStart) {
 					this.next();
@@ -2416,6 +2234,37 @@ function RipplePlugin(config) {
 					return node;
 				}
 
+				// &[ or &{ at statement level — lazy destructuring assignment
+				// e.g., &[data] = track(0); or &{x, y} = obj;
+				if (this.type === tt.bitwiseAND) {
+					const charAfterAmp = this.input.charCodeAt(this.end);
+					if (charAfterAmp === 123 || charAfterAmp === 91) {
+						const node = /** @type {AST.ExpressionStatement} */ (this.startNode());
+						const assign_node = /** @type {AST.AssignmentExpression} */ (this.startNode());
+						this.next(); // consume &
+						// Parse the left-hand side (array or object expression)
+						const left = /** @type {AST.ArrayPattern | AST.ObjectPattern} */ (
+							/** @type {unknown} */ (this.parseExprAtom())
+						);
+						// Convert expression to destructuring pattern
+						this.toAssignable(left, false);
+						left.lazy = true;
+						// Expect = operator
+						this.expect(tt.eq);
+						// Parse the right-hand side
+						assign_node.operator = '=';
+						assign_node.left = left;
+						assign_node.right = /** @type {AST.Expression} */ (this.parseMaybeAssign());
+						node.expression = /** @type {AST.AssignmentExpression} */ (
+							this.finishNode(assign_node, 'AssignmentExpression')
+						);
+						this.semicolon();
+						return /** @type {AST.ExpressionStatement} */ (
+							this.finishNode(node, 'ExpressionStatement')
+						);
+					}
+				}
+
 				return super.parseStatement(context, topLevel, exports);
 			}
 
@@ -2809,15 +2658,9 @@ function get_comment_handlers(source, comments, index = 0) {
 								isSwitchCaseSibling = true;
 							} else if (parent.type === 'SwitchCase') {
 								node_array = parent.consequent;
-							} else if (
-								parent.type === 'ArrayExpression' ||
-								parent.type === 'RippleArrayExpression'
-							) {
+							} else if (parent.type === 'ArrayExpression') {
 								node_array = parent.elements;
-							} else if (
-								parent.type === 'ObjectExpression' ||
-								parent.type === 'RippleObjectExpression'
-							) {
+							} else if (parent.type === 'ObjectExpression') {
 								node_array = parent.properties;
 							} else if (
 								parent.type === 'FunctionDeclaration' ||