ripple-binary-codec 2.8.0-smartcontract.0 → 2.9.0-batch.1

package/src/serdes/binary-serializer.ts

@@ -99,7 +99,7 @@ class BinarySerializer {
    *
    * @param length the length of the bytes
    */
-  static encodeVariableLength(length: number): Uint8Array {
+  private encodeVariableLength(length: number): Uint8Array {
     const lenBytes = new Uint8Array(3)
     if (length <= 192) {
       lenBytes[0] = length
@@ -158,7 +158,7 @@ class BinarySerializer {
       // this part doesn't happen for the Account field in a UNLModify transaction
       value.toBytesSink(bytes)
     }
-    this.put(BinarySerializer.encodeVariableLength(bytes.getLength()))
+    this.put(this.encodeVariableLength(bytes.getLength()))
     this.writeBytesList(bytes)
   }
 }

package/src/types/account-id.ts

@@ -6,7 +6,6 @@ import {
 } from 'ripple-address-codec'
 import { Hash160 } from './hash-160'
 import { hexToBytes } from '@xrplf/isomorphic/utils'
-import { SerializedTypeID } from './serialized-type'
 
 const HEX_REGEX = /^[A-F0-9]{40}$/
 
@@ -82,10 +81,6 @@ class AccountID extends Hash160 {
   toBase58(): string {
     return encodeAccountID(this.bytes)
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_ACCOUNT
-  }
 }
 
 export { AccountID }

package/src/types/amount.ts

@@ -2,7 +2,7 @@ import { BinaryParser } from '../serdes/binary-parser'
 
 import { AccountID } from './account-id'
 import { Currency } from './currency'
-import { JsonObject, SerializedType, SerializedTypeID } from './serialized-type'
+import { JsonObject, SerializedType } from './serialized-type'
 import BigNumber from 'bignumber.js'
 import { bytesToHex, concat, hexToBytes } from '@xrplf/isomorphic/utils'
 import { readUInt32BE, writeUInt32BE } from '../utils'
@@ -372,10 +372,6 @@ class Amount extends SerializedType {
   private isIOU(): boolean {
     return (this.bytes[0] & 0x80) !== 0
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_AMOUNT
-  }
 }
 
 export { Amount, AmountObject }

package/src/types/blob.ts

@@ -1,4 +1,4 @@
-import { SerializedType, SerializedTypeID } from './serialized-type'
+import { SerializedType } from './serialized-type'
 import { BinaryParser } from '../serdes/binary-parser'
 import { hexToBytes } from '@xrplf/isomorphic/utils'
 
@@ -41,10 +41,6 @@ class Blob extends SerializedType {
 
     throw new Error('Cannot construct Blob from value given')
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_VL
-  }
 }
 
 export { Blob }

package/src/types/currency.ts

@@ -1,6 +1,5 @@
 import { Hash160 } from './hash-160'
 import { bytesToHex, hexToBytes, hexToString } from '@xrplf/isomorphic/utils'
-import { SerializedTypeID } from './serialized-type'
 
 const XRP_HEX_REGEX = /^0{40}$/
 const ISO_REGEX = /^[A-Z0-9a-z?!@#$%^&*(){}[\]|]{3}$/
@@ -136,10 +135,6 @@ class Currency extends Hash160 {
     }
     return bytesToHex(this.bytes)
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_CURRENCY
-  }
 }
 
 export { Currency }

package/src/types/hash-128.ts

@@ -1,6 +1,5 @@
 import { Hash } from './hash'
 import { bytesToHex } from '@xrplf/isomorphic/utils'
-import { SerializedTypeID } from './serialized-type'
 
 /**
  * Hash with a width of 128 bits
@@ -29,10 +28,6 @@ class Hash128 extends Hash {
     }
     return hex
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_UINT128
-  }
 }
 
 export { Hash128 }

package/src/types/hash-160.ts

@@ -1,5 +1,4 @@
 import { Hash } from './hash'
-import { SerializedTypeID } from './serialized-type'
 
 /**
  * Hash with a width of 160 bits
@@ -15,10 +14,6 @@ class Hash160 extends Hash {
 
     super(bytes ?? Hash160.ZERO_160.bytes)
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_UINT160
-  }
 }
 
 export { Hash160 }

package/src/types/hash-192.ts

@@ -1,5 +1,4 @@
 import { Hash } from './hash'
-import { SerializedTypeID } from './serialized-type'
 
 /**
  * Hash with a width of 192 bits
@@ -15,10 +14,6 @@ class Hash192 extends Hash {
 
     super(bytes ?? Hash192.ZERO_192.bytes)
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_UINT192
-  }
 }
 
 export { Hash192 }

package/src/types/hash-256.ts

@@ -1,5 +1,4 @@
 import { Hash } from './hash'
-import { SerializedTypeID } from './serialized-type'
 
 /**
  * Hash with a width of 256 bits
@@ -11,10 +10,6 @@ class Hash256 extends Hash {
   constructor(bytes: Uint8Array) {
     super(bytes ?? Hash256.ZERO_256.bytes)
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_UINT256
-  }
 }
 
 export { Hash256 }

package/src/types/index.ts

@@ -2,8 +2,6 @@ import { AccountID } from './account-id'
 import { Amount } from './amount'
 import { Blob } from './blob'
 import { Currency } from './currency'
-import { Data } from './data'
-import { DataType } from './dataType'
 import { Hash128 } from './hash-128'
 import { Hash160 } from './hash-160'
 import { Hash192 } from './hash-192'
@@ -28,8 +26,6 @@ const coreTypes: Record<string, typeof SerializedType> = {
   Amount,
   Blob,
   Currency,
-  Data,
-  DataType,
   Hash128,
   Hash160,
   Hash192,
@@ -59,8 +55,6 @@ export {
   Amount,
   Blob,
   Currency,
-  Data,
-  DataType,
   Hash128,
   Hash160,
   Hash192,

package/src/types/issue.ts

@@ -3,7 +3,7 @@ import { BinaryParser } from '../serdes/binary-parser'
 
 import { AccountID } from './account-id'
 import { Currency } from './currency'
-import { JsonObject, SerializedType, SerializedTypeID } from './serialized-type'
+import { JsonObject, SerializedType } from './serialized-type'
 import { Hash192 } from './hash-192'
 import { readUInt32BE, writeUInt32BE } from '../utils'
 
@@ -158,10 +158,6 @@ class Issue extends SerializedType {
       issuer: issuer.toJSON(),
     }
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_ISSUE
-  }
 }
 
 export { Issue, IssueObject }

package/src/types/path-set.ts

@@ -1,7 +1,7 @@
 import { AccountID } from './account-id'
 import { Currency } from './currency'
 import { BinaryParser } from '../serdes/binary-parser'
-import { SerializedType, JsonObject, SerializedTypeID } from './serialized-type'
+import { SerializedType, JsonObject } from './serialized-type'
 import { bytesToHex, concat } from '@xrplf/isomorphic/utils'
 
 /**
@@ -285,10 +285,6 @@ class PathSet extends SerializedType {
 
     return json
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_PATHSET
-  }
 }
 
 export { PathSet }

package/src/types/serialized-type.ts

@@ -2,69 +2,6 @@ import { BytesList } from '../serdes/binary-serializer'
 import { BinaryParser } from '../serdes/binary-parser'
 import { XrplDefinitionsBase } from '../enums'
 import { bytesToHex } from '@xrplf/isomorphic/utils'
-import definitions from '../enums/definitions.json'
-
-/**
- * Enum for SerializedTypeID values used in XRPL
- * These match the C++ implementation's STI_ constants
- */
-export enum SerializedTypeID {
-  STI_NOTPRESENT = 0,
-  STI_UINT16 = 1,
-  STI_UINT32 = 2,
-  STI_UINT64 = 3,
-  STI_UINT128 = 4,
-  STI_UINT256 = 5,
-  STI_AMOUNT = 6,
-  STI_VL = 7,
-  STI_ACCOUNT = 8,
-  STI_NUMBER = 9,
-  STI_INT32 = 10,
-  STI_INT64 = 11,
-
-  STI_OBJECT = 14,
-  STI_ARRAY = 15,
-
-  STI_UINT8 = 16,
-  STI_UINT160 = 17,
-  STI_PATHSET = 18,
-  STI_VECTOR256 = 19,
-  STI_UINT96 = 20,
-  STI_UINT192 = 21,
-  STI_UINT384 = 22,
-  STI_UINT512 = 23,
-  STI_ISSUE = 24,
-  STI_XCHAIN_BRIDGE = 25,
-  STI_CURRENCY = 26,
-  STI_DATA = 27,
-  STI_DATATYPE = 28,
-  STI_JSON = 29,
-}
-
-/**
- * Maps built dynamically from definitions.json TYPES.
- * This ensures type string names (e.g. "Hash256", "Hash128") stay in sync
- * with the canonical definitions rather than using hardcoded uppercase variants.
- */
-
-// Map of type name strings to SerializedTypeID values
-export const TYPE_STRING_TO_ID: Record<string, SerializedTypeID> = {}
-
-// Map of numeric type codes to SerializedTypeID values
-export const TYPE_NUMBER_TO_ID: Record<number, SerializedTypeID> = {}
-
-// Map of SerializedTypeID values to type name strings
-export const TYPE_ID_TO_STRING: Record<number, string> = {}
-
-// Populate all three maps from definitions.json TYPES
-for (const [name, id] of Object.entries(definitions.TYPES)) {
-  if (id >= 0) {
-    const typeId = id as SerializedTypeID
-    TYPE_STRING_TO_ID[name] = typeId
-    TYPE_NUMBER_TO_ID[id] = typeId
-    TYPE_ID_TO_STRING[typeId] = name
-  }
-}
 
 type JSON = string | number | boolean | null | undefined | JSON[] | JsonObject
 
@@ -140,10 +77,6 @@ class SerializedType {
   toString(): string {
     return this.toHex()
   }
-
-  getSType(): SerializedTypeID {
-    return this.getSType()
-  }
 }
 
 /**

package/src/types/st-array.ts

@@ -1,5 +1,5 @@
 import { DEFAULT_DEFINITIONS, XrplDefinitionsBase } from '../enums'
-import { SerializedType, JsonObject, SerializedTypeID } from './serialized-type'
+import { SerializedType, JsonObject } from './serialized-type'
 import { STObject } from './st-object'
 import { BinaryParser } from '../serdes/binary-parser'
 import { concat } from '@xrplf/isomorphic/utils'
@@ -108,10 +108,6 @@ class STArray extends SerializedType {
 
     return result
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_ARRAY
-  }
 }
 
 export { STArray }

package/src/types/st-number.ts

@@ -1,6 +1,6 @@
 /* eslint-disable complexity -- required for various checks */
 import { BinaryParser } from '../serdes/binary-parser'
-import { SerializedType, SerializedTypeID } from './serialized-type'
+import { SerializedType } from './serialized-type'
 import { writeInt32BE, writeInt64BE, readInt32BE, readInt64BE } from '../utils'
 
 /**
@@ -307,8 +307,4 @@ export class STNumber extends SerializedType {
       fractionPart ? '.' + fractionPart : ''
     }`
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_NUMBER
-  }
 }

package/src/types/st-object.ts

@@ -4,7 +4,7 @@ import {
   Bytes,
   XrplDefinitionsBase,
 } from '../enums'
-import { SerializedType, JsonObject, SerializedTypeID } from './serialized-type'
+import { SerializedType, JsonObject } from './serialized-type'
 import { xAddressToClassicAddress, isValidXAddress } from 'ripple-address-codec'
 import { BinaryParser } from '../serdes/binary-parser'
 import { BinarySerializer, BytesList } from '../serdes/binary-serializer'
@@ -151,13 +151,7 @@ class STObject extends SerializedType {
             ? STArray.from(xAddressDecoded[field.name], definitions)
             : field.type.name === 'UInt64'
               ? UInt64.from(xAddressDecoded[field.name], field.name)
-              : field.associatedType?.from
-                ? field.associatedType.from(xAddressDecoded[field.name])
-                : (() => {
-                    throw new Error(
-                      `Type ${field.type.name} for field ${field.name} is missing associatedType.from`,
-                    )
-                  })()
+              : field.associatedType.from(xAddressDecoded[field.name])
 
       if (associatedValue == undefined) {
         throw new TypeError(
@@ -207,10 +201,6 @@ class STObject extends SerializedType {
 
     return accumulator
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_OBJECT
-  }
 }
 
 export { STObject }

package/src/types/uint-16.ts

@@ -1,7 +1,6 @@
 import { UInt } from './uint'
 import { BinaryParser } from '../serdes/binary-parser'
 import { readUInt16BE, writeUInt16BE } from '../utils'
-import { SerializedTypeID } from './serialized-type'
 
 /**
  * Derived UInt class for serializing/deserializing 16 bit UInt
@@ -49,10 +48,6 @@ class UInt16 extends UInt {
   valueOf(): number {
     return parseInt(readUInt16BE(this.bytes, 0))
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_UINT16
-  }
 }
 
 export { UInt16 }

package/src/types/uint-32.ts

@@ -1,7 +1,6 @@
 import { UInt } from './uint'
 import { BinaryParser } from '../serdes/binary-parser'
 import { readUInt32BE, writeUInt32BE } from '../utils'
-import { SerializedTypeID } from './serialized-type'
 
 /**
  * Derived UInt class for serializing/deserializing 32 bit UInt
@@ -55,10 +54,6 @@ class UInt32 extends UInt {
   valueOf(): number {
     return parseInt(readUInt32BE(this.bytes, 0), 10)
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_UINT32
-  }
 }
 
 export { UInt32 }

package/src/types/uint-64.ts

@@ -3,7 +3,6 @@ import { BinaryParser } from '../serdes/binary-parser'
 import { bytesToHex, concat, hexToBytes } from '@xrplf/isomorphic/utils'
 import { readUInt32BE, writeUInt32BE } from '../utils'
 import { DEFAULT_DEFINITIONS, XrplDefinitionsBase } from '../enums'
-import { SerializedTypeID } from './serialized-type'
 
 const HEX_REGEX = /^[a-fA-F0-9]{1,16}$/
 const BASE10_REGEX = /^[0-9]{1,20}$/
@@ -132,10 +131,6 @@ class UInt64 extends UInt {
   toBytes(): Uint8Array {
     return this.bytes
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_UINT64
-  }
 }
 
 export { UInt64 }

package/src/types/uint-8.ts

@@ -2,7 +2,6 @@ import { UInt } from './uint'
 import { BinaryParser } from '../serdes/binary-parser'
 import { bytesToHex } from '@xrplf/isomorphic/utils'
 import { writeUInt8 } from '../utils'
-import { SerializedTypeID } from './serialized-type'
 
 /**
  * Derived UInt class for serializing/deserializing 8 bit UInt
@@ -48,10 +47,6 @@ class UInt8 extends UInt {
   valueOf(): number {
     return parseInt(bytesToHex(this.bytes), 16)
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_UINT8
-  }
 }
 
 export { UInt8 }

package/src/types/vector-256.ts

@@ -1,4 +1,4 @@
-import { SerializedType, SerializedTypeID } from './serialized-type'
+import { SerializedType } from './serialized-type'
 import { BinaryParser } from '../serdes/binary-parser'
 import { Hash256 } from './hash-256'
 import { BytesList } from '../serdes/binary-serializer'
@@ -74,10 +74,6 @@ class Vector256 extends SerializedType {
     }
     return result
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_VECTOR256
-  }
 }
 
 export { Vector256 }

package/src/types/xchain-bridge.ts

@@ -1,7 +1,7 @@
 import { BinaryParser } from '../serdes/binary-parser'
 
 import { AccountID } from './account-id'
-import { JsonObject, SerializedType, SerializedTypeID } from './serialized-type'
+import { JsonObject, SerializedType } from './serialized-type'
 import { Issue, IssueObject } from './issue'
 import { concat } from '@xrplf/isomorphic/utils'
 
@@ -123,10 +123,6 @@ class XChainBridge extends SerializedType {
     })
     return json as XChainBridgeObject
   }
-
-  getSType(): SerializedTypeID {
-    return SerializedTypeID.STI_XCHAIN_BRIDGE
-  }
 }
 
 export { XChainBridge, XChainBridgeObject }

package/dist/src/types/data.d.ts

@@ -1,86 +0,0 @@
-import { BinaryParser } from '../serdes/binary-parser';
-import { JsonObject, SerializedType, SerializedTypeID } from './serialized-type';
-/**
- * Interface for Data JSON representation
- */
-interface DataJSON extends JsonObject {
-    type: string;
-    value: string | number | JsonObject;
-}
-/**
- * STData: Encodes XRPL's "Data" type.
- *
- * This type wraps both a SerializedTypeID and the actual data value.
- * It's encoded as a 2-byte type ID followed by the serialized data.
- *
- * Usage:
- *   Data.from({ type: "Amount", value: "1000000" })
- *   Data.from({ type: "UInt64", value: "123456789" })
- *   Data.fromParser(parser)
- */
-declare class Data extends SerializedType {
-    static readonly ZERO_DATA: Data;
-    /**
-     * Construct Data from bytes
-     * @param bytes - Uint8Array containing type ID and data
-     */
-    constructor(bytes: Uint8Array);
-    /**
-     * Create Data from various input types
-     *
-     * @param value - Can be:
-     *   - Data instance (returns as-is)
-     *   - DataJSON object with 'type' and 'value' fields
-     * @returns Data instance
-     * @throws Error if value type is not supported
-     */
-    static from(value: unknown): Data;
-    /**
-     * Create Data from JSON representation
-     *
-     * @param json - Object with 'type' and 'value' fields
-     * @returns Data instance
-     * @throws Error if type is not supported
-     */
-    static fromJSON(json: DataJSON): Data;
-    /**
-     * Read Data from a BinaryParser stream
-     *
-     * @param parser - BinaryParser positioned at the start of Data
-     * @returns Data instance
-     */
-    static fromParser(parser: BinaryParser): Data;
-    /**
-     * Get the inner SerializedTypeID
-     *
-     * @returns The inner type ID
-     */
-    getInnerType(): SerializedTypeID;
-    /**
-     * Get the string representation of the inner type
-     *
-     * @returns String name of the type
-     */
-    getInnerTypeString(): string;
-    /**
-     * Get the data value
-     *
-     * @returns The stored data value
-     */
-    getValue(): SerializedType;
-    /**
-     * Convert to JSON representation
-     *
-     * @returns JSON object with 'type' and 'value' fields
-     */
-    toJSON(): DataJSON;
-    /**
-     * Compare with another Data for equality
-     *
-     * @param other - Another Data to compare with
-     * @returns true if both have the same inner type and data
-     */
-    equals(other: Data): boolean;
-    getSType(): SerializedTypeID;
-}
-export { Data };