ripple-binary-codec 2.7.0 → 2.8.0

package/src/quality.ts

@@ -13,8 +13,13 @@ class quality {
    * @returns Serialized quality
    */
   static encode(quality: string): Uint8Array {
-    const decimal = BigNumber(quality)
-    const exponent = (decimal?.e || 0) - 15
+    let decimal: BigNumber
+    try {
+      decimal = new BigNumber(quality)
+    } catch (_err) {
+      throw new Error(`${quality} is not a valid quality`)
+    }
+    const exponent = (decimal.e || 0) - 15
     const qualityString = decimal.times(`1e${-exponent}`).abs().toString()
     const bytes = coreTypes.UInt64.from(BigInt(qualityString)).toBytes()
     bytes[0] = exponent + 100
@@ -30,7 +35,12 @@ class quality {
   static decode(quality: string): BigNumber {
     const bytes = hexToBytes(quality).slice(-8)
     const exponent = bytes[0] - 100
-    const mantissa = new BigNumber(`0x${bytesToHex(bytes.slice(1))}`)
+    let mantissa: BigNumber
+    try {
+      mantissa = new BigNumber(`0x${bytesToHex(bytes.slice(1))}`)
+    } catch (_err) {
+      throw new Error(`${quality} is not a valid quality`)
+    }
     return mantissa.times(`1e${exponent}`)
   }
 }

package/src/serdes/binary-parser.ts

@@ -46,8 +46,13 @@ class BinaryParser {
    * @param n the number of bytes to skip
    */
   skip(n: number): void {
+    if (n < 0) {
+      throw new Error(`skip: negative length ${n}`)
+    }
     if (n > this.bytes.byteLength) {
-      throw new Error()
+      throw new Error(
+        `skip: requested ${n} bytes but only ${this.bytes.byteLength} available`,
+      )
     }
     this.bytes = this.bytes.slice(n)
   }
@@ -59,8 +64,13 @@ class BinaryParser {
    * @return The bytes
    */
   read(n: number): Uint8Array {
+    if (n < 0) {
+      throw new Error(`read: negative length ${n}`)
+    }
     if (n > this.bytes.byteLength) {
-      throw new Error()
+      throw new Error(
+        `read: requested ${n} bytes but only ${this.bytes.byteLength} available`,
+      )
     }
 
     const slice = this.bytes.slice(0, n)

package/src/types/amount.ts

@@ -92,7 +92,7 @@ class Amount extends SerializedType {
       return value
     }
 
-    let amount = new Uint8Array(8)
+    let amount: Uint8Array = new Uint8Array(8)
     if (typeof value === 'string') {
       Amount.assertXrpIsValid(value)
 
@@ -110,7 +110,12 @@ class Amount extends SerializedType {
     }
 
     if (isAmountObjectIOU(value)) {
-      const number = new BigNumber(value.value)
+      let number: BigNumber
+      try {
+        number = new BigNumber(value.value)
+      } catch (_err) {
+        throw new Error(`${value.value} is an illegal amount`)
+      }
       Amount.assertIouIsValid(number)
 
       if (number.isZero()) {
@@ -189,7 +194,7 @@ class Amount extends SerializedType {
    */
   toJSON(): AmountObject | string {
     if (this.isNative()) {
-      const bytes = this.bytes
+      const bytes = this.bytes.slice()
       const isPositive = bytes[0] & 0x40
       const sign = isPositive ? '' : '-'
       bytes[0] &= 0x3f
@@ -261,7 +266,12 @@ class Amount extends SerializedType {
       throw new Error(`${amount.toString()} is an illegal amount`)
     }
 
-    const decimal = new BigNumber(amount)
+    let decimal: BigNumber
+    try {
+      decimal = new BigNumber(amount)
+    } catch (_err) {
+      throw new Error(`${amount.toString()} is an illegal amount`)
+    }
     if (!decimal.isZero()) {
       if (decimal.lt(MIN_XRP) || decimal.gt(MAX_DROPS)) {
         throw new Error(`${amount.toString()} is an illegal amount`)
@@ -301,7 +311,12 @@ class Amount extends SerializedType {
       throw new Error(`${amount.toString()} is an illegal amount`)
     }
 
-    const decimal = new BigNumber(amount)
+    let decimal: BigNumber
+    try {
+      decimal = new BigNumber(amount)
+    } catch (_err) {
+      throw new Error(`${amount.toString()} is an illegal amount`)
+    }
     if (!decimal.isZero()) {
       if (decimal < BigNumber(0)) {
         throw new Error(`${amount.toString()} is an illegal amount`)

package/src/types/uint-64.ts

@@ -51,7 +51,7 @@ class UInt64 extends UInt {
       return val
     }
 
-    let buf = new Uint8Array(UInt64.width)
+    let buf: Uint8Array = new Uint8Array(UInt64.width)
 
     if (typeof val === 'number' && Number.isInteger(val)) {
       if (val < 0) {

package/src/utils.ts

@@ -196,7 +196,7 @@ export function compare(a: TypedArray, b: TypedArray): 1 | -1 | 0 {
     throw new Error('Cannot compare arrays of different length')
   }
 
-  for (let i = 0; i < a.length - 1; i += 1) {
+  for (let i = 0; i < a.length; i += 1) {
     if (a[i] > b[i]) return 1
     if (a[i] < b[i]) return -1
   }