ripple-binary-codec 1.1.2 → 1.2.0-beta.1

package/test/hash.test.js

@@ -50,10 +50,10 @@ describe("Hash256", function () {
 });
 
 describe("Currency", function () {
-  test("Will have a null iso() for dodgy XRP ", function () {
-    const bad = Currency.from("0000000000000000000000005852500000000000");
-    expect(bad.iso()).toBeUndefined();
-    expect(bad.isNative()).toBe(false);
+  test("Will throw an error for dodgy XRP ", function () {
+    expect(() =>
+      Currency.from("0000000000000000000000005852500000000000")
+    ).toThrow();
   });
   test("Currency with lowercase letters decode to hex", () => {
     expect(Currency.from("xRp").toJSON()).toBe(
@@ -73,6 +73,10 @@ describe("Currency", function () {
     const xrp = new Currency(Buffer.alloc(20));
     expect(xrp.iso()).toBe("XRP");
   });
+  test("Can handle non-standard currency codes", () => {
+    const currency = "015841551A748AD2C1F76FF6ECB0CCCD00000000";
+    expect(Currency.from(currency).toJSON()).toBe(currency);
+  });
   test("throws on invalid reprs", function () {
     expect(() => Currency.from(Buffer.alloc(19))).toThrow();
     expect(() => Currency.from(1)).toThrow();

package/test/lower-case-hex.test.js

@@ -11,7 +11,8 @@ let json = {
   Account: "rUnFEsHjxqTswbivzL2DNHBb34rhAgZZZK",
   PreviousTxnLgrSeq: 8,
   LedgerEntryType: "AccountRoot",
-  PreviousTxnID: "0735A0B32B2A3F4C938B76D6933003E29447DB8C7CE382BBE089402FF12A03E5".toLowerCase(),
+  PreviousTxnID:
+    "0735A0B32B2A3F4C938B76D6933003E29447DB8C7CE382BBE089402FF12A03E5".toLowerCase(),
   Flags: 0,
   Sequence: 1,
   Balance: "10000000000",

package/test/uint.test.js

@@ -27,6 +27,77 @@ const json = {
   LowNode: "0",
 };
 
+const binaryEntry0 =
+  "11007222001100002501EC24873700000000000000003800000000000000A35506FC7DE374089D50F81AAE13E7BBF3D0E694769331E14F55351B38D0148018EA62D44BF89AC2A40B800000000000000000000000004A50590000000000000000000000000000000000000000000000000166D6C38D7EA4C680000000000000000000000000004A5059000000000047C1258B4B79774B28176324068F759EDE226F686780000000000000000000000000000000000000004A505900000000005BBC0F22F61D9224A110650CFE21CC0C4BE13098";
+const jsonEntry0 = {
+  Balance: {
+    currency: "JPY",
+    issuer: "rrrrrrrrrrrrrrrrrrrrBZbvji",
+    value: "0.3369568318",
+  },
+  Flags: 1114112,
+  HighLimit: {
+    currency: "JPY",
+    issuer: "r94s8px6kSw1uZ1MV98dhSRTvc6VMPoPcN",
+    value: "0",
+  },
+  HighNode: "a3",
+  LedgerEntryType: "RippleState",
+  LowLimit: {
+    currency: "JPY",
+    issuer: "rfYQMgj3g3Qp8VLoZNvvU35mEuuJC8nCmY",
+    value: "1000000000",
+  },
+  LowNode: "0",
+  PreviousTxnID:
+    "06FC7DE374089D50F81AAE13E7BBF3D0E694769331E14F55351B38D0148018EA",
+  PreviousTxnLgrSeq: 32253063,
+  index: "000319BAE0A618A7D3BB492F17E98E5D92EA0C6458AFEBED44206B5B4798A840",
+};
+
+const binaryEntry1 =
+  "1100642200000000320000000000000002580CB3C1AD2C371136AEA434246D971C5FCCD32CBF520667E131AB7B10D706E7528214BA53D10260FFCC968ACD16BA30F7CEABAD6E5D92011340A3454ACED87177146EABD5E4A256021D836D1E3617618B1EB362D10B0D1BAC6AE1ED9E8D280BBE0B6656748FD647231851C6C650794D5E6852DFA1E35E68630F";
+const jsonEntry1 = {
+  Flags: 0,
+  IndexPrevious: "2",
+  Indexes: [
+    "A3454ACED87177146EABD5E4A256021D836D1E3617618B1EB362D10B0D1BAC6A",
+    "E1ED9E8D280BBE0B6656748FD647231851C6C650794D5E6852DFA1E35E68630F",
+  ],
+  LedgerEntryType: "DirectoryNode",
+  Owner: "rHzDaMNybxQppiE3uWyt2N265KvAKdiRdP",
+  RootIndex: "0CB3C1AD2C371136AEA434246D971C5FCCD32CBF520667E131AB7B10D706E752",
+  index: "0B4A2E68C111F7E42FAEEE405F7344560C8240840B151D9D04131EB79D080167",
+};
+
+const binaryEntry2 =
+  "1100722200210000250178D1CA37000000000000000038000000000000028355C0C37CE200B509E0A529880634F7841A9EF4CB65F03C12E6004CFAD9718D66946280000000000000000000000000000000000000004743420000000000000000000000000000000000000000000000000166D6071AFD498D000000000000000000000000000047434200000000002599D1D255BCA61189CA64C84528F2FCBE4BFC3867800000000000000000000000000000000000000047434200000000006EEBB1D1852CE667876A0B3630861FB6C6AB358E";
+const jsonEntry2 = {
+  Balance: {
+    currency: "GCB",
+    issuer: "rrrrrrrrrrrrrrrrrrrrBZbvji",
+    value: "0",
+  },
+  Flags: 2162688,
+  HighLimit: {
+    currency: "GCB",
+    issuer: "rBfVgTnsdh8ckC19RM8aVGNuMZnpwrMP6n",
+    value: "0",
+  },
+  HighNode: "283",
+  LedgerEntryType: "RippleState",
+  LowLimit: {
+    currency: "GCB",
+    issuer: "rhRFGCy2RJTA8oxkjjtYTvofPVGqcgvXWj",
+    value: "2000000",
+  },
+  LowNode: "0",
+  PreviousTxnID:
+    "C0C37CE200B509E0A529880634F7841A9EF4CB65F03C12E6004CFAD9718D6694",
+  PreviousTxnLgrSeq: 24695242,
+  index: "0000041EFD027808D3F78C8352F97E324CB816318E00B977C74ECDDC7CD975B2",
+};
+
 test("compareToTests[0]", () => {
   expect(UInt8.from(124).compareTo(UInt64.from(124))).toBe(0);
 });
@@ -64,6 +135,12 @@ test("UInt64 from string zero", () => {
   expect(encode(json)).toEqual(binary);
 });
 
+test("UInt64 from non 16 length hex", () => {
+  expect(encode(jsonEntry0)).toEqual(binaryEntry0);
+  expect(encode(jsonEntry1)).toEqual(binaryEntry1);
+  expect(encode(jsonEntry2)).toEqual(binaryEntry2);
+});
+
 test("valueOfTests", () => {
   let val = UInt8.from(1);
   val |= 0x2;

package/HISTORY.md

@@ -1,86 +0,0 @@
-# ripple-binary-codec Release History
-
-## 1.1.2 (2021-03-10)
-- Fix for case UInt64.from string '0' due to changes in rippled 1.7.0
-
-## 1.1.1 (2021-02-12)
-- PathSet.toJSON() does not return undefined values
-- Add support for X-Addresses in Issued Currency Amounts
-- Fix STArray error message
-
-## 1.1.0 (2020-12-03)
-- Add support for Tickets (TicketBatch amendment)
-- Fix web browser compatibility
-
-## 1.0.2 (2020-09-11)
-- Allow currencies to be encoded from any 3 character ASCII code
-
-## 1.0.1 (2020-09-08)
-- Filter out fields with undefined values
-
-## 1.0.0 (2020-08-17)
-
-- Migrate to TypeScript
-  - Javascript classes used
-  - Generics for constructing core types
-- Reduced dependencies
-  - Dependent on create-hash, decimal.js, ripple-address-codec
-- Migrate testing to Jest and added tests
-  - Tests for pseudo-transactions
-- Added support for NegativeUNL pseudo-transactions
-
-## 0.2.6 (2019-12-31)
-
-- Update dependencies
-  - decimal.js, fs-extra, mocha, handlebars, bn.js, babel-eslint, ripple-address-codec
-
-## 0.2.5 (2019-12-14)
-
-- Add support for AccountDelete (#37)
-
-## 0.2.4 (2019-09-04)
-
-- Update ripple-address-codec to 3.0.4
-
-## 0.2.3 (2019-08-29)
-
-- Expand node version compatibility (#32, #33)
-
-## 0.2.2 (2019-07-26)
-
-- Input validation - Amount and Fee should not allow fractional XRP drops ([#31](https://github.com/ripple/ripple-binary-codec/issues/31))
-- Fix lint errors
-- Update dependencies (including lodash and mocha)
-- Require node 10 (.nvmrc)
-- Remove assert-diff
-- Remove codecov.io as it did not appear to work. The `package.json` script was:
-  - `"codecov": "cat ./coverage/coverage.json | ./node_modules/codecov.io/bin/codecov.io.js"`
-
-## 0.2.1
-
-- Add tecKILLED from amendment fix1578 (PR #27 fixes #25)
-
-## 0.2.0
-
-- Add DepositPreauth fields
-  - https://developers.ripple.com/depositauth.html
-
-## 0.1.14
-
-- Skip amount validation when deserializing f72c115
-
-## 0.1.13
-
-- Add Check, CheckCreate, CheckCash, CheckCancel
-
-## 0.1.11
-
-- Add ledger header decode function
-
-## 0.1.8
-
-## 0.1.7
-
-## 0.1.6
-
-## 0.1.3