rig-review 4.11.0 → 4.12.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/docs/DESIGN.md CHANGED
@@ -4,7 +4,7 @@
4
4
 
5
5
  The delivery unit is an existing output folder or an optional curated review package handed from an agent to a person. This reusable app owns inspection, reference comparison, annotations and feedback export. Upstream compiler, splitter and runtime remain their respective tools. The existing producing agent needs no change to open its output here.
6
6
 
7
- The person uses the existing inspection workspace. The header **Setup · Animate · Compare** is the sole mode switch (#741); the resizable bottom panel shows the current mode's blocks, the top **Comment · C** button opens the bottom Comments panel and pin capture without a bottom Comments tab (#835), and live-job act controls sit in the shared act row (`#workspace-act-row`) directly beneath the top bar (#845; standalone package inspection keeps the act bar in the bottom heading). Parts packages use this same screen (#745). Header Compare retains its existing A/B comparison with a reference, enabled when a second build is supplied; its View, Rig, Playback and Feedback sections remain unchanged. Card D is **PARKED**, not planned. Setup already offers Difference as the fourth view item for parts (#745) and rig (#752). Setup covers setup geometry, source art, pivot/joint placement, meshes, weights and draw order; Animate covers angle coverage, frame intervals, reference video/poses, contact/deformation, audio inspection and the inspection environment (wind, gravity and impulses through the published player's `environment`/`moved`; its state is feedback context, never a model or motion edit) and the physics tuning panel (#103: constraint values edited as config patch ops and applied through the producer, never written into the model by review), and the readings block (#108: the compiler's own `rigc render` readings of the drawn animation, run on the inspected build and on the latest scratch build, shown as timeline ticks and worst-frame lines), the Environment block's *Use for readings* (#112: the controls exported as a `rigc-environment/1` schedule that readings, Apply's check and *Check under this world* — the installed producer's `rig-parts check --environment` — read, so the bars and readings are taken under the wind the person watched; the schedule is feedback context and is never authored into the rig), and the requirements block (#113: the scene's declared requirements written as a `spine-parts-requirements/1` file and measured by the installed producer's `rig-parts check --requirements`, one worst-frame line each). Time/angle controls navigate inspection. Timeline edits are six typed keyed operations on a scratch copy of `motion.animations_from`, built by the installed producer; review never writes source motion. Implemented modeling instruments send bounded changes through the installed producer into scratch, including setup-space mesh deltas.
7
+ The person uses the existing inspection workspace. The header **Setup · Animate · Compare** is the sole mode switch (#741); the resizable bottom panel shows the current mode's blocks, the top **Comment · C** button opens the right communication panel at Comments and starts pin capture (#835, #1041), and act controls sit in the shared act row (`#workspace-act-row`) directly beneath the top bar (#845, #1040). Parts packages use this same screen (#745). Header Compare retains its existing A/B comparison with a reference, enabled when a second build is supplied; its View, Rig, Playback and Feedback sections remain unchanged. Card D is **PARKED**, not planned. Setup already offers Difference as the fourth view item for parts (#745) and rig (#752). Setup covers setup geometry, source art, pivot/joint placement, meshes, weights and draw order; Animate covers angle coverage, frame intervals, reference video/poses, contact/deformation, audio inspection and the inspection environment (wind, gravity and impulses through the published player's `environment`/`moved`; its state is feedback context, never a model or motion edit) and the physics tuning panel (#103: constraint values edited as config patch ops and applied through the producer, never written into the model by review), and the readings block (#108: the compiler's own `rigc render` readings of the drawn animation, run on the inspected build and on the latest scratch build, shown as timeline ticks and worst-frame lines), the Environment block's *Use for readings* (#112: the controls exported as a `rigc-environment/1` schedule that readings, Apply's check and *Check under this world* — the installed producer's `rig-parts check --environment` — read, so the bars and readings are taken under the wind the person watched; the schedule is feedback context and is never authored into the rig), and the requirements block (#113: the scene's declared requirements written as a `spine-parts-requirements/1` file and measured by the installed producer's `rig-parts check --requirements`, one worst-frame line each). Time/angle controls navigate inspection. Timeline edits are six typed keyed operations on a scratch copy of `motion.animations_from`, built by the installed producer; review never writes source motion. Implemented modeling instruments send bounded changes through the installed producer into scratch, including setup-space mesh deltas.
8
8
 
9
9
  ## Core UI rules (owner, 2026-11-11)
10
10
 
@@ -43,7 +43,8 @@ change adds no screen, behavior or public contract.
43
43
  Remove separate sidebar key-region checkpoint and evidence panels. Retain the
44
44
  supported checkpoint act flow through its existing contract.
45
45
  - **R3a** Any main view in rig, comparison, parts, job, interview or package review
46
- has a resizable bottom panel directly beneath it. Use one control set in this
46
+ has a resizable bottom panel directly beneath it for the controllers tied to
47
+ that view. Use one control set in this
47
48
  order: **Zoom in → Zoom out → Fit → 1:1 → View switch**, with the same names and
48
49
  behavior across views. Use the shared viewport implementation and extend it
49
50
  for missing behavior. Keep main-view code shared across screens.
@@ -52,8 +53,8 @@ change adds no screen, behavior or public contract.
52
53
  - **R5** `web/index.html` is the single web entry for every screen, including rig,
53
54
  comparison, parts, interview, package, job, hub and owner workspaces. Compose
54
55
  these screens from a shared workspace shell, main view (viewport and controls),
55
- resizable bottom and side panels, main and secondary toolbars, view switcher,
56
- inspector and comments components. Do not introduce a screen through a new
56
+ resizable bottom and side panels (the right one is the communication panel),
57
+ main and secondary toolbars, view switcher, inspector and comments components. Do not introduce a screen through a new
57
58
  HTML page or per-screen server route. Preserve existing public job, hub,
58
59
  language and capability URLs as redirects or routes into the single entry.
59
60
  The owner rules on the shared shell layout before implementation.
@@ -157,7 +158,9 @@ Any future modeling edit needs provenance, undo/redo, explicit units and an expo
157
158
 
158
159
  ## Workspace layout
159
160
 
160
- The single review page is one inspection workspace: a left column, the stage, the Inspector under the stage and one status footer. There is no right panel.
161
+ The single review page is one inspection workspace: a left column, the stage, the Inspector under the stage, the communication panel at the right and one status footer.
162
+
163
+ **Panel identity rule (#1041).** The bottom panel holds the controllers tied to the view. The right panel holds communication with the AI. Place any new element by this rule.
161
164
 
162
165
  - **Left column.** A fixed header row (Parts title and slot search on one line; the search's name, *Find slot*, is its `aria-label`) and one scrolling body. Nothing sits above the header and it never scrolls. The body holds the reference select, the part list and browser Settings; it is the column's only scroll container. Region coverage and Difference inspection stay in the main view under R3. Settings opens and closes from its own header (`#settings-toggle`, `aria-expanded`, controlling `#settings-body`); it starts collapsed and the state is a browser preference.
163
166
  - **Header.** **Setup · Animate · Compare** sits next to the package title and is the only mode switch (#741). Setup and Animate keep their existing `rig` / `playback` mode IDs. Compare is enabled with a second build and retains A/B with a reference; card D is parked. There is no second mode selector in the bottom panel. The pending ask is shown beside the act bar. **Historical:** numbered step chips and `stage-nav.ts` were removed; they must not be restored.
@@ -170,8 +173,9 @@ The single review page is one inspection workspace: a left column, the stage, th
170
173
  - **Rig fields.** In Setup, after Bones: `#rig-fields` (#110). The producer config's small fields as patch ops at their own pointers (`src/rig-fields.ts`, `web/rig-fields-panel.ts`): a rigid part's bone (`/regions/<part>`, a select), a lash's blink still row (`/motion/blink/still/<part>`, a dashed line across the part dragged in whole rig px), a stop's inward / outward bounds (`/stops/<i>`, two filled arcs at the pivot around a dashed rest aim, their ends dragged in whole degrees), an inherit mode per bone (`/bones/<i>/inherit`, a chain's `link_inherit`) and `turn`'s pivot and per-part depth (`/turn/pivot`, `/turn/depths/<part>`, sliders). Stage handles live in `#rig-fields-stage` over the rig viewport (tokens `--rv-field-still`, `-inward`, `-inward-line`, `-outward`, `-outward-line`, `-rest`, `-handle-bg`, `-ink`; the stage stays dark, so both blocks carry the same values). The turn dial holds the drawn build's `turn` bone at x through play's `adjust`, composed with the idle preview, and shows `#rig-fields-dial-label` (*preview — Apply decides*); it is never recorded. Apply is the generic runner's whole-rig `rig` op behind the reproduced baseline; the readout quotes `BLINK_NO_HOLE` and `FEET_STAY_LEVEL` before and after, and **Angle range** runs one #108 reading. Adding a stop and `turn.deform` are out of scope.
171
174
  - **Cloth.** In Setup, after Cuts: `#cloth-panel` (#111). One form per cloth tag the installed reader accepts (`bottomwear`, `back hair`, `front hair`, `handwear-r`, `handwear-l` — resolved from its `package.json` `exports["./cloth-targets.json"]`, schema `rig-parts/cloth-targets@1`, since `@rig-c/parts` 2.51.0, refused as `CLOTH_TARGETS_INVALID` when malformed or outside the package; when that export key is absent on an older producer, it falls back to the tags the config already declares with `read: false` and refuses adding a new tag as `CLOTH_TARGETS_UNAVAILABLE: the installed rig-parts <version> has no cloth-targets export (needs 2.51.0)`), holding the recipe's fields as the config states them; each change is a patch op at `/cloth/<tag>/…` (`src/cloth-recipe.ts`, `web/cloth-panel.ts`). **Show links** draws, in rig px of the setup pose, every chain the tag's parts are meshed on from the config's `points` and `tip`, and after an Apply the chains of the config the producer wrote (one label per set). Apply runs `rig-parts propose --cloth --write-config` on the declared parts, painting and keypoints, then builds the written config (`build` when the config declares `limbs`, else `rig --config`) and reloads it under the stage's Environment. Review never merges the producer's draft: it reads only the written config, lists where it differs from its input and refuses one that differs outside the drafted sections. Hand-editing the drafted constraints is the physics block's, after the draft.
172
175
  - **Mesh edit.** In Setup only, the view bar's **Edit mesh** toggle (`#mesh-edit`, `aria-pressed`) opens `#mesh-editor-bar`: sub-modes Modify / Create / Delete / Edges (keys `V` / `C` / `X` / `E`, one pressed), Undo, Redo, Reset, Download JSON and **Apply · Rebuild** (#135: `rig-parts remesh --delta` through the shared runner, the revision loaded in place, the producer's refusal verbatim; while a delta revision is on the stage Reset returns to the inspected build). A package without the compiled model document refuses `MESH_EDIT_MODEL_UNAVAILABLE` and does not open; whole rig refuses `MESH_EDIT_SELECT_SLOT`; a non-mesh or linked-mesh slot `MESH_EDIT_NO_MESH <slot>`. It edits in setup space (#100): the attachment's stored provenance in the model document (`src/setup-mesh.ts`) and geometry from Play's public `readSetupMesh` (`web/setup-pose.ts`, shared with Weights) and drawn over the paused stage with the stage camera. It records a typed delta (`src/mesh-edit.ts`, `basis: "setup"`, the shape `rig-parts remesh --delta` reads) and previews it over the original triangulation on the overlay; Delete removes only constraint edges the delta added (the triangulation is the producer's); it is not a mesher and never retriangulates, writes the package or runs a producer. The chest editor and mesh edit are exclusive: turning one on turns the other off.
173
- - **Inspector.** The shared bottom panel sits directly under the main view, with saved height and a resizable separator. Header mode selects its content; its tab row remains reachable when content is collapsed (#741). Setup has Part · Modeling · Chest · Mesh · Weights · Bones · Fields · Cuts · Cloth; Animate has Transport · Sound · Environment · Physics · Idle tracks · Readings · Requirements · Retarget · Report and the existing timeline. The bottom tab row has no visible **Comments (n)** tab (#835): the top **Comment · C** button and `C` shortcut reveal the bottom Comments panel and start pin capture when supported, while live-job act controls sit in `#workspace-act-row` beneath the top bar (#845; standalone package inspection keeps the act bar in the bottom heading). Parts use Part and the Comments panel; rig-only blocks are disabled with a missing-rig reason. `mountRigInspector`, `bindInspectorBlocks` and `mountBottomPanel` reuse the existing blocks, preserve their state and keep one programmatic Comments selection/panel across modes. Block navigation does not apply or submit.
174
- - **Review dialog.** This label is historical for rig feedback: `mountRigInspector` moves its existing source context, comments, frame range, category, typed target, correction request, provenance, strip downloads and warnings into the bottom Comments panel (opened from the top **Comment · C** entry rather than a bottom **Comments (n)** tab, #835) and removes `#review-dialog`. The decision, submit and save state live in the act bar — in `#workspace-act-row` directly beneath the top bar on live jobs (#845), or in the bottom heading on standalone package screens. Record publications separately reuse existing checkpoint, signoff, reopen and interview forms in a native dialog over this same screen (#754), including an explicitly empty workspace when no picture is supplied. That hosting has shipped; remaining interview-modal work B (#722), record-modal memo-to-Comments work C (#715), and legacy job-window owner-surface removal (#756) have not.
176
+ - **Inspector.** The shared bottom panel sits directly under the main view, with saved height and a resizable separator. Header mode selects its content; its tab row remains reachable when content is collapsed (#741). Setup has Part · Modeling · Chest · Mesh · Weights · Bones · Fields · Cuts · Cloth; Animate has Transport · Sound · Environment · Physics · Idle tracks · Readings · Requirements · Retarget · Report and the existing timeline. The bottom tab row has no Comments or Question tab (#835, #1041): both live in the communication panel. Live-job act controls sit in `#workspace-act-row` beneath the top bar (#845; standalone package inspection keeps the act bar in the bottom heading). Parts use Part; rig-only blocks are disabled with a missing-rig reason. When no controller block is left (a record or interview job without a picture), the bottom panel collapses to nothing, heading and separator included, and the stage takes the height. `mountRigInspector`, `bindInspectorBlocks` and `mountBottomPanel` reuse the existing blocks and preserve their state. Block navigation does not apply or submit.
177
+ - **Communication panel.** The right panel (`#workspace-communication`, #1041) holds communication with the AI: the pending question (`#workspace-interview-answer`) on top, the record forms (`#job-record-asks`: checkpoint, signoff and plan approval, under **Checkpoint** or **Sign-off**) next, and Comments (`#inspector-feedback`) below, each under a one-line heading, with the comment rows above the provenance block. It is single-column by container query. Its width is the saved `communicationWidth` (280–640 px, default 360) with the shared width separator. It is laid out only while something is pending (a question, a record form or a comment) or after **Comment · C** or a pending ask opens it; otherwise the stage keeps the full width. Opening it never changes the bottom panel's state, and it lays the workspace out at once, before pin capture arms, so a pin placed right after `C` lands on the final stage. Below the stage minimum it becomes a right-side drawer that is non-modal while it holds a question.
178
+ - **Review dialog.** This label is historical for rig feedback: `mountRigInspector` moves its existing source context, comments, frame range, category, typed target, correction request, provenance, strip downloads and warnings into the Comments section of the communication panel (opened from the top **Comment · C** entry, #835, #1041) and removes `#review-dialog`. The decision, submit and save state live in the act bar — in `#workspace-act-row` directly beneath the top bar on live jobs (#845), or in the bottom heading on standalone package screens. Record publications separately reuse existing checkpoint, signoff, reopen and interview forms in a native dialog over this same screen (#754), including an explicitly empty workspace when no picture is supplied. That hosting has shipped; remaining interview-modal work B (#722), record-modal memo-to-Comments work C (#715), and legacy job-window owner-surface removal (#756) have not.
175
179
  - **Footer.** Message (truncated, full text as tooltip) on the left; player, effective layout, renderer, layers, idle, remote control and draft state in the middle; the numeric view region (behind **View region**) and the source hash on the right. The View region body is a `position:fixed` popover above the 40px footer, right-aligned, its width and height clamped to the viewport and its content scrolling inside, so the footer's clipping never hides it and opening it never scrolls the page.
176
180
 
177
181
  ### Status ownership
@@ -236,9 +240,9 @@ A future optimization operation sends explicit source-bound selection/bounds to
236
240
 
237
241
  Side and bottom panels have pointer and keyboard separators with separator semantics: orientation, the controlled panel, an accessible name and the actual reachable minimum/maximum/current pixels. Arrow keys act only when the separator itself has focus, so text-entry arrows are never intercepted. A drag holds pointer capture; cancel, lost capture, blur, Escape and disposal restore the previous desired size and release it.
238
242
 
239
- The allocator measures the layout rectangle minus stage chrome and keeps a 240×180 CSS-pixel stage minimum. It shrinks side panels proportionally toward their own minima; when the width still cannot hold them it turns the left, then the right column, and when the height cannot hold it the Inspector, into a native modal drawer opened from a trigger outside it. Effective sizes are computed from desired sizes and never written back; a separator inverts the allocator so a clamped pixel value is not saved as the desktop desire.
243
+ The allocator measures the layout rectangle minus stage chrome and keeps a 240×180 CSS-pixel stage minimum. It shrinks side panels proportionally toward their own minima; when the width still cannot hold them it turns the left, then the right column, and when the height cannot hold it the Inspector, into a native drawer opened from a trigger outside it (modal, except the communication panel while it holds a question). Showing or hiding a region above the stage (the chest editor bar) lays the workspace out before the next frame, so the stage is never drawn under its minimum with a stale allocation (#1035). Effective sizes are computed from desired sizes and never written back; a separator inverts the allocator so a clamped pixel value is not saved as the desktop desire.
240
244
 
241
- Browser defaults live in one closed, versioned record: theme, default camera sync, default idle repeat, whether Settings is collapsed (`settingsCollapsed`, default `true`) and the three desired panel sizes. A record saved before `settingsCollapsed` existed carries neither the value nor its stamp and loads as collapsed at stamp revision 0; the schema name is unchanged. The saved `rightWidth` is the Parts explorer's width wherever the page shows it, so the review page's left parts column keeps the width chosen before the move; `leftWidth` is the compare page's sources column. Each field carries a logical stamp, so stale whole-record writes from other tabs converge per field without wall-clock ordering; an equal-stamp disagreement quarantines only that field until an explicit edit repairs it. Denied, unavailable or corrupt storage falls back to in-page defaults. The legacy same-origin appearance key migrates once, only when no new record exists. Reset layout changes geometry only.
245
+ Browser defaults live in one closed, versioned record: theme, default camera sync, default idle repeat, whether Settings is collapsed (`settingsCollapsed`, default `true`) and the desired panel sizes. `communicationWidth` was added in #1041: a record saved before it (4.10.0 and earlier) loads with the default width at stamp revision 0. The bottom panel's default height is 240px since #1040 moved the act bar out of its heading; an unstamped earlier default (280, 350, 120 or 262) upgrades to it, and a height the person resized (stamped) is kept. A record saved before `settingsCollapsed` existed carries neither the value nor its stamp and loads as collapsed at stamp revision 0; the schema name is unchanged. The saved `rightWidth` is the Parts explorer's width wherever the page shows it, so the review page's left parts column keeps the width chosen before the move; `leftWidth` is the compare page's sources column. Each field carries a logical stamp, so stale whole-record writes from other tabs converge per field without wall-clock ordering; an equal-stamp disagreement quarantines only that field until an explicit edit repairs it. Denied, unavailable or corrupt storage falls back to in-page defaults. The legacy same-origin appearance key migrates once, only when no new record exists. Reset layout changes geometry only.
242
246
 
243
247
  Content state stays source-bound. Each Inspector section's x/y scroll offset is captured before its panel hides and restored after it shows, after two frames of layout, and again when its content extent changes. Restoring clamps to the current extent without replacing the remembered offset, and intentional user scrolling supersedes a pending restore. Offsets are kept in the source draft's UI state, never in the global record or a copied view link.
244
248
 
@@ -315,8 +319,8 @@ beside the act bar. Selecting a mode never applies, approves or submits.
315
319
 
316
320
  The standing Review window hosts published subjects on the existing inspection
317
321
  screen. Rig and parts use its shared viewport and bottom panel. Record
318
- checkpoint, signoff and interview asks use existing forms in a dialog
319
- (#754). A record without a picture keeps that absence explicit; it does not
322
+ checkpoint, signoff and interview asks use existing forms in the right
323
+ communication panel (#754, #1041). A record without a picture keeps that absence explicit; it does not
320
324
  manufacture a model or package. Remaining B (#722), C (#715), F (#734) and #756
321
325
  work is tracked in [the screen specification](https://github.com/rig-c/review/blob/main/docs/SCREENS.md#4-migration-order).
322
326
 
@@ -1140,7 +1140,7 @@ or establish official Create writer acceptance.
1140
1140
  ### Act kinds, plan identity and parts identity
1141
1141
 
1142
1142
  - **Five enabled kinds and two reserved disabled kinds.** `JOB_ENABLED_ACT_KINDS` enables `'interview-picks'`, `'checkpoint'`, `'parts-verdict'`, `'review-verdict'` and `'signoff'`. `JOB_RESERVED_ACT_KINDS` reserves `'described-correction'` and `'mesh-edit'`. Asks and standalone acts of either kind refuse `JOB_ACT_KIND_DISABLED`. `described-correction` awaits the joint [Create #182](https://github.com/rig-c/create/issues/182) context allowlist. The jointly signed mesh value rides on the rig-review verdict under [Mesh edits on Request changes (act@8)](#mesh-edits-on-request-changes-act8).
1143
- - **`interview-picks`.** `JobActValues['interview-picks']` carries `questionId`, ordered `selections` (`itemId`, `optionId`, nullable `otherText`) and `note`, with non-null `source.optionSet` (`id` and `sha256`).
1143
+ - **`interview-picks`.** `JobActValues['interview-picks']` carries `questionId`, ordered `selections` (`itemId`, `optionId`, nullable `otherText`) and `note`, with non-null `source.optionSet` (`id` and `sha256`). A record act (`rig-review/act@4`) may add an optional last key `words`, the reviewer's comments as the `projectComments` output, exactly as checkpoint and signoff carry them ([Review #1048](https://github.com/rig-c/review/issues/1048)). It is present only when comments exist, so an act without comments keeps its earlier bytes; it is checked like checkpoint and signoff `words` (a string of at most 10,000 characters) and any other extra key still refuses `JOB_ACT_INVALID`.
1144
1144
  - **`checkpoint`.** `JobActValues['checkpoint']` carries `checkpointId`, `planStepId`, `outcome` restricted to `'pass'` or `'fail'` and required `words` as a `string`. `pending` stays in the UI draft only and never produces a finalized act. Only `'pass'` is eligible for Create's checkpoint sign-off writer, whereas `'fail'` is feedback or a named consumer refusal and never an approval write. `words` is preserved verbatim including empty or whitespace-only strings, matching Create's writer without adding a UI gate. In `JobSubject`, `checkpointId` defaults to the Create plan step ID and optional `planStepId` is required when the displayed Review checkpoint ID differs, matching [Create #184](https://github.com/rig-c/create/issues/184) without alias inference or browser trust. The browser supplies `checkpointId`, `outcome` and `words` only (`JobUIActValues['checkpoint']`), the daemon copies resolved `planStepId` from the validated ask and requires `source.plan`, and Create derives execution stage from its authoritative step phase and order without Review stamping a stage.
1145
1145
  - **`parts-verdict`.** `JobActValues['parts-verdict']` is `PartsVerdictValue` (`verdict` as `'approved'` or `'changes-requested'`, `issues` as `readonly PartsIssue[]` under `rig-review-parts-comment/2` — empty on `'approved'` and non-empty on `'changes-requested'`, bound to `source.sourceHash`, retained `partIds`, and `source.parts.images` hashes — and `words`), emitted in new finalized `rig-review/act@5` acts (`JobPartsVerdictAct`) and requiring non-null `source.projectHash`, a `draft` selector and `source.parts`. Historical `rig-review/act@2` `parts-verdict` acts remain in the `JobAct` union via `JobLegacyAct` with `value: JobLegacyPartsVerdictValue` (`verdict` as `'pending'`, `'approved'` or `'changes-requested'`, `parts` with `partId`, `part` outcome and note, `mesh` outcome and note with `JobPartOutcome` as `'pending'`, `'clean'` or `'flagged'`, and `words`).
1146
1146
  - **`review-verdict`.** The original model branch carries `stage` (`'rig-review'` or `'direction-review'`), `verdict` and `words`, requiring non-null `source.model` with runtime stage, selector and direction consistency checks. A declared `rig-review` ask can also bind a `draft` selector with `source.projectHash` and null `source.direction`. It uses the existing rig screen and still capture, and its finalized act preserves the retained draft publication's source hash, model and selector. A compiled rig's Request changes can carry [chest landmarks (act@9)](#chest-landmarks-on-request-changes-act9).
@@ -1483,6 +1483,41 @@ publication nor draws bound parts. Without it the picture choice is unchanged: t
1483
1483
  record's own rig, then an earlier picture publication, then bound parts, then a
1484
1484
  scene-context option set.
1485
1485
 
1486
+ #### Pins on the plan picture
1487
+
1488
+ While the plan picture or a record interview's question image is shown, stage
1489
+ comments pin a point or a region on it through the same pin layer as a rig view,
1490
+ with no new control ([Review #1048](https://github.com/rig-c/review/issues/1048)). The row is an
1491
+ ordinary StageComment-backed Feedback with `viewport: 'reference'`,
1492
+ `camera.space: 'image'` and `world` in the picture's natural pixels, Y down. Its
1493
+ `referenceId` and `referenceHash` name the picture, and their meaning depends on
1494
+ the source that carries the pin:
1495
+
1496
+ - **Record publication:** `referenceId` is the `path` of an entry in that
1497
+ publication's `files`: the declared `planPicture`, or the sealed file of the
1498
+ shown question image (`api/interview` lists it as the image's `path` and
1499
+ `sha256`). `referenceHash` is that entry's sealed `sha256`, copied from the
1500
+ source and never recomputed by the page.
1501
+ - **Rig package:** `referenceId` is the selected bookmark reference, and
1502
+ `referenceHash` is the loader's hash of it, as described under the comment
1503
+ context above. Nothing changes for these marks.
1504
+
1505
+ A record act carries comments only as the scalar `words` projection: checkpoint
1506
+ and signoff in their `words`, interview picks in their optional `words`. A picture
1507
+ pin therefore projects its own label, so the picture and the pixels reach the act:
1508
+
1509
+ `["rig-review-comment/1", mode, "reference", referenceId, referenceHash, x, y, w, h]`
1510
+
1511
+ Here `x`, `y`, `w` and `h` are `world` rounded to integers in natural pixels, Y
1512
+ down, and a point has `w` and `h` of 0. Only a pin that names one of the record's sealed
1513
+ pictures (the plan picture or a question image) takes this label. Rig, package and every other label keep their
1514
+ existing tuple byte for byte. A pin that names the picture's path with a
1515
+ different `sha256`, or whose label does not parse back to that path and hash,
1516
+ refuses `COMMENT_PICTURE_LABEL_INVALID`, both when projected and when a local
1517
+ draft is restored. New picture bytes give the record a new `sourceHash`, so an
1518
+ unsent pin is not carried to the new publication; the existing "source changed …
1519
+ could not be carried over" notice reports it.
1520
+
1486
1521
  ### Sealed plan step text
1487
1522
 
1488
1523
  Both publication-pinned `api/review` responses append delivery-only `planText`
@@ -1685,6 +1720,7 @@ labels are `JSON.stringify` of these logical target tuples:
1685
1720
  | Parts | `[schema, parts.map(part => part.name), view.mode]` |
1686
1721
  | Image | `[name]` |
1687
1722
  | StageComment-backed Feedback | `[mark.schema, mark.mode, mark.viewport, target.kind, target.name, frameStart, frameEnd]` |
1723
+ | StageComment-backed Feedback on a record's plan picture | `[mark.schema, mark.mode, "reference", referenceId, referenceHash, x, y, w, h]` ([pins on the plan picture](#pins-on-the-plan-picture)) |
1688
1724
  | Other Feedback | `[target.kind, target.name, frameStart, frameEnd, side ?? null]` |
1689
1725
 
1690
1726
  Capture IDs, hashes and crop bytes stay in the raw anchor and do not enter the
package/docs/STABILITY.md CHANGED
@@ -882,6 +882,34 @@ sources keep their bytes and `sourceHash`. `PlanContext` and `PlanSource` gain t
882
882
  optional field; no runtime export or error code is added. See the
883
883
  [plan picture contract](REVIEW_PACKAGE.md#plan-picture).
884
884
 
885
+ A pin on the shown plan picture reuses `referenceId` and `referenceHash`
886
+ ([Review #1048](https://github.com/rig-c/review/issues/1048)). In a record
887
+ publication `referenceId` is the path of an entry of that publication's `files`
888
+ and `referenceHash` is that entry's sealed sha256. In a rig package `referenceId`
889
+ stays the selected bookmark reference. `projectComments` gains an optional second
890
+ argument, the record's sealed pictures; with it, such a pin projects the label
891
+ `["rig-review-comment/1", mode, "reference", referenceId, referenceHash, x, y, w, h]`
892
+ with integer natural-pixel coordinates. Without the argument, and for every other
893
+ mark, labels are byte-identical to before. A label that does not parse back refuses
894
+ `COMMENT_PICTURE_LABEL_INVALID`. No act field or schema changes. See
895
+ [pins on the plan picture](REVIEW_PACKAGE.md#pins-on-the-plan-picture).
896
+
897
+ ## Record interview comments
898
+
899
+ A record `interview-picks` act (`rig-review/act@4`) may carry an optional, additive
900
+ `value.words` ([Review #1048](https://github.com/rig-c/review/issues/1048)): the
901
+ reviewer's general and pinned comments as the `projectComments` output, the same
902
+ projection checkpoint and signoff carry. It is the last key and present only when
903
+ comments exist, so an act without comments keeps its bytes. `parseRecordAct`
904
+ accepts it with the checkpoint and signoff `words` check and still refuses any
905
+ other extra key. A pin on a sealed question image takes the same label as a plan
906
+ picture pin, and `api/interview` adds the image's sealed `path` and `sha256` on
907
+ record publications. The schema stays `rig-review/act@4`: Create decodes record
908
+ acts through this package's own `parseRecordAct`, so the producer and the parser
909
+ move together, an older parser refuses a commented act by name and drops nothing,
910
+ and acts without comments are unchanged. `JobActValues['interview-picks']` gains
911
+ the optional `words`; no runtime export or error code is added.
912
+
885
913
  ## Package manifest `frames` declaration
886
914
 
887
915
  `rig-review/1` manifests accept an optional `frames` field beside `model`: a
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "rig-review",
3
- "version": "4.11.0",
3
+ "version": "4.12.0",
4
4
  "type": "module",
5
5
  "description": "Local human rig inspection and structured feedback export",
6
6
  "license": "MIT",
@@ -26,7 +26,7 @@
26
26
  "pngjs": "7.0.0"
27
27
  },
28
28
  "devDependencies": {
29
- "@rig-c/parts": "2.49.1",
29
+ "@rig-c/parts": "2.51.0",
30
30
  "@types/bun": "^1.3.0",
31
31
  "typescript": "^5.9.3"
32
32
  },
package/src/job-act.ts CHANGED
@@ -372,7 +372,7 @@ export function prepareJobRecordAct(options: {
372
372
  switch (askSubject.kind) {
373
373
  case 'interview-picks': {
374
374
  if (boundSource.subject !== 'option-set') throw new JobError('JOB_ACT_SOURCE_STALE');
375
- const value = actObject(submission.value, ['questionId', 'selections', 'note']);
375
+ const value = actObject(submission.value, ['questionId', 'selections', 'note', 'words']);
376
376
  if (
377
377
  !('questionId' in value) ||
378
378
  !('selections' in value) ||
@@ -401,6 +401,8 @@ export function prepareJobRecordAct(options: {
401
401
  };
402
402
  });
403
403
  const note = words(value.note);
404
+ // #1048: comments ride the optional `words`; with none the act keeps its pre-#1048 bytes (no key).
405
+ const comments = 'words' in value ? words(value.words) : '';
404
406
  try {
405
407
  validatePicks(
406
408
  {
@@ -425,7 +427,7 @@ export function prepareJobRecordAct(options: {
425
427
  kind: 'interview-picks',
426
428
  // #1004: the act's singular set fields name this ask's set.
427
429
  source: recordActSource(boundSource, askSubject),
428
- value: { questionId: askSubject.questionId, selections, note },
430
+ value: { questionId: askSubject.questionId, selections, note, ...(comments ? { words: comments } : {}) },
429
431
  });
430
432
  }
431
433
  case 'checkpoint': {
package/src/job-api.ts CHANGED
@@ -1293,7 +1293,8 @@ export function parseRecordAct(value: unknown): RecordAct {
1293
1293
  switch (item.kind) {
1294
1294
  case 'interview-picks': {
1295
1295
  if (source.subject !== 'option-set') throw new JobError('JOB_ACT_INVALID');
1296
- const rawValue = exactObject(item.value, ['questionId', 'selections', 'note'], 'JOB_ACT_INVALID');
1296
+ // #1048: `words` is optional and additive; it carries the comments with the same checker as checkpoint and signoff.
1297
+ const rawValue = exactObject(item.value, ['questionId', 'selections', 'note'], 'JOB_ACT_INVALID', ['words']);
1297
1298
  const questionId = asCode(() => jobId(rawValue.questionId), 'JOB_ACT_INVALID');
1298
1299
  if (received.set && questionId !== received.set.questionId) {
1299
1300
  throw new JobError('JOB_ACT_INVALID', `value.questionId ${questionId} is not the act set ${received.set.questionId}/${received.set.setId}`);
@@ -1310,6 +1311,7 @@ export function parseRecordAct(value: unknown): RecordAct {
1310
1311
  return { itemId, optionId, otherText };
1311
1312
  });
1312
1313
  const note = parseActWords(rawValue.note, 'JOB_ACT_INVALID');
1314
+ const words = Object.hasOwn(rawValue, 'words') ? parseActWords(rawValue.words, 'JOB_ACT_INVALID') : undefined;
1313
1315
  return {
1314
1316
  schema: JOB_RECORD_ACT_SCHEMA,
1315
1317
  actId,
@@ -1320,7 +1322,7 @@ export function parseRecordAct(value: unknown): RecordAct {
1320
1322
  authority,
1321
1323
  at,
1322
1324
  source,
1323
- value: { questionId, selections, note },
1325
+ value: words === undefined ? { questionId, selections, note } : { questionId, selections, note, words },
1324
1326
  };
1325
1327
  }
1326
1328
  case 'checkpoint': {
@@ -545,6 +545,9 @@ export interface JobActValues {
545
545
  readonly otherText: string | null;
546
546
  }[];
547
547
  readonly note: string;
548
+ /** #1048: optional and additive. Present only when the reviewer left comments; exactly the `projectComments`
549
+ * output that checkpoint and signoff carry. An act without comments has no `words` key. */
550
+ readonly words?: string;
548
551
  };
549
552
  readonly checkpoint: {
550
553
  readonly checkpointId: string;
package/src/job-front.ts CHANGED
@@ -315,11 +315,15 @@ export function retainedPublicationRoutes(session: JobSession) {
315
315
  const interviewMetadata = (rigPicture = false, painting?: NonNullable<ReturnType<typeof retainedRecordPainting>>) => {
316
316
  const interview = isRetainedRecordSource(retained) ? undefined :
317
317
  retained.interview !== undefined ? retained.interview : display.publication.interview;
318
+ // #1048: a record question image names its sealed `files` entry, so a pin binds to those bytes.
319
+ const sealed = isRetainedRecordSource(retained) ? retained.source.files : [];
318
320
  return json({
319
321
  questions: questions.map(question => ({...question,
320
322
  ...(rigPicture && question.missingPicture === 'rig' ? {missingPicture: undefined} : {}),
321
323
  images: (painting && question.missingPicture ? [painting] : question.images).map((image, index) => ({name: image.name,
322
- url: `/api/interview/image/${question.ref.sha256}/${index}`})),
324
+ url: `/api/interview/image/${question.ref.sha256}/${index}`,
325
+ ...(sealed.some(file => file.path === image.ref.path && file.sha256 === image.ref.sha256)
326
+ ? {path: image.ref.path, sha256: image.ref.sha256} : {})})),
323
327
  })),
324
328
  ...(interview === undefined ? {} : {interview}),
325
329
  });
package/src/job-source.ts CHANGED
@@ -956,10 +956,18 @@ export async function loadRetainedRecordRig(retained: JobRetainedRecordSource) {
956
956
  }
957
957
  }
958
958
 
959
- /** Create declares the original painting as the first project input. */
959
+ /** Create declares the original painting as `project.painting`, or as the first project input on older records. */
960
960
  export function retainedRecordPainting(retained: JobRetainedRecordSource): Pick<InterviewQuestion['images'][number], 'ref' | 'name'> | null {
961
961
  const {project} = readProjectRecordBytes(retained.snapshotRoot, retained.record);
962
- const input = asPlainObject(Array.isArray(project.inputs) ? project.inputs[0] : null);
962
+ const inputs = Array.isArray(project.inputs) ? project.inputs : [];
963
+ let rawInput: unknown = null;
964
+ if (Object.hasOwn(project, 'painting')) {
965
+ if (typeof project.painting !== 'string') return null;
966
+ rawInput = inputs.find(item => asPlainObject(item)?.path === project.painting) ?? null;
967
+ } else {
968
+ rawInput = inputs[0] ?? null;
969
+ }
970
+ const input = asPlainObject(rawInput);
963
971
  const seal = retained.seals.find(file => file.path === input?.path && file.sha256 === input?.sha256);
964
972
  if (!seal || !/\.(png|jpe?g|webp|svg)$/i.test(seal.path)) return null;
965
973
  return {ref: seal, name: posix.basename(seal.path)};
@@ -8,14 +8,41 @@ import type {CompareFeedback} from './compare-session.ts';
8
8
  export interface MarkPoint {x:number;y:number}
9
9
  export interface MarkRegion {x:number;y:number;width:number;height:number}
10
10
 
11
+ /** A sealed record file a pin can name: the path and sha256 of an entry of the publication's `files` (#1048). */
12
+ export interface PictureIdentity {readonly path: string; readonly sha256: string}
13
+ const pictureLabelInvalid = (why: string): never => { throw new Error('COMMENT_PICTURE_LABEL_INVALID: ' + why); };
14
+ /** #1048 A1: `[schema, mode, 'reference', referenceId, referenceHash, x, y, w, h]`, integers in the picture's natural pixels, Y down. */
15
+ function pictureCommentLabel(mark: StageComment, picture: PictureIdentity): string {
16
+ if (mark.referenceHash !== picture.sha256) pictureLabelInvalid(`referenceHash is not the sealed sha256 of ${picture.path}`);
17
+ const {x, y, width, height} = mark.world;
18
+ const label = JSON.stringify([mark.schema, mark.mode, 'reference', picture.path, picture.sha256,
19
+ Math.round(x), Math.round(y), Math.round(width), Math.round(height)]);
20
+ parsePictureCommentLabel(label);
21
+ return label;
22
+ }
23
+ /** The restore path's inverse of the A1 label; anything else refuses by name. */
24
+ export function parsePictureCommentLabel(label: string): {mode: CommentMode; referenceId: string; referenceHash: string; region: MarkRegion} {
25
+ let value: unknown;
26
+ try { value = JSON.parse(label); } catch { return pictureLabelInvalid('not JSON'); }
27
+ if (!Array.isArray(value) || value.length !== 9) return pictureLabelInvalid('expected nine fields');
28
+ const [schema, mode, viewport, referenceId, referenceHash, x, y, width, height] = value as unknown[];
29
+ if (schema !== 'rig-review-comment/1' || !commentModes.includes(mode as CommentMode) || viewport !== 'reference') pictureLabelInvalid('schema, mode or viewport');
30
+ if (typeof referenceId !== 'string' || !referenceId || referenceId.length > 512 || typeof referenceHash !== 'string' || !/^[a-f0-9]{64}$/.test(referenceHash)) pictureLabelInvalid('picture identity');
31
+ if (![x, y, width, height].every(n => Number.isSafeInteger(n)) || (width as number) < 0 || (height as number) < 0) pictureLabelInvalid('region is not natural-pixel integers');
32
+ return {mode: mode as CommentMode, referenceId: referenceId as string, referenceHash: referenceHash as string,
33
+ region: {x: x as number, y: y as number, width: width as number, height: height as number}};
34
+ }
35
+
11
36
  /** Stable logical labels survive a new Apply capture; raw anchors retain its full evidence. */
12
- function commentLabel(anchor: JobCommentAnchor): string {
37
+ function commentLabel(anchor: JobCommentAnchor, pictures?: readonly PictureIdentity[]): string {
13
38
  if ('checkpointId' in anchor) return JSON.stringify(['checkpoint', anchor.checkpointId]);
14
39
  if ('schema' in anchor) return JSON.stringify([anchor.schema, anchor.parts.map(part => part.name), anchor.view.mode]);
15
40
  if ('name' in anchor) return JSON.stringify([anchor.name]);
16
41
  const context = anchor.context as Record<string, unknown> | undefined;
17
42
  if (hasStageComment(context?.comment)) {
18
43
  const mark = parseStageComment(context!.comment);
44
+ const picture = mark.viewport === 'reference' ? pictures?.find(item => item.path === mark.referenceId) : undefined;
45
+ if (picture) return pictureCommentLabel(mark, picture);
19
46
  return JSON.stringify([mark.schema, mark.mode, mark.viewport, anchor.target.kind, anchor.target.name,
20
47
  anchor.frameStart, anchor.frameEnd]);
21
48
  }
@@ -23,13 +50,14 @@ function commentLabel(anchor: JobCommentAnchor): string {
23
50
  'side' in anchor ? anchor.side : null]);
24
51
  }
25
52
 
26
- /** The signed scalar projection. Entry text and array order are never normalized. */
27
- export function projectComments(comments: readonly JobComment[]): string {
53
+ /** The signed scalar projection. Entry text and array order are never normalized.
54
+ * `pictures` is a record host's sealed shown pictures (#1048); without it every label keeps its existing branch. */
55
+ export function projectComments(comments: readonly JobComment[], pictures?: readonly PictureIdentity[]): string {
28
56
  if (!Array.isArray(comments) || comments.length > 1000) throw new Error('JOB_ACT_INVALID');
29
57
  const blocks = comments.map(comment => {
30
58
  if (!comment || typeof comment.text !== 'string' || !comment.text.trim() || comment.text.length > 10000 ||
31
59
  Object.keys(comment).some(key => key !== 'text' && key !== 'anchor')) throw new Error('JOB_ACT_INVALID');
32
- return `[${comment.anchor === undefined ? 'general' : commentLabel(comment.anchor)}]\n${comment.text}`;
60
+ return `[${comment.anchor === undefined ? 'general' : commentLabel(comment.anchor, pictures)}]\n${comment.text}`;
33
61
  });
34
62
  const text = blocks.join('\n\n');
35
63
  if (text.length > 10000) throw new Error('JOB_ACT_INVALID');
package/web/catalog-en.ts CHANGED
@@ -31,7 +31,7 @@ export const enCatalog: Readonly<Record<string, string>> = {
31
31
  "Comment · C": "Comment · C",
32
32
 
33
33
  "project.json": "project.json",
34
- 'job.commentsFromWorkspace': 'Comments from the workspace are included. Close this request to add or edit comments.',
34
+ 'job.commentsFromWorkspace': 'Comments from the workspace are included. Add or edit them under Comments below.',
35
35
  'Add general comment': 'Add general comment',
36
36
  'General comment': 'General comment',
37
37
  "Difference: {0} of {1} pixels differ, compared where the rig draws \u00b7 rest still vs original painting.": "Difference: {0} of {1} pixels differ, compared where the rig draws · rest still vs original painting.",
@@ -800,6 +800,7 @@ export const enCatalog: Readonly<Record<string, string>> = {
800
800
  "Close Inspector": "Close Inspector",
801
801
  "Close Parts and settings": "Close Parts and settings",
802
802
  "Close Parts explorer": "Close Parts explorer",
803
+ "Close Communication": "Close Communication",
803
804
  "Close Settings": "Close Settings",
804
805
  "Close Sources and settings": "Close Sources and settings",
805
806
  "Close strip": "Close strip",
@@ -1404,6 +1405,7 @@ export const enCatalog: Readonly<Record<string, string>> = {
1404
1405
  "Part {0}: malformed posed geometry": "Part {0}: malformed posed geometry",
1405
1406
  "Parts and settings": "Parts and settings",
1406
1407
  "Parts explorer": "Parts explorer",
1408
+ "Communication": "Communication",
1407
1409
  "Parts unavailable · {0}. The rig keeps drawing whole; selection, Solo and feedback targeting are off {1}.": "Parts unavailable · {0}. The rig keeps drawing whole; selection, Solo and feedback targeting are off {1}.",
1408
1410
  "Parts unavailable · {0}. The whole rig stays drawn; no slot is selected, soloed or targeted from stale data.": "Parts unavailable · {0}. The whole rig stays drawn; no slot is selected, soloed or targeted from stale data.",
1409
1411
  "Pass": "Pass",
@@ -1647,6 +1649,7 @@ export const enCatalog: Readonly<Record<string, string>> = {
1647
1649
  "Resize Inspector": "Resize Inspector",
1648
1650
  "Resize Parts and settings": "Resize Parts and settings",
1649
1651
  "Resize Parts explorer": "Resize Parts explorer",
1652
+ "Resize Communication": "Resize Communication",
1650
1653
  "Resize Sources and settings": "Resize Sources and settings",
1651
1654
  "Resize {0}": "Resize {0}",
1652
1655
  "Resolve the saved local draft conflict before submitting.": "Resolve the saved local draft conflict before submitting.",
@@ -1987,7 +1990,7 @@ export const enCatalog: Readonly<Record<string, string>> = {
1987
1990
  "WEIGHTS_RAMP_UNAVAILABLE: no bone colour tokens": "WEIGHTS_RAMP_UNAVAILABLE: no bone colour tokens",
1988
1991
  "WEIGHTS_RAMP_UNAVAILABLE: the weight ramp tokens are not hex colours": "WEIGHTS_RAMP_UNAVAILABLE: the weight ramp tokens are not hex colours",
1989
1992
  "WEIGHTS_SELECT_BONE: pick a bone": "WEIGHTS_SELECT_BONE: pick a bone",
1990
- "WORKSPACE_COLUMNS: left {0} / right {1}; required distinct leftWidth, rightWidth or null": "WORKSPACE_COLUMNS: left {0} / right {1}; required distinct leftWidth, rightWidth or null",
1993
+ "WORKSPACE_COLUMNS: left {0} / right {1}; required distinct leftWidth, rightWidth, communicationWidth or null": "WORKSPACE_COLUMNS: left {0} / right {1}; required distinct leftWidth, rightWidth, communicationWidth or null",
1991
1994
  "WORKSPACE_DRAWER: named dialog and trigger required": "WORKSPACE_DRAWER: named dialog and trigger required",
1992
1995
  "WORKSPACE_RECTANGLE: finite 0..65536 CSS pixels required": "WORKSPACE_RECTANGLE: finite 0..65536 CSS pixels required",
1993
1996
  "WORKSPACE_SEPARATOR: controls and accessible label required": "WORKSPACE_SEPARATOR: controls and accessible label required",
@@ -3234,6 +3237,7 @@ export const enCatalog: Readonly<Record<string, string>> = {
3234
3237
  "COMMENT_CROP_UNAVAILABLE: mark is outside the viewport": "COMMENT_CROP_UNAVAILABLE: mark is outside the viewport",
3235
3238
  "mark is outside the viewport": "mark is outside the viewport",
3236
3239
  "COMMENT_CROP_LIMIT: mark a smaller region (PNG limit 150 KiB)": "COMMENT_CROP_LIMIT: mark a smaller region (PNG limit 150 KiB)",
3240
+ "COMMENT_PICTURE_LABEL_INVALID: the pin does not name a sealed picture of this record": "COMMENT_PICTURE_LABEL_INVALID: the pin does not name a sealed picture of this record",
3237
3241
  "mark a smaller region (PNG limit 150 KiB)": "mark a smaller region (PNG limit 150 KiB)",
3238
3242
  "Stage comments": "Stage comments",
3239
3243
  "COMMENT_BUSY: wait for inspection": "COMMENT_BUSY: wait for inspection",
@@ -3368,11 +3372,13 @@ export const enCatalog: Readonly<Record<string, string>> = {
3368
3372
  "Checker": "Checker",
3369
3373
  "Alpha only": "Alpha only",
3370
3374
  "Footprints of parts in front": "Footprints of parts in front",
3375
+ "Point": "Point",
3371
3376
  "Region": "Region",
3372
3377
  "Pages": "Pages",
3373
3378
  "VERDICT": "VERDICT",
3374
3379
  "Note": "Note",
3375
3380
  "Sign-off": "Sign-off",
3381
+ "Checkpoint · Sign-off": "Checkpoint · Sign-off",
3376
3382
  "Save sign-off": "Save sign-off",
3377
3383
  "{under} opens under {above} · {animation} f{frame} ({time} s) · {found} cells found / {allowed} allowed": "{under} opens under {above} · {animation} f{frame} ({time} s) · {found} cells found / {allowed} allowed",
3378
3384
  "Seam {a} | {b} · {px40} px over 40 · {px80} px over 80": "Seam {a} | {b} · {px40} px over 40 · {px80} px over 80",
package/web/catalog-ko.ts CHANGED
@@ -31,7 +31,7 @@ export const koCatalog: Readonly<Record<string, string>> = {
31
31
  "Comment · C": "코멘트 · C",
32
32
 
33
33
  "project.json": "project.json",
34
- 'job.commentsFromWorkspace': '작업 공간의 코멘트를 함께 제출해요. 코멘트를 추가하거나 고치려면 이 요청을 닫으세요.',
34
+ 'job.commentsFromWorkspace': '작업 공간의 코멘트를 함께 제출해요. 코멘트는 아래 코멘트에서 추가하거나 고칠 수 있어요.',
35
35
  'Add general comment': '일반 코멘트 추가',
36
36
  'General comment': '일반 코멘트',
37
37
  "Difference: {0} of {1} pixels differ, compared where the rig draws \u00b7 rest still vs original painting.": "차이: 리그가 그리는 {1}픽셀 중 {0}픽셀 다름 · 정지 셋업과 원본 그림.",
@@ -800,6 +800,7 @@ export const koCatalog: Readonly<Record<string, string>> = {
800
800
  "Close Inspector": "인스펙터 닫기",
801
801
  "Close Parts and settings": "파츠 및 설정 닫기",
802
802
  "Close Parts explorer": "파츠 탐색기 닫기",
803
+ "Close Communication": "소통 패널 닫기",
803
804
  "Close Settings": "설정 닫기",
804
805
  "Close Sources and settings": "소스 및 설정 닫기",
805
806
  "Close strip": "스트립 닫기",
@@ -1404,6 +1405,7 @@ export const koCatalog: Readonly<Record<string, string>> = {
1404
1405
  "Part {0}: malformed posed geometry": "파츠 {0}: 잘못된 포즈 지오메트리",
1405
1406
  "Parts and settings": "파츠 및 설정",
1406
1407
  "Parts explorer": "파츠 탐색기",
1408
+ "Communication": "AI와의 소통",
1407
1409
  "Parts unavailable · {0}. The rig keeps drawing whole; selection, Solo and feedback targeting are off {1}.": "파츠 사용 불가 · {0}. 리그는 전체로 계속 그려지며 선택, 솔로 및 피드백 대상 지정은 {1} 비활성화돼요.",
1408
1410
  "Parts unavailable · {0}. The whole rig stays drawn; no slot is selected, soloed or targeted from stale data.": "파츠 사용 불가 · {0}. 전체 리그는 계속 그려지며 오래된 데이터로부터 슬롯이 선택, 솔로 또는 대상 지정되지 않아요.",
1409
1411
  "Pass": "통과",
@@ -1647,6 +1649,7 @@ export const koCatalog: Readonly<Record<string, string>> = {
1647
1649
  "Resize Inspector": "인스펙터 크기 조절",
1648
1650
  "Resize Parts and settings": "파츠 및 설정 크기 조절",
1649
1651
  "Resize Parts explorer": "파츠 탐색기 크기 조절",
1652
+ "Resize Communication": "소통 패널 크기 조절",
1650
1653
  "Resize Sources and settings": "소스 및 설정 크기 조절",
1651
1654
  "Resize {0}": "{0} 크기 조절",
1652
1655
  "Resolve the saved local draft conflict before submitting.": "제출하기 전에 저장된 로컬 초안 충돌을 해결하세요.",
@@ -1987,7 +1990,7 @@ export const koCatalog: Readonly<Record<string, string>> = {
1987
1990
  "WEIGHTS_RAMP_UNAVAILABLE: no bone colour tokens": "WEIGHTS_RAMP_UNAVAILABLE: 본 색상 토큰이 없어요",
1988
1991
  "WEIGHTS_RAMP_UNAVAILABLE: the weight ramp tokens are not hex colours": "WEIGHTS_RAMP_UNAVAILABLE: 가중치 램프 토큰이 16진수 색상이 아니에요",
1989
1992
  "WEIGHTS_SELECT_BONE: pick a bone": "WEIGHTS_SELECT_BONE: 본을 선택하세요",
1990
- "WORKSPACE_COLUMNS: left {0} / right {1}; required distinct leftWidth, rightWidth or null": "WORKSPACE_COLUMNS: 좌측 {0} / 우측 {1}; 고유한 leftWidth, rightWidth 또는 null이 필요해요",
1993
+ "WORKSPACE_COLUMNS: left {0} / right {1}; required distinct leftWidth, rightWidth, communicationWidth or null": "WORKSPACE_COLUMNS: 좌측 {0} / 우측 {1}; 고유한 leftWidth, rightWidth, communicationWidth 또는 null이 필요해요",
1991
1994
  "WORKSPACE_DRAWER: named dialog and trigger required": "WORKSPACE_DRAWER: 이름이 지정된 대화상자와 트리거가 필요해요",
1992
1995
  "WORKSPACE_RECTANGLE: finite 0..65536 CSS pixels required": "WORKSPACE_RECTANGLE: 유한한 0..65536 CSS 픽셀이 필요해요",
1993
1996
  "WORKSPACE_SEPARATOR: controls and accessible label required": "WORKSPACE_SEPARATOR: 컨트롤과 접근성 라벨이 필요해요",
@@ -3234,6 +3237,7 @@ export const koCatalog: Readonly<Record<string, string>> = {
3234
3237
  "COMMENT_CROP_UNAVAILABLE: mark is outside the viewport": "COMMENT_CROP_UNAVAILABLE: 표시 영역이 뷰포트 밖에 있어요",
3235
3238
  "mark is outside the viewport": "표시 영역이 뷰포트 밖에 있어요",
3236
3239
  "COMMENT_CROP_LIMIT: mark a smaller region (PNG limit 150 KiB)": "COMMENT_CROP_LIMIT: 더 작은 영역을 표시하세요 (PNG 제한 150 KiB)",
3240
+ "COMMENT_PICTURE_LABEL_INVALID: the pin does not name a sealed picture of this record": "COMMENT_PICTURE_LABEL_INVALID: 이 핀은 이 기록의 봉인된 그림을 가리키지 않아요",
3237
3241
  "mark a smaller region (PNG limit 150 KiB)": "더 작은 영역을 표시하세요 (PNG 제한 150 KiB)",
3238
3242
  "Stage comments": "스테이지 코멘트",
3239
3243
  "COMMENT_BUSY: wait for inspection": "COMMENT_BUSY: 점검이 완료될 때까지 기다리세요",
@@ -3368,11 +3372,13 @@ export const koCatalog: Readonly<Record<string, string>> = {
3368
3372
  "Checker": "체커",
3369
3373
  "Alpha only": "알파만",
3370
3374
  "Footprints of parts in front": "앞 파츠의 풋프린트",
3375
+ "Point": "지점",
3371
3376
  "Region": "영역",
3372
3377
  "Pages": "페이지",
3373
3378
  "VERDICT": "판정",
3374
3379
  "Note": "메모",
3375
3380
  "Sign-off": "승인",
3381
+ "Checkpoint · Sign-off": "체크포인트 · 승인",
3376
3382
  "Save sign-off": "승인 저장",
3377
3383
  "{under} opens under {above} · {animation} f{frame} ({time} s) · {found} cells found / {allowed} allowed": "{under}이(가) {above} 아래에서 벌어짐 · {animation} f{frame} ({time}초) · 셀 {found}개 발견 / 허용 {allowed}개",
3378
3384
  "Seam {a} | {b} · {px40} px over 40 · {px80} px over 80": "이음매 {a} | {b} · 40 초과 {px40} px · 80 초과 {px80} px",
@@ -32,8 +32,9 @@ export interface InspectorBlocksOptions {
32
32
  available?:readonly string[];
33
33
  /** Called when a click or a key changes a section's active tab. */
34
34
  changed?:()=>void;
35
- /** The rig reuses its block rows in the heading, with one programmatic Comments selection. */
36
- bottom?:{strip:HTMLElement;comment:HTMLButtonElement;panel:HTMLElement};
35
+ /** The rig reuses its block rows in the heading. A `comment` button and `panel` add one programmatic Comments
36
+ * selection; the single review page omits them because Comments live in its right communication panel (#1041). */
37
+ bottom?:{strip:HTMLElement;comment?:HTMLButtonElement;panel?:HTMLElement};
37
38
  }
38
39
  export interface InspectorBlocks {state():ActiveBlocks;restore(state:ActiveBlocks):void;select(section:string,id:string):void;activate(section:string):void;register(tab:{id:string;panel:HTMLElement;label:string;position?:'first'|'last'}):()=>void;dispose():void}
39
40
 
@@ -112,7 +113,7 @@ export function bindInspectorBlocks(options:InspectorBlocksOptions):InspectorBlo
112
113
  if(!more.menu.hidden)placeOverflow(more.menu);
113
114
  };
114
115
  }
115
- definitions.set(name,{section,row,scrollRoot,tabs,syncOverflow});saved[name]=tabs.find(tab=>tab.button.getAttribute('aria-selected')==='true')?.id??tabs[0]?.id??'feedback';
116
+ definitions.set(name,{section,row,scrollRoot,tabs,syncOverflow});const first=tabs.find(tab=>tab.button.getAttribute('aria-selected')==='true')?.id??tabs[0]?.id??(options.bottom.comment?'feedback':undefined);if(first)saved[name]=first;
116
117
  row.hidden=true;options.bottom.strip.append(row);continue;
117
118
  }
118
119
  ids.set(name,new Set(tabs.map(tab=>tab.id)));
@@ -133,9 +134,10 @@ export function bindInspectorBlocks(options:InspectorBlocksOptions):InspectorBlo
133
134
  if(active===name&&!force)return;
134
135
  if(active){saved[active]=rows.get(active)?.state()??saved[active]!;rows.get(active)?.dispose();rows.delete(active);definitions.get(active)!.row.hidden=true;}
135
136
  active=name;const {section,row,scrollRoot,tabs,syncOverflow}=definitions.get(name)!,bottom=options.bottom;
136
- bottom.comment.dataset.blockTarget='feedback';bottom.comment.hidden=true;bottom.comment.remove();row.hidden=false;
137
- const all=[...tabs,{button:bottom.comment,id:'feedback',panel:bottom.panel,included:[]}];
138
- ids.set(name,new Set(all.map(tab=>tab.id)));
137
+ const comments=bottom.comment&&bottom.panel?{button:bottom.comment,id:'feedback',panel:bottom.panel,included:[]}:null;
138
+ if(comments){comments.button.dataset.blockTarget='feedback';comments.button.hidden=true;comments.button.remove();}
139
+ const all=comments?[...tabs,comments]:tabs;row.hidden=!all.length;
140
+ ids.set(name,new Set(all.map(tab=>tab.id)));if(!all.length){syncOverflow();options.changed?.();return;}
139
141
  const sync=()=>{section.dataset.comments=String(rows.get(name)?.state()==='feedback'||external.has(rows.get(name)?.state()??''));syncOverflow();options.changed?.();};
140
142
  for(const tab of all)tab.button.setAttribute('aria-selected',String(tab.id===saved[name]));
141
143
  rows.set(name,bindInspectorTabs(sync,()=>{},{tabs:all.map(tab=>({id:tab.id,button:tab.button,panels:[tab.panel],included:tab.included,attribute:'aria-selected'})),panels:all.map(tab=>tab.panel),root:row,scrollRoot,initialize:true}));
@@ -167,7 +169,7 @@ export function bindInspectorBlocks(options:InspectorBlocksOptions):InspectorBlo
167
169
  },
168
170
  select:(name,id)=>{rows.get(name)?.select(resolve(name,id));definitions.get(name)?.syncOverflow();},
169
171
  /** Restore saved tabs without touching the workspace's section scroll offset. */
170
- restore(value){for(const [name,id]of Object.entries(value)){if(options.bottom){const definition=definitions.get(name);if(id==='feedback'||definition?.tabs.some(tab=>tab.id===resolve(name,id)))saved[name]=resolve(name,id);}rows.get(name)?.restore(resolve(name,id));definitions.get(name)?.syncOverflow();}},
172
+ restore(value){for(const [name,id]of Object.entries(value)){if(options.bottom){const definition=definitions.get(name);if(id==='feedback'&&!!options.bottom.comment||definition?.tabs.some(tab=>tab.id===resolve(name,id)))saved[name]=resolve(name,id);}rows.get(name)?.restore(resolve(name,id));definitions.get(name)?.syncOverflow();}},
171
173
  dispose(){disposedState=state();for(const cleanup of cleanups)cleanup();for(const row of rows.values())row.dispose();rows.clear();ids.clear();},
172
174
  };
173
175
  }
@@ -125,7 +125,7 @@ export function interviewQuestionList(items: readonly {label: string; answered:
125
125
  }
126
126
 
127
127
  /** Real interview API rows shared by job publications and joined project inspection. */
128
- export type InterviewDisplayQuestion = Omit<InterviewQuestion,'images'> & {images:{name:string;url:string}[];saved?:Picks|null};
128
+ export type InterviewDisplayQuestion = Omit<InterviewQuestion,'images'> & {images:{name:string;url:string;path?:string;sha256?:string}[];saved?:Picks|null};
129
129
 
130
130
  /** Read-only diagnostics and verbatim historical records, independent of submission transport. */
131
131
  export function interviewRecords(diagnostics:readonly InterviewDiagnostic[]=[],historical:readonly HistoricalInterview[]=[],factory?:InterviewText):HTMLElement {
@@ -147,7 +147,7 @@ export function interviewRecords(diagnostics:readonly InterviewDiagnostic[]=[],h
147
147
 
148
148
  /** The question list and survey form. Hosts supply source data and submit transport. */
149
149
  export function createInterviewForm(options:{question:InterviewDisplayQuestion;id:string;node?:InterviewText;form?:HTMLFormElement;fieldset?:HTMLFieldSetElement;source?:HTMLElement;
150
- mainView?:boolean;images:readonly {name:string;src:string}[];questions?:readonly {label:string;answered:boolean}[]|(()=>readonly {label:string;answered:boolean}[]);selected?:number;onSelect?:(index:number)=>void;answered?:boolean;
150
+ mainView?:boolean;images:readonly {name:string;src:string;path?:string;sha256?:string}[];questions?:readonly {label:string;answered:boolean}[]|(()=>readonly {label:string;answered:boolean}[]);selected?:number;onSelect?:(index:number)=>void;answered?:boolean;
151
151
  diagnostics?:readonly InterviewDiagnostic[];historical?:readonly HistoricalInterview[];
152
152
  /** #1004: a control kept at the top of the question list (the job page's one submit for several sets). */
153
153
  listAction?:HTMLElement}) {