rig-review 0.24.1 → 0.25.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +1 -1
- package/docs/PANELS.md +19 -4
- package/docs/REVIEW_PACKAGE.md +3 -3
- package/docs/WORKFLOWS.md +1 -1
- package/package.json +1 -1
- package/skills/rig-review/SKILL.md +1 -1
- package/web/animation-inspection.ts +2 -1
- package/web/catalog-en.ts +2956 -0
- package/web/catalog-ko.ts +2956 -0
- package/web/compare-picked-tools.ts +4 -3
- package/web/compare.css +6 -0
- package/web/compare.html +1 -1
- package/web/compare.ts +2 -2
- package/web/i18n.ts +1154 -0
- package/web/index.html +1 -1
- package/web/main.ts +6 -5
- package/web/stage-comments.ts +95 -41
- package/web/styles.css +3 -2
- package/web/workspace-preferences.ts +15 -13
- package/web/workspace-ui.ts +8 -7
package/README.md
CHANGED
|
@@ -76,7 +76,7 @@ http://127.0.0.1:4318/instances/<key>/?input=…&handoff=…#cap=…
|
|
|
76
76
|
| <a id="cuts-cut-polygons-patch-boxes-limb-joints--rig-parts-build"></a>Designate cuts, patches and limb joints | Cuts | [Cuts — PANELS](docs/PANELS.md#cuts-cut-polygons-patch-boxes-limb-joints--rig-parts-build) |
|
|
77
77
|
| <a id="mesh-edit-typed-delta-preview-only"></a>Preview a setup-space delta and rebuild | Edit Mesh | [Mesh edit — PANELS](docs/PANELS.md#mesh-edit-typed-delta-preview-only) |
|
|
78
78
|
| <a id="retarget-map-flags--rig-pose-watch"></a>Retarget a declared pose sequence | Retarget | [Retarget — PANELS](docs/PANELS.md#retarget-map-flags--rig-pose-watch) |
|
|
79
|
-
| Mark
|
|
79
|
+
| Mark, read and edit stage comments | Comment · C (n) | [Stage comments — PANELS](docs/PANELS.md#stage-comments) |
|
|
80
80
|
| **Control and share** | | |
|
|
81
81
|
| <a id="control-the-current-inspection-page"></a>Control an opted-in inspection | `control` | [Inspection control — WORKFLOWS](docs/WORKFLOWS.md#control-the-current-inspection-page) |
|
|
82
82
|
| <a id="keep-and-share-an-inspection"></a>Restore a view link or local draft | View link, draft | [Keep and share — WORKFLOWS](docs/WORKFLOWS.md#keep-and-share-an-inspection) |
|
package/docs/PANELS.md
CHANGED
|
@@ -30,6 +30,21 @@ body. A drawer keeps its title and close button in place while its body
|
|
|
30
30
|
scrolls. The per-inspection **Repeat idle** toggle sits in the Animate
|
|
31
31
|
transport row.
|
|
32
32
|
|
|
33
|
+
**Settings** (`#workspace-settings`) stores workspace-level preferences across
|
|
34
|
+
tabs under `rig-review.workspace.v1` (`web/workspace-preferences.ts`):
|
|
35
|
+
**Appearance** (`system`, `dark`, `light`), **Language** (`system`, `en`, `ko`),
|
|
36
|
+
default **Sync cameras**, default **Repeat idle**, collapsed state and panel
|
|
37
|
+
geometry (**Reset layout** resets geometry only). Stored records from `0.24.1`
|
|
38
|
+
without `language` load unchanged with `language: "system"`. Under `system`, a
|
|
39
|
+
first visit whose browser language starts with `ko` resolves to Korean (`ko`),
|
|
40
|
+
and any other browser language resolves to English (`en`); `<html lang>` tracks
|
|
41
|
+
the resolved language (`en` or `ko`). Visible UI strings on the review and
|
|
42
|
+
compare pages come from the zero-dependency catalogue layer (`web/catalog-en.ts`,
|
|
43
|
+
`web/catalog-ko.ts`, `web/i18n.ts`), switching live without reload and without
|
|
44
|
+
losing pending edits, selection or the playhead. CLI/`check`/`feedback` output,
|
|
45
|
+
schema field names, error codes (`CODE_NAME: <translated detail>`), rig bone,
|
|
46
|
+
slot and animation names, and a reviewer's own comments stay untouched.
|
|
47
|
+
|
|
33
48
|
Animate's **Environment** block drives the player's physics while you
|
|
34
49
|
inspect: a **Wind** base (−100…100), **Breeze**, a **Gust** pulse
|
|
35
50
|
(peak 0…200, duration 0.1…20 s, **Repeat** every max(6, duration + 0.6) s)
|
|
@@ -407,12 +422,12 @@ remains independent, temporary and unrecorded.
|
|
|
407
422
|
|
|
408
423
|
## Stage comments
|
|
409
424
|
|
|
410
|
-
The visible **Comment · C** stage button is
|
|
425
|
+
The visible **Comment · C (n)** stage button is the single comment control on both the review and compare toolbars (rig, compare A/B and reference video). Turning it on enters comment mode and opens the **Comments** list; turning it off, or pressing Escape, leaves both. In comment mode, drag a rectangle (or click a point), type in the inline composer, and press Enter. Playback pauses, turn is held, and the composer receives focus; Escape cancels and leaves comment mode and the list. Text is the only required input. An active Edit Mesh keeps its Create shortcut C; leave the editor before using Comment. With Comment off, selection, turn and camera gestures keep their normal behavior.
|
|
411
426
|
|
|
412
|
-
**Comments**
|
|
427
|
+
The **Comments** list shows numbered marks with their placement mode. Setup and Animate marks appear on the stage only in that mode; the compare page always records Compare. Returning to a mode shows its marks again at their captured pose. Pins stay visible on the stage when comment mode is off, and clicking a pin enters comment mode and opens the list. Clicking either a pin or a list row restores its captured mode before its exact frame/time, camera and turn and opens that comment in the same inline composer. Rows have no separate Edit button; **Delete** lives inside the composer for unsubmitted comments, and submitted marks open read-only in the composer and list. Placement mode is captured when the gesture begins, before asynchronous crop/save; changing mode cancels the pending drag or composer and never rebinds it. Pins and rectangles use world coordinates (reference pixels, Y down, for the video), follow zoom and pan, and appear only at the captured frame/time and dial state. Reference letterboxing is included in its camera mapping. The list is also a way back to a mark hidden in another mode or pose. JSON exports index every canonical feedback comment by mode; Markdown places the full comments under their mode headings. Missing mode refuses `COMMENT_MODE_MISSING`, unknown mode refuses `COMMENT_MODE_UNKNOWN`, and a mode incompatible with the saved page/inspector refuses `COMMENT_MODE_MISMATCH`; no missing-mode guess or migration is made. Ordinary feedback and legacy text context are unchanged.
|
|
413
428
|
|
|
414
|
-
Each mark is an ordinary feedback row, category defect, with its available single-frame interval, or explicit time-only evidence when a single review has no producer frame, and topmost intersecting drawn slot (or the rig for empty regions and reference views). Picking intersects posed triangles with the held clipping polygon and uses nearest-first draw order; it is geometric coverage, not texture alpha picking. The crop is a bounded, resampled PNG of the current pane background and shown layers, with the mark burned in; it is an agent reading aid, not a pixel-identical measurement. It copies displayed rig rasters when they match the held public frame, plus the actual overlay canvases; a whole live canvas is used directly when available. The fallback uses the held public frame and current backend, and Images off omits its image tier. Video crops retain the actual displayed content and letterbox. Compare can use its existing indexed decoded reference when producer timing is missing. A clockless single rig or reference view saves a `rig-review-time-only/1` seconds basis and an explicit frame-unavailable reason. The mark frame, row frameStart/frameEnd, context.frame and inclusive interval are null; the list and exports state the time and why the frame is unavailable. No numeric sentinel, inferred FPS or callback-count frame is used. A frame strip refuses this row by name (`COMMENT_CLOCK_UNAVAILABLE`); the comment itself remains savable, editable before submission and restorable at its exact saved seconds/camera/turn.
|
|
429
|
+
Each mark is an ordinary feedback row, category defect, with its available single-frame interval, or explicit time-only evidence when a single review has no producer frame, and topmost intersecting drawn slot (or the rig for empty regions and reference views). Picking intersects posed triangles with the held clipping polygon and uses nearest-first draw order; it is geometric coverage, not texture alpha picking. The crop is a bounded, resampled PNG of the current pane background and shown layers, with the mark burned in; it is an agent reading aid, not a pixel-identical measurement. Capture starts at up to 768 pixels per side and, when a detailed or full-viewport region exceeds the 200,000-character (150 KiB) PNG data-URL limit, re-renders at a smaller scale until the encoded PNG fits within the stored limits, keeping the recorded width and height matched to the saved PNG and the burned-in mark visible at the reduced scale. It copies displayed rig rasters when they match the held public frame, plus the actual overlay canvases; a whole live canvas is used directly when available. The fallback uses the held public frame and current backend, and Images off omits its image tier. Video crops retain the actual displayed content and letterbox. Compare can use its existing indexed decoded reference when producer timing is missing. A clockless single rig or reference view saves a `rig-review-time-only/1` seconds basis and an explicit frame-unavailable reason. The mark frame, row frameStart/frameEnd, context.frame and inclusive interval are null; the list and exports state the time and why the frame is unavailable. No numeric sentinel, inferred FPS or callback-count frame is used. A frame strip refuses this row by name (`COMMENT_CLOCK_UNAVAILABLE`); the comment itself remains savable, editable before submission and restorable at its exact saved seconds/camera/turn.
|
|
415
430
|
|
|
416
|
-
|
|
431
|
+
Placing and editing comments are refused while an unapplied authoring preview or designation is on stage, without disabling the **Comment · C (n)** button. The control's tooltip and adjacent status note name `COMMENT_UNAPPLIED_PREVIEW` and the active tool (Idle tracks, Rig fields dial/handles, Physics live overrides, a loaded density-strip candidate, or Chest/Bones/Cuts/Cloth/Mesh editing geometry/handles), and clicking **Comment · C (n)** still opens the list read-only so existing comments stay reachable and restorable while placing and editing are refused by that same named reason. Pending form values with no stage effect remain allowed. Stop that preview explicitly; Comment never clears or applies it. An applied scratch build retains its refusal (`COMMENT_APPLIED_BUILD_UNSUPPORTED`), and a model replacement names `COMMENT_SOURCE_BUSY`. Enable-before-preview and asynchronous pause/crop transitions are rechecked before capture/save. Standalone Turn pad, world/reference inspection and source mesh/bone/selection/weights inspection stay available. Retarget has no unapplied live pose path; Apply is a rebuild.
|
|
417
432
|
|
|
418
433
|
A reference-basis comment cannot become a producer-frame strip: CLI and browser batch export refuse `COMMENT_REFERENCE_STRIP_UNAVAILABLE` for reference-frame comments on any viewport, including compare A/B fallback. No frame-rate/time mapping is attempted. Ordinary manual and producer-frame intervals still export; time-only comments retain `COMMENT_CLOCK_UNAVAILABLE`. Comments and their JSON/issue reports remain savable/readable with their original reference timing.
|
package/docs/REVIEW_PACKAGE.md
CHANGED
|
@@ -804,14 +804,14 @@ An optional `feedback[].context.comment` (`rig-review-comment/1`) records requir
|
|
|
804
804
|
|
|
805
805
|
When a frame is available, the row's inclusive interval is that one frame. A decoded-reference basis is explicitly distinct from a producer frame; the existing raw `context.frame` stays null when producer timing is unknown. No video FPS is inferred. The target is the first drawn slot intersecting the marked posed/clipped triangles, or the rig for an empty or reference mark. The normal session source binding, same-origin JSON mutation, capability and 1 MiB body limit apply unchanged. Saves validate the comment source/model binding, viewport side, bounded numeric evidence and PNG signature, dimensions, chunk CRCs, bounded RGB/RGBA scanline decode and exact hash. A changed source follows the existing HTTP 409/restart refusal.
|
|
806
806
|
|
|
807
|
-
The inline PNG is bounded to 150 KiB (200000 data-URL characters), each dimension at most 1024 pixels; the browser
|
|
807
|
+
The inline PNG is bounded to 150 KiB (200000 data-URL characters), each dimension at most 1024 pixels (the reader-side limit in the record format); the browser starts capture at up to 768 pixels per dimension and re-renders at a smaller scale when needed until the encoded PNG data URL fits inside the 200000-character limit, keeping `crop.width` and `crop.height` equal to the saved PNG dimensions and the burned-in mark visible at reduced scale. Submission materializes only the digest-derived `comment-crops/<sha256>.png` beneath session state, never a client-chosen path. Existing nonregular or mismatched crop files refuse. CLI feedback exports resolve crop paths for local reading and omit `crop.png` only in the derived report; the submitted session and draft retain the original inline PNG; no HTTP filesystem endpoint is added. The PNG composes the actual computed pane backgrounds and visible layers. A whole live canvas is copied when available; otherwise unambiguous displayed image/canvas rasters are matched by z to the held public frame and copied with their actual transforms, opacity and clips. If that safe raster mapping is unavailable, the published CanvasRenderer uses the held frame and actual backend; an unsupported Canvas2D RGB/dark tint refuses `COMMENT_CAPTURE_UNAVAILABLE`. Images off omits model pixels, and mesh/bone/selection overlays copy the existing displayed overlay canvases. Reference crops retain the displayed media background/letterbox. Unsupported background syntax refuses `COMMENT_BACKGROUND_UNAVAILABLE`. No HTML/foreignObject rasterization or DOM screenshot mechanism is used. These are resampled inspection pixels for agent reading, not pixel-identical measurements or proof of upstream compiler validation.
|
|
808
808
|
|
|
809
|
-
Marks share the ordinary feedback array, source-bound drafts and submission. List restoration validates the bookmark's loaded source binding before applying frame, per-pane cameras and turn. Existing sessions and no-comment JSON/issue output retain their prior shape. Submitted marks
|
|
809
|
+
Marks share the ordinary feedback array, source-bound drafts and submission. List restoration validates the bookmark's loaded source binding before applying frame, per-pane cameras and turn. Existing sessions and no-comment JSON/issue output retain their prior shape. Submitted marks open read-only in the composer and stage list and server saves refuse their edit or deletion (`COMMENT_SUBMITTED`); a new comment starts a new unsent row. No source, model or motion file changes.
|
|
810
810
|
|
|
811
811
|
Single reference marks validate `referenceId` against the selected bookmark reference and `referenceHash` against the exact file hash the package loader already computed, or the CLI-selected reference binding. `/api/review.referenceHashes` exposes these existing source-bound hashes by declared ID; it adds no asset path or decoder endpoint. Single review exposes no decoded reference index. Without an explicit producer frame at the saved time, rig and reference marks save `frame:null` plus `timeBasis:{schema:"rig-review-time-only/1",basis:"seconds",reason:"frame is unavailable: no explicit producer frame index at this time (COMMENT_FRAME_UNAVAILABLE)"}`. The row frameStart/frameEnd, context.frame and context.interval must all be null, while exact finite nonnegative `time` seconds, animation, target, source/model/reference bindings, turn, camera, region and crop remain validated. This named shape is allowed only on single structured comments; an ordinary null interval, a mixed null/numeric range, a numeric interval falsely claiming a time-only frame, or a time-only claim when a producer frame is available is refused (`COMMENT_TIME_ONLY_INVALID`). A comparison cannot use this exception and retains its existing producer/reference frame basis. JSON and issue exports explicitly say that the frame is unavailable and why; strip export refuses `COMMENT_CLOCK_UNAVAILABLE` instead of coercing null to zero. Seconds, video callback counts and inferred FPS are never called frame indices.
|
|
812
812
|
|
|
813
813
|
The comment mode is captured once at gesture start; switching mode cancels an unfinished gesture/composer. Single Setup binds `mode:setup` to bookmark `selection.inspector:rig`; Animate binds `mode:animate` to `playback`. Compare always records `mode:compare` with a compare page binding, regardless of its Inspector section. Pins/rectangles require the current mode as well as the captured pose; list restoration applies the captured mode before showing the pin. Missing mode refuses `COMMENT_MODE_MISSING`, an unknown enum refuses `COMMENT_MODE_UNKNOWN`, and a page/viewport/inspector mismatch refuses `COMMENT_MODE_MISMATCH`. Structured comments without mode are deliberately refused rather than guessed; ordinary feedback and legacy text `context.comment` remain unchanged. Derived CLI JSON retains the complete canonical `feedback` array and adds `commentGroups:{schema:"rig-review-comment-groups/1",canonical:"feedback",modes:[{mode,feedbackIds}]}` only when structured comments exist. Each ID resolves to that array's full evidence exactly once. Markdown puts the actual comments under `Comments · setup`, `Comments · animate` or `Comments · compare` headings; ordinary feedback retains its category/target sections. Neither export adds a second persistence system. No-comment JSON and Markdown bytes keep the existing format.
|
|
814
814
|
|
|
815
|
-
Stage comment capture refuses unrecorded authoring effects, by `COMMENT_UNAPPLIED_PREVIEW` plus tool name: actual idle/dial adjust functions, live physics parameter patches, a pending loaded density-strip model, visible authoring geometry (Chest/Bones/Cuts/Cloth/Mesh), and Idle/Rig fields stage handles. Unapplied form operations alone do not trigger this refusal. The Comment control displays the reason and
|
|
815
|
+
Stage comment capture refuses unrecorded authoring effects, by `COMMENT_UNAPPLIED_PREVIEW` plus tool name: actual idle/dial adjust functions, live physics parameter patches, a pending loaded density-strip model, visible authoring geometry (Chest/Bones/Cuts/Cloth/Mesh), and Idle/Rig fields stage handles. Unapplied form operations alone do not trigger this refusal. The **Comment · C (n)** control displays the reason without disabling the button, so the list still opens read-only and rows still restore while placing and editing are refused by name; active capture is cancelled if a preview begins, and capture/save recheck after asynchronous pause/crop. No preview is automatically cleared/applied or omitted from a crop. Applied scratch builds retain their refusal (`COMMENT_APPLIED_BUILD_UNSUPPORTED`); rebuild/model swaps refuse `COMMENT_SOURCE_BUSY`. Turn pad, world/reference and source inspection remain inspection, not authored previews.
|
|
816
816
|
|
|
817
817
|
`frame.basis:reference` remains valid comment evidence and is retained in JSON/issue reports, but it is not a producer frame interval. `COMMENT_REFERENCE_STRIP_UNAVAILABLE` refuses its CLI and browser batch strip exports before planning/render, independently of viewport side. No reference→producer time/index mapping occurs. Numeric producer/manual ranges remain unchanged; unavailable time-only ranges still refuse `COMMENT_CLOCK_UNAVAILABLE`.
|
package/docs/WORKFLOWS.md
CHANGED
|
@@ -345,6 +345,6 @@ Control capabilities are excluded from links and browser persistence.
|
|
|
345
345
|
|
|
346
346
|
## Comment on a detail
|
|
347
347
|
|
|
348
|
-
On the view you are inspecting, choose **Comment · C**, drag over the detail, type, and press Enter.
|
|
348
|
+
On the view you are inspecting, choose **Comment · C (n)**, drag over the detail (or click a point), type, and press Enter. Turning **Comment · C (n)** on enters comment mode and opens the comment list; turning it off or pressing Escape leaves both. Click a pin on the stage or a row in the list to restore its captured pose and open that comment in the same composer to edit or delete before submitting through the existing review flow (submitted marks open read-only, and under a capture refusal the button still opens the list read-only). No target, interval or category form is required. [Panel behavior](PANELS.md#stage-comments) explains pins, crop fitting and frame availability.
|
|
349
349
|
|
|
350
350
|
`rig-review feedback <input> --format json` and `--format issue` retain these comments in the existing feedback report. Compare uses the same A/B/reference/animation arguments as its open command. Each comment includes source hashes, viewport, frame basis, animation, `context.turn`, camera, screen/world region, nearest-first drawn slots, and crop path/SHA-256/dimensions. Derived CLI reports omit the inline PNG; the private draft and submitted session retain it. The CLI resolves the PNG's derived crop path under the review state directory so an agent can open it without a browser. Crop files are created on submission, outside the input package. Unsubmitted UI drafts stay local. No comment field or output byte is added to a review without comments.
|
package/package.json
CHANGED
|
@@ -28,7 +28,7 @@ every rule lives.
|
|
|
28
28
|
2. **Inspect, rebuild in scratch and submit (person in the browser):**
|
|
29
29
|
`rig-review` never opens a browser itself. Only the person holding the
|
|
30
30
|
`#cap=…` tab can inspect panels, run `Apply · Rebuild` through the installed
|
|
31
|
-
producer (`rig-parts`, `rig-pose`) into scratch,
|
|
31
|
+
producer (`rig-parts`, `rig-pose`) into scratch, place, read or edit **Comment · C (n)** crops,
|
|
32
32
|
choose **approved** or **changes-requested** in **Write review**, and click
|
|
33
33
|
**Submit review** — [Feedback ownership](https://github.com/rig-c/review/blob/main/docs/WORKFLOWS.md#feedback-ownership).
|
|
34
34
|
3. **Act on what comes back (agent):**
|
|
@@ -26,6 +26,7 @@ import {
|
|
|
26
26
|
type TrackClassification,
|
|
27
27
|
} from '../src/animation-ops.ts';
|
|
28
28
|
import type {AppliedAnimation} from '../src/applied-context.ts';
|
|
29
|
+
import {sourceTextContent} from './i18n.ts';
|
|
29
30
|
import type {AnimationSourceView} from './rebuild-client.ts';
|
|
30
31
|
import {InspectionSelection} from './inspection-selection.ts';
|
|
31
32
|
import {animationPreviewAdjust} from './preview.ts';
|
|
@@ -880,7 +881,7 @@ export class AnimationInspectionPanel {
|
|
|
880
881
|
this.renderTimeline();
|
|
881
882
|
this.renderChannels();
|
|
882
883
|
}
|
|
883
|
-
const curStatus=(this.editorStatus
|
|
884
|
+
const curStatus=sourceTextContent(this.editorStatus).trim();
|
|
884
885
|
if(applied){
|
|
885
886
|
if(restoredOutcome){
|
|
886
887
|
this.setEditorStatus(restoredOutcome.text,restoredOutcome.error);
|