rig-review 0.20.0 → 0.22.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +6 -2
- package/docs/ANIMATION_INSPECTION.md +1 -1
- package/docs/DESIGN.md +1 -1
- package/docs/PANELS.md +2 -2
- package/package.json +1 -1
- package/src/animation-ops.ts +522 -38
- package/src/applied-context.ts +6 -2
- package/src/compare-html.ts +5 -5
- package/src/rebuild.ts +110 -11
- package/web/animation-inspection.ts +2785 -42
- package/web/compare-picked-tools.ts +445 -155
- package/web/compare.css +86 -15
- package/web/compare.html +1 -1
- package/web/index.html +1 -1
- package/web/inspector-blocks.ts +22 -16
- package/web/main.ts +117 -9
- package/web/preview.ts +31 -0
- package/web/rebuild-client.ts +14 -6
- package/web/requirements-panel.ts +1 -1
- package/web/styles.css +95 -16
- package/web/workspace-preferences.ts +3 -2
- package/web/workspace-ui.ts +10 -9
package/README.md
CHANGED
|
@@ -1,3 +1,7 @@
|
|
|
1
|
+
<p align="center">
|
|
2
|
+
<img src="https://raw.githubusercontent.com/rig-c/review/main/assets/banner.svg" alt="@rig-c/review — Local human rig inspection, reference comparison and feedback export" width="100%" />
|
|
3
|
+
</p>
|
|
4
|
+
|
|
1
5
|
# review
|
|
2
6
|
|
|
3
7
|
A reusable local workspace for a person to inspect an agent's rig output, compare source references, and export feedback ready to become an issue. The person receives a package or opens an existing output folder; the agent does not build a new viewer for each rig.
|
|
@@ -11,8 +15,8 @@ The app provides one inspection workspace for setup geometry and motion, compile
|
|
|
11
15
|
[Play](https://github.com/rig-c/play) → **Adapter** (consumer integration).
|
|
12
16
|
|
|
13
17
|
Review is the human inspection and source-bound feedback gate in this delivery
|
|
14
|
-
flow. It inspects the upstream build without replacing Core's compiler gate
|
|
15
|
-
|
|
18
|
+
flow. It inspects the upstream build without replacing Core's compiler gate, and
|
|
19
|
+
its motion edits are data the installed producer builds in scratch. Review itself uses the published Play runtime for previews;
|
|
16
20
|
the chain describes delivery and feedback responsibilities, not runtime import
|
|
17
21
|
order. Adapter denotes downstream consumer integration, without depending on the
|
|
18
22
|
published adapters (`@rig-c/pixi`, `@rig-c/phaser`, `@rig-c/three`) or changing
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Read-only animation inspection
|
|
2
2
|
|
|
3
|
-
Animate → Transport offers a timeline, a stored-curve view and a bone tree for the current compiled build.
|
|
3
|
+
Animate → Transport offers a timeline, a stored-curve view and a bone tree for the current compiled build. The bone value tracks of `motion.animations_from` are editable (#235): an edit is a pending op, and Apply builds it through the installed producer into scratch. The package's files are never written. Two-build comparison is outside this feature.
|
|
4
4
|
|
|
5
5
|
The timeline lists bone groups followed by slot groups, one lane per stored timeline, with a mark per key including simultaneous keys. Key times remain exact seconds. Clicking a mark seeks through the existing transport; transport movement updates its playhead. No FPS is inferred. A selected bone filters its direct bone tracks; a selected slot filters that slot's tracks. Whole rig clears the filter.
|
|
6
6
|
|
package/docs/DESIGN.md
CHANGED
|
@@ -30,7 +30,7 @@ Edits reach the producer as data (issue #102): every edit card states its edit a
|
|
|
30
30
|
|
|
31
31
|
Physics tuning (#103) edits only what the handoff config declares: a constraint row is resolved by `name` (and kind) against the config, never by index alone, and every op records both the index (its pointer) and the name, which the server checks (`EDIT_PATCH_NAME_MISMATCH`). Rows the rig stage adds (the `turn` twins) have no config field and are shown not editable with the reason. An Apply reloads under the world it was pressed in so before and after are seen under one wind, gust and jolt state; review judges no value (a mass of 0 is rigc's `A23` to refuse). A build whose check FAILed may be loaded and looked at, but a review written on it is not submitted (`EDIT_SUBMIT_UNCHECKED`). Published Play 1.14.0 supplies the six-field live preview (#206): strength, damping, inertia, wind, gravity and mix use its public set/read/clear methods; mass and component toggles still require Apply. Slider input updates the pending override; the label distinguishes it from the last evaluated effective values. The next evaluation uses the patch; a paused page explicitly re-poses the held time without seeking. Clear removes overrides while preserving pending ops and integrated history, and authored values resume at the next evaluation; it does not undo the old trajectory. Apply and model replacement clear the preview. It is labelled "preview — Apply decides" and is never recorded as applied state. Play replays the current standing patch, not historical edits: backward seek recomputes with today's patch, and a newly opened track's first authored pose precedes its pending patch. The readout's BEFORE for the inspected build is that build's own check: once the baseline reproduces, `rig-parts check` runs on the baseline output (byte-identical to the inspected rig) in the background, and its summary is stored beside the baseline record.
|
|
32
32
|
|
|
33
|
-
The producer writes motion in scratch; review never
|
|
33
|
+
The producer writes motion in scratch; review never writes a source key. A timeline edit (#235) is a list of ops on a scratch copy of `motion.animations_from`, built by the installed producer. Idle tracks (#104) edit the idle the producer keys, never the package's motion.json: every edit is a config patch op at `/motion/tracks/<i>/…` or `/motion/blink/…`, and the producer (`retune` on parts 1.44.0+, else `rig --config`; then `check`) writes the keys. The panel offers only what the producer accepts where its rule is closed — a period is `motion.duration / n` (rig-parts `periodFits`: the duration over the period within 1e-9 of a whole number) — and pre-checks the pending idle under the producer's own names and words (`CONFIG_PERIOD_DIVIDES_DURATION`, `CONFIG_BONE_PROPERTY_KEYED_ONCE`, `CONFIG_NAME_RESOLVES`, `RIG_BLINK_INSIDE_IDLE`), so a refusal before Apply is the producer's line, and the producer judges again on Apply. The preview (decision on #104: allowed) drives the edited bones through play's `adjust` with the producer's sine `v(t) = base + amp·sin(2π(t/period − phase))` on the bone the inspected idle keys (`<bone>_ctl` under ctl keys, read off the handoff rig, never guessed: a property the idle does not key yet is refused by name, `IDLE_PREVIEW_TARGET_UNKNOWN`); it uses Play 1.14.0's `BoneAdjust` context `trackTime` through both composed adjustments, with no displayed player clock or seek-compensation re-pose. Bit-exact seek/continuous equivalence requires the unchanged patch, animation, environment, reset and step partition. It is labelled "preview — Apply decides", is cleared on Apply and Reset, and is never recorded or submitted. Blink edits are eased keys and are not previewed.
|
|
34
34
|
|
|
35
35
|
The Mesh panel (#106) edits one part's `meshes.<part>` entry as the producer's config loader reads it and rebuilds that part with `remesh --mesh`; it is a mesh-density and region editor for the producer's own parameters, not a mesher — review triangulates nothing, and the only geometry it writes is region points (whole rig px) and circle centres. The submitted patch is exactly one op, `replace /meshes/<part>`, so nothing else in the config can move with it. It offers the modes whose fields it draws (grid, contour); `influence` waits until the producer documents it in `remesh`. Its pre-check is the config loader's rules in the loader's names; what the rig stage measures (the keep-radius floor, bridges, heat sources, the remesh rules) is the producer's to say, and comes back verbatim. After a build, three counts must agree — `remesh.json`'s after-count, the revision model's triangles and what the overlay draws — and the panel names each, so an overlay still drawing the old mesh is visible as a disagreement, not hidden.
|
|
36
36
|
|
package/docs/PANELS.md
CHANGED
|
@@ -227,9 +227,9 @@ serving use per-port origins and keep them separate.
|
|
|
227
227
|
|
|
228
228
|
## Inspect animation keys
|
|
229
229
|
|
|
230
|
-
Animate
|
|
230
|
+
Animate keeps its timeline in a panel of its own beside the other blocks, with Timeline, Curves and Bone tree views of the build currently on stage. Bone value tracks of `motion.animations_from` are editable: an edit is a pending op, previewed on the stage, and **Apply · Rebuild** builds it through the installed producer into scratch; in a comparison session, switching to **Animate** edits and rebuilds only the picked side (**Editing Build A / Build B** via `/api/compare/a/rebuild` or `/api/compare/b/rebuild`) while keeping the other side's pose, pending ops, applied record and files untouched. Other tracks say why they are read-only. The timeline preserves every stored bone/slot track and key time; click a key to seek, Shift-click to add or remove editable keys from a multi-key selection, or box-drag across empty lane area to select editable keys across tracks (read-only tracks are skipped and named in the status bar, with zero browser text selection and an unshaded selection frame behind the keys). Dragging any selected key retimes the whole selection by the same delta as one undo step (`ANIMATION_KEY_ORDER`, `ANIMATION_KEY_TIME_INVALID` and `ANIMATION_OPS_TOO_MANY` refuse by name without writing), and **Delete** removes the selection as one undo step (`ANIMATION_TRACK_MIN_KEYS` refuses when fewer than two keys would remain on a track). Scrub the ruler or click an empty editable lane to move the playhead. Bone selection filters its direct tracks. Tree, Parts and stage selections stay synchronized; enable **Bone points** to pick or pose a bone on stage. Selecting a bone highlights all directly attached Parts rows without inventing a selected slot. With **Bone points** on, **Pose: Rotate** and **Pose: Move** (`Alt` during drag switches for that gesture) let you drag a bone handle on stage to set its `rotate` or `translate` key at the playhead—or insert and set a key at an unkeyed playhead as one undo step—inverting the parent bone's world matrix so a translated bone tracks the cursor whether its parent is rotated or not. When multiple bones share a stage point, the currently selected bone sits on top, followed by editable bones in clip track order above unkeyed or read-only bones, and clicking an overlapping point without dragging cycles through the overlapping editable bones. A bone without a matching source track (`ANIMATION_BONE_NO_TRACK`), driven by a physics/IK/transform constraint (`ANIMATION_BONE_CONSTRAINED`), or on a read-only track (`ANIMATION_TRACK_READ_ONLY`) refuses by name.
|
|
231
231
|
|
|
232
|
-
Curves show the compiled skeleton’s exact linear, stepped or cubic Bézier segments and stored handles. The separately labeled **Runtime evaluation** cursor/readout uses Play’s ten-piece Float32 interpolation, which can differ from the cubic. Its local value includes setup rotation/translation and scale multiplication, in stored timeline order, before constraints and previews. Rotation is unwrapped local degrees. **Inspect time** accepts exact seconds; frame labels require the existing explicit clock.
|
|
232
|
+
Curves show the compiled skeleton’s exact linear, stepped or cubic Bézier segments and stored handles. On an editable bone value track, **Segment** picks the outgoing key, **Mode** switches between linear, stepped and cubic Bézier, and dragging the two handles on the plot edits the segment’s `[cx1, cy1, cx2, cy2]` (`set_key_curve` / `set_key_ease` ops, coalesced on the same key and previewed live on the stage before **Apply · Rebuild**). The separately labeled **Runtime evaluation** cursor/readout uses Play’s ten-piece Float32 interpolation, which can differ from the cubic. Its local value includes setup rotation/translation and scale multiplication, in stored timeline order, before constraints and previews. Rotation is unwrapped local degrees. **Inspect time** accepts exact seconds; frame labels require the existing explicit clock. Nothing is written into the package. See [animation inspection](ANIMATION_INSPECTION.md) for the numeric validation and reproduction commands.
|
|
233
233
|
|
|
234
234
|
## Inspect a part
|
|
235
235
|
|