rhachet-roles-ehmpathy 1.15.2 → 1.15.4

package/dist/logic/roles/mechanic/.briefs/patterns/flow.refact.questions/best-practice/require.testchange.review.md

@@ -0,0 +1,33 @@
+if your refactor produces a change in behavior that was not explicitly asked for, it should always be questioned and reviewed with the asker
+
+if your refactor produces a change in behavior that was not explicitly asked for && requires the change of tests that covered the old behavior, this is an even bigger red flag, and should especially be questioned and reviewed with the asker
+
+---
+
+for example
+
+"ignore other files, only bootup briefs and skills"
+
+IF
+- the concept of "other files" is new since the last commit on main (i.e., its a staged or unstaged change, or committed on the branch but not main)
+- the fulfillment of that ask requries you to remove assertions against "bootup readme.md"
+
+THEN
+- should you just blindly remove the "bootup readme.md" behavior assertions from the test files to comply?
+- OR
+- should you just blindly assume that the user only meant the new changes?
+- OR
+- should you ask the caller to review the two options, since their requset might cause a change to new behavior
+
+?
+
+Ideally, ask the caller explicitly to clarify their request
+- did they mean to revert the new behavior but keep the old?
+- or
+- did they mean to revert the new behavior AND change to old?
+
+If you're unable to ask though, always assume they intended to preserve the old behavior when there is new behavior they could be asking about - unless they explicitly mentioned the old behavior with the same terms the test spoke about it with.
+
+---
+
+but never blindly degrade prior behavior without explicit confirmation

package/dist/logic/roles/mechanic/.skills/init.bhuild.sh

@@ -30,6 +30,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.bhuild.sh failed at line $LINENO" >&2' ERR
+
 # parse arguments
 BEHAVIOR_NAME=""
 TARGET_DIR="$PWD"

package/dist/logic/roles/mechanic/.skills/init.claude.hooks.cleanup.sh

@@ -22,6 +22,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.hooks.cleanup.sh failed at line $LINENO" >&2' ERR
+
 SKILLS_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 HOOKS_DIR="$SKILLS_DIR/claude.hooks"
 
@@ -38,7 +41,7 @@ fi
 STALE_COMMANDS=$(jq -r '
   .hooks // {} | to_entries[] |
   .value[] | .hooks[] | .command // empty
-' "$SETTINGS_FILE" 2>/dev/null | grep -E "claude\.hooks/" | while read -r cmd; do
+' "$SETTINGS_FILE" | { grep -E "claude\.hooks/" || true; } | while read -r cmd; do
   # Extract the path - it might be absolute or relative
   # Look for the claude.hooks/ part and check if the file exists
   if [[ "$cmd" == /* ]]; then

package/dist/logic/roles/mechanic/.skills/init.claude.hooks.findsert.sh

@@ -27,6 +27,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.hooks.findsert.sh failed at line $LINENO" >&2' ERR
+
 # Defaults
 HOOK_TYPE=""
 MATCHER=""

package/dist/logic/roles/mechanic/.skills/init.claude.hooks.sh

@@ -20,6 +20,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.hooks.sh failed at line $LINENO" >&2' ERR
+
 SKILLS_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 FINDSERT="$SKILLS_DIR/init.claude.hooks.findsert.sh"
 CLEANUP="$SKILLS_DIR/init.claude.hooks.cleanup.sh"

package/dist/logic/roles/mechanic/.skills/init.claude.permissions.jsonc

@@ -9,11 +9,20 @@
   "permissions": {
     // commands that should never be auto-approved
     "deny": [
-      // git write operations - require explicit user approval for audit trail
+      // git write operations - require explicit user request for audit trail
       "Bash(git commit:*)",
       "Bash(git add:*)",
       "Bash(git stash:*)",
       "Bash(git checkout:*)",
+      "Bash(git branch -d:*)",
+      "Bash(git branch -D:*)",
+      "Bash(git tag -d:*)",
+      "Bash(git remote add:*)",
+      "Bash(git remote remove:*)",
+      "Bash(git remote set-url:*)",
+      "Bash(git reflog expire:*)",
+      "Bash(git reflog delete:*)",
+      "Bash(git config:*)",
 
       // "anywrite" commands - CRITICAL SECURITY RISK
       //
@@ -118,9 +127,6 @@
       "WebFetch(domain:raw.githubusercontent.com)",
       "WebFetch(domain:biomejs.dev)",
 
-      // git read-only
-      "Bash(git log:*)",
-
       // filesystem read operations
       "Bash(ls:*)",
       "Bash(tree:*)",
@@ -139,6 +145,17 @@
       "Bash(git mv:*)",
       "Bash(git rm:*)",
 
+      // git read-only - all have no write variants
+      "Bash(git log:*)",
+      "Bash(git status:*)",
+      "Bash(git diff:*)",
+      "Bash(git show:*)",
+      "Bash(git blame:*)",
+      "Bash(git describe:*)",
+      "Bash(git ls-files:*)",
+      "Bash(git ls-tree:*)",
+      "Bash(git cat-file:*)",
+
       // sedreplace - safe bulk find-and-replace on git-tracked files only
       "Bash(bash .agent/repo=ehmpathy/role=mechanic/skills/.skills/claude.tools/sedreplace.sh:*)",
 

package/dist/logic/roles/mechanic/.skills/init.claude.permissions.sh

@@ -26,6 +26,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.permissions.sh failed at line $LINENO" >&2' ERR
+
 PROJECT_ROOT="$PWD"
 SETTINGS_FILE="$PROJECT_ROOT/.claude/settings.local.json"
 

package/dist/logic/roles/mechanic/.skills/init.claude.sh

@@ -20,6 +20,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.sh failed at line $LINENO" >&2' ERR
+
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 GITROOT="$(git rev-parse --show-toplevel)"
 SETTINGS_FILE="$GITROOT/.claude/settings.local.json"

package/package.json

@@ -2,7 +2,7 @@
   "name": "rhachet-roles-ehmpathy",
   "author": "ehmpathy",
   "description": "empathetic software construction roles and skills, via rhachet",
-  "version": "1.15.2",
+  "version": "1.15.4",
   "repository": "ehmpathy/rhachet-roles-ehmpathy",
   "homepage": "https://github.com/ehmpathy/rhachet-roles-ehmpathy",
   "keywords": [