rhachet-roles-ehmpathy 1.15.1 → 1.15.3

package/dist/logic/roles/mechanic/.briefs/patterns/flow.refact.questions/best-practice/require.testchange.review.md

@@ -0,0 +1,33 @@
+if your refactor produces a change in behavior that was not explicitly asked for, it should always be questioned and reviewed with the asker
+
+if your refactor produces a change in behavior that was not explicitly asked for && requires the change of tests that covered the old behavior, this is an even bigger red flag, and should especially be questioned and reviewed with the asker
+
+---
+
+for example
+
+"ignore other files, only bootup briefs and skills"
+
+IF
+- the concept of "other files" is new since the last commit on main (i.e., its a staged or unstaged change, or committed on the branch but not main)
+- the fulfillment of that ask requries you to remove assertions against "bootup readme.md"
+
+THEN
+- should you just blindly remove the "bootup readme.md" behavior assertions from the test files to comply?
+- OR
+- should you just blindly assume that the user only meant the new changes?
+- OR
+- should you ask the caller to review the two options, since their requset might cause a change to new behavior
+
+?
+
+Ideally, ask the caller explicitly to clarify their request
+- did they mean to revert the new behavior but keep the old?
+- or
+- did they mean to revert the new behavior AND change to old?
+
+If you're unable to ask though, always assume they intended to preserve the old behavior when there is new behavior they could be asking about - unless they explicitly mentioned the old behavior with the same terms the test spoke about it with.
+
+---
+
+but never blindly degrade prior behavior without explicit confirmation

package/dist/logic/roles/mechanic/.skills/claude.tools/sedreplace.sh

@@ -0,0 +1,135 @@
+#!/usr/bin/env bash
+######################################################################
+# .what = safe find-and-replace across git-tracked files only
+#
+# .why  = enables bulk text replacement without:
+#         - touching files outside the repo
+#         - modifying untracked files
+#         - accidental command chaining attacks
+#
+#         this is a controlled alternative to raw sed, which is
+#         denied in permissions due to security risks.
+#
+# usage:
+#   sedreplace.sh --old "pattern" --new "replacement"              # dry-run
+#   sedreplace.sh --old "pattern" --new "replacement" --execute    # apply
+#   sedreplace.sh --old "pattern" --new "replacement" --glob "*.ts"  # filter
+#
+# guarantee:
+#   - only operates on git-tracked files (git ls-files)
+#   - dry-run by default (shows diff, no changes)
+#   - requires --execute to apply changes
+#   - fail-fast on errors
+######################################################################
+set -euo pipefail
+
+# parse named arguments
+OLD_PATTERN=""
+NEW_PATTERN=""
+GLOB_FILTER=""
+EXECUTE=false
+
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    --old)
+      OLD_PATTERN="$2"
+      shift 2
+      ;;
+    --new)
+      NEW_PATTERN="$2"
+      shift 2
+      ;;
+    --glob)
+      GLOB_FILTER="$2"
+      shift 2
+      ;;
+    --execute)
+      EXECUTE=true
+      shift
+      ;;
+    *)
+      echo "unknown argument: $1"
+      echo "usage: sedreplace.sh --old 'pattern' --new 'replacement' [--glob '*.ts'] [--execute]"
+      exit 1
+      ;;
+  esac
+done
+
+# validate required args
+if [[ -z "$OLD_PATTERN" ]]; then
+  echo "error: --old pattern is required"
+  exit 1
+fi
+
+if [[ -z "$NEW_PATTERN" ]]; then
+  echo "error: --new replacement is required"
+  exit 1
+fi
+
+# ensure we're in a git repo
+if ! git rev-parse --git-dir > /dev/null 2>&1; then
+  echo "error: not in a git repository"
+  exit 1
+fi
+
+# get git-tracked files, optionally filtered by glob
+if [[ -n "$GLOB_FILTER" ]]; then
+  FILES=$(git ls-files "$GLOB_FILTER")
+else
+  FILES=$(git ls-files)
+fi
+
+if [[ -z "$FILES" ]]; then
+  echo "no files match the criteria"
+  exit 0
+fi
+
+# find files containing the pattern
+MATCHING_FILES=$(echo "$FILES" | xargs grep -l "$OLD_PATTERN" 2>/dev/null || true)
+
+if [[ -z "$MATCHING_FILES" ]]; then
+  echo "no files contain pattern: $OLD_PATTERN"
+  exit 0
+fi
+
+# count matches
+MATCH_COUNT=$(echo "$MATCHING_FILES" | wc -l)
+echo "found $MATCH_COUNT file(s) containing pattern"
+echo ""
+
+if [[ "$EXECUTE" == "false" ]]; then
+  # dry-run: show what would change
+  echo "=== DRY RUN (use --execute to apply) ==="
+  echo ""
+
+  for file in $MATCHING_FILES; do
+    echo "--- $file ---"
+    # show the diff that would result
+    sed "s|$OLD_PATTERN|$NEW_PATTERN|g" "$file" | diff -u "$file" - || true
+    echo ""
+  done
+
+  echo "=== END DRY RUN ==="
+  echo ""
+  echo "to apply changes, run with --execute flag"
+else
+  # execute: apply changes
+  echo "=== APPLYING CHANGES ==="
+  echo ""
+
+  for file in $MATCHING_FILES; do
+    echo "updating: $file"
+    # use sed -i for in-place editing
+    # note: macOS sed requires -i '' but linux sed uses -i
+    if [[ "$(uname)" == "Darwin" ]]; then
+      sed -i '' "s|$OLD_PATTERN|$NEW_PATTERN|g" "$file"
+    else
+      sed -i "s|$OLD_PATTERN|$NEW_PATTERN|g" "$file"
+    fi
+  done
+
+  echo ""
+  echo "=== DONE: updated $MATCH_COUNT file(s) ==="
+  echo ""
+  echo "to undo: git checkout ."
+fi

package/dist/logic/roles/mechanic/.skills/init.bhuild.sh

@@ -30,6 +30,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.bhuild.sh failed at line $LINENO" >&2' ERR
+
 # parse arguments
 BEHAVIOR_NAME=""
 TARGET_DIR="$PWD"

package/dist/logic/roles/mechanic/.skills/init.claude.hooks.cleanup.sh

@@ -22,6 +22,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.hooks.cleanup.sh failed at line $LINENO" >&2' ERR
+
 SKILLS_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 HOOKS_DIR="$SKILLS_DIR/claude.hooks"
 
@@ -38,7 +41,7 @@ fi
 STALE_COMMANDS=$(jq -r '
   .hooks // {} | to_entries[] |
   .value[] | .hooks[] | .command // empty
-' "$SETTINGS_FILE" 2>/dev/null | grep -E "claude\.hooks/" | while read -r cmd; do
+' "$SETTINGS_FILE" | { grep -E "claude\.hooks/" || true; } | while read -r cmd; do
   # Extract the path - it might be absolute or relative
   # Look for the claude.hooks/ part and check if the file exists
   if [[ "$cmd" == /* ]]; then

package/dist/logic/roles/mechanic/.skills/init.claude.hooks.findsert.sh

@@ -27,6 +27,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.hooks.findsert.sh failed at line $LINENO" >&2' ERR
+
 # Defaults
 HOOK_TYPE=""
 MATCHER=""

package/dist/logic/roles/mechanic/.skills/init.claude.hooks.sh

@@ -20,6 +20,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.hooks.sh failed at line $LINENO" >&2' ERR
+
 SKILLS_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 FINDSERT="$SKILLS_DIR/init.claude.hooks.findsert.sh"
 CLEANUP="$SKILLS_DIR/init.claude.hooks.cleanup.sh"

package/dist/logic/roles/mechanic/.skills/init.claude.permissions.jsonc

@@ -139,6 +139,9 @@
       "Bash(git mv:*)",
       "Bash(git rm:*)",
 
+      // sedreplace - safe bulk find-and-replace on git-tracked files only
+      "Bash(bash .agent/repo=ehmpathy/role=mechanic/skills/.skills/claude.tools/sedreplace.sh:*)",
+
       // npm read operations
       "Bash(npm view:*)",
       "Bash(npm list:*)",

package/dist/logic/roles/mechanic/.skills/init.claude.permissions.sh

@@ -26,6 +26,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.permissions.sh failed at line $LINENO" >&2' ERR
+
 PROJECT_ROOT="$PWD"
 SETTINGS_FILE="$PROJECT_ROOT/.claude/settings.local.json"
 

package/dist/logic/roles/mechanic/.skills/init.claude.sh

@@ -20,6 +20,9 @@
 
 set -euo pipefail
 
+# fail loud: print what failed
+trap 'echo "❌ init.claude.sh failed at line $LINENO" >&2' ERR
+
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
 GITROOT="$(git rev-parse --show-toplevel)"
 SETTINGS_FILE="$GITROOT/.claude/settings.local.json"

package/package.json

@@ -2,7 +2,7 @@
   "name": "rhachet-roles-ehmpathy",
   "author": "ehmpathy",
   "description": "empathetic software construction roles and skills, via rhachet",
-  "version": "1.15.1",
+  "version": "1.15.3",
   "repository": "ehmpathy/rhachet-roles-ehmpathy",
   "homepage": "https://github.com/ehmpathy/rhachet-roles-ehmpathy",
   "keywords": [