rhachet-roles-bhuild 0.18.1 → 0.19.0

package/dist/domain.operations/behavior/init/templates/3.3.1.blueprint.product.guard.heavy

@@ -254,7 +254,72 @@ reviews:
 
         fix all gaps before you continue.
 
-    # 12. consistent mechanisms
+    # 12. journey acceptance test
+    - slug: has-journey-acceptance-test
+      say: |
+        review that the blueprint declares a journey acceptance test.
+
+        a journey acceptance test exercises a complete, realistic user journey
+        through multiple timesteps — not isolated unit tests, but an exhaustive
+        end-to-end flow that exercises real-world usage.
+
+        ## what a journey test must include
+
+        | requirement | description |
+        |-------------|-------------|
+        | multiple timesteps | [t0], [t1], [t2]... through the complete journey |
+        | realistic scenario | exercises actual user workflow, not contrived examples |
+        | edge cases along the way | blocked states, error paths, recovery flows |
+        | snapshots at checkpoints | visual diff at each significant state change |
+        | final state verification | journey ends with expected outcome verified |
+
+        ## pattern
+
+        ```typescript
+        describe('feature.journey', () => {
+          given('[case1] complete user journey', () => {
+            when('[t0] initial state', () => {
+              then('preconditions hold', () => { ... });
+            });
+
+            when('[t1] first action', () => {
+              then('state transitions correctly', () => {
+                expect(result).toMatchSnapshot();
+              });
+            });
+
+            when('[t2] blocked scenario', () => {
+              then('error is surfaced with helpful message', () => {
+                expect(error).toMatchSnapshot();
+              });
+            });
+
+            // ... more timesteps through the journey ...
+
+            when('[tN] journey complete', () => {
+              then('final state is correct', () => {
+                expect(finalState).toMatchSnapshot();
+              });
+            });
+          });
+        });
+        ```
+
+        ## ask for the blueprint
+
+        - does the blueprint declare a journey acceptance test?
+        - does the journey exercise a realistic user workflow?
+        - does the journey include multiple timesteps (not just t0)?
+        - does the journey cover blocked/error states along the way?
+        - does the journey snapshot at each significant checkpoint?
+        - does the journey verify the final expected outcome?
+
+        a blueprint without a journey test is incomplete. the journey test is
+        how we verify the feature works as a whole, not just in isolation.
+
+        fix all gaps before you continue.
+
+    # 13. consistent mechanisms
     - slug: has-consistent-mechanisms
       say: |
         review for new mechanisms that duplicate extant functionality.
@@ -273,7 +338,7 @@ reviews:
         1. replace with the extant mechanism
         2. or flag as an open question if unsure
 
-    # 13. consistent conventions
+    # 14. consistent conventions
     - slug: has-consistent-conventions
       say: |
         review for divergence from extant names and patterns.
@@ -293,7 +358,7 @@ reviews:
         1. align with the extant convention
         2. or flag as an open question if the extant convention seems wrong
 
-    # 14. directory decomposition
+    # 15. directory decomposition
     - slug: has-proper-directory-decomposition
       say: |
         review that directories follow the layered decomposition pattern and
@@ -373,7 +438,7 @@ reviews:
 
         fix all directory placement issues before you continue.
 
-    # 15. behavior coverage
+    # 16. behavior coverage
     - slug: has-behavior-declaration-coverage
       say: |
         review for coverage of the behavior declaration.
@@ -390,7 +455,7 @@ reviews:
 
         fix all gaps before you continue.
 
-    # 16. behavior adherance
+    # 17. behavior adherance
     - slug: has-behavior-declaration-adherance
       say: |
         review for adherance to the behavior declaration.
@@ -407,7 +472,7 @@ reviews:
 
         fix all gaps before you continue.
 
-    # 17. standards adherance
+    # 18. standards adherance
     - slug: has-role-standards-adherance
       say: |
         review for adherance to mechanic role standards.
@@ -427,7 +492,7 @@ reviews:
 
         fix all gaps before you continue.
 
-    # 18. standards coverage
+    # 19. standards coverage
     - slug: has-role-standards-coverage
       say: |
         review for coverage of mechanic role standards.
@@ -449,6 +514,8 @@ reviews:
 
   peer:
     - npx rhachet run --repo bhrain --skill review --rules '.agent/repo=ehmpathy/role=mechanic/briefs/practices/code.{prod,test}/pitofsuccess.errors/rule.*.md' --diffs since-main --paths-with '$route/3.3.blueprint.*.md' --join intersect --output '$route/.reviews/$stone.peer-review.failhides.md' --mode hard
+    - npx rhachet enroll claude --roles architect,mechanic -p "review the blueprint at $route/$stone.md for architectural gaps and defects. emit BLOCKERS and NITPICKS."
+    - npx rhachet enroll claude --roles architect,mechanic -p "review diff for architectural scope leak, decompose to reuse opportunities, and other arch smells. emit BLOCKERS and NITPICKS."
 
 judges:
   - npx rhachet run --repo bhrain --skill route.stone.judge --mechanism reviewed? --stone $stone --route $route --allow-blockers 0 --allow-nitpicks 3

package/dist/domain.operations/behavior/init/templates/3.3.1.blueprint.product.guard.light

@@ -202,7 +202,72 @@ reviews:
 
         fix all gaps before you continue.
 
-    # 8. consistent mechanisms
+    # 8. journey acceptance test
+    - slug: has-journey-acceptance-test
+      say: |
+        review that the blueprint declares a journey acceptance test.
+
+        a journey acceptance test exercises a complete, realistic user journey
+        through multiple timesteps — not isolated unit tests, but an exhaustive
+        end-to-end flow that exercises real-world usage.
+
+        ## what a journey test must include
+
+        | requirement | description |
+        |-------------|-------------|
+        | multiple timesteps | [t0], [t1], [t2]... through the complete journey |
+        | realistic scenario | exercises actual user workflow, not contrived examples |
+        | edge cases along the way | blocked states, error paths, recovery flows |
+        | snapshots at checkpoints | visual diff at each significant state change |
+        | final state verification | journey ends with expected outcome verified |
+
+        ## pattern
+
+        ```typescript
+        describe('feature.journey', () => {
+          given('[case1] complete user journey', () => {
+            when('[t0] initial state', () => {
+              then('preconditions hold', () => { ... });
+            });
+
+            when('[t1] first action', () => {
+              then('state transitions correctly', () => {
+                expect(result).toMatchSnapshot();
+              });
+            });
+
+            when('[t2] blocked scenario', () => {
+              then('error is surfaced with helpful message', () => {
+                expect(error).toMatchSnapshot();
+              });
+            });
+
+            // ... more timesteps through the journey ...
+
+            when('[tN] journey complete', () => {
+              then('final state is correct', () => {
+                expect(finalState).toMatchSnapshot();
+              });
+            });
+          });
+        });
+        ```
+
+        ## ask for the blueprint
+
+        - does the blueprint declare a journey acceptance test?
+        - does the journey exercise a realistic user workflow?
+        - does the journey include multiple timesteps (not just t0)?
+        - does the journey cover blocked/error states along the way?
+        - does the journey snapshot at each significant checkpoint?
+        - does the journey verify the final expected outcome?
+
+        a blueprint without a journey test is incomplete. the journey test is
+        how we verify the feature works as a whole, not just in isolation.
+
+        fix all gaps before you continue.
+
+    # 9. consistent mechanisms
     - slug: has-consistent-mechanisms
       say: |
         review for new mechanisms that duplicate extant functionality.
@@ -221,7 +286,7 @@ reviews:
         1. replace with the extant mechanism
         2. or flag as an open question if unsure
 
-    # 9. consistent conventions
+    # 10. consistent conventions
     - slug: has-consistent-conventions
       say: |
         review for divergence from extant names and patterns.
@@ -241,7 +306,7 @@ reviews:
         1. align with the extant convention
         2. or flag as an open question if the extant convention seems wrong
 
-    # 10. directory decomposition
+    # 11. directory decomposition
     - slug: has-proper-directory-decomposition
       say: |
         review that directories follow the layered decomposition pattern and
@@ -321,7 +386,7 @@ reviews:
 
         fix all directory placement issues before you continue.
 
-    # 11. behavior coverage
+    # 12. behavior coverage
     - slug: has-behavior-declaration-coverage
       say: |
         review for coverage of the behavior declaration.
@@ -338,7 +403,7 @@ reviews:
 
         fix all gaps before you continue.
 
-    # 12. behavior adherance
+    # 13. behavior adherance
     - slug: has-behavior-declaration-adherance
       say: |
         review for adherance to the behavior declaration.
@@ -355,7 +420,7 @@ reviews:
 
         fix all gaps before you continue.
 
-    # 13. standards adherance
+    # 14. standards adherance
     - slug: has-role-standards-adherance
       say: |
         review for adherance to mechanic role standards.
@@ -375,7 +440,7 @@ reviews:
 
         fix all gaps before you continue.
 
-    # 14. standards coverage
+    # 15. standards coverage
     - slug: has-role-standards-coverage
       say: |
         review for coverage of mechanic role standards.
@@ -397,6 +462,8 @@ reviews:
 
   peer:
     - npx rhachet run --repo bhrain --skill review --rules '.agent/repo=ehmpathy/role=mechanic/briefs/practices/code.{prod,test}/pitofsuccess.errors/rule.*.md' --diffs since-main --paths-with '$route/3.3.blueprint.*.md' --join intersect --output '$route/.reviews/$stone.peer-review.failhides.md' --mode hard
+    - npx rhachet enroll claude --roles architect,mechanic -p "review the blueprint at $route/$stone.md for architectural gaps and defects. emit BLOCKERS and NITPICKS."
+    - npx rhachet enroll claude --roles architect,mechanic -p "review diff for architectural scope leak, decompose to reuse opportunities, and other arch smells. emit BLOCKERS and NITPICKS."
 
 judges:
   - npx rhachet run --repo bhrain --skill route.stone.judge --mechanism reviewed? --stone $stone --route $route --allow-blockers 0 --allow-nitpicks 3

package/package.json

@@ -2,7 +2,7 @@
   "name": "rhachet-roles-bhuild",
   "author": "ehmpathy",
   "description": "roles for building resilient systems, via rhachet",
-  "version": "0.18.1",
+  "version": "0.19.0",
   "repository": "ehmpathy/rhachet-roles-bhuild",
   "homepage": "https://github.com/ehmpathy/rhachet-roles-bhuild",
   "keywords": [