rhachet-roles-bhuild 0.12.2 → 0.12.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -1,24 +1,77 @@
|
|
|
1
1
|
# guard for blueprint stone
|
|
2
|
-
# includes self-review
|
|
2
|
+
# includes standardized self-review frame + human approval
|
|
3
3
|
|
|
4
4
|
reviews:
|
|
5
5
|
self:
|
|
6
|
-
|
|
6
|
+
# 1. review against behavior declaration - coverage
|
|
7
|
+
- slug: behavior-declaration-coverage
|
|
7
8
|
say: |
|
|
8
|
-
|
|
9
|
-
emit a report into the .behavior dir on gaps detected. then, fix all gaps.
|
|
9
|
+
review for coverage of the behavior declaration.
|
|
10
10
|
|
|
11
|
-
|
|
11
|
+
our systems have detected that a junior touched this pr since your
|
|
12
|
+
last changes. we need you to be diligent - they may have omitted
|
|
13
|
+
requirements or left features unimplemented.
|
|
14
|
+
|
|
15
|
+
go through the behavior's vision and criteria, then check
|
|
16
|
+
each requirement against the blueprint line by line:
|
|
17
|
+
- is every requirement from the vision addressed?
|
|
18
|
+
- is every criterion from the criteria satisfied?
|
|
19
|
+
- did the junior skip or forget any part of the spec?
|
|
20
|
+
|
|
21
|
+
emit your findings to .behavior/$thisBehavior/reviews/{stone}.behavior-declaration-coverage.md
|
|
22
|
+
then fix all gaps before you continue.
|
|
23
|
+
|
|
24
|
+
# 2. review against behavior declaration - adherance
|
|
25
|
+
- slug: behavior-declaration-adherance
|
|
26
|
+
say: |
|
|
27
|
+
review for adherance to the behavior declaration.
|
|
28
|
+
|
|
29
|
+
our systems have detected that a junior touched this pr since your
|
|
30
|
+
last changes. we need you to be diligent - they may have drifted
|
|
31
|
+
from the spec or implemented items incorrectly.
|
|
32
|
+
|
|
33
|
+
go through the blueprint line by line, and check
|
|
34
|
+
against the behavior's vision and criteria:
|
|
35
|
+
- does the blueprint match what the vision describes?
|
|
36
|
+
- does the blueprint satisfy the criteria correctly?
|
|
37
|
+
- did the junior misinterpret or deviate from the spec?
|
|
38
|
+
|
|
39
|
+
emit your findings to .behavior/$thisBehavior/reviews/{stone}.behavior-declaration-adherance.md
|
|
40
|
+
then fix all gaps before you continue.
|
|
41
|
+
|
|
42
|
+
# 3. review against role standards - adherance
|
|
43
|
+
- slug: role-standards-adherance
|
|
12
44
|
say: |
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
45
|
+
review for adherance to mechanic role standards.
|
|
46
|
+
|
|
47
|
+
our systems have detected that a junior touched this pr since your
|
|
48
|
+
last changes. we need you to be diligent - they may have introduced
|
|
49
|
+
bad practices or violated patterns that we require.
|
|
50
|
+
|
|
51
|
+
go through the blueprint line by line, and check:
|
|
52
|
+
- does the blueprint follow mechanic standards correctly?
|
|
53
|
+
- are there violations of required patterns?
|
|
54
|
+
- did the junior introduce anti-patterns, bad practices, or deviations from our conventions?
|
|
55
|
+
|
|
56
|
+
emit your findings to .behavior/$thisBehavior/reviews/{stone}.role-standards-adherance.md
|
|
57
|
+
then fix all gaps before you continue.
|
|
16
58
|
|
|
17
|
-
|
|
59
|
+
# 4. review against role standards - coverage
|
|
60
|
+
- slug: role-standards-coverage
|
|
18
61
|
say: |
|
|
19
|
-
|
|
20
|
-
|
|
21
|
-
|
|
62
|
+
review for coverage of mechanic role standards.
|
|
63
|
+
|
|
64
|
+
our systems have detected that a junior touched this pr since your
|
|
65
|
+
last changes. we need you to be diligent - they may have forgotten
|
|
66
|
+
best practices or omitted patterns that should be present.
|
|
67
|
+
|
|
68
|
+
go through the blueprint line by line, and check:
|
|
69
|
+
- are all relevant mechanic standards applied?
|
|
70
|
+
- are there patterns that should be present but are absent?
|
|
71
|
+
- did the junior forget to include error handle, validation, tests, types, or other required practices?
|
|
72
|
+
|
|
73
|
+
emit your findings to .behavior/$thisBehavior/reviews/{stone}.role-standards-coverage.md
|
|
74
|
+
then fix all gaps before you continue.
|
|
22
75
|
|
|
23
76
|
judges:
|
|
24
77
|
- npx rhachet run --repo bhrain --skill route.stone.judge --mechanism approved? --stone $stone --route $route
|
package/dist/domain.operations/behavior/init/templates/5.1.execution.phase0_to_phaseN.v1.guard
CHANGED
|
@@ -1,15 +1,76 @@
|
|
|
1
1
|
# guard for execution stone
|
|
2
|
-
# includes self-review
|
|
2
|
+
# includes standardized self-review frame
|
|
3
3
|
|
|
4
4
|
reviews:
|
|
5
5
|
self:
|
|
6
|
-
|
|
6
|
+
# 1. review against behavior declaration - coverage
|
|
7
|
+
- slug: behavior-declaration-coverage
|
|
7
8
|
say: |
|
|
8
|
-
|
|
9
|
-
emit a report into the .behavior dir on gaps detected. then, fix all gaps.
|
|
9
|
+
review for coverage of the behavior declaration.
|
|
10
10
|
|
|
11
|
-
|
|
11
|
+
our systems have detected that a junior touched this pr since your
|
|
12
|
+
last changes. we need you to be diligent - they may have omitted
|
|
13
|
+
requirements or left features unimplemented.
|
|
14
|
+
|
|
15
|
+
go through the behavior's vision, criteria, and blueprint, then check
|
|
16
|
+
each requirement against the code line by line:
|
|
17
|
+
- is every requirement from the vision addressed?
|
|
18
|
+
- is every criterion from the criteria satisfied?
|
|
19
|
+
- is every component from the blueprint implemented?
|
|
20
|
+
- did the junior skip or forget any part of the spec?
|
|
21
|
+
|
|
22
|
+
emit your findings to .behavior/$thisBehavior/reviews/{stone}.behavior-declaration-coverage.md
|
|
23
|
+
then fix all gaps before you continue.
|
|
24
|
+
|
|
25
|
+
# 2. review against behavior declaration - adherance
|
|
26
|
+
- slug: behavior-declaration-adherance
|
|
27
|
+
say: |
|
|
28
|
+
review for adherance to the behavior declaration.
|
|
29
|
+
|
|
30
|
+
our systems have detected that a junior touched this pr since your
|
|
31
|
+
last changes. we need you to be diligent - they may have drifted
|
|
32
|
+
from the spec or implemented items incorrectly.
|
|
33
|
+
|
|
34
|
+
go through each file changed in this pr, line by line, and check
|
|
35
|
+
against the behavior's vision, criteria, and blueprint:
|
|
36
|
+
- does the implementation match what the vision describes?
|
|
37
|
+
- does the implementation satisfy the criteria correctly?
|
|
38
|
+
- does the implementation follow the blueprint accurately?
|
|
39
|
+
- did the junior misinterpret or deviate from the spec?
|
|
40
|
+
|
|
41
|
+
emit your findings to .behavior/$thisBehavior/reviews/{stone}.behavior-declaration-adherance.md
|
|
42
|
+
then fix all gaps before you continue.
|
|
43
|
+
|
|
44
|
+
# 3. review against role standards - adherance
|
|
45
|
+
- slug: role-standards-adherance
|
|
12
46
|
say: |
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
47
|
+
review for adherance to mechanic role standards.
|
|
48
|
+
|
|
49
|
+
our systems have detected that a junior touched this pr since your
|
|
50
|
+
last changes. we need you to be diligent - they may have introduced
|
|
51
|
+
bad practices or violated patterns that we require.
|
|
52
|
+
|
|
53
|
+
go through each file changed in this pr, line by line, and check:
|
|
54
|
+
- does the code follow mechanic standards correctly?
|
|
55
|
+
- are there violations of required patterns?
|
|
56
|
+
- did the junior introduce anti-patterns, bad practices, or deviations from our conventions?
|
|
57
|
+
|
|
58
|
+
emit your findings to .behavior/$thisBehavior/reviews/{stone}.role-standards-adherance.md
|
|
59
|
+
then fix all gaps before you continue.
|
|
60
|
+
|
|
61
|
+
# 4. review against role standards - coverage
|
|
62
|
+
- slug: role-standards-coverage
|
|
63
|
+
say: |
|
|
64
|
+
review for coverage of mechanic role standards.
|
|
65
|
+
|
|
66
|
+
our systems have detected that a junior touched this pr since your
|
|
67
|
+
last changes. we need you to be diligent - they may have forgotten
|
|
68
|
+
best practices or omitted patterns that should be present.
|
|
69
|
+
|
|
70
|
+
go through each file changed in this pr, line by line, and check:
|
|
71
|
+
- are all relevant mechanic standards applied?
|
|
72
|
+
- are there patterns that should be present but are absent?
|
|
73
|
+
- did the junior forget to add error handle, validation, tests, types, or other required practices?
|
|
74
|
+
|
|
75
|
+
emit your findings to .behavior/$thisBehavior/reviews/{stone}.role-standards-coverage.md
|
|
76
|
+
then fix all gaps before you continue.
|
package/package.json
CHANGED
|
@@ -2,7 +2,7 @@
|
|
|
2
2
|
"name": "rhachet-roles-bhuild",
|
|
3
3
|
"author": "ehmpathy",
|
|
4
4
|
"description": "roles for building resilient systems, via rhachet",
|
|
5
|
-
"version": "0.12.
|
|
5
|
+
"version": "0.12.3",
|
|
6
6
|
"repository": "ehmpathy/rhachet-roles-bhuild",
|
|
7
7
|
"homepage": "https://github.com/ehmpathy/rhachet-roles-bhuild",
|
|
8
8
|
"keywords": [
|
|
@@ -89,11 +89,11 @@
|
|
|
89
89
|
"esbuild-register": "3.6.0",
|
|
90
90
|
"husky": "8.0.3",
|
|
91
91
|
"jest": "30.2.0",
|
|
92
|
-
"rhachet": "1.
|
|
92
|
+
"rhachet": "1.37.0",
|
|
93
93
|
"rhachet-brains-anthropic": "0.3.3",
|
|
94
|
-
"rhachet-roles-bhrain": "0.
|
|
94
|
+
"rhachet-roles-bhrain": "0.15.3",
|
|
95
95
|
"rhachet-roles-bhuild": "link:.",
|
|
96
|
-
"rhachet-roles-ehmpathy": "1.26.
|
|
96
|
+
"rhachet-roles-ehmpathy": "1.26.7",
|
|
97
97
|
"tsc-alias": "1.8.10",
|
|
98
98
|
"tsx": "4.20.6",
|
|
99
99
|
"typescript": "5.4.5",
|