rez_core 2.1.70 → 2.1.71

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "rez_core",
-  "version": "2.1.70",
+  "version": "2.1.71",
   "description": "",
   "author": "", 
   "private": false,

package/src/module/listmaster/service/list-master-item.service.ts

@@ -61,54 +61,93 @@ export class ListMasterItemService {
   ): Promise<any> {
     const orgId = loggedInUser.organization_id;
 
-    for (const item of items) {
+    const errors: any[] = [];
+
+    for (let i = 0; i < items.length; i++) {
+      const item = items[i];
       const name = item.name?.trim();
       const code = item.code?.trim();
 
-      if (!name) {
-        throw new BadRequestException('Name is required and cannot be empty');
-      }
-
-      let existingItem;
+      try {
+        if (!name) {
+          throw new BadRequestException(`name is missing at index ${i}`);
+        }
 
-      // Priority: lookup by code + name
-      if (code) {
-        existingItem = await this.listItemsRepo.findOneByCondition({
-          code,
+        if (code) {
+          // Check if code exists
+          const existingItem = await this.listItemsRepo.findOneByCondition({
+            code,
+            listtype: listType,
+            organization_id: orgId,
+          });
+
+          if (existingItem) {
+            // It's an update — check if name is changing to a used name
+            if (existingItem.name.toLowerCase() !== name.toLowerCase()) {
+              const nameExists = await this.listItemsRepo.findOneByCondition({
+                name,
+                listtype: listType,
+                organization_id: orgId,
+              });
+
+              if (nameExists && nameExists.id !== existingItem.id) {
+                throw new BadRequestException(
+                  `${name} already used by another item`,
+                );
+              }
+            }
+
+            // Update the existing item
+            await this.updateEntity(
+              {
+                ...existingItem,
+                ...item,
+                name,
+                listtype: listType,
+              },
+              loggedInUser,
+            );
+
+            continue;
+          }
+        }
+
+        // Creation path
+        const nameExists = await this.listItemsRepo.findOneByCondition({
           name,
           listtype: listType,
           organization_id: orgId,
         });
-      }
 
-      // Fallback: lookup by name only if not found above
-      if (!existingItem) {
-        existingItem = await this.listItemsRepo.findOneByCondition({
-          name,
-          listtype: listType,
-          organization_id: orgId,
-        });
-      }
+        if (nameExists) {
+          throw new BadRequestException(
+            `list item with name ${name} already exists`,
+          );
+        }
+
+        const finalCode = code || ''; // Could generate code here if needed
 
-      if (existingItem) {
-        await this.updateEntity(
-          {
-            ...existingItem,
-            ...item,
-            listtype: listType,
-          },
-          loggedInUser,
-        );
-      } else {
         await this.createEntity(
           {
             ...item,
-            listtype: listType,
             name,
+            code: finalCode,
+            listtype: listType,
             value: '',
           },
           loggedInUser,
         );
+      } catch (error) {
+        errors.push({
+          row: i,
+          error: [
+            {
+              field: 'name',
+              message:
+                error.message || 'An error occurred while processing the item',
+            },
+          ],
+        });
       }
     }
 
@@ -119,7 +158,9 @@ export class ListMasterItemService {
     );
 
     return {
+      success: errors.length === 0,
       listType,
+      errors,
       items: updatedItems,
     };
   }