revspec 0.4.0 → 0.6.0

package/CLAUDE.md

@@ -3,7 +3,9 @@
 - Tech: Bun + TypeScript + @opentui/core
 - npm: `revspec` | GitHub: icyrainz/revspec
 - Run: `bun run bin/revspec.ts <file.md>`
-- Test: `bun test`
+- Test: `bun run test` (~3s, excludes E2E)
+- E2E: `bun run test:e2e` (~25s, bun-pty snapshots — only run before release, update with `--update-snapshots`)
+- All: `bun run test:all` (everything)
 - Release: `./scripts/release.sh` (version is set manually in package.json)
 - Dev: `bun link` to symlink local build to global `revspec` command
 

package/README.md

@@ -29,28 +29,56 @@ revspec spec.md
 
 Opens a TUI in line mode with vim-style navigation. Press `c` on any line to open a thread and start commenting.
 
+### Markdown rendering
+
+Revspec renders markdown in-place (toggle with `m`):
+
+- **Headings** — colored and bold, `#`–`######`
+- **Inline** — bold (`**`/`__`), italic (`*`/`_`), bold-italic (`***`), strikethrough (`~~`), `code`, [links](url)
+- **Fenced code blocks** — ` ``` ` markers dimmed, body in green
+- **Tables** — box-drawing borders, header row bolded, auto-column-widths
+- **Lists** — unordered (`•`), ordered, task lists (`☐`/`☑`)
+- **Blockquotes** — bar gutter, italicized text
+- **Cursor line** highlighting across all elements
+- **Search highlights** — colored match segments
+
 ### Keybindings
 
+**Navigation**
+
 | Key | Action |
 |-----|--------|
 | `j/k` | Move cursor down/up |
 | `gg` / `G` | Go to top / bottom |
 | `Ctrl+D/U` | Half page down/up |
-| `m` | Toggle markdown / line mode |
-| `c` | Open thread / comment on line |
-| `r` | Resolve thread (toggle) |
-| `R` | Resolve all pending |
-| `dd` | Delete draft comment (double-tap) |
-| `/` | Search |
+| `zz` | Center cursor line in viewport |
+| `/` | Search (smartcase: lowercase = case-insensitive, any uppercase = case-sensitive) |
 | `n/N` | Next/prev search match |
+| `Esc` | Clear search highlights |
 | `]t/[t` | Next/prev thread |
 | `]r/[r` | Next/prev unread AI reply |
-| `l` | List threads |
+
+**Review**
+
+| Key | Action |
+|-----|--------|
+| `c` | Open thread / comment on line |
+| `r` | Resolve thread (toggle) |
+| `R` | Resolve all pending |
+| `dd` | Delete thread (with confirm) |
+| `T` | List threads |
 | `a` | Approve spec |
+
+**Commands**
+
+| Key | Action |
+|-----|--------|
 | `:w` | Merge changes to review JSON |
-| `:wq` | Merge and quit |
-| `:q` | Quit (only if merged) |
+| `:wq` / `:qw` | Merge and quit |
+| `:q` | Quit (blocks if unsaved) |
 | `:q!` | Quit without merging |
+| `:{N}` | Jump to line N (e.g. `:42`) |
+| `Ctrl+C` | Quit without merging |
 | `?` | Help |
 
 ### Thread popup
@@ -58,7 +86,7 @@ Opens a TUI in line mode with vim-style navigation. Press `c` on any line to ope
 The thread popup has two modes:
 
 - **Insert mode** — type your comment, `Tab` sends, `Esc` switches to normal mode
-- **Normal mode** — `j/k` and `Ctrl+D/U` scroll the conversation history, `c` to reply, `r` to resolve, `Esc` to close
+- **Normal mode** — `j/k` and `Ctrl+D/U` scroll the conversation, `gg/G` top/bottom, `c` to reply, `r` to resolve, `Esc` to close
 
 ## Live AI Integration
 
@@ -112,6 +140,16 @@ Install the `/revspec` skill for Claude Code:
 
 Then use `/revspec` in Claude Code after generating a spec.
 
+## Testing
+
+```bash
+bun test                    # Run all tests (~70s)
+bun test test/e2e           # E2E snapshot tests only (~66s)
+bun test --update-snapshots # Regenerate snapshots after UI changes
+```
+
+E2E tests use `bun-pty` to spawn revspec in a pseudo-terminal (80x24), send keystrokes, capture plain-text screen output, and compare against saved snapshots. Covers: navigation, search, overlays (help, comment, thread list, confirm), thread creation/resolve/delete, command mode, and context-sensitive hints.
+
 ## Protocol
 
 Communication happens through a JSONL file (`spec.review.live.jsonl`) — append-only, both sides write to it. On session end, events are merged into `spec.review.json`.

package/bun.lock

@@ -9,6 +9,7 @@
       },
       "devDependencies": {
         "@types/bun": "latest",
+        "bun-pty": "^0.4.8",
       },
       "peerDependencies": {
         "typescript": "^5",
@@ -110,6 +111,8 @@
 
     "bun-ffi-structs": ["bun-ffi-structs@0.1.2", "", { "peerDependencies": { "typescript": "^5" } }, "sha512-Lh1oQAYHDcnesJauieA4UNkWGXY9hYck7OA5IaRwE3Bp6K2F2pJSNYqq+hIy7P3uOvo3km3oxS8304g5gDMl/w=="],
 
+    "bun-pty": ["bun-pty@0.4.8", "", {}, "sha512-rO70Mrbr13+jxHHHu2YBkk2pNqrJE5cJn29WE++PUr+GFA0hq/VgtQPZANJ8dJo6d7XImvBk37Innt8GM7O28w=="],
+
     "bun-types": ["bun-types@1.3.10", "", { "dependencies": { "@types/node": "*" } }, "sha512-tcpfCCl6XWo6nCVnpcVrxQ+9AYN1iqMIzgrSKYMB/fjLtV2eyAVEg7AxQJuCq/26R6HpKWykQXuSOq/21RYcbg=="],
 
     "bun-webgpu": ["bun-webgpu@0.1.5", "", { "dependencies": { "@webgpu/types": "^0.1.60" }, "optionalDependencies": { "bun-webgpu-darwin-arm64": "^0.1.5", "bun-webgpu-darwin-x64": "^0.1.5", "bun-webgpu-linux-x64": "^0.1.5", "bun-webgpu-win32-x64": "^0.1.5" } }, "sha512-91/K6S5whZKX7CWAm9AylhyKrLGRz6BUiiPiM/kXadSnD4rffljCD/q9cNFftm5YXhx4MvLqw33yEilxogJvwA=="],

package/package.json

@@ -1,16 +1,19 @@
 {
   "name": "revspec",
-  "version": "0.4.0",
+  "version": "0.6.0",
   "type": "module",
   "bin": {
     "revspec": "./bin/revspec.ts"
   },
   "scripts": {
     "start": "bun run bin/revspec.ts",
-    "test": "bun test"
+    "test": "bun test test/unit test/integration",
+    "test:e2e": "bun test test/e2e",
+    "test:all": "bun test"
   },
   "devDependencies": {
-    "@types/bun": "latest"
+    "@types/bun": "latest",
+    "bun-pty": "^0.4.8"
   },
   "peerDependencies": {
     "typescript": "^5"

package/src/state/review-state.ts

@@ -136,6 +136,11 @@ export class ReviewState {
     }
   }
 
+  deleteThread(threadId: string): void {
+    this.threads = this.threads.filter((t) => t.id !== threadId);
+    this._unreadThreadIds.delete(threadId);
+  }
+
   addOwnerReply(threadId: string, text: string, ts?: number): void {
     const thread = this.threads.find((t) => t.id === threadId);
     if (!thread) return;

package/src/tui/app.ts

@@ -17,6 +17,7 @@ import { buildPagerNodes, createPager, countExtraVisualLines, type PagerComponen
 import {
   buildTopBar,
   buildBottomBar,
+  setBottomBarMessage,
   createTopBar,
   createBottomBar,
   type TopBarComponents,
@@ -129,7 +130,8 @@ export async function runTui(
 
     buildPagerNodes(pager.lineNode, state, searchQuery, state.unreadThreadIds);
     buildTopBar(topBar, specFile, state, state.unreadCount(), specMtimeChanged);
-    buildBottomBar(bottomBar, commandBuffer);
+    const hasThread = !!state.threadAtLine(state.cursorLine);
+    buildBottomBar(bottomBar, commandBuffer, hasThread);
     renderer.requestRender();
   }
 
@@ -221,12 +223,12 @@ export async function runTui(
     if (cmd === "w") {
       // Merge JSONL -> JSON, stay open
       doMerge();
-      bottomBar.text.content = " \u2714 Merged to review JSON";
+      setBottomBarMessage(bottomBar, " \u2714 Merged to review JSON");
       renderer.requestRender();
       setTimeout(() => { refreshPager(); }, 1200);
       return "stay";
     }
-    if (cmd === "wq") {
+    if (cmd === "wq" || cmd === "qw") {
       // Merge and exit
       mergeAndExit(resolve);
       return "merged";
@@ -234,7 +236,7 @@ export async function runTui(
     if (cmd === "q") {
       // Exit only if merged (no pending changes)
       if (hasPendingChanges()) {
-        bottomBar.text.content = " Unmerged changes. Use :w to save or :q! to discard";
+        setBottomBarMessage(bottomBar, " Unmerged changes. Use :w to save or :q! to discard");
         renderer.requestRender();
         setTimeout(() => { refreshPager(); }, 2000);
         return "stay";
@@ -251,6 +253,14 @@ export async function runTui(
       keybinds.destroy();
       return "exit";
     }
+    // :{N} — jump to line number
+    const lineNum = parseInt(cmd, 10);
+    if (!isNaN(lineNum) && lineNum > 0) {
+      state.cursorLine = Math.min(lineNum, state.lineCount);
+      ensureCursorVisible();
+      refreshPager();
+      return "stay";
+    }
     return "stay"; // unknown command, ignore
   }
 
@@ -359,11 +369,14 @@ export async function runTui(
     currentLine: number,
     direction: 1 | -1
   ): number | null {
-    const q = query.toLowerCase();
+    // Smartcase: if query has any uppercase, case-sensitive
+    const caseSensitive = query !== query.toLowerCase();
+    const q = caseSensitive ? query : query.toLowerCase();
     const total = lines.length;
     for (let offset = 1; offset <= total; offset++) {
       const i = ((currentLine - 1) + offset * direction + total) % total;
-      if (lines[i].toLowerCase().includes(q)) {
+      const line = caseSensitive ? lines[i] : lines[i].toLowerCase();
+      if (line.includes(q)) {
         return i + 1; // 1-based
       }
     }
@@ -384,7 +397,7 @@ export async function runTui(
     { key: "n", action: "search-next" },
     { key: "N", action: "search-prev" },
     { key: "c", action: "comment" },
-    { key: "l", action: "thread-list" },
+    { key: "T", action: "thread-list" },
     { key: "r", action: "resolve" },
     { key: "R", action: "resolve-all" },
     { key: "dd", action: "delete-draft" },
@@ -393,11 +406,12 @@ export async function runTui(
     { key: "[t", action: "prev-thread" },
     { key: "]r", action: "next-unread" },
     { key: "[r", action: "prev-unread" },
+    { key: "zz", action: "center-cursor" },
     { key: "?", action: "help" },
     { key: "/", action: "search" },
     { key: ":", action: "command-mode" },
   ];
-  const keybinds = createKeybindRegistry(bindings);
+  const keybinds = createKeybindRegistry(bindings, 300);
 
   refreshPager();
   renderer.start();
@@ -458,9 +472,13 @@ export async function runTui(
         return;
       }
 
-      // Ctrl+C to exit — merge and quit
+      // Ctrl+C to exit — quit without merging (same as :q!)
       if (key.ctrl && key.name === "c") {
-        mergeAndExit(resolve);
+        appendEvent(jsonlPath, { type: "session-end", author: "reviewer", ts: Date.now() });
+        liveWatcher.stop();
+        keybinds.destroy();
+        renderer.destroy();
+        resolve();
         return;
       }
 
@@ -480,7 +498,7 @@ export async function runTui(
       if (!action) {
         const p = keybinds.pending();
         if (p) {
-          bottomBar.text.content = ` ${p}`;
+          setBottomBarMessage(bottomBar, ` ${p}`);
           renderer.requestRender();
         }
         return;
@@ -525,6 +543,14 @@ export async function runTui(
           ensureCursorVisible();
           refreshPager();
           break;
+        case "center-cursor": {
+          const extra = countExtraVisualLines(state.specLines, state.cursorLine - 1);
+          const cursorRow = state.cursorLine - 1 + extra;
+          const halfView = Math.floor(pageSize() / 2);
+          pager.scrollBox.scrollTo(Math.max(0, cursorRow - halfView));
+          refreshPager();
+          break;
+        }
         case "search-next":
           if (searchQuery) {
             const match = findNextMatch(state.specLines, searchQuery, state.cursorLine, 1);
@@ -533,7 +559,7 @@ export async function runTui(
               ensureCursorVisible();
             }
           } else {
-            bottomBar.text.content = " No active search \u2014 use / to search";
+            setBottomBarMessage(bottomBar, " No active search \u2014 use / to search");
             renderer.requestRender();
             setTimeout(() => { refreshPager(); }, 1500);
           }
@@ -547,7 +573,7 @@ export async function runTui(
               ensureCursorVisible();
             }
           } else {
-            bottomBar.text.content = " No active search \u2014 use / to search";
+            setBottomBarMessage(bottomBar, " No active search \u2014 use / to search");
             renderer.requestRender();
             setTimeout(() => { refreshPager(); }, 1500);
           }
@@ -570,7 +596,7 @@ export async function runTui(
             const msg = wasResolved
               ? ` \u21a9 Reopened thread #${thread.id}`
               : ` \u2714 Resolved thread #${thread.id}`;
-            bottomBar.text.content = msg;
+            setBottomBarMessage(bottomBar, msg);
             renderer.requestRender();
             setTimeout(() => { refreshPager(); }, 1500);
           }
@@ -584,7 +610,7 @@ export async function runTui(
             appendEvent(jsonlPath, { type: "resolve", threadId: t.id, author: "reviewer", ts: Date.now() });
           }
           refreshPager();
-          bottomBar.text.content = ` \u2714 Resolved ${pending} pending thread(s)`;
+          setBottomBarMessage(bottomBar, ` \u2714 Resolved ${pending} pending thread(s)`);
           renderer.requestRender();
           setTimeout(() => { refreshPager(); }, 1500);
           break;
@@ -592,26 +618,31 @@ export async function runTui(
         case "delete-draft": {
           const thread = state.threadAtLine(state.cursorLine);
           if (!thread) break;
-          const hadReviewerMsg = thread.messages.some((m) => m.author === "reviewer");
-          if (hadReviewerMsg) {
-            state.deleteLastDraftMessage(thread.id);
-            appendEvent(jsonlPath, { type: "delete", threadId: thread.id, author: "reviewer", ts: Date.now() });
-            refreshPager();
-            bottomBar.text.content = " \u2714 Deleted draft comment";
-            renderer.requestRender();
-            setTimeout(() => { refreshPager(); }, 1500);
-          } else {
-            bottomBar.text.content = " No reviewer message to delete";
-            renderer.requestRender();
-            setTimeout(() => { refreshPager(); }, 1500);
-          }
+          const deleteOverlay = createConfirm({
+            renderer,
+            title: "Delete Thread",
+            message: `Delete thread #${thread.id} on line ${thread.line}?`,
+            onConfirm: () => {
+              dismissOverlay();
+              state.deleteThread(thread.id);
+              appendEvent(jsonlPath, { type: "delete", threadId: thread.id, author: "reviewer", ts: Date.now() });
+              refreshPager();
+              setBottomBarMessage(bottomBar, ` \u2714 Deleted thread #${thread.id}`);
+              renderer.requestRender();
+              setTimeout(() => { refreshPager(); }, 1500);
+            },
+            onCancel: () => {
+              dismissOverlay();
+            },
+          });
+          showOverlay(deleteOverlay);
           break;
         }
         case "approve":
           if (state.canApprove()) {
             const confirmOverlay = createConfirm({
               renderer,
-              message: "Approve spec and proceed to implementation? [y/n]",
+              message: "Approve spec and proceed to implementation?",
               onConfirm: () => {
                 dismissOverlay();
                 appendEvent(jsonlPath, { type: "approve", author: "reviewer", ts: Date.now() });
@@ -628,7 +659,7 @@ export async function runTui(
             const msg = total === 0
               ? "No threads to approve"
               : `${total} thread${total !== 1 ? "s" : ""} still open/pending`;
-            bottomBar.text.content = ` \u26a0  ${msg}`;
+            setBottomBarMessage(bottomBar, ` \u26a0  ${msg}`);
             renderer.requestRender();
             setTimeout(() => { refreshPager(); }, 2000);
           }
@@ -638,8 +669,8 @@ export async function runTui(
           if (next !== null) {
             state.cursorLine = next;
             ensureCursorVisible();
-            refreshPager();
           }
+          refreshPager();
           break;
         }
         case "prev-thread": {
@@ -647,8 +678,8 @@ export async function runTui(
           if (prev !== null) {
             state.cursorLine = prev;
             ensureCursorVisible();
-            refreshPager();
           }
+          refreshPager();
           break;
         }
         case "next-unread": {
@@ -656,8 +687,8 @@ export async function runTui(
           if (nextLine !== null) {
             state.cursorLine = nextLine;
             ensureCursorVisible();
-            refreshPager();
           }
+          refreshPager();
           break;
         }
         case "prev-unread": {
@@ -665,8 +696,8 @@ export async function runTui(
           if (prevLine !== null) {
             state.cursorLine = prevLine;
             ensureCursorVisible();
-            refreshPager();
           }
+          refreshPager();
           break;
         }
         case "help":

package/src/tui/comment-input.ts

@@ -50,16 +50,17 @@ function createThreadView(
     { key: "NORMAL", action: "" },
     { key: "c", action: "reply" },
     { key: "r", action: "resolve" },
-    { key: "Esc/q", action: "close" },
+    { key: "q", action: "close" },
   ];
   const insertHints = [
     { key: "INSERT", action: "" },
     { key: "Tab", action: "send" },
-    { key: "Esc", action: "back" },
+    { key: "Esc", action: "normal" },
   ];
 
   // --- State ---
   let mode: "normal" | "insert" = "insert";
+  let pendingG: ReturnType<typeof setTimeout> | null = null;
 
   // Build the textarea now (we need it in the key handler closure)
   const textarea = new TextareaRenderable(renderer, {
@@ -151,10 +152,19 @@ function createThreadView(
       case "g":
         if (key.shift) {
           // G = go to bottom
+          if (pendingG) { clearTimeout(pendingG); pendingG = null; }
           scrollBox.scrollTo(scrollBox.scrollHeight);
           renderer.requestRender();
+        } else if (pendingG) {
+          // gg = go to top
+          clearTimeout(pendingG);
+          pendingG = null;
+          scrollBox.scrollTo(0);
+          renderer.requestRender();
+        } else {
+          // First g — wait for second
+          pendingG = setTimeout(() => { pendingG = null; }, 300);
         }
-        // TODO: gg = go to top (needs double-tap tracking)
         return;
     }
   };
@@ -173,6 +183,7 @@ function createThreadView(
     hints: insertHints,
   });
 
+
   // --- Scrollable conversation history ---
   const scrollBox = dialog.content;
 
@@ -272,6 +283,7 @@ function createThreadView(
   return {
     container: dialog.container,
     cleanup() {
+      if (pendingG) clearTimeout(pendingG);
       renderer.keyInput.off("keypress", keyHandler);
       dialog.cleanup();
       textarea.destroy();