revspec 0.1.0 → 0.2.1

package/test/protocol/read.test.ts

@@ -23,7 +23,7 @@ describe("readReviewFile", () => {
           id: "t1",
           line: 10,
           status: "open",
-          messages: [{ author: "human", text: "Looks good?" }],
+          messages: [{ author: "reviewer", text: "Looks good?" }],
         },
       ],
     };
@@ -73,7 +73,7 @@ describe("readDraftFile", () => {
           id: "t2",
           line: 5,
           status: "pending",
-          messages: [{ author: "ai", text: "Response here" }],
+          messages: [{ author: "owner", text: "Response here" }],
         },
       ],
     };

package/test/protocol/types.test.ts

@@ -22,7 +22,7 @@ describe("isValidThread", () => {
         id: "t1",
         line: 5,
         status: "open",
-        messages: [{ author: "human", text: "hello" }],
+        messages: [{ author: "reviewer", text: "hello" }],
       })
     ).toBe(true);
   });
@@ -69,7 +69,7 @@ describe("isValidReviewFile", () => {
             id: "t1",
             line: 1,
             status: "open",
-            messages: [{ author: "human", text: "comment" }],
+            messages: [{ author: "reviewer", text: "comment" }],
           },
         ],
       })

package/test/protocol/write.test.ts

@@ -19,7 +19,7 @@ describe("writeReviewFile", () => {
           id: "t1",
           line: 3,
           status: "open",
-          messages: [{ author: "human", text: "Is this right?" }],
+          messages: [{ author: "reviewer", text: "Is this right?" }],
         },
       ],
     };
@@ -60,7 +60,7 @@ describe("writeDraftFile", () => {
           id: "t2",
           line: 7,
           status: "resolved",
-          messages: [{ author: "ai", text: "Fixed." }],
+          messages: [{ author: "owner", text: "Fixed." }],
         },
       ],
     };

package/test/state/review-state.test.ts

@@ -8,7 +8,7 @@ function makeThread(
   id: string,
   line: number,
   status: Thread["status"],
-  messages: Thread["messages"] = [{ author: "human", text: "comment" }]
+  messages: Thread["messages"] = [{ author: "reviewer", text: "comment" }]
 ): Thread {
   return { id, line, status, messages };
 }
@@ -39,10 +39,9 @@ describe("ReviewState", () => {
       expect(state.threads[0].line).toBe(3);
       expect(state.threads[0].status).toBe("open");
       expect(state.threads[0].messages).toHaveLength(1);
-      expect(state.threads[0].messages[0]).toEqual({
-        author: "human",
-        text: "needs clarification",
-      });
+      expect(state.threads[0].messages[0].author).toBe("reviewer");
+      expect(state.threads[0].messages[0].text).toBe("needs clarification");
+      expect(state.threads[0].messages[0].ts).toBeGreaterThan(0);
     });
 
     it("assigns auto-incremented id", () => {
@@ -57,10 +56,9 @@ describe("ReviewState", () => {
       const state = new ReviewState(SPEC, [makeThread("t1", 2, "pending")]);
       state.replyToThread("t1", "my reply");
       expect(state.threads[0].messages).toHaveLength(2);
-      expect(state.threads[0].messages[1]).toEqual({
-        author: "human",
-        text: "my reply",
-      });
+      expect(state.threads[0].messages[1].author).toBe("reviewer");
+      expect(state.threads[0].messages[1].text).toBe("my reply");
+      expect(state.threads[0].messages[1].ts).toBeGreaterThan(0);
     });
 
     it("flips status to open", () => {
@@ -235,9 +233,9 @@ describe("ReviewState", () => {
       expect(state.canApprove()).toBe(false);
     });
 
-    it("returns false when there are no threads", () => {
+    it("returns true when there are no threads (clean approval)", () => {
       const state = new ReviewState(SPEC, []);
-      expect(state.canApprove()).toBe(false);
+      expect(state.canApprove()).toBe(true);
     });
   });
 
@@ -265,14 +263,14 @@ describe("ReviewState", () => {
           line: 1,
           status: "open",
           messages: [
-            { author: "ai", text: "AI response" },
-            { author: "human", text: "my draft" },
+            { author: "owner", text: "AI response" },
+            { author: "reviewer", text: "my draft" },
           ],
         },
       ]);
       state.deleteLastDraftMessage("t1");
       expect(state.threads[0].messages).toHaveLength(1);
-      expect(state.threads[0].messages[0].author).toBe("ai");
+      expect(state.threads[0].messages[0].author).toBe("owner");
     });
 
     it("removes the thread entirely when it becomes empty", () => {
@@ -281,7 +279,7 @@ describe("ReviewState", () => {
           id: "t1",
           line: 1,
           status: "open",
-          messages: [{ author: "human", text: "only message" }],
+          messages: [{ author: "reviewer", text: "only message" }],
         },
       ]);
       state.deleteLastDraftMessage("t1");
@@ -323,4 +321,79 @@ describe("ReviewState", () => {
       expect(state.activeThreadCount()).toEqual({ open: 0, pending: 0 });
     });
   });
+
+  describe("unread tracking", () => {
+    it("tracks unread owner replies", () => {
+      const state = new ReviewState(["line1", "line2"], []);
+      state.addComment(1, "fix this");
+      state.addOwnerReply("t1", "done", 1001);
+      expect(state.unreadCount()).toBe(1);
+    });
+
+    it("markRead clears unread for a thread", () => {
+      const state = new ReviewState(["line1"], []);
+      state.addComment(1, "fix");
+      state.addOwnerReply("t1", "done", 1001);
+      state.markRead("t1");
+      expect(state.unreadCount()).toBe(0);
+    });
+
+    it("nextUnreadThread returns line of next unread thread after cursor", () => {
+      const state = new ReviewState(["a", "b", "c", "d", "e"], []);
+      state.addComment(2, "fix");
+      state.addComment(4, "fix too");
+      state.addOwnerReply("t1", "done", 1001);
+      state.addOwnerReply("t2", "done", 1002);
+      state.cursorLine = 1;
+      expect(state.nextUnreadThread()).toBe(2);
+    });
+
+    it("prevUnreadThread returns line of prev unread thread before cursor", () => {
+      const state = new ReviewState(["a", "b", "c", "d", "e"], []);
+      state.addComment(2, "fix");
+      state.addComment(4, "fix too");
+      state.addOwnerReply("t1", "done", 1001);
+      state.addOwnerReply("t2", "done", 1002);
+      state.cursorLine = 5;
+      expect(state.prevUnreadThread()).toBe(4);
+    });
+
+    it("nextUnreadThread returns null when no unread", () => {
+      const state = new ReviewState(["a"], []);
+      expect(state.nextUnreadThread()).toBeNull();
+    });
+
+    it("isThreadUnread returns correct state", () => {
+      const state = new ReviewState(["a"], []);
+      state.addComment(1, "fix");
+      expect(state.isThreadUnread("t1")).toBe(false);
+      state.addOwnerReply("t1", "done", 1001);
+      expect(state.isThreadUnread("t1")).toBe(true);
+      state.markRead("t1");
+      expect(state.isThreadUnread("t1")).toBe(false);
+    });
+
+    it("nextUnreadThread wraps around", () => {
+      const state = new ReviewState(["a", "b", "c", "d", "e"], []);
+      state.addComment(2, "fix");
+      state.addOwnerReply("t1", "done", 1001);
+      state.cursorLine = 4;
+      expect(state.nextUnreadThread()).toBe(2); // wraps to beginning
+    });
+
+    it("addOwnerReply sets thread status to pending", () => {
+      const state = new ReviewState(["a"], []);
+      state.addComment(1, "fix");
+      expect(state.threads[0].status).toBe("open");
+      state.addOwnerReply("t1", "done", 1001);
+      expect(state.threads[0].status).toBe("pending");
+    });
+
+    it("addOwnerReply preserves timestamp on message", () => {
+      const state = new ReviewState(["a"], []);
+      state.addComment(1, "fix");
+      state.addOwnerReply("t1", "done", 1234567890);
+      expect(state.threads[0].messages[1].ts).toBe(1234567890);
+    });
+  });
 });

package/test/tui/pager.test.ts

@@ -9,7 +9,7 @@ function makeThread(
   id: string,
   line: number,
   status: Thread["status"],
-  messages: Thread["messages"] = [{ author: "human", text: "comment" }]
+  messages: Thread["messages"] = [{ author: "reviewer", text: "comment" }]
 ): Thread {
   return { id, line, status, messages };
 }
@@ -21,10 +21,8 @@ describe("buildPagerContent", () => {
     const lines = content.split("\n");
 
     expect(lines).toHaveLength(4);
-    // Line 1 is the cursor line, gets ">" prefix
     expect(lines[0]).toContain("   1");
     expect(lines[0]).toContain("# Title");
-    // Other lines get " " prefix
     expect(lines[1]).toContain("   2");
     expect(lines[1]).toContain("Some text");
     expect(lines[2]).toContain("   3");
@@ -37,45 +35,42 @@ describe("buildPagerContent", () => {
     const content = buildPagerContent(state);
     const lines = content.split("\n");
 
-    // Line 3 (index 2) should have ">" prefix
     expect(lines[2]).toMatch(/^>/);
-    // Other lines should have " " prefix
     expect(lines[0]).toMatch(/^ /);
     expect(lines[1]).toMatch(/^ /);
     expect(lines[3]).toMatch(/^ /);
   });
 
-  it("shows status indicator for open threads", () => {
+  it("shows gutter indicator for open threads", () => {
     const state = new ReviewState(SPEC, [makeThread("t1", 2, "open")]);
     const content = buildPagerContent(state);
     const lines = content.split("\n");
 
-    // Line 2 should contain the open icon (*)
-    expect(lines[1]).toContain("*");
+    expect(lines[1]).toContain("\u258c");
   });
 
-  it("shows status indicator for pending threads", () => {
+  it("shows gutter indicator for pending threads", () => {
     const state = new ReviewState(SPEC, [makeThread("t1", 2, "pending")]);
     const content = buildPagerContent(state);
     const lines = content.split("\n");
 
-    expect(lines[1]).toContain("~");
+    expect(lines[1]).toContain("\u258c");
   });
 
-  it("shows status indicator for resolved threads", () => {
+  it("shows checkmark for resolved threads", () => {
     const state = new ReviewState(SPEC, [makeThread("t1", 2, "resolved")]);
     const content = buildPagerContent(state);
     const lines = content.split("\n");
 
-    expect(lines[1]).toContain("\u2714");
+    expect(lines[1]).toContain("\u2713");
   });
 
-  it("shows status indicator for outdated threads", () => {
+  it("shows gutter indicator for outdated threads", () => {
     const state = new ReviewState(SPEC, [makeThread("t1", 2, "outdated")]);
     const content = buildPagerContent(state);
     const lines = content.split("\n");
 
-    expect(lines[1]).toContain("\u26A0");
+    expect(lines[1]).toContain("\u258c");
   });
 
   it("shows different icons for different statuses", () => {
@@ -88,38 +83,24 @@ describe("buildPagerContent", () => {
     const content = buildPagerContent(state);
     const lines = content.split("\n");
 
-    expect(lines[0]).toContain("*");
-    expect(lines[1]).toContain("~");
-    expect(lines[2]).toContain("\u2714");
-    expect(lines[3]).toContain("\u26A0");
+    expect(lines[0]).toContain("\u258c");
+    expect(lines[1]).toContain("\u258c");
+    expect(lines[2]).toContain("\u2713");
+    expect(lines[3]).toContain("\u258c");
   });
 
-  it("shows thread hint with latest message text", () => {
+  it("does not show inline comment preview (removed)", () => {
     const state = new ReviewState(SPEC, [
       makeThread("t1", 2, "open", [
-        { author: "ai", text: "AI said something" },
-        { author: "human", text: "My response" },
+        { author: "reviewer", text: "My response" },
       ]),
     ]);
     const content = buildPagerContent(state);
     const lines = content.split("\n");
 
-    expect(lines[1]).toContain("My response");
-  });
-
-  it("truncates long comment text to 40 chars", () => {
-    const longText =
-      "This is a very long comment that should be truncated because it exceeds the maximum hint length";
-    const state = new ReviewState(SPEC, [
-      makeThread("t1", 2, "open", [{ author: "human", text: longText }]),
-    ]);
-    const content = buildPagerContent(state);
-    const lines = content.split("\n");
-
-    // Should be truncated to 39 chars + ellipsis
-    expect(lines[1]).toContain("\u2026");
-    // The full text should NOT appear
-    expect(lines[1]).not.toContain(longText);
+    // Only gutter indicator, no inline text preview
+    expect(lines[1]).toContain("\u258c");
+    expect(lines[1]).not.toContain("My response");
   });
 
   it("does not show status indicator for lines without threads", () => {
@@ -127,11 +108,8 @@ describe("buildPagerContent", () => {
     const content = buildPagerContent(state);
     const lines = content.split("\n");
 
-    // Line 1 (no thread) should not contain any status icons
-    expect(lines[0]).not.toContain("\u{1F4AC}");
-    expect(lines[0]).not.toContain("\u{1F535}");
-    expect(lines[0]).not.toContain("\u2714");
-    expect(lines[0]).not.toContain("\u26A0");
+    expect(lines[0]).not.toContain("\u258c");
+    expect(lines[0]).not.toContain("\u2713");
   });
 
   it("pads line numbers to 4 characters", () => {
@@ -139,7 +117,6 @@ describe("buildPagerContent", () => {
     const content = buildPagerContent(state);
     const lines = content.split("\n");
 
-    // Line numbers are wrapped in ANSI gray codes, so check the raw number is present
     expect(lines[0]).toContain("   1");
     expect(lines[0]).toContain("# Title");
   });
@@ -155,10 +132,8 @@ describe("buildPagerContent", () => {
     const content = buildPagerContent(state, "text");
     const lines = content.split("\n");
 
-    // Lines 2 and 3 contain "text" — should be highlighted
     expect(lines[1]).toContain("Some >>text<<");
     expect(lines[2]).toContain("More >>text<<");
-    // Lines 1 and 4 do not contain "text"
     expect(lines[0]).not.toContain(">>");
     expect(lines[3]).not.toContain(">>");
   });
@@ -180,5 +155,5 @@ describe("buildPagerContent", () => {
     expect(lines[1]).toContain("Some text");
     expect(lines[1]).not.toContain(">>");
   });
-});
 
+});