reviewflow 3.40.0 → 3.40.2

package/dist/tests/acceptance/73-stage4-controller-thinning.acceptance.test.js

@@ -0,0 +1,226 @@
+import { describe, it, expect, vi } from 'vitest';
+import { processReviewRequest, } from '../../modules/platform-integration/usecases/processReviewRequest.usecase.js';
+import { processWebhook, } from '../../modules/platform-integration/usecases/processWebhook.usecase.js';
+import { evaluateQualityGate } from '../../modules/tracking/entities/qualityGate/qualityGate.js';
+import { HandlePlatformApprovalUseCase } from '../../modules/tracking/usecases/tracking/handlePlatformApproval.usecase.js';
+import { TransitionStateUseCase } from '../../modules/tracking/usecases/tracking/transitionState.usecase.js';
+import { TrackedMrFactory } from '../../tests/factories/trackedMr.factory.js';
+import { createStubLogger } from '../../tests/stubs/logger.stub.js';
+import { InMemoryReviewRequestTrackingGateway } from '../../tests/stubs/reviewRequestTracking.stub.js';
+const PROJECT_PATH = '/checkout/project';
+function buildApproveEvent() {
+    return {
+        type: 'approve',
+        platform: 'gitlab',
+        projectPath: 'group/project',
+        localPath: PROJECT_PATH,
+        mergeRequestNumber: 42,
+        reviewId: null,
+    };
+}
+function buildDeps(tracked, threshold) {
+    const trackingGateway = new InMemoryReviewRequestTrackingGateway();
+    if (tracked) {
+        trackingGateway.create(PROJECT_PATH, tracked);
+    }
+    return {
+        handleClose: async () => ({
+            status: 'cleaned',
+            jobCancelled: true,
+            trackingArchived: true,
+            contextDeleted: true,
+        }),
+        transitionState: new TransitionStateUseCase(trackingGateway),
+        recordPush: { execute: () => null },
+        checkFollowupNeeded: { execute: () => false },
+        removeWorktree: async () => ({ status: 'removed' }),
+        handlePlatformApproval: new HandlePlatformApprovalUseCase(trackingGateway),
+        getQualityThreshold: () => threshold,
+        logger: createStubLogger(),
+    };
+}
+describe('SPEC-073 Stage 4b — approve verdict via processWebhook (acceptance)', () => {
+    describe('the approve verdict is decided inward, platform-neutral', () => {
+        it('approved: a tracked MR clearing the quality gate transitions to approved', async () => {
+            const tracked = TrackedMrFactory.create({
+                id: 'gitlab-group/project-42',
+                latestScore: 9,
+                openThreads: 0,
+                bypass: null,
+            });
+            const result = await processWebhook(buildApproveEvent(), buildDeps(tracked, 8));
+            expect(result).toEqual({ type: 'approved', mergeRequestNumber: 42 });
+        });
+        it('approval-revoked: a sub-threshold tracked MR is reverted with a revoke message', async () => {
+            const tracked = TrackedMrFactory.create({
+                id: 'gitlab-group/project-42',
+                latestScore: 4,
+                openThreads: 0,
+                bypass: null,
+            });
+            const result = await processWebhook(buildApproveEvent(), buildDeps(tracked, 8));
+            expect(result.type).toBe('approval-revoked');
+            if (result.type !== 'approval-revoked')
+                throw new Error('expected approval-revoked');
+            expect(result.mergeRequestNumber).toBe(42);
+            expect(result.reason).toBe('below-threshold');
+            expect(result.revokeMessage.length).toBeGreaterThan(0);
+        });
+        it('approval-revoked: blocking issues revert the approval with the blockers reason', async () => {
+            const tracked = TrackedMrFactory.create({
+                id: 'gitlab-group/project-42',
+                latestScore: 9,
+                openThreads: 2,
+                bypass: null,
+            });
+            const result = await processWebhook(buildApproveEvent(), buildDeps(tracked, 8));
+            expect(result.type).toBe('approval-revoked');
+            if (result.type !== 'approval-revoked')
+                throw new Error('expected approval-revoked');
+            expect(result.reason).toBe('blockers-present');
+        });
+        it('approval-ignored: an untracked MR yields a not-found ignore', async () => {
+            const result = await processWebhook(buildApproveEvent(), buildDeps(null, 8));
+            expect(result).toEqual({
+                type: 'approval-ignored',
+                mergeRequestNumber: 42,
+                reason: 'not-found',
+            });
+        });
+        it('approved: a bypassed MR below threshold passes the gate via the bypass', async () => {
+            const tracked = TrackedMrFactory.create({
+                id: 'gitlab-group/project-42',
+                latestScore: 4,
+                openThreads: 0,
+                bypass: { reason: 'urgent', author: 'alice', recordedAt: '2026-01-01T00:00:00Z' },
+            });
+            const result = await processWebhook(buildApproveEvent(), buildDeps(tracked, 8));
+            expect(result).toEqual({ type: 'approved', mergeRequestNumber: 42 });
+        });
+    });
+    describe('the platform-neutral usecase imports no platform-specific types', () => {
+        it('uses evaluateQualityGate as the gate function for the transition check', () => {
+            expect(typeof evaluateQualityGate).toBe('function');
+        });
+    });
+});
+const REVIEW_PROJECT_PATH = 'group/project';
+const reviewProcessor = async () => { };
+function buildReviewJob() {
+    return {
+        id: 'gitlab-group/project-42',
+        platform: 'gitlab',
+        projectPath: REVIEW_PROJECT_PATH,
+        localPath: PROJECT_PATH,
+        mrNumber: 42,
+        skill: 'review-front',
+        mrUrl: 'https://gitlab.com/group/project/-/merge_requests/42',
+        sourceBranch: 'feature/x',
+        targetBranch: 'main',
+        jobType: 'review',
+    };
+}
+function acceptedBudget() {
+    return {
+        limitUsd: 200,
+        consumedUsd: 0,
+        remainingUsd: 200,
+        percentUsed: 0,
+        exceeded: false,
+        periodStart: '2026-05-01T00:00:00.000Z',
+    };
+}
+function exceededBudget() {
+    return {
+        limitUsd: 200,
+        consumedUsd: 250,
+        remainingUsd: -50,
+        percentUsed: 125,
+        exceeded: true,
+        periodStart: '2026-05-01T00:00:00.000Z',
+    };
+}
+function buildReviewInput(overrides = {}) {
+    return {
+        job: buildReviewJob(),
+        processor: reviewProcessor,
+        triggerSource: 'webhook-initial',
+        localPaths: [PROJECT_PATH],
+        actorUsername: 'alice',
+        projectPath: REVIEW_PROJECT_PATH,
+        gateActorTrust: true,
+        ...overrides,
+    };
+}
+function buildReviewDeps(overrides = {}) {
+    return {
+        enforceBudget: { execute: vi.fn(async () => ({ accepted: true, status: acceptedBudget() })) },
+        enqueue: vi.fn(async () => true),
+        logger: createStubLogger(),
+        ...overrides,
+    };
+}
+describe('SPEC-073 Stage 4a — review-request enqueue sequencing via processReviewRequest (acceptance)', () => {
+    describe('the review-request verdict is decided inward, platform-neutral', () => {
+        it('budget-exceeded: a refused budget short-circuits before any enqueue', async () => {
+            const enqueue = vi.fn(async () => true);
+            const verdict = await processReviewRequest(buildReviewInput(), buildReviewDeps({
+                enforceBudget: {
+                    execute: vi.fn(async () => ({ accepted: false, status: exceededBudget() })),
+                },
+                enqueue,
+            }));
+            expect(verdict).toEqual({ type: 'budget-exceeded', status: exceededBudget() });
+            expect(enqueue).not.toHaveBeenCalled();
+        });
+        it('queued: a trusted full-auto trigger is enqueued through the gate', async () => {
+            const gateClaudeInvocation = {
+                execute: vi.fn(async () => ({
+                    status: 'enqueued',
+                    jobId: 'gitlab-group/project-42',
+                })),
+            };
+            const verdict = await processReviewRequest(buildReviewInput(), buildReviewDeps({
+                gateClaudeInvocation,
+                isTrustedActor: { execute: vi.fn(async () => true) },
+            }));
+            expect(verdict).toEqual({ type: 'queued', jobId: 'gitlab-group/project-42' });
+        });
+        it('pending: a semi-auto trigger is parked with its pendingId', async () => {
+            const gateClaudeInvocation = {
+                execute: vi.fn(async () => ({
+                    status: 'pending',
+                    pendingId: 'pending-gitlab-42',
+                })),
+            };
+            const verdict = await processReviewRequest(buildReviewInput(), buildReviewDeps({
+                gateClaudeInvocation,
+                isTrustedActor: { execute: vi.fn(async () => true) },
+            }));
+            expect(verdict).toEqual({ type: 'pending', pendingId: 'pending-gitlab-42' });
+        });
+        it('pending (untrusted-actor): the no-gate fallback parks an untrusted actor without enqueuing', async () => {
+            const enqueue = vi.fn(async () => true);
+            const verdict = await processReviewRequest(buildReviewInput({ gateActorTrust: true }), buildReviewDeps({ enqueue, isTrustedActor: { execute: vi.fn(async () => false) } }));
+            expect(verdict).toEqual({ type: 'pending', pendingId: null, reason: 'untrusted-actor' });
+            expect(enqueue).not.toHaveBeenCalled();
+        });
+        it('deduplicated: the gate rejecting the job yields a deduplicated verdict', async () => {
+            const gateClaudeInvocation = {
+                execute: vi.fn(async () => ({ status: 'rejected', reason: 'already-active' })),
+            };
+            const verdict = await processReviewRequest(buildReviewInput(), buildReviewDeps({
+                gateClaudeInvocation,
+                isTrustedActor: { execute: vi.fn(async () => true) },
+            }));
+            expect(verdict).toEqual({ type: 'deduplicated', jobId: 'gitlab-group/project-42' });
+        });
+        it('queued (no gate): the followup raw-enqueue fallback queues an ungated trigger', async () => {
+            const enqueue = vi.fn(async () => true);
+            const verdict = await processReviewRequest(buildReviewInput({ triggerSource: 'webhook-followup', gateActorTrust: false }), buildReviewDeps({ enqueue }));
+            expect(verdict).toEqual({ type: 'queued', jobId: 'gitlab-group/project-42' });
+            expect(enqueue).toHaveBeenCalledTimes(1);
+        });
+    });
+});
+//# sourceMappingURL=73-stage4-controller-thinning.acceptance.test.js.map

package/dist/tests/acceptance/73-stage4-controller-thinning.acceptance.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"73-stage4-controller-thinning.acceptance.test.js","sourceRoot":"","sources":["../../../src/tests/acceptance/73-stage4-controller-thinning.acceptance.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAGlD,OAAO,EACL,oBAAoB,GAGrB,MAAM,yEAAyE,CAAC;AACjF,OAAO,EACL,cAAc,GAEf,MAAM,mEAAmE,CAAC;AAI3E,OAAO,EAAE,mBAAmB,EAAE,MAAM,wDAAwD,CAAC;AAE7F,OAAO,EAAE,6BAA6B,EAAE,MAAM,wEAAwE,CAAC;AACvH,OAAO,EAAE,sBAAsB,EAAE,MAAM,iEAAiE,CAAC;AACzG,OAAO,EAAE,gBAAgB,EAAE,MAAM,wCAAwC,CAAC;AAC1E,OAAO,EAAE,gBAAgB,EAAE,MAAM,8BAA8B,CAAC;AAChE,OAAO,EAAE,oCAAoC,EAAE,MAAM,6CAA6C,CAAC;AAEnG,MAAM,YAAY,GAAG,mBAAmB,CAAC;AAEzC,SAAS,iBAAiB;IACxB,OAAO;QACL,IAAI,EAAE,SAAS;QACf,QAAQ,EAAE,QAAQ;QAClB,WAAW,EAAE,eAAe;QAC5B,SAAS,EAAE,YAAY;QACvB,kBAAkB,EAAE,EAAE;QACtB,QAAQ,EAAE,IAAI;KACf,CAAC;AACJ,CAAC;AAED,SAAS,SAAS,CAChB,OAAyB,EACzB,SAAwB;IAExB,MAAM,eAAe,GAAG,IAAI,oCAAoC,EAAE,CAAC;IACnE,IAAI,OAAO,EAAE,CAAC;QACZ,eAAe,CAAC,MAAM,CAAC,YAAY,EAAE,OAAO,CAAC,CAAC;IAChD,CAAC;IACD,OAAO;QACL,WAAW,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC;YACxB,MAAM,EAAE,SAAS;YACjB,YAAY,EAAE,IAAI;YAClB,gBAAgB,EAAE,IAAI;YACtB,cAAc,EAAE,IAAI;SACrB,CAAC;QACF,eAAe,EAAE,IAAI,sBAAsB,CAAC,eAAe,CAAC;QAC5D,UAAU,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE,CAAC,IAAI,EAAE;QACnC,mBAAmB,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE,CAAC,KAAK,EAAE;QAC7C,cAAc,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC;QACnD,sBAAsB,EAAE,IAAI,6BAA6B,CAAC,eAAe,CAAC;QAC1E,mBAAmB,EAAE,GAAG,EAAE,CAAC,SAAS;QACpC,MAAM,EAAE,gBAAgB,EAAE;KAC3B,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,qEAAqE,EAAE,GAAG,EAAE;IACnF,QAAQ,CAAC,yDAAyD,EAAE,GAAG,EAAE;QACvE,EAAE,CAAC,0EAA0E,EAAE,KAAK,IAAI,EAAE;YACxF,MAAM,OAAO,GAAG,gBAAgB,CAAC,MAAM,CAAC;gBACtC,EAAE,EAAE,yBAAyB;gBAC7B,WAAW,EAAE,CAAC;gBACd,WAAW,EAAE,CAAC;gBACd,MAAM,EAAE,IAAI;aACb,CAAC,CAAC;YAEH,MAAM,MAAM,GAAG,MAAM,cAAc,CAAC,iBAAiB,EAAE,EAAE,SAAS,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC;YAEhF,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,kBAAkB,EAAE,EAAE,EAAE,CAAC,CAAC;QACvE,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,gFAAgF,EAAE,KAAK,IAAI,EAAE;YAC9F,MAAM,OAAO,GAAG,gBAAgB,CAAC,MAAM,CAAC;gBACtC,EAAE,EAAE,yBAAyB;gBAC7B,WAAW,EAAE,CAAC;gBACd,WAAW,EAAE,CAAC;gBACd,MAAM,EAAE,IAAI;aACb,CAAC,CAAC;YAEH,MAAM,MAAM,GAAG,MAAM,cAAc,CAAC,iBAAiB,EAAE,EAAE,SAAS,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC;YAEhF,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;YAC7C,IAAI,MAAM,CAAC,IAAI,KAAK,kBAAkB;gBAAE,MAAM,IAAI,KAAK,CAAC,2BAA2B,CAAC,CAAC;YACrF,MAAM,CAAC,MAAM,CAAC,kBAAkB,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;YAC3C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;YAC9C,MAAM,CAAC,MAAM,CAAC,aAAa,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;QACzD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,gFAAgF,EAAE,KAAK,IAAI,EAAE;YAC9F,MAAM,OAAO,GAAG,gBAAgB,CAAC,MAAM,CAAC;gBACtC,EAAE,EAAE,yBAAyB;gBAC7B,WAAW,EAAE,CAAC;gBACd,WAAW,EAAE,CAAC;gBACd,MAAM,EAAE,IAAI;aACb,CAAC,CAAC;YAEH,MAAM,MAAM,GAAG,MAAM,cAAc,CAAC,iBAAiB,EAAE,EAAE,SAAS,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC;YAEhF,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;YAC7C,IAAI,MAAM,CAAC,IAAI,KAAK,kBAAkB;gBAAE,MAAM,IAAI,KAAK,CAAC,2BAA2B,CAAC,CAAC;YACrF,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;QACjD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,6DAA6D,EAAE,KAAK,IAAI,EAAE;YAC3E,MAAM,MAAM,GAAG,MAAM,cAAc,CAAC,iBAAiB,EAAE,EAAE,SAAS,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;YAE7E,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC;gBACrB,IAAI,EAAE,kBAAkB;gBACxB,kBAAkB,EAAE,EAAE;gBACtB,MAAM,EAAE,WAAW;aACpB,CAAC,CAAC;QACL,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,wEAAwE,EAAE,KAAK,IAAI,EAAE;YACtF,MAAM,OAAO,GAAG,gBAAgB,CAAC,MAAM,CAAC;gBACtC,EAAE,EAAE,yBAAyB;gBAC7B,WAAW,EAAE,CAAC;gBACd,WAAW,EAAE,CAAC;gBACd,MAAM,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,EAAE,OAAO,EAAE,UAAU,EAAE,sBAAsB,EAAE;aAClF,CAAC,CAAC;YAEH,MAAM,MAAM,GAAG,MAAM,cAAc,CAAC,iBAAiB,EAAE,EAAE,SAAS,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC;YAEhF,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,kBAAkB,EAAE,EAAE,EAAE,CAAC,CAAC;QACvE,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,iEAAiE,EAAE,GAAG,EAAE;QAC/E,EAAE,CAAC,wEAAwE,EAAE,GAAG,EAAE;YAChF,MAAM,CAAC,OAAO,mBAAmB,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;QACtD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,MAAM,mBAAmB,GAAG,eAAe,CAAC;AAC5C,MAAM,eAAe,GAAkC,KAAK,IAAI,EAAE,GAAE,CAAC,CAAC;AAEtE,SAAS,cAAc;IACrB,OAAO;QACL,EAAE,EAAE,yBAAyB;QAC7B,QAAQ,EAAE,QAAQ;QAClB,WAAW,EAAE,mBAAmB;QAChC,SAAS,EAAE,YAAY;QACvB,QAAQ,EAAE,EAAE;QACZ,KAAK,EAAE,cAAc;QACrB,KAAK,EAAE,sDAAsD;QAC7D,YAAY,EAAE,WAAW;QACzB,YAAY,EAAE,MAAM;QACpB,OAAO,EAAE,QAAQ;KAClB,CAAC;AACJ,CAAC;AAED,SAAS,cAAc;IACrB,OAAO;QACL,QAAQ,EAAE,GAAG;QACb,WAAW,EAAE,CAAC;QACd,YAAY,EAAE,GAAG;QACjB,WAAW,EAAE,CAAC;QACd,QAAQ,EAAE,KAAK;QACf,WAAW,EAAE,0BAA0B;KACxC,CAAC;AACJ,CAAC;AAED,SAAS,cAAc;IACrB,OAAO;QACL,QAAQ,EAAE,GAAG;QACb,WAAW,EAAE,GAAG;QAChB,YAAY,EAAE,CAAC,EAAE;QACjB,WAAW,EAAE,GAAG;QAChB,QAAQ,EAAE,IAAI;QACd,WAAW,EAAE,0BAA0B;KACxC,CAAC;AACJ,CAAC;AAED,SAAS,gBAAgB,CACvB,YAAgD,EAAE;IAElD,OAAO;QACL,GAAG,EAAE,cAAc,EAAE;QACrB,SAAS,EAAE,eAAe;QAC1B,aAAa,EAAE,iBAAiB;QAChC,UAAU,EAAE,CAAC,YAAY,CAAC;QAC1B,aAAa,EAAE,OAAO;QACtB,WAAW,EAAE,mBAAmB;QAChC,cAAc,EAAE,IAAI;QACpB,GAAG,SAAS;KACb,CAAC;AACJ,CAAC;AAED,SAAS,eAAe,CACtB,YAAuD,EAAE;IAEzD,OAAO;QACL,aAAa,EAAE,EAAE,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,cAAc,EAAE,EAAE,CAAC,CAAC,EAAE;QAC7F,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,IAAI,CAAC;QAChC,MAAM,EAAE,gBAAgB,EAAE;QAC1B,GAAG,SAAS;KACb,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,6FAA6F,EAAE,GAAG,EAAE;IAC3G,QAAQ,CAAC,gEAAgE,EAAE,GAAG,EAAE;QAC9E,EAAE,CAAC,qEAAqE,EAAE,KAAK,IAAI,EAAE;YACnF,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,IAAI,CAAC,CAAC;YACxC,MAAM,OAAO,GAAG,MAAM,oBAAoB,CACxC,gBAAgB,EAAE,EAClB,eAAe,CAAC;gBACd,aAAa,EAAE;oBACb,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,QAAQ,EAAE,KAAK,EAAE,MAAM,EAAE,cAAc,EAAE,EAAE,CAAC,CAAC;iBAC5E;gBACD,OAAO;aACR,CAAC,CACH,CAAC;YAEF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,iBAAiB,EAAE,MAAM,EAAE,cAAc,EAAE,EAAE,CAAC,CAAC;YAC/E,MAAM,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QACzC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;YAChF,MAAM,oBAAoB,GAAG;gBAC3B,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC;oBAC1B,MAAM,EAAE,UAAmB;oBAC3B,KAAK,EAAE,yBAAyB;iBACjC,CAAC,CAAC;aACJ,CAAC;YACF,MAAM,OAAO,GAAG,MAAM,oBAAoB,CACxC,gBAAgB,EAAE,EAClB,eAAe,CAAC;gBACd,oBAAoB;gBACpB,cAAc,EAAE,EAAE,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,IAAI,CAAC,EAAE;aACrD,CAAC,CACH,CAAC;YAEF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,KAAK,EAAE,yBAAyB,EAAE,CAAC,CAAC;QAChF,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,2DAA2D,EAAE,KAAK,IAAI,EAAE;YACzE,MAAM,oBAAoB,GAAG;gBAC3B,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC;oBAC1B,MAAM,EAAE,SAAkB;oBAC1B,SAAS,EAAE,mBAAmB;iBAC/B,CAAC,CAAC;aACJ,CAAC;YACF,MAAM,OAAO,GAAG,MAAM,oBAAoB,CACxC,gBAAgB,EAAE,EAClB,eAAe,CAAC;gBACd,oBAAoB;gBACpB,cAAc,EAAE,EAAE,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,IAAI,CAAC,EAAE;aACrD,CAAC,CACH,CAAC;YAEF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,SAAS,EAAE,mBAAmB,EAAE,CAAC,CAAC;QAC/E,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4FAA4F,EAAE,KAAK,IAAI,EAAE;YAC1G,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,IAAI,CAAC,CAAC;YACxC,MAAM,OAAO,GAAG,MAAM,oBAAoB,CACxC,gBAAgB,CAAC,EAAE,cAAc,EAAE,IAAI,EAAE,CAAC,EAC1C,eAAe,CAAC,EAAE,OAAO,EAAE,cAAc,EAAE,EAAE,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,KAAK,CAAC,EAAE,EAAE,CAAC,CACpF,CAAC;YAEF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,SAAS,EAAE,IAAI,EAAE,MAAM,EAAE,iBAAiB,EAAE,CAAC,CAAC;YACzF,MAAM,CAAC,OAAO,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QACzC,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,wEAAwE,EAAE,KAAK,IAAI,EAAE;YACtF,MAAM,oBAAoB,GAAG;gBAC3B,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,EAAE,MAAM,EAAE,UAAmB,EAAE,MAAM,EAAE,gBAAgB,EAAE,CAAC,CAAC;aACxF,CAAC;YACF,MAAM,OAAO,GAAG,MAAM,oBAAoB,CACxC,gBAAgB,EAAE,EAClB,eAAe,CAAC;gBACd,oBAAoB;gBACpB,cAAc,EAAE,EAAE,OAAO,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,IAAI,CAAC,EAAE;aACrD,CAAC,CACH,CAAC;YAEF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,cAAc,EAAE,KAAK,EAAE,yBAAyB,EAAE,CAAC,CAAC;QACtF,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,+EAA+E,EAAE,KAAK,IAAI,EAAE;YAC7F,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,IAAI,CAAC,CAAC;YACxC,MAAM,OAAO,GAAG,MAAM,oBAAoB,CACxC,gBAAgB,CAAC,EAAE,aAAa,EAAE,kBAAkB,EAAE,cAAc,EAAE,KAAK,EAAE,CAAC,EAC9E,eAAe,CAAC,EAAE,OAAO,EAAE,CAAC,CAC7B,CAAC;YAEF,MAAM,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,KAAK,EAAE,yBAAyB,EAAE,CAAC,CAAC;YAC9E,MAAM,CAAC,OAAO,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAC;QAC3C,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/tests/units/frameworks/claude/claudeInvoker.test.js

@@ -49,5 +49,20 @@ describe('buildMcpSystemPrompt', () => {
             expect(prompt).toContain('job-xyz');
         });
     });
+    describe('report output path — prevents report-missing in --bg mode', () => {
+        it('pins the review report to .claude/reviews with the review suffix', () => {
+            const prompt = buildMcpSystemPrompt(buildJob({ jobType: 'review', mrNumber: 5450 }));
+            expect(prompt).toContain('.claude/reviews/');
+            expect(prompt).toContain('-MR-5450-review.md');
+        });
+        it('uses the followup suffix for followup jobs', () => {
+            const prompt = buildMcpSystemPrompt(buildJob({ jobType: 'followup', mrNumber: 77 }));
+            expect(prompt).toContain('-MR-77-followup.md');
+        });
+        it('forbids writing the report to the background job tmp directory', () => {
+            const prompt = buildMcpSystemPrompt(buildJob({ jobType: 'review', mrNumber: 5450 }));
+            expect(prompt).toContain('CLAUDE_JOB_DIR');
+        });
+    });
 });
 //# sourceMappingURL=claudeInvoker.test.js.map

package/dist/tests/units/frameworks/claude/claudeInvoker.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"claudeInvoker.test.js","sourceRoot":"","sources":["../../../../../src/tests/units/frameworks/claude/claudeInvoker.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAE9C,OAAO,EAAE,oBAAoB,EAAE,MAAM,sCAAsC,CAAC;AAG5E,SAAS,QAAQ,CAAC,SAA6B;IAC7C,OAAO;QACL,EAAE,EAAE,OAAO;QACX,QAAQ,EAAE,QAAQ;QAClB,WAAW,EAAE,eAAe;QAC5B,SAAS,EAAE,cAAc;QACzB,QAAQ,EAAE,EAAE;QACZ,KAAK,EAAE,iBAAiB;QACxB,KAAK,EAAE,2BAA2B;QAClC,YAAY,EAAE,QAAQ;QACtB,YAAY,EAAE,MAAM;QACpB,OAAO,EAAE,UAAU;QACnB,GAAG,SAAS;KACb,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,sBAAsB,EAAE,GAAG,EAAE;IACpC,QAAQ,CAAC,qDAAqD,EAAE,GAAG,EAAE;QACnE,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;YACzD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;YAEnF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAC7C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;YACxD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;YAEnF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC;QAC5C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;YACjD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;YAEnF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,cAAc,CAAC,CAAC;QAC/C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;YAC/C,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC;YAErF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAC7C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;YACjD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;YAEnF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,cAAc,CAAC,CAAC;QAC/C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;YAC/C,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC;YAErF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAC7C,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,gDAAgD,EAAE,GAAG,EAAE;QAC9D,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;YACvD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,EAAE,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;YAEjE,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,aAAa,CAAC,CAAC;YACxC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;QACtC,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
+{"version":3,"file":"claudeInvoker.test.js","sourceRoot":"","sources":["../../../../../src/tests/units/frameworks/claude/claudeInvoker.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAE9C,OAAO,EAAE,oBAAoB,EAAE,MAAM,sCAAsC,CAAC;AAG5E,SAAS,QAAQ,CAAC,SAA6B;IAC7C,OAAO;QACL,EAAE,EAAE,OAAO;QACX,QAAQ,EAAE,QAAQ;QAClB,WAAW,EAAE,eAAe;QAC5B,SAAS,EAAE,cAAc;QACzB,QAAQ,EAAE,EAAE;QACZ,KAAK,EAAE,iBAAiB;QACxB,KAAK,EAAE,2BAA2B;QAClC,YAAY,EAAE,QAAQ;QACtB,YAAY,EAAE,MAAM;QACpB,OAAO,EAAE,UAAU;QACnB,GAAG,SAAS;KACb,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,sBAAsB,EAAE,GAAG,EAAE;IACpC,QAAQ,CAAC,qDAAqD,EAAE,GAAG,EAAE;QACnE,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;YACzD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;YAEnF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAC7C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;YACxD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;YAEnF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC;QAC5C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;YACjD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;YAEnF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,cAAc,CAAC,CAAC;QAC/C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;YAC/C,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC;YAErF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAC7C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;YACjD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC;YAEnF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,cAAc,CAAC,CAAC;QAC/C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;YAC/C,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,QAAQ,EAAE,QAAQ,EAAE,QAAQ,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC;YAErF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QAC7C,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,gDAAgD,EAAE,GAAG,EAAE;QAC9D,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;YACvD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,EAAE,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;YAEjE,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,aAAa,CAAC,CAAC;YACxC,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;QACtC,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACzE,EAAE,CAAC,kEAAkE,EAAE,GAAG,EAAE;YAC1E,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC;YAErF,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,kBAAkB,CAAC,CAAC;YAC7C,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,oBAAoB,CAAC,CAAC;QACjD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;YACpD,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC,CAAC,CAAC;YAErF,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,oBAAoB,CAAC,CAAC;QACjD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,gEAAgE,EAAE,GAAG,EAAE;YACxE,MAAM,MAAM,GAAG,oBAAoB,CAAC,QAAQ,CAAC,EAAE,OAAO,EAAE,QAAQ,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC;YAErF,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,gBAAgB,CAAC,CAAC;QAC7C,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}