reviewflow 3.34.0 → 3.35.0

package/dist/tests/units/modules/claude-invocation/usecases/awaitSessionCompletion.usecase.test.js

@@ -35,6 +35,72 @@ describe('awaitSessionCompletion use case', () => {
         expect(completion.source).toBe('polling');
         expect(completion.outcome).toBe('completed');
     });
+    it('maps a stopped agent status to a stopped polling outcome', async () => {
+        const session = ClaudeSessionFactory.create({ sessionId: parseSessionId('stop0003') });
+        const bridge = new StubMcpCompletionBridge();
+        const sessionGateway = new StubClaudeSessionGateway();
+        sessionGateway.scheduleAgentCompletion('stop0003', 'stopped', 1);
+        const promise = awaitSessionCompletion({ session, timeoutMs: 60_000, pollIntervalMs: 30_000 }, { sessionGateway, completionBridge: bridge, now: () => new Date('2026-05-22T10:00:00Z') });
+        await vi.advanceTimersByTimeAsync(30_000);
+        const completion = await promise;
+        expect(completion.source).toBe('polling');
+        expect(completion.outcome).toBe('stopped');
+        expect(completion.reason).toBeNull();
+    });
+    it('maps a failed agent status to a failed polling outcome', async () => {
+        const session = ClaudeSessionFactory.create({ sessionId: parseSessionId('fail0004') });
+        const bridge = new StubMcpCompletionBridge();
+        const sessionGateway = new StubClaudeSessionGateway();
+        sessionGateway.scheduleAgentCompletion('fail0004', 'failed', 1);
+        const promise = awaitSessionCompletion({ session, timeoutMs: 60_000, pollIntervalMs: 30_000 }, { sessionGateway, completionBridge: bridge, now: () => new Date('2026-05-22T10:00:00Z') });
+        await vi.advanceTimersByTimeAsync(30_000);
+        const completion = await promise;
+        expect(completion.source).toBe('polling');
+        expect(completion.outcome).toBe('failed');
+        expect(completion.reason).toBeNull();
+    });
+    it('keeps polling while the agent is still running, then settles when it completes', async () => {
+        const session = ClaudeSessionFactory.create({ sessionId: parseSessionId('run00005') });
+        const bridge = new StubMcpCompletionBridge();
+        class RunningThenDoneSessionGateway extends StubClaudeSessionGateway {
+            async listAgents() {
+                const call = this.listAgentsCallCount + 1;
+                await super.listAgents();
+                const status = call === 1 ? 'running' : 'completed';
+                return [{ sessionId: session.sessionId, status }];
+            }
+        }
+        const sessionGateway = new RunningThenDoneSessionGateway();
+        const promise = awaitSessionCompletion({ session, timeoutMs: 60_000, pollIntervalMs: 10_000 }, { sessionGateway, completionBridge: bridge, now: () => new Date('2026-05-22T10:00:00Z') });
+        await vi.advanceTimersByTimeAsync(10_000);
+        expect(sessionGateway.listAgentsCallCount).toBe(1);
+        await vi.advanceTimersByTimeAsync(10_000);
+        const completion = await promise;
+        expect(completion.source).toBe('polling');
+        expect(completion.outcome).toBe('completed');
+    });
+    it('treats a listAgents error as non-fatal and retries on the next tick', async () => {
+        const session = ClaudeSessionFactory.create({ sessionId: parseSessionId('errr0006') });
+        const bridge = new StubMcpCompletionBridge();
+        class ThrowOnceSessionGateway extends StubClaudeSessionGateway {
+            hasThrown = false;
+            async listAgents() {
+                if (!this.hasThrown) {
+                    this.hasThrown = true;
+                    throw new Error('daemon unreachable');
+                }
+                return super.listAgents();
+            }
+        }
+        const sessionGateway = new ThrowOnceSessionGateway();
+        sessionGateway.scheduleAgentCompletion('errr0006', 'completed', 1);
+        const promise = awaitSessionCompletion({ session, timeoutMs: 60_000, pollIntervalMs: 10_000 }, { sessionGateway, completionBridge: bridge, now: () => new Date('2026-05-22T10:00:00Z') });
+        await vi.advanceTimersByTimeAsync(10_000);
+        await vi.advanceTimersByTimeAsync(10_000);
+        const completion = await promise;
+        expect(completion.source).toBe('polling');
+        expect(completion.outcome).toBe('completed');
+    });
     it('returns timeout when no signal arrives within the timeout window', async () => {
         const session = ClaudeSessionFactory.create({ sessionId: parseSessionId('time0002') });
         const bridge = new StubMcpCompletionBridge();

package/dist/tests/units/modules/claude-invocation/usecases/awaitSessionCompletion.usecase.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"awaitSessionCompletion.usecase.test.js","sourceRoot":"","sources":["../../../../../../src/tests/units/modules/claude-invocation/usecases/awaitSessionCompletion.usecase.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,sBAAsB,EAAE,MAAM,wEAAwE,CAAC;AAChH,OAAO,EAAE,uBAAuB,EAAE,MAAM,qCAAqC,CAAC;AAC9E,OAAO,EAAE,wBAAwB,EAAE,MAAM,qCAAqC,CAAC;AAC/E,OAAO,EAAE,oBAAoB,EAAE,MAAM,4CAA4C,CAAC;AAClF,OAAO,EAAE,cAAc,EAAE,MAAM,4EAA4E,CAAC;AAE5G,QAAQ,CAAC,iCAAiC,EAAE,GAAG,EAAE;IAC/C,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACnB,EAAE,CAAC,aAAa,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAC,CAAC;IACrD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kDAAkD,EAAE,KAAK,IAAI,EAAE;QAChE,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,MAAM,CAAC,kBAAkB,CAAC,OAAO,CAAC,KAAK,EAAE;YACvC,MAAM,EAAE,KAAK;YACb,OAAO,EAAE,WAAW;YACpB,MAAM,EAAE,IAAI;SACb,CAAC,CAAC;QAEH,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EACtD,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,CAC1F,CAAC;QACF,MAAM,EAAE,CAAC,iBAAiB,EAAE,CAAC;QAC7B,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACtC,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,uBAAuB,CAAC,UAAU,EAAE,WAAW,EAAE,CAAC,CAAC,CAAC;QAEnE,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EACtD,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,CAC1F,CAAC;QACF,MAAM,EAAE,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;QAChF,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,IAAI,KAAK,GAAG,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAC,OAAO,EAAE,CAAC;QACvD,MAAM,GAAG,GAAG,GAAS,EAAE,CAAC,IAAI,IAAI,CAAC,KAAK,CAAC,CAAC;QAExC,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,EAAE,GAAG,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EAC3D,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,CAClD,CAAC;QACF,KAAK,IAAI,EAAE,GAAG,MAAM,CAAC;QACrB,MAAM,EAAE,CAAC,wBAAwB,CAAC,EAAE,GAAG,MAAM,CAAC,CAAC;QAC/C,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
+{"version":3,"file":"awaitSessionCompletion.usecase.test.js","sourceRoot":"","sources":["../../../../../../src/tests/units/modules/claude-invocation/usecases/awaitSessionCompletion.usecase.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,sBAAsB,EAAE,MAAM,wEAAwE,CAAC;AAChH,OAAO,EAAE,uBAAuB,EAAE,MAAM,qCAAqC,CAAC;AAC9E,OAAO,EAAE,wBAAwB,EAAE,MAAM,qCAAqC,CAAC;AAC/E,OAAO,EAAE,oBAAoB,EAAE,MAAM,4CAA4C,CAAC;AAClF,OAAO,EAAE,cAAc,EAAE,MAAM,4EAA4E,CAAC;AAM5G,QAAQ,CAAC,iCAAiC,EAAE,GAAG,EAAE;IAC/C,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACnB,EAAE,CAAC,aAAa,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAC,CAAC;IACrD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kDAAkD,EAAE,KAAK,IAAI,EAAE;QAChE,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,MAAM,CAAC,kBAAkB,CAAC,OAAO,CAAC,KAAK,EAAE;YACvC,MAAM,EAAE,KAAK;YACb,OAAO,EAAE,WAAW;YACpB,MAAM,EAAE,IAAI;SACb,CAAC,CAAC;QAEH,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EACtD,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,CAC1F,CAAC;QACF,MAAM,EAAE,CAAC,iBAAiB,EAAE,CAAC;QAC7B,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACtC,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,uBAAuB,CAAC,UAAU,EAAE,WAAW,EAAE,CAAC,CAAC,CAAC;QAEnE,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EACtD,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,CAC1F,CAAC;QACF,MAAM,EAAE,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0DAA0D,EAAE,KAAK,IAAI,EAAE;QACxE,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,uBAAuB,CAAC,UAAU,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAEjE,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EACtD,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,CAC1F,CAAC;QACF,MAAM,EAAE,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC3C,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;IACvC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,KAAK,IAAI,EAAE;QACtE,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,uBAAuB,CAAC,UAAU,EAAE,QAAQ,EAAE,CAAC,CAAC,CAAC;QAEhE,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EACtD,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,CAC1F,CAAC;QACF,MAAM,EAAE,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;IACvC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gFAAgF,EAAE,KAAK,IAAI,EAAE;QAC9F,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,6BAA8B,SAAQ,wBAAwB;YACzD,KAAK,CAAC,UAAU;gBACvB,MAAM,IAAI,GAAG,IAAI,CAAC,mBAAmB,GAAG,CAAC,CAAC;gBAC1C,MAAM,KAAK,CAAC,UAAU,EAAE,CAAC;gBACzB,MAAM,MAAM,GAAqB,IAAI,KAAK,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,WAAW,CAAC;gBACtE,OAAO,CAAC,EAAE,SAAS,EAAE,OAAO,CAAC,SAAS,EAAE,MAAM,EAAE,CAAC,CAAC;YACpD,CAAC;SACF;QACD,MAAM,cAAc,GAAG,IAAI,6BAA6B,EAAE,CAAC;QAE3D,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EACtD,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,CAC1F,CAAC;QACF,MAAM,EAAE,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,CAAC,cAAc,CAAC,mBAAmB,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACnD,MAAM,EAAE,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qEAAqE,EAAE,KAAK,IAAI,EAAE;QACnF,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,uBAAwB,SAAQ,wBAAwB;YACpD,SAAS,GAAG,KAAK,CAAC;YACjB,KAAK,CAAC,UAAU;gBACvB,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,CAAC;oBACpB,IAAI,CAAC,SAAS,GAAG,IAAI,CAAC;oBACtB,MAAM,IAAI,KAAK,CAAC,oBAAoB,CAAC,CAAC;gBACxC,CAAC;gBACD,OAAO,KAAK,CAAC,UAAU,EAAE,CAAC;YAC5B,CAAC;SACF;QACD,MAAM,cAAc,GAAG,IAAI,uBAAuB,EAAE,CAAC;QACrD,cAAc,CAAC,uBAAuB,CAAC,UAAU,EAAE,WAAW,EAAE,CAAC,CAAC,CAAC;QAEnE,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EACtD,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,CAC1F,CAAC;QACF,MAAM,EAAE,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,EAAE,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;QAChF,MAAM,OAAO,GAAG,oBAAoB,CAAC,MAAM,CAAC,EAAE,SAAS,EAAE,cAAc,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;QACvF,MAAM,MAAM,GAAG,IAAI,uBAAuB,EAAE,CAAC;QAC7C,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,IAAI,KAAK,GAAG,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAC,OAAO,EAAE,CAAC;QACvD,MAAM,GAAG,GAAG,GAAS,EAAE,CAAC,IAAI,IAAI,CAAC,KAAK,CAAC,CAAC;QAExC,MAAM,OAAO,GAAG,sBAAsB,CACpC,EAAE,OAAO,EAAE,SAAS,EAAE,EAAE,GAAG,MAAM,EAAE,cAAc,EAAE,MAAM,EAAE,EAC3D,EAAE,cAAc,EAAE,gBAAgB,EAAE,MAAM,EAAE,GAAG,EAAE,CAClD,CAAC;QACF,KAAK,IAAI,EAAE,GAAG,MAAM,CAAC;QACrB,MAAM,EAAE,CAAC,wBAAwB,CAAC,EAAE,GAAG,MAAM,CAAC,CAAC;QAC/C,MAAM,UAAU,GAAG,MAAM,OAAO,CAAC;QAEjC,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/tests/units/modules/claude-invocation/usecases/cleanupClaudeSession.usecase.test.js

@@ -13,5 +13,67 @@ describe('cleanupClaudeSession use case', () => {
         expect(sessionGateway.stopCalls).toContain(sessionId);
         expect(sessionGateway.removeCalls).toContain(sessionId);
     });
+    it('records a stop warning when stop fails with a warning', async () => {
+        const sessionGateway = new StubClaudeSessionGateway();
+        sessionGateway.setStopResult({ success: false, warning: 'not running' });
+        const sessionId = parseSessionId('clean002');
+        const result = await cleanupClaudeSession({ sessionId }, { sessionGateway });
+        expect(result.stopped).toBe(false);
+        expect(result.removed).toBe(true);
+        expect(result.warnings).toEqual(['stop: not running']);
+    });
+    it('records a remove warning when remove fails with a warning', async () => {
+        const sessionGateway = new StubClaudeSessionGateway();
+        sessionGateway.setRemoveResult({ success: false, warning: 'still present' });
+        const sessionId = parseSessionId('clean003');
+        const result = await cleanupClaudeSession({ sessionId }, { sessionGateway });
+        expect(result.stopped).toBe(true);
+        expect(result.removed).toBe(false);
+        expect(result.warnings).toEqual(['remove: still present']);
+    });
+    it('does not record a warning when a step fails without a warning message', async () => {
+        const sessionGateway = new StubClaudeSessionGateway();
+        sessionGateway.setStopResult({ success: false, warning: null });
+        const sessionId = parseSessionId('clean004');
+        const result = await cleanupClaudeSession({ sessionId }, { sessionGateway });
+        expect(result.stopped).toBe(false);
+        expect(result.removed).toBe(true);
+        expect(result.warnings).toEqual([]);
+    });
+    it('captures the message when stop throws an Error', async () => {
+        const sessionGateway = new StubClaudeSessionGateway();
+        sessionGateway.setStopError(new Error('daemon unreachable'));
+        const sessionId = parseSessionId('clean005');
+        const result = await cleanupClaudeSession({ sessionId }, { sessionGateway });
+        expect(result.stopped).toBe(false);
+        expect(result.removed).toBe(true);
+        expect(result.warnings).toEqual([
+            'stop failed: daemon unreachable',
+            'stop: daemon unreachable',
+        ]);
+    });
+    it('stringifies the value when remove throws a non-Error', async () => {
+        const sessionGateway = new StubClaudeSessionGateway();
+        sessionGateway.setRemoveError('boom');
+        const sessionId = parseSessionId('clean006');
+        const result = await cleanupClaudeSession({ sessionId }, { sessionGateway });
+        expect(result.stopped).toBe(true);
+        expect(result.removed).toBe(false);
+        expect(result.warnings).toEqual(['remove failed: boom', 'remove: boom']);
+    });
+    it('accumulates warnings from both stop and remove failures', async () => {
+        const sessionGateway = new StubClaudeSessionGateway();
+        sessionGateway.setStopError(new Error('stop blew up'));
+        sessionGateway.setRemoveResult({ success: false, warning: 'cannot delete' });
+        const sessionId = parseSessionId('clean007');
+        const result = await cleanupClaudeSession({ sessionId }, { sessionGateway });
+        expect(result.stopped).toBe(false);
+        expect(result.removed).toBe(false);
+        expect(result.warnings).toEqual([
+            'stop failed: stop blew up',
+            'stop: stop blew up',
+            'remove: cannot delete',
+        ]);
+    });
 });
 //# sourceMappingURL=cleanupClaudeSession.usecase.test.js.map

package/dist/tests/units/modules/claude-invocation/usecases/cleanupClaudeSession.usecase.test.js.map

@@ -1 +1 @@
-{"version":3,"file":"cleanupClaudeSession.usecase.test.js","sourceRoot":"","sources":["../../../../../../src/tests/units/modules/claude-invocation/usecases/cleanupClaudeSession.usecase.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,oBAAoB,EAAE,MAAM,sEAAsE,CAAC;AAC5G,OAAO,EAAE,wBAAwB,EAAE,MAAM,qCAAqC,CAAC;AAC/E,OAAO,EAAE,cAAc,EAAE,MAAM,4EAA4E,CAAC;AAE5G,QAAQ,CAAC,+BAA+B,EAAE,GAAG,EAAE;IAC7C,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;QAC/D,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,MAAM,SAAS,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;QAE7C,MAAM,MAAM,GAAG,MAAM,oBAAoB,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC,CAAC;QAE7E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QACpC,MAAM,CAAC,cAAc,CAAC,SAAS,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;QACtD,MAAM,CAAC,cAAc,CAAC,WAAW,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
+{"version":3,"file":"cleanupClaudeSession.usecase.test.js","sourceRoot":"","sources":["../../../../../../src/tests/units/modules/claude-invocation/usecases/cleanupClaudeSession.usecase.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,oBAAoB,EAAE,MAAM,sEAAsE,CAAC;AAC5G,OAAO,EAAE,wBAAwB,EAAE,MAAM,qCAAqC,CAAC;AAC/E,OAAO,EAAE,cAAc,EAAE,MAAM,4EAA4E,CAAC;AAE5G,QAAQ,CAAC,+BAA+B,EAAE,GAAG,EAAE;IAC7C,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;QAC/D,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,MAAM,SAAS,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;QAE7C,MAAM,MAAM,GAAG,MAAM,oBAAoB,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC,CAAC;QAE7E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QACpC,MAAM,CAAC,cAAc,CAAC,SAAS,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;QACtD,MAAM,CAAC,cAAc,CAAC,WAAW,CAAC,CAAC,SAAS,CAAC,SAAS,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,KAAK,IAAI,EAAE;QACrE,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,aAAa,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,OAAO,EAAE,aAAa,EAAE,CAAC,CAAC;QACzE,MAAM,SAAS,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;QAE7C,MAAM,MAAM,GAAG,MAAM,oBAAoB,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC,CAAC;QAE7E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,CAAC,mBAAmB,CAAC,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2DAA2D,EAAE,KAAK,IAAI,EAAE;QACzE,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,eAAe,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,OAAO,EAAE,eAAe,EAAE,CAAC,CAAC;QAC7E,MAAM,SAAS,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;QAE7C,MAAM,MAAM,GAAG,MAAM,oBAAoB,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC,CAAC;QAE7E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,CAAC,uBAAuB,CAAC,CAAC,CAAC;IAC7D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uEAAuE,EAAE,KAAK,IAAI,EAAE;QACrF,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,aAAa,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC;QAChE,MAAM,SAAS,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;QAE7C,MAAM,MAAM,GAAG,MAAM,oBAAoB,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC,CAAC;QAE7E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IACtC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gDAAgD,EAAE,KAAK,IAAI,EAAE;QAC9D,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,YAAY,CAAC,IAAI,KAAK,CAAC,oBAAoB,CAAC,CAAC,CAAC;QAC7D,MAAM,SAAS,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;QAE7C,MAAM,MAAM,GAAG,MAAM,oBAAoB,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC,CAAC;QAE7E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC;YAC9B,iCAAiC;YACjC,0BAA0B;SAC3B,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC;QACtC,MAAM,SAAS,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;QAE7C,MAAM,MAAM,GAAG,MAAM,oBAAoB,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC,CAAC;QAE7E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,CAAC,qBAAqB,EAAE,cAAc,CAAC,CAAC,CAAC;IAC3E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,KAAK,IAAI,EAAE;QACvE,MAAM,cAAc,GAAG,IAAI,wBAAwB,EAAE,CAAC;QACtD,cAAc,CAAC,YAAY,CAAC,IAAI,KAAK,CAAC,cAAc,CAAC,CAAC,CAAC;QACvD,cAAc,CAAC,eAAe,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,OAAO,EAAE,eAAe,EAAE,CAAC,CAAC;QAC7E,MAAM,SAAS,GAAG,cAAc,CAAC,UAAU,CAAC,CAAC;QAE7C,MAAM,MAAM,GAAG,MAAM,oBAAoB,CAAC,EAAE,SAAS,EAAE,EAAE,EAAE,cAAc,EAAE,CAAC,CAAC;QAE7E,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACnC,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC;YAC9B,2BAA2B;YAC3B,oBAAoB;YACpB,uBAAuB;SACxB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/tests/units/modules/cli-configuration/interface-adapters/controllers/http/cliStatus.routes.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=cliStatus.routes.test.d.ts.map

package/dist/tests/units/modules/cli-configuration/interface-adapters/controllers/http/cliStatus.routes.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"cliStatus.routes.test.d.ts","sourceRoot":"","sources":["../../../../../../../../src/tests/units/modules/cli-configuration/interface-adapters/controllers/http/cliStatus.routes.test.ts"],"names":[],"mappings":""}

package/dist/tests/units/modules/cli-configuration/interface-adapters/controllers/http/cliStatus.routes.test.js

@@ -0,0 +1,182 @@
+import { describe, it, expect, beforeEach, vi } from 'vitest';
+import { EventEmitter } from 'node:events';
+import Fastify from 'fastify';
+class FakeChildProcess extends EventEmitter {
+    stdout = new EventEmitter();
+    stderr = new EventEmitter();
+    emitStdout(data) {
+        this.stdout.emit('data', Buffer.from(data));
+    }
+    emitStderr(data) {
+        this.stderr.emit('data', Buffer.from(data));
+    }
+}
+let currentChild;
+let lastCommand;
+vi.mock('node:child_process', () => ({
+    spawn: (command) => {
+        lastCommand = command;
+        return currentChild;
+    },
+}));
+vi.mock('@/shared/services/claudePathResolver.js', () => ({
+    resolveClaudePath: () => '/usr/bin/claude',
+}));
+const { cliStatusRoutes } = await import('../../../../../../../modules/cli-configuration/interface-adapters/controllers/http/cliStatus.routes.js');
+describe('cliStatus routes', () => {
+    let app;
+    beforeEach(async () => {
+        app = Fastify();
+        await app.register(cliStatusRoutes);
+        await app.ready();
+        currentChild = new FakeChildProcess();
+    });
+    function injectAfter(url, drive) {
+        const responsePromise = app.inject({ method: 'GET', url });
+        setImmediate(() => drive(currentChild));
+        return responsePromise;
+    }
+    describe('GET /api/claude/status', () => {
+        it('should report available when version is returned with exit code 0', async () => {
+            const response = await injectAfter('/api/claude/status', (child) => {
+                child.emitStdout('1.2.3');
+                child.emit('close', 0);
+            });
+            expect(lastCommand).toBe('/usr/bin/claude');
+            const body = response.json();
+            expect(body.available).toBe(true);
+            expect(body.version).toBe('1.2.3');
+            expect(body.message).toBe('Claude CLI operational');
+            expect(typeof body.duration).toBe('number');
+        });
+        it('should report unavailable with the error message on spawn error', async () => {
+            const response = await injectAfter('/api/claude/status', (child) => {
+                child.emit('error', new Error('spawn ENOENT'));
+            });
+            const body = response.json();
+            expect(body.available).toBe(false);
+            expect(body.error).toBe('spawn ENOENT');
+            expect(body.message).toBe('Claude CLI not installed or not accessible');
+        });
+        it('should report authentication message when stderr mentions not logged in', async () => {
+            const response = await injectAfter('/api/claude/status', (child) => {
+                child.emitStderr('error: not logged in');
+                child.emit('close', 1);
+            });
+            const body = response.json();
+            expect(body.available).toBe(false);
+            expect(body.exitCode).toBe(1);
+            expect(body.stderr).toBe('error: not logged in');
+            expect(body.message).toBe('Not authenticated - run "claude login"');
+        });
+        it('should report generic CLI error when exit code is non-zero without auth hint', async () => {
+            const response = await injectAfter('/api/claude/status', (child) => {
+                child.emitStderr('boom');
+                child.emit('close', 2);
+            });
+            const body = response.json();
+            expect(body.available).toBe(false);
+            expect(body.exitCode).toBe(2);
+            expect(body.message).toBe('Claude CLI error');
+        });
+        it('should report error when exit code is 0 but stdout is empty', async () => {
+            const response = await injectAfter('/api/claude/status', (child) => {
+                child.emit('close', 0);
+            });
+            const body = response.json();
+            expect(body.available).toBe(false);
+            expect(body.message).toBe('Claude CLI error');
+        });
+    });
+    describe('GET /api/gitlab/status', () => {
+        it('should spawn glab and report authenticated with valid JSON user', async () => {
+            const response = await injectAfter('/api/gitlab/status', (child) => {
+                child.emitStdout(JSON.stringify({ username: 'octocat' }));
+                child.emit('close', 0);
+            });
+            expect(lastCommand).toBe('glab');
+            const body = response.json();
+            expect(body.available).toBe(true);
+            expect(body.authenticated).toBe(true);
+            expect(body.username).toBe('octocat');
+            expect(body.message).toBe('GitLab CLI operational');
+        });
+        it('should report invalid response when stdout is not valid JSON', async () => {
+            const response = await injectAfter('/api/gitlab/status', (child) => {
+                child.emitStdout('not-json');
+                child.emit('close', 0);
+            });
+            const body = response.json();
+            expect(body.available).toBe(true);
+            expect(body.authenticated).toBe(false);
+            expect(body.message).toBe('Invalid GitLab response');
+        });
+        it('should report not installed on spawn error', async () => {
+            const response = await injectAfter('/api/gitlab/status', (child) => {
+                child.emit('error', new Error('glab missing'));
+            });
+            const body = response.json();
+            expect(body.available).toBe(false);
+            expect(body.authenticated).toBe(false);
+            expect(body.error).toBe('glab missing');
+            expect(body.message).toBe('GitLab CLI (glab) not installed');
+            expect(body.command).toBe('sudo apt install glab');
+        });
+        it('should report not authenticated when exit code is non-zero', async () => {
+            const response = await injectAfter('/api/gitlab/status', (child) => {
+                child.emitStderr('unauthorized');
+                child.emit('close', 1);
+            });
+            const body = response.json();
+            expect(body.available).toBe(true);
+            expect(body.authenticated).toBe(false);
+            expect(body.message).toBe('Not authenticated to GitLab');
+        });
+    });
+    describe('GET /api/github/status', () => {
+        it('should spawn gh and report authenticated with valid JSON user', async () => {
+            const response = await injectAfter('/api/github/status', (child) => {
+                child.emitStdout(JSON.stringify({ login: 'monalisa' }));
+                child.emit('close', 0);
+            });
+            expect(lastCommand).toBe('gh');
+            const body = response.json();
+            expect(body.available).toBe(true);
+            expect(body.authenticated).toBe(true);
+            expect(body.username).toBe('monalisa');
+            expect(body.message).toBe('GitHub CLI operational');
+        });
+        it('should report invalid response when stdout is not valid JSON', async () => {
+            const response = await injectAfter('/api/github/status', (child) => {
+                child.emitStdout('}{');
+                child.emit('close', 0);
+            });
+            const body = response.json();
+            expect(body.available).toBe(true);
+            expect(body.authenticated).toBe(false);
+            expect(body.message).toBe('Invalid GitHub response');
+        });
+        it('should report not installed on spawn error', async () => {
+            const response = await injectAfter('/api/github/status', (child) => {
+                child.emit('error', new Error('gh missing'));
+            });
+            const body = response.json();
+            expect(body.available).toBe(false);
+            expect(body.authenticated).toBe(false);
+            expect(body.error).toBe('gh missing');
+            expect(body.message).toBe('GitHub CLI (gh) not installed');
+            expect(body.command).toBe('sudo apt install gh');
+        });
+        it('should report not authenticated when exit code is non-zero', async () => {
+            const response = await injectAfter('/api/github/status', (child) => {
+                child.emitStderr('bad creds');
+                child.emit('close', 1);
+            });
+            const body = response.json();
+            expect(body.available).toBe(true);
+            expect(body.authenticated).toBe(false);
+            expect(body.message).toBe('Not authenticated - run: gh auth login');
+        });
+    });
+});
+//# sourceMappingURL=cliStatus.routes.test.js.map

package/dist/tests/units/modules/cli-configuration/interface-adapters/controllers/http/cliStatus.routes.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"cliStatus.routes.test.js","sourceRoot":"","sources":["../../../../../../../../src/tests/units/modules/cli-configuration/interface-adapters/controllers/http/cliStatus.routes.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,YAAY,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,OAAO,MAAM,SAAS,CAAC;AAG9B,MAAM,gBAAiB,SAAQ,YAAY;IACzC,MAAM,GAAG,IAAI,YAAY,EAAE,CAAC;IAC5B,MAAM,GAAG,IAAI,YAAY,EAAE,CAAC;IAE5B,UAAU,CAAC,IAAY;QACrB,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,MAAM,EAAE,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;IAC9C,CAAC;IAED,UAAU,CAAC,IAAY;QACrB,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,MAAM,EAAE,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;IAC9C,CAAC;CACF;AAED,IAAI,YAA8B,CAAC;AACnC,IAAI,WAAmB,CAAC;AAExB,EAAE,CAAC,IAAI,CAAC,oBAAoB,EAAE,GAAG,EAAE,CAAC,CAAC;IACnC,KAAK,EAAE,CAAC,OAAe,EAAE,EAAE;QACzB,WAAW,GAAG,OAAO,CAAC;QACtB,OAAO,YAAY,CAAC;IACtB,CAAC;CACF,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,yCAAyC,EAAE,GAAG,EAAE,CAAC,CAAC;IACxD,iBAAiB,EAAE,GAAG,EAAE,CAAC,iBAAiB;CAC3C,CAAC,CAAC,CAAC;AAEJ,MAAM,EAAE,eAAe,EAAE,GAAG,MAAM,MAAM,CACtC,qFAAqF,CACtF,CAAC;AAEF,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;IAChC,IAAI,GAAoB,CAAC;IAEzB,UAAU,CAAC,KAAK,IAAI,EAAE;QACpB,GAAG,GAAG,OAAO,EAAE,CAAC;QAChB,MAAM,GAAG,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC;QACpC,MAAM,GAAG,CAAC,KAAK,EAAE,CAAC;QAClB,YAAY,GAAG,IAAI,gBAAgB,EAAE,CAAC;IACxC,CAAC,CAAC,CAAC;IAEH,SAAS,WAAW,CAClB,GAAW,EACX,KAAwC;QAExC,MAAM,eAAe,GAAG,GAAG,CAAC,MAAM,CAAC,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,EAAE,CAAC,CAAC;QAC3D,YAAY,CAAC,GAAG,EAAE,CAAC,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC;QACxC,OAAO,eAAe,CAAC;IACzB,CAAC;IAED,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;QACtC,EAAE,CAAC,mEAAmE,EAAE,KAAK,IAAI,EAAE;YACjF,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,UAAU,CAAC,OAAO,CAAC,CAAC;gBAC1B,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;YAC5C,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;YACnC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,wBAAwB,CAAC,CAAC;YACpD,MAAM,CAAC,OAAO,IAAI,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC9C,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,iEAAiE,EAAE,KAAK,IAAI,EAAE;YAC/E,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,IAAI,KAAK,CAAC,cAAc,CAAC,CAAC,CAAC;YACjD,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACnC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;YACxC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,4CAA4C,CAAC,CAAC;QAC1E,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,yEAAyE,EAAE,KAAK,IAAI,EAAE;YACvF,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,UAAU,CAAC,sBAAsB,CAAC,CAAC;gBACzC,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACnC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;YAC9B,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,sBAAsB,CAAC,CAAC;YACjD,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,wCAAwC,CAAC,CAAC;QACtE,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,8EAA8E,EAAE,KAAK,IAAI,EAAE;YAC5F,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;gBACzB,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACnC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;YAC9B,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;QAChD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,6DAA6D,EAAE,KAAK,IAAI,EAAE;YAC3E,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACnC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;QAChD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;QACtC,EAAE,CAAC,iEAAiE,EAAE,KAAK,IAAI,EAAE;YAC/E,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,EAAE,QAAQ,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;gBAC1D,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;YACjC,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACtC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;YACtC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,wBAAwB,CAAC,CAAC;QACtD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,8DAA8D,EAAE,KAAK,IAAI,EAAE;YAC5E,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC;gBAC7B,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACvC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,yBAAyB,CAAC,CAAC;QACvD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;YAC1D,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,IAAI,KAAK,CAAC,cAAc,CAAC,CAAC,CAAC;YACjD,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACnC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACvC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC;YACxC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,iCAAiC,CAAC,CAAC;YAC7D,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QACrD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4DAA4D,EAAE,KAAK,IAAI,EAAE;YAC1E,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,UAAU,CAAC,cAAc,CAAC,CAAC;gBACjC,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACvC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,6BAA6B,CAAC,CAAC;QAC3D,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,wBAAwB,EAAE,GAAG,EAAE;QACtC,EAAE,CAAC,+DAA+D,EAAE,KAAK,IAAI,EAAE;YAC7E,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,EAAE,KAAK,EAAE,UAAU,EAAE,CAAC,CAAC,CAAC;gBACxD,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC/B,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACtC,MAAM,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAC;YACvC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,wBAAwB,CAAC,CAAC;QACtD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,8DAA8D,EAAE,KAAK,IAAI,EAAE;YAC5E,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC;gBACvB,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACvC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,yBAAyB,CAAC,CAAC;QACvD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;YAC1D,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,IAAI,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC;YAC/C,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACnC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACvC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAC;YACtC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,+BAA+B,CAAC,CAAC;YAC3D,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAC;QACnD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4DAA4D,EAAE,KAAK,IAAI,EAAE;YAC1E,MAAM,QAAQ,GAAG,MAAM,WAAW,CAAC,oBAAoB,EAAE,CAAC,KAAK,EAAE,EAAE;gBACjE,KAAK,CAAC,UAAU,CAAC,WAAW,CAAC,CAAC;gBAC9B,KAAK,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACzB,CAAC,CAAC,CAAC;YAEH,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAClC,MAAM,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;YACvC,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,wCAAwC,CAAC,CAAC;QACtE,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/tests/units/modules/cli-configuration/interface-adapters/controllers/http/projectConfig.routes.test.js

@@ -128,6 +128,136 @@ describe('projectConfigRoutes — GET /api/project-config', () => {
         expect(payload.error).toMatch(/review-back/);
         await app.close();
     });
+    it('returns 400 when the path query parameter is missing', async () => {
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config',
+        });
+        expect(response.statusCode).toBe(400);
+        const payload = response.json();
+        expect(payload.success).toBe(false);
+        expect(payload.error).toBe('Project path required');
+        await app.close();
+    });
+    it('returns 400 when the path is not absolute', async () => {
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config?path=relative/path',
+        });
+        expect(response.statusCode).toBe(400);
+        expect(response.json().error).toBe('Invalid path (must be absolute without ..)');
+        await app.close();
+    });
+    it('reports missing base required fields when they are absent', async () => {
+        vi.mocked(fsPromises.readFile).mockResolvedValue(jsonResponse({ reviewSkill: 'review-front' }));
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config?path=/fake/project',
+        });
+        const payload = response.json();
+        expect(payload.success).toBe(false);
+        expect(payload.error).toMatch(/Missing fields:/);
+        expect(payload.error).toMatch(/github/);
+        await app.close();
+    });
+    it('resolves the reviewSkill SKILL.md when reviewSkill is explicitly set', async () => {
+        vi.mocked(fsPromises.readFile).mockResolvedValue(jsonResponse(ProjectConfigFactory.create({ reviewSkill: 'review-front' })));
+        const statMock = vi.mocked(fsPromises.stat);
+        statMock.mockResolvedValue(fakeStats());
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config?path=/fake/project',
+        });
+        expect(response.json().success).toBe(true);
+        const checkedPaths = statMock.mock.calls.map((call) => String(call[0]));
+        expect(checkedPaths.some((checkedPath) => checkedPath.includes('review-front/SKILL.md'))).toBe(true);
+        await app.close();
+    });
+    it('rejects a config whose agents field is not an array', async () => {
+        const config = { ...ProjectConfigFactory.create(), agents: 'not-an-array' };
+        vi.mocked(fsPromises.readFile).mockResolvedValue(jsonResponse(config));
+        vi.mocked(fsPromises.stat).mockResolvedValue(fakeStats());
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config?path=/fake/project',
+        });
+        const payload = response.json();
+        expect(payload.success).toBe(false);
+        expect(payload.error).toBe('Field "agents" must be an array');
+        await app.close();
+    });
+    it('rejects a config whose agents entries are malformed', async () => {
+        const config = {
+            ...ProjectConfigFactory.create(),
+            agents: [{ name: '', displayName: '' }],
+        };
+        vi.mocked(fsPromises.readFile).mockResolvedValue(jsonResponse(config));
+        vi.mocked(fsPromises.stat).mockResolvedValue(fakeStats());
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config?path=/fake/project',
+        });
+        const payload = response.json();
+        expect(payload.success).toBe(false);
+        expect(payload.error).toMatch(/Invalid agents format/);
+        await app.close();
+    });
+    it('accepts a config with a well-formed agents array', async () => {
+        vi.mocked(fsPromises.readFile).mockResolvedValue(jsonResponse(ProjectConfigFactory.create({
+            agents: [{ name: 'security', displayName: 'Security Auditor' }],
+        })));
+        vi.mocked(fsPromises.stat).mockResolvedValue(fakeStats());
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config?path=/fake/project',
+        });
+        expect(response.json().success).toBe(true);
+        await app.close();
+    });
+    it('returns the ENOENT message when config.json is missing', async () => {
+        const enoentError = Object.assign(new Error('no such file'), { code: 'ENOENT' });
+        vi.mocked(fsPromises.readFile).mockRejectedValue(enoentError);
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config?path=/fake/project',
+        });
+        const payload = response.json();
+        expect(payload.success).toBe(false);
+        expect(payload.error).toBe('config.json file not found in .claude/reviews/');
+        await app.close();
+    });
+    it('returns a read error when the config file is not valid JSON', async () => {
+        vi.mocked(fsPromises.readFile).mockResolvedValue('not-json{');
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config?path=/fake/project',
+        });
+        const payload = response.json();
+        expect(payload.success).toBe(false);
+        expect(payload.error).toMatch(/^Read error: /);
+        await app.close();
+    });
+    it('stringifies a non-Error thrown value in the read error message', async () => {
+        vi.mocked(fsPromises.readFile).mockRejectedValue('boom');
+        const app = await buildApp();
+        const response = await app.inject({
+            method: 'GET',
+            url: '/api/project-config?path=/fake/project',
+        });
+        const payload = response.json();
+        expect(payload.success).toBe(false);
+        expect(payload.error).toBe('Read error: boom');
+        await app.close();
+    });
 });
 function baseConfig(overrides = {}) {
     return {
@@ -367,5 +497,100 @@ describe('projectConfigRoutes — PATCH /api/project-config', () => {
         expect(response.json().config.maxConcurrentReviews).toBeUndefined();
         await app.close();
     });
+    it('returns 501 when the PATCH use case is not configured', async () => {
+        const app = Fastify();
+        await app.register(projectConfigRoutes);
+        const response = await app.inject({
+            method: 'PATCH',
+            url: '/api/project-config?path=' + encodeURIComponent('/repo/A'),
+            payload: { language: 'en' },
+        });
+        expect(response.statusCode).toBe(501);
+        expect(response.json().error).toBe('PATCH not configured');
+        await app.close();
+    });
+    it('returns 400 when the body is not a JSON object', async () => {
+        const gateway = new StubProjectConfigGateway();
+        gateway.set('/repo/A', baseConfig());
+        const app = await buildAppWithPatch(gateway);
+        const response = await app.inject({
+            method: 'PATCH',
+            url: '/api/project-config?path=' + encodeURIComponent('/repo/A'),
+            headers: { 'content-type': 'application/json' },
+            payload: JSON.stringify(['not', 'an', 'object']),
+        });
+        expect(response.statusCode).toBe(400);
+        expect(response.json().error).toBe('Body must be a JSON object');
+        await app.close();
+    });
+    it('applies a valid defaultModel from the patch body', async () => {
+        const gateway = new StubProjectConfigGateway();
+        gateway.set('/repo/A', baseConfig({ defaultModel: 'sonnet' }));
+        const app = await buildAppWithPatch(gateway);
+        const response = await app.inject({
+            method: 'PATCH',
+            url: '/api/project-config?path=' + encodeURIComponent('/repo/A'),
+            payload: { defaultModel: 'opus' },
+        });
+        expect(response.statusCode).toBe(200);
+        expect(response.json().config.defaultModel).toBe('opus');
+        await app.close();
+    });
+    it('treats an empty-string qualityThreshold as a clear request', async () => {
+        const gateway = new StubProjectConfigGateway();
+        gateway.set('/repo/A', baseConfig({ qualityThreshold: 7 }));
+        const app = await buildAppWithPatch(gateway);
+        const response = await app.inject({
+            method: 'PATCH',
+            url: '/api/project-config?path=' + encodeURIComponent('/repo/A'),
+            payload: { qualityThreshold: '' },
+        });
+        expect(response.statusCode).toBe(200);
+        expect(response.json().config.qualityThreshold).toBeUndefined();
+        await app.close();
+    });
+    it('keeps a boolean maxConcurrentReviews to surface a validation error', async () => {
+        const gateway = new StubProjectConfigGateway();
+        gateway.set('/repo/A', baseConfig());
+        const app = await buildAppWithPatch(gateway);
+        const response = await app.inject({
+            method: 'PATCH',
+            url: '/api/project-config?path=' + encodeURIComponent('/repo/A'),
+            payload: { maxConcurrentReviews: true },
+        });
+        expect(response.statusCode).toBe(400);
+        await app.close();
+    });
+    it('applies reviewSkill and reviewFollowupSkill string values from the patch', async () => {
+        const gateway = new StubProjectConfigGateway();
+        gateway.set('/repo/A', baseConfig());
+        const app = await buildAppWithPatch(gateway);
+        const response = await app.inject({
+            method: 'PATCH',
+            url: '/api/project-config?path=' + encodeURIComponent('/repo/A'),
+            payload: { reviewSkill: 'review-back', reviewFollowupSkill: 'review-followup-v2' },
+        });
+        expect(response.statusCode).toBe(200);
+        const body = response.json();
+        expect(body.config.reviewSkill).toBe('review-back');
+        expect(body.config.reviewFollowupSkill).toBe('review-followup-v2');
+        await app.close();
+    });
+    it('invokes the onSaved callback after a successful update', async () => {
+        const gateway = new StubProjectConfigGateway();
+        gateway.set('/repo/A', baseConfig());
+        const updateProjectConfig = new UpdateProjectConfigUseCase(gateway);
+        const onSaved = vi.fn();
+        const app = Fastify();
+        await app.register(projectConfigRoutes, { updateProjectConfig, onSaved });
+        const response = await app.inject({
+            method: 'PATCH',
+            url: '/api/project-config?path=' + encodeURIComponent('/repo/A'),
+            payload: { language: 'en' },
+        });
+        expect(response.statusCode).toBe(200);
+        expect(onSaved).toHaveBeenCalledWith('/repo/A');
+        await app.close();
+    });
 });
 //# sourceMappingURL=projectConfig.routes.test.js.map