reviewflow 3.31.0 → 3.33.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +20 -0
- package/dist/main/routes.d.ts.map +1 -1
- package/dist/main/routes.js +55 -2
- package/dist/main/routes.js.map +1 -1
- package/dist/main/server.d.ts.map +1 -1
- package/dist/main/server.js +5 -1
- package/dist/main/server.js.map +1 -1
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.gateway.d.ts +8 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.gateway.d.ts.map +1 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.gateway.js +2 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.gateway.js.map +1 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.guard.d.ts +8 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.guard.d.ts.map +1 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.guard.js +4 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.guard.js.map +1 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.schema.d.ts +17 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.schema.d.ts.map +1 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.schema.js +11 -0
- package/dist/modules/ember-chat/entities/emberMemory/emberMemory.schema.js.map +1 -0
- package/dist/modules/ember-chat/interface-adapters/controllers/http/emberChat.routes.d.ts +2 -0
- package/dist/modules/ember-chat/interface-adapters/controllers/http/emberChat.routes.d.ts.map +1 -1
- package/dist/modules/ember-chat/interface-adapters/controllers/http/emberChat.routes.js +7 -1
- package/dist/modules/ember-chat/interface-adapters/controllers/http/emberChat.routes.js.map +1 -1
- package/dist/modules/ember-chat/interface-adapters/gateways/emberMemory.fileSystem.gateway.d.ts +22 -0
- package/dist/modules/ember-chat/interface-adapters/gateways/emberMemory.fileSystem.gateway.d.ts.map +1 -0
- package/dist/modules/ember-chat/interface-adapters/gateways/emberMemory.fileSystem.gateway.js +55 -0
- package/dist/modules/ember-chat/interface-adapters/gateways/emberMemory.fileSystem.gateway.js.map +1 -0
- package/dist/modules/ember-chat/services/emberSystemPrompt.d.ts +2 -0
- package/dist/modules/ember-chat/services/emberSystemPrompt.d.ts.map +1 -1
- package/dist/modules/ember-chat/services/emberSystemPrompt.js +41 -8
- package/dist/modules/ember-chat/services/emberSystemPrompt.js.map +1 -1
- package/dist/modules/ember-chat/usecases/askEmber/askEmber.usecase.d.ts +2 -0
- package/dist/modules/ember-chat/usecases/askEmber/askEmber.usecase.d.ts.map +1 -1
- package/dist/modules/ember-chat/usecases/askEmber/askEmber.usecase.js +32 -2
- package/dist/modules/ember-chat/usecases/askEmber/askEmber.usecase.js.map +1 -1
- package/dist/modules/ember-chat/usecases/clearEmberMemory/clearEmberMemory.usecase.d.ts +7 -0
- package/dist/modules/ember-chat/usecases/clearEmberMemory/clearEmberMemory.usecase.d.ts.map +1 -0
- package/dist/modules/ember-chat/usecases/clearEmberMemory/clearEmberMemory.usecase.js +4 -0
- package/dist/modules/ember-chat/usecases/clearEmberMemory/clearEmberMemory.usecase.js.map +1 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.defaults.d.ts +3 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.defaults.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.defaults.js +9 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.defaults.js.map +1 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.gateway.d.ts +28 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.gateway.js +2 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.gateway.js.map +1 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.scanner.d.ts +11 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.scanner.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.scanner.js +70 -0
- package/dist/modules/platform-integration/entities/egressScan/egressScan.scanner.js.map +1 -0
- package/dist/modules/platform-integration/entities/egressScan/egressTrace.gateway.d.ts +5 -0
- package/dist/modules/platform-integration/entities/egressScan/egressTrace.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/egressScan/egressTrace.gateway.js +2 -0
- package/dist/modules/platform-integration/entities/egressScan/egressTrace.gateway.js.map +1 -0
- package/dist/modules/platform-integration/entities/executorToken/executorCapability.d.ts +9 -0
- package/dist/modules/platform-integration/entities/executorToken/executorCapability.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/executorToken/executorCapability.js +10 -0
- package/dist/modules/platform-integration/entities/executorToken/executorCapability.js.map +1 -0
- package/dist/modules/platform-integration/entities/idempotency/idempotencyStore.gateway.d.ts +4 -0
- package/dist/modules/platform-integration/entities/idempotency/idempotencyStore.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/idempotency/idempotencyStore.gateway.js +2 -0
- package/dist/modules/platform-integration/entities/idempotency/idempotencyStore.gateway.js.map +1 -0
- package/dist/modules/platform-integration/entities/memberAccess/memberAccess.d.ts +27 -0
- package/dist/modules/platform-integration/entities/memberAccess/memberAccess.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/memberAccess/memberAccess.gateway.d.ts +13 -0
- package/dist/modules/platform-integration/entities/memberAccess/memberAccess.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/memberAccess/memberAccess.gateway.js +2 -0
- package/dist/modules/platform-integration/entities/memberAccess/memberAccess.gateway.js.map +1 -0
- package/dist/modules/platform-integration/entities/memberAccess/memberAccess.js +21 -0
- package/dist/modules/platform-integration/entities/memberAccess/memberAccess.js.map +1 -0
- package/dist/modules/platform-integration/entities/transport/cidr.d.ts +2 -0
- package/dist/modules/platform-integration/entities/transport/cidr.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/transport/cidr.js +36 -0
- package/dist/modules/platform-integration/entities/transport/cidr.js.map +1 -0
- package/dist/modules/platform-integration/entities/transport/clientIpResolver.gateway.d.ts +8 -0
- package/dist/modules/platform-integration/entities/transport/clientIpResolver.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/transport/clientIpResolver.gateway.js +2 -0
- package/dist/modules/platform-integration/entities/transport/clientIpResolver.gateway.js.map +1 -0
- package/dist/modules/platform-integration/entities/transport/transportContext.d.ts +16 -0
- package/dist/modules/platform-integration/entities/transport/transportContext.d.ts.map +1 -0
- package/dist/modules/platform-integration/entities/transport/transportContext.js +2 -0
- package/dist/modules/platform-integration/entities/transport/transportContext.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/github.controller.d.ts.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/github.controller.js +4 -4
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/github.controller.js.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.d.ts +5 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.d.ts.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.js +112 -18
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/gitlab.controller.js.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/transportGuard.middleware.d.ts +25 -0
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/transportGuard.middleware.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/transportGuard.middleware.js +26 -0
- package/dist/modules/platform-integration/interface-adapters/controllers/webhook/transportGuard.middleware.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.d.ts +14 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.js +34 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/inMemoryIdempotencyStore.gateway.d.ts +14 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/inMemoryIdempotencyStore.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/inMemoryIdempotencyStore.gateway.js +27 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/inMemoryIdempotencyStore.gateway.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/loggerEgressTrace.gateway.d.ts +9 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/loggerEgressTrace.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/loggerEgressTrace.gateway.js +14 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/loggerEgressTrace.gateway.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/memberAccess.gitlab.cli.gateway.d.ts +31 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/memberAccess.gitlab.cli.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/memberAccess.gitlab.cli.gateway.js +83 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/memberAccess.gitlab.cli.gateway.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/scopedGitLabExecutor.d.ts +17 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/scopedGitLabExecutor.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/scopedGitLabExecutor.js +17 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/scopedGitLabExecutor.js.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/threadFetch.gitlab.gateway.d.ts +6 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/threadFetch.gitlab.gateway.d.ts.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/gateways/threadFetch.gitlab.gateway.js +28 -1
- package/dist/modules/platform-integration/interface-adapters/gateways/threadFetch.gitlab.gateway.js.map +1 -1
- package/dist/modules/platform-integration/interface-adapters/gateways/transport/clientIpResolver.forwardedFor.gateway.d.ts +5 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/transport/clientIpResolver.forwardedFor.gateway.d.ts.map +1 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/transport/clientIpResolver.forwardedFor.gateway.js +16 -0
- package/dist/modules/platform-integration/interface-adapters/gateways/transport/clientIpResolver.forwardedFor.gateway.js.map +1 -0
- package/dist/modules/platform-integration/services/autoExecutorActionFilter.d.ts +9 -0
- package/dist/modules/platform-integration/services/autoExecutorActionFilter.d.ts.map +1 -0
- package/dist/modules/platform-integration/services/autoExecutorActionFilter.js +33 -0
- package/dist/modules/platform-integration/services/autoExecutorActionFilter.js.map +1 -0
- package/dist/modules/platform-integration/services/pinnedThreadFetchTarget.d.ts +23 -0
- package/dist/modules/platform-integration/services/pinnedThreadFetchTarget.d.ts.map +1 -0
- package/dist/modules/platform-integration/services/pinnedThreadFetchTarget.js +21 -0
- package/dist/modules/platform-integration/services/pinnedThreadFetchTarget.js.map +1 -0
- package/dist/modules/platform-integration/services/scopedExecutorEnvironment.d.ts +21 -0
- package/dist/modules/platform-integration/services/scopedExecutorEnvironment.d.ts.map +1 -0
- package/dist/modules/platform-integration/services/scopedExecutorEnvironment.js +39 -0
- package/dist/modules/platform-integration/services/scopedExecutorEnvironment.js.map +1 -0
- package/dist/modules/platform-integration/usecases/isTrustedActor.usecase.d.ts +17 -0
- package/dist/modules/platform-integration/usecases/isTrustedActor.usecase.d.ts.map +1 -0
- package/dist/modules/platform-integration/usecases/isTrustedActor.usecase.js +23 -0
- package/dist/modules/platform-integration/usecases/isTrustedActor.usecase.js.map +1 -0
- package/dist/modules/platform-integration/usecases/transport/evaluateTransport.usecase.d.ts +3 -0
- package/dist/modules/platform-integration/usecases/transport/evaluateTransport.usecase.d.ts.map +1 -0
- package/dist/modules/platform-integration/usecases/transport/evaluateTransport.usecase.js +18 -0
- package/dist/modules/platform-integration/usecases/transport/evaluateTransport.usecase.js.map +1 -0
- package/dist/modules/review-execution/entities/actionProvenance/actionProvenance.d.ts +9 -0
- package/dist/modules/review-execution/entities/actionProvenance/actionProvenance.d.ts.map +1 -0
- package/dist/modules/review-execution/entities/actionProvenance/actionProvenance.js +11 -0
- package/dist/modules/review-execution/entities/actionProvenance/actionProvenance.js.map +1 -0
- package/dist/modules/review-execution/entities/threadInventory/threadInventory.gateway.d.ts +13 -0
- package/dist/modules/review-execution/entities/threadInventory/threadInventory.gateway.d.ts.map +1 -0
- package/dist/modules/review-execution/entities/threadInventory/threadInventory.gateway.js +2 -0
- package/dist/modules/review-execution/entities/threadInventory/threadInventory.gateway.js.map +1 -0
- package/dist/modules/review-execution/interface-adapters/gateways/threadInventory.gitlab.gateway.d.ts +14 -0
- package/dist/modules/review-execution/interface-adapters/gateways/threadInventory.gitlab.gateway.d.ts.map +1 -0
- package/dist/modules/review-execution/interface-adapters/gateways/threadInventory.gitlab.gateway.js +31 -0
- package/dist/modules/review-execution/interface-adapters/gateways/threadInventory.gitlab.gateway.js.map +1 -0
- package/dist/modules/review-execution/services/constrainActionSurface.d.ts +19 -0
- package/dist/modules/review-execution/services/constrainActionSurface.d.ts.map +1 -0
- package/dist/modules/review-execution/services/constrainActionSurface.js +49 -0
- package/dist/modules/review-execution/services/constrainActionSurface.js.map +1 -0
- package/dist/modules/review-execution/services/contextActionsExecutor.d.ts +2 -1
- package/dist/modules/review-execution/services/contextActionsExecutor.d.ts.map +1 -1
- package/dist/modules/review-execution/services/contextActionsExecutor.js +20 -2
- package/dist/modules/review-execution/services/contextActionsExecutor.js.map +1 -1
- package/dist/modules/review-execution/services/dispatchConstrainedActions.d.ts +30 -0
- package/dist/modules/review-execution/services/dispatchConstrainedActions.d.ts.map +1 -0
- package/dist/modules/review-execution/services/dispatchConstrainedActions.js +20 -0
- package/dist/modules/review-execution/services/dispatchConstrainedActions.js.map +1 -0
- package/dist/modules/review-execution/services/publicOutputExecutor.d.ts +10 -0
- package/dist/modules/review-execution/services/publicOutputExecutor.d.ts.map +1 -0
- package/dist/modules/review-execution/services/publicOutputExecutor.js +27 -0
- package/dist/modules/review-execution/services/publicOutputExecutor.js.map +1 -0
- package/dist/modules/review-execution/services/resolveThreadInventory.d.ts +19 -0
- package/dist/modules/review-execution/services/resolveThreadInventory.d.ts.map +1 -0
- package/dist/modules/review-execution/services/resolveThreadInventory.js +39 -0
- package/dist/modules/review-execution/services/resolveThreadInventory.js.map +1 -0
- package/dist/modules/review-execution/services/threadActionsExecutor.d.ts +11 -1
- package/dist/modules/review-execution/services/threadActionsExecutor.d.ts.map +1 -1
- package/dist/modules/review-execution/services/threadActionsExecutor.js +24 -2
- package/dist/modules/review-execution/services/threadActionsExecutor.js.map +1 -1
- package/dist/modules/review-execution/usecases/gateClaudeInvocation.usecase.d.ts +6 -0
- package/dist/modules/review-execution/usecases/gateClaudeInvocation.usecase.d.ts.map +1 -1
- package/dist/modules/review-execution/usecases/gateClaudeInvocation.usecase.js +2 -1
- package/dist/modules/review-execution/usecases/gateClaudeInvocation.usecase.js.map +1 -1
- package/dist/security/gitlabWebhookTokenSource.d.ts +9 -0
- package/dist/security/gitlabWebhookTokenSource.d.ts.map +1 -0
- package/dist/security/gitlabWebhookTokenSource.js +15 -0
- package/dist/security/gitlabWebhookTokenSource.js.map +1 -0
- package/dist/security/transportGuardConfig.d.ts +16 -0
- package/dist/security/transportGuardConfig.d.ts.map +1 -0
- package/dist/security/transportGuardConfig.js +38 -0
- package/dist/security/transportGuardConfig.js.map +1 -0
- package/dist/security/verifier.d.ts +9 -2
- package/dist/security/verifier.d.ts.map +1 -1
- package/dist/security/verifier.js +27 -10
- package/dist/security/verifier.js.map +1 -1
- package/dist/tests/acceptance/190-ember-live-answers-subscription.acceptance.test.js +7 -0
- package/dist/tests/acceptance/190-ember-live-answers-subscription.acceptance.test.js.map +1 -1
- package/dist/tests/acceptance/192-ember-ondemand-grounding-and-memory.acceptance.test.d.ts +2 -0
- package/dist/tests/acceptance/192-ember-ondemand-grounding-and-memory.acceptance.test.d.ts.map +1 -0
- package/dist/tests/acceptance/192-ember-ondemand-grounding-and-memory.acceptance.test.js +261 -0
- package/dist/tests/acceptance/192-ember-ondemand-grounding-and-memory.acceptance.test.js.map +1 -0
- package/dist/tests/factories/emberMemory.factory.d.ts +8 -0
- package/dist/tests/factories/emberMemory.factory.d.ts.map +1 -0
- package/dist/tests/factories/emberMemory.factory.js +19 -0
- package/dist/tests/factories/emberMemory.factory.js.map +1 -0
- package/dist/tests/factories/transportContext.factory.d.ts +5 -0
- package/dist/tests/factories/transportContext.factory.d.ts.map +1 -0
- package/dist/tests/factories/transportContext.factory.js +14 -0
- package/dist/tests/factories/transportContext.factory.js.map +1 -0
- package/dist/tests/stubs/egressScan.stub.d.ts +16 -0
- package/dist/tests/stubs/egressScan.stub.d.ts.map +1 -0
- package/dist/tests/stubs/egressScan.stub.js +28 -0
- package/dist/tests/stubs/egressScan.stub.js.map +1 -0
- package/dist/tests/stubs/emberMemory.stub.d.ts +25 -0
- package/dist/tests/stubs/emberMemory.stub.d.ts.map +1 -0
- package/dist/tests/stubs/emberMemory.stub.js +61 -0
- package/dist/tests/stubs/emberMemory.stub.js.map +1 -0
- package/dist/tests/stubs/idempotencyStore.stub.d.ts +9 -0
- package/dist/tests/stubs/idempotencyStore.stub.d.ts.map +1 -0
- package/dist/tests/stubs/idempotencyStore.stub.js +19 -0
- package/dist/tests/stubs/idempotencyStore.stub.js.map +1 -0
- package/dist/tests/stubs/memberAccess.stub.d.ts +24 -0
- package/dist/tests/stubs/memberAccess.stub.d.ts.map +1 -0
- package/dist/tests/stubs/memberAccess.stub.js +28 -0
- package/dist/tests/stubs/memberAccess.stub.js.map +1 -0
- package/dist/tests/units/entities/egressScan/egressScan.scanner.test.d.ts +2 -0
- package/dist/tests/units/entities/egressScan/egressScan.scanner.test.d.ts.map +1 -0
- package/dist/tests/units/entities/egressScan/egressScan.scanner.test.js +136 -0
- package/dist/tests/units/entities/egressScan/egressScan.scanner.test.js.map +1 -0
- package/dist/tests/units/interface-adapters/controllers/webhook/gitlab.controller.test.js +114 -0
- package/dist/tests/units/interface-adapters/controllers/webhook/gitlab.controller.test.js.map +1 -1
- package/dist/tests/units/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.test.d.ts +2 -0
- package/dist/tests/units/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.test.d.ts.map +1 -0
- package/dist/tests/units/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.test.js +116 -0
- package/dist/tests/units/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.test.js.map +1 -0
- package/dist/tests/units/modules/ember-chat/controllers/emberChat.routes.test.js +14 -0
- package/dist/tests/units/modules/ember-chat/controllers/emberChat.routes.test.js.map +1 -1
- package/dist/tests/units/modules/ember-chat/entities/emberMemory.guard.test.d.ts +2 -0
- package/dist/tests/units/modules/ember-chat/entities/emberMemory.guard.test.d.ts.map +1 -0
- package/dist/tests/units/modules/ember-chat/entities/emberMemory.guard.test.js +51 -0
- package/dist/tests/units/modules/ember-chat/entities/emberMemory.guard.test.js.map +1 -0
- package/dist/tests/units/modules/ember-chat/gateways/emberMemory.fileSystem.gateway.test.d.ts +2 -0
- package/dist/tests/units/modules/ember-chat/gateways/emberMemory.fileSystem.gateway.test.d.ts.map +1 -0
- package/dist/tests/units/modules/ember-chat/gateways/emberMemory.fileSystem.gateway.test.js +82 -0
- package/dist/tests/units/modules/ember-chat/gateways/emberMemory.fileSystem.gateway.test.js.map +1 -0
- package/dist/tests/units/modules/ember-chat/services/emberSystemPrompt.test.js +74 -2
- package/dist/tests/units/modules/ember-chat/services/emberSystemPrompt.test.js.map +1 -1
- package/dist/tests/units/modules/ember-chat/usecases/askEmber.usecase.test.js +56 -1
- package/dist/tests/units/modules/ember-chat/usecases/askEmber.usecase.test.js.map +1 -1
- package/dist/tests/units/modules/ember-chat/usecases/clearEmberMemory.usecase.test.d.ts +2 -0
- package/dist/tests/units/modules/ember-chat/usecases/clearEmberMemory.usecase.test.d.ts.map +1 -0
- package/dist/tests/units/modules/ember-chat/usecases/clearEmberMemory.usecase.test.js +14 -0
- package/dist/tests/units/modules/ember-chat/usecases/clearEmberMemory.usecase.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/controllers/gitlabProcessorProvenance.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/controllers/gitlabProcessorProvenance.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/controllers/gitlabProcessorProvenance.test.js +69 -0
- package/dist/tests/units/modules/platform-integration/controllers/gitlabProcessorProvenance.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/entities/executorCapability.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/entities/executorCapability.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/entities/executorCapability.test.js +28 -0
- package/dist/tests/units/modules/platform-integration/entities/executorCapability.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/entities/memberAccess/memberAccess.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/entities/memberAccess/memberAccess.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/entities/memberAccess/memberAccess.test.js +18 -0
- package/dist/tests/units/modules/platform-integration/entities/memberAccess/memberAccess.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/gateways/defaultGitLabExecutor.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/gateways/defaultGitLabExecutor.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/gateways/defaultGitLabExecutor.test.js +13 -0
- package/dist/tests/units/modules/platform-integration/gateways/defaultGitLabExecutor.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/gateways/memberAccess.gitlab.cli.gateway.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/gateways/memberAccess.gitlab.cli.gateway.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/gateways/memberAccess.gitlab.cli.gateway.test.js +105 -0
- package/dist/tests/units/modules/platform-integration/gateways/memberAccess.gitlab.cli.gateway.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/gateways/scopedGitLabExecutor.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/gateways/scopedGitLabExecutor.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/gateways/scopedGitLabExecutor.test.js +85 -0
- package/dist/tests/units/modules/platform-integration/gateways/scopedGitLabExecutor.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/controllers/webhook/gitlabIdempotency.controller.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/controllers/webhook/gitlabIdempotency.controller.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/controllers/webhook/gitlabIdempotency.controller.test.js +216 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/controllers/webhook/gitlabIdempotency.controller.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/gateways/inMemoryIdempotencyStore.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/gateways/inMemoryIdempotencyStore.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/gateways/inMemoryIdempotencyStore.test.js +48 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/gateways/inMemoryIdempotencyStore.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/transport/clientIpResolver.forwardedFor.gateway.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/transport/clientIpResolver.forwardedFor.gateway.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/transport/clientIpResolver.forwardedFor.gateway.test.js +29 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/transport/clientIpResolver.forwardedFor.gateway.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/transport/transportGuard.middleware.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/transport/transportGuard.middleware.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/transport/transportGuard.middleware.test.js +66 -0
- package/dist/tests/units/modules/platform-integration/interface-adapters/transport/transportGuard.middleware.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/services/autoExecutorActionFilter.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/services/autoExecutorActionFilter.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/services/autoExecutorActionFilter.test.js +38 -0
- package/dist/tests/units/modules/platform-integration/services/autoExecutorActionFilter.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/services/autoExecutorCapabilityGate.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/services/autoExecutorCapabilityGate.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/services/autoExecutorCapabilityGate.test.js +40 -0
- package/dist/tests/units/modules/platform-integration/services/autoExecutorCapabilityGate.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/services/pinnedThreadFetchTarget.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/services/pinnedThreadFetchTarget.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/services/pinnedThreadFetchTarget.test.js +76 -0
- package/dist/tests/units/modules/platform-integration/services/pinnedThreadFetchTarget.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/services/scopedExecutorEnvironment.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/services/scopedExecutorEnvironment.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/services/scopedExecutorEnvironment.test.js +120 -0
- package/dist/tests/units/modules/platform-integration/services/scopedExecutorEnvironment.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/usecases/isTrustedActor.usecase.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/usecases/isTrustedActor.usecase.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/usecases/isTrustedActor.usecase.test.js +33 -0
- package/dist/tests/units/modules/platform-integration/usecases/isTrustedActor.usecase.test.js.map +1 -0
- package/dist/tests/units/modules/platform-integration/usecases/transport/evaluateTransport.usecase.test.d.ts +2 -0
- package/dist/tests/units/modules/platform-integration/usecases/transport/evaluateTransport.usecase.test.d.ts.map +1 -0
- package/dist/tests/units/modules/platform-integration/usecases/transport/evaluateTransport.usecase.test.js +69 -0
- package/dist/tests/units/modules/platform-integration/usecases/transport/evaluateTransport.usecase.test.js.map +1 -0
- package/dist/tests/units/modules/review-execution/entities/actionProvenance/actionProvenance.test.d.ts +2 -0
- package/dist/tests/units/modules/review-execution/entities/actionProvenance/actionProvenance.test.d.ts.map +1 -0
- package/dist/tests/units/modules/review-execution/entities/actionProvenance/actionProvenance.test.js +26 -0
- package/dist/tests/units/modules/review-execution/entities/actionProvenance/actionProvenance.test.js.map +1 -0
- package/dist/tests/units/modules/review-execution/interface-adapters/gateways/threadInventory.gitlab.gateway.test.d.ts +2 -0
- package/dist/tests/units/modules/review-execution/interface-adapters/gateways/threadInventory.gitlab.gateway.test.d.ts.map +1 -0
- package/dist/tests/units/modules/review-execution/interface-adapters/gateways/threadInventory.gitlab.gateway.test.js +44 -0
- package/dist/tests/units/modules/review-execution/interface-adapters/gateways/threadInventory.gitlab.gateway.test.js.map +1 -0
- package/dist/tests/units/modules/review-execution/services/constrainActionSurface.parity.test.d.ts +2 -0
- package/dist/tests/units/modules/review-execution/services/constrainActionSurface.parity.test.d.ts.map +1 -0
- package/dist/tests/units/modules/review-execution/services/constrainActionSurface.parity.test.js +29 -0
- package/dist/tests/units/modules/review-execution/services/constrainActionSurface.parity.test.js.map +1 -0
- package/dist/tests/units/modules/review-execution/services/constrainActionSurface.test.d.ts +2 -0
- package/dist/tests/units/modules/review-execution/services/constrainActionSurface.test.d.ts.map +1 -0
- package/dist/tests/units/modules/review-execution/services/constrainActionSurface.test.js +115 -0
- package/dist/tests/units/modules/review-execution/services/constrainActionSurface.test.js.map +1 -0
- package/dist/tests/units/modules/review-execution/services/contextActionsExecutor.autopath.test.d.ts +2 -0
- package/dist/tests/units/modules/review-execution/services/contextActionsExecutor.autopath.test.d.ts.map +1 -0
- package/dist/tests/units/modules/review-execution/services/contextActionsExecutor.autopath.test.js +52 -0
- package/dist/tests/units/modules/review-execution/services/contextActionsExecutor.autopath.test.js.map +1 -0
- package/dist/tests/units/modules/review-execution/services/dispatchConstrainedActions.test.d.ts +2 -0
- package/dist/tests/units/modules/review-execution/services/dispatchConstrainedActions.test.d.ts.map +1 -0
- package/dist/tests/units/modules/review-execution/services/dispatchConstrainedActions.test.js +124 -0
- package/dist/tests/units/modules/review-execution/services/dispatchConstrainedActions.test.js.map +1 -0
- package/dist/tests/units/modules/review-execution/services/resolveThreadInventory.test.d.ts +2 -0
- package/dist/tests/units/modules/review-execution/services/resolveThreadInventory.test.d.ts.map +1 -0
- package/dist/tests/units/modules/review-execution/services/resolveThreadInventory.test.js +67 -0
- package/dist/tests/units/modules/review-execution/services/resolveThreadInventory.test.js.map +1 -0
- package/dist/tests/units/modules/review-execution/usecases/gateClaudeInvocation.usecase.test.js +42 -0
- package/dist/tests/units/modules/review-execution/usecases/gateClaudeInvocation.usecase.test.js.map +1 -1
- package/dist/tests/units/security/gitlabTokenRotation.test.d.ts +2 -0
- package/dist/tests/units/security/gitlabTokenRotation.test.d.ts.map +1 -0
- package/dist/tests/units/security/gitlabTokenRotation.test.js +39 -0
- package/dist/tests/units/security/gitlabTokenRotation.test.js.map +1 -0
- package/dist/tests/units/security/noSpoofableTransportGuard.test.d.ts +2 -0
- package/dist/tests/units/security/noSpoofableTransportGuard.test.d.ts.map +1 -0
- package/dist/tests/units/security/noSpoofableTransportGuard.test.js +30 -0
- package/dist/tests/units/security/noSpoofableTransportGuard.test.js.map +1 -0
- package/dist/tests/units/security/transportGuardConfig.test.d.ts +2 -0
- package/dist/tests/units/security/transportGuardConfig.test.d.ts.map +1 -0
- package/dist/tests/units/security/transportGuardConfig.test.js +38 -0
- package/dist/tests/units/security/transportGuardConfig.test.js.map +1 -0
- package/dist/tests/units/security/verifier.test.js +33 -2
- package/dist/tests/units/security/verifier.test.js.map +1 -1
- package/dist/tests/units/services/contextActionsExecutor.egress.test.d.ts +2 -0
- package/dist/tests/units/services/contextActionsExecutor.egress.test.d.ts.map +1 -0
- package/dist/tests/units/services/contextActionsExecutor.egress.test.js +117 -0
- package/dist/tests/units/services/contextActionsExecutor.egress.test.js.map +1 -0
- package/dist/tests/units/services/contextActionsExecutor.test.js +24 -31
- package/dist/tests/units/services/contextActionsExecutor.test.js.map +1 -1
- package/dist/tests/units/services/publicOutputExecutor.test.d.ts +2 -0
- package/dist/tests/units/services/publicOutputExecutor.test.d.ts.map +1 -0
- package/dist/tests/units/services/publicOutputExecutor.test.js +72 -0
- package/dist/tests/units/services/publicOutputExecutor.test.js.map +1 -0
- package/dist/tests/units/services/threadActionsExecutor.egress.test.d.ts +2 -0
- package/dist/tests/units/services/threadActionsExecutor.egress.test.d.ts.map +1 -0
- package/dist/tests/units/services/threadActionsExecutor.egress.test.js +113 -0
- package/dist/tests/units/services/threadActionsExecutor.egress.test.js.map +1 -0
- package/dist/tests/units/services/threadActionsExecutor.test.js +32 -96
- package/dist/tests/units/services/threadActionsExecutor.test.js.map +1 -1
- package/package.json +1 -1
|
@@ -0,0 +1,39 @@
|
|
|
1
|
+
import { describe, it, expect, beforeEach, afterEach } from 'vitest';
|
|
2
|
+
import { createFastifyRequestStub } from '../../../tests/stubs/fastifyRequest.stub.js';
|
|
3
|
+
import { verifyGitLabSignature } from '../../../security/verifier.js';
|
|
4
|
+
import { __resetGitlabTokenCacheForTests } from '../../../security/gitlabWebhookTokenSource.js';
|
|
5
|
+
const ENV_KEY = 'GITLAB_WEBHOOK_TOKEN';
|
|
6
|
+
describe('verifyGitLabSignature token rotation (AC9)', () => {
|
|
7
|
+
let original;
|
|
8
|
+
beforeEach(() => {
|
|
9
|
+
original = process.env[ENV_KEY];
|
|
10
|
+
__resetGitlabTokenCacheForTests();
|
|
11
|
+
});
|
|
12
|
+
afterEach(() => {
|
|
13
|
+
if (original === undefined) {
|
|
14
|
+
Reflect.deleteProperty(process.env, ENV_KEY);
|
|
15
|
+
}
|
|
16
|
+
else {
|
|
17
|
+
process.env[ENV_KEY] = original;
|
|
18
|
+
}
|
|
19
|
+
__resetGitlabTokenCacheForTests();
|
|
20
|
+
});
|
|
21
|
+
it('reads the current configured token, not a value captured at bootstrap', () => {
|
|
22
|
+
process.env[ENV_KEY] = 'first-token-value';
|
|
23
|
+
const firstRequest = createFastifyRequestStub({ headers: { 'x-gitlab-token': 'first-token-value' } });
|
|
24
|
+
expect(verifyGitLabSignature(firstRequest).valid).toBe(true);
|
|
25
|
+
process.env[ENV_KEY] = 'rotated-token-value';
|
|
26
|
+
const staleRequest = createFastifyRequestStub({ headers: { 'x-gitlab-token': 'first-token-value' } });
|
|
27
|
+
expect(verifyGitLabSignature(staleRequest).valid).toBe(false);
|
|
28
|
+
const rotatedRequest = createFastifyRequestStub({ headers: { 'x-gitlab-token': 'rotated-token-value' } });
|
|
29
|
+
expect(verifyGitLabSignature(rotatedRequest).valid).toBe(true);
|
|
30
|
+
});
|
|
31
|
+
it('rejects a token of different length without a length-based short circuit', () => {
|
|
32
|
+
process.env[ENV_KEY] = 'a-token-of-some-length';
|
|
33
|
+
const shortRequest = createFastifyRequestStub({ headers: { 'x-gitlab-token': 'short' } });
|
|
34
|
+
const result = verifyGitLabSignature(shortRequest);
|
|
35
|
+
expect(result.valid).toBe(false);
|
|
36
|
+
expect(result.error).toContain('invalide');
|
|
37
|
+
});
|
|
38
|
+
});
|
|
39
|
+
//# sourceMappingURL=gitlabTokenRotation.test.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"gitlabTokenRotation.test.js","sourceRoot":"","sources":["../../../../src/tests/units/security/gitlabTokenRotation.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACrE,OAAO,EAAE,wBAAwB,EAAE,MAAM,sCAAsC,CAAC;AAChF,OAAO,EAAE,qBAAqB,EAAE,MAAM,wBAAwB,CAAC;AAC/D,OAAO,EAAE,+BAA+B,EAAE,MAAM,wCAAwC,CAAC;AAEzF,MAAM,OAAO,GAAG,sBAAsB,CAAC;AAEvC,QAAQ,CAAC,4CAA4C,EAAE,GAAG,EAAE;IAC1D,IAAI,QAA4B,CAAC;IAEjC,UAAU,CAAC,GAAG,EAAE;QACd,QAAQ,GAAG,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QAChC,+BAA+B,EAAE,CAAC;IACpC,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;YAC3B,OAAO,CAAC,cAAc,CAAC,OAAO,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;QAC/C,CAAC;aAAM,CAAC;YACN,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,GAAG,QAAQ,CAAC;QAClC,CAAC;QACD,+BAA+B,EAAE,CAAC;IACpC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uEAAuE,EAAE,GAAG,EAAE;QAC/E,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,GAAG,mBAAmB,CAAC;QAC3C,MAAM,YAAY,GAAG,wBAAwB,CAAC,EAAE,OAAO,EAAE,EAAE,gBAAgB,EAAE,mBAAmB,EAAE,EAAE,CAAC,CAAC;QACtG,MAAM,CAAC,qBAAqB,CAAC,YAAY,CAAC,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAE7D,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,GAAG,qBAAqB,CAAC;QAE7C,MAAM,YAAY,GAAG,wBAAwB,CAAC,EAAE,OAAO,EAAE,EAAE,gBAAgB,EAAE,mBAAmB,EAAE,EAAE,CAAC,CAAC;QACtG,MAAM,CAAC,qBAAqB,CAAC,YAAY,CAAC,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAE9D,MAAM,cAAc,GAAG,wBAAwB,CAAC,EAAE,OAAO,EAAE,EAAE,gBAAgB,EAAE,qBAAqB,EAAE,EAAE,CAAC,CAAC;QAC1G,MAAM,CAAC,qBAAqB,CAAC,cAAc,CAAC,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACjE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0EAA0E,EAAE,GAAG,EAAE;QAClF,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,GAAG,wBAAwB,CAAC;QAChD,MAAM,YAAY,GAAG,wBAAwB,CAAC,EAAE,OAAO,EAAE,EAAE,gBAAgB,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;QAE1F,MAAM,MAAM,GAAG,qBAAqB,CAAC,YAAY,CAAC,CAAC;QAEnD,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACjC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,CAAC;IAC7C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"noSpoofableTransportGuard.test.d.ts","sourceRoot":"","sources":["../../../../src/tests/units/security/noSpoofableTransportGuard.test.ts"],"names":[],"mappings":""}
|
|
@@ -0,0 +1,30 @@
|
|
|
1
|
+
import { describe, it, expect } from 'vitest';
|
|
2
|
+
import { readFileSync } from 'node:fs';
|
|
3
|
+
import { fileURLToPath } from 'node:url';
|
|
4
|
+
import { dirname, resolve } from 'node:path';
|
|
5
|
+
const here = dirname(fileURLToPath(import.meta.url));
|
|
6
|
+
const repoRoot = resolve(here, '..', '..', '..', '..');
|
|
7
|
+
function readSource(relativePath) {
|
|
8
|
+
return readFileSync(resolve(repoRoot, relativePath), 'utf-8');
|
|
9
|
+
}
|
|
10
|
+
describe('no spoofable transport guard (AC6)', () => {
|
|
11
|
+
const middleware = readSource('src/modules/platform-integration/interface-adapters/controllers/webhook/transportGuard.middleware.ts');
|
|
12
|
+
const routes = readSource('src/main/routes.ts');
|
|
13
|
+
it('the transport guard never reads request.protocol or request.ip as a trust input', () => {
|
|
14
|
+
expect(middleware).not.toMatch(/\.protocol\b/);
|
|
15
|
+
expect(middleware).not.toMatch(/\brequest\.ip\b/);
|
|
16
|
+
expect(middleware).not.toMatch(/\breq\.ip\b/);
|
|
17
|
+
});
|
|
18
|
+
it('the transport guard derives the socket address from socket.remoteAddress only', () => {
|
|
19
|
+
expect(middleware).toContain('socket.remoteAddress');
|
|
20
|
+
});
|
|
21
|
+
it('the webhook routes never use request.protocol or request.ip as a trust guard', () => {
|
|
22
|
+
expect(routes).not.toMatch(/request\.protocol\b/);
|
|
23
|
+
expect(routes).not.toMatch(/\brequest\.ip\b/);
|
|
24
|
+
expect(routes).not.toMatch(/\breq\.ip\b/);
|
|
25
|
+
});
|
|
26
|
+
it('the webhook routes feed the guard from the raw socket address', () => {
|
|
27
|
+
expect(routes).toContain('request.socket.remoteAddress');
|
|
28
|
+
});
|
|
29
|
+
});
|
|
30
|
+
//# sourceMappingURL=noSpoofableTransportGuard.test.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"noSpoofableTransportGuard.test.js","sourceRoot":"","sources":["../../../../src/tests/units/security/noSpoofableTransportGuard.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,YAAY,EAAE,MAAM,SAAS,CAAC;AACvC,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AACzC,OAAO,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAE7C,MAAM,IAAI,GAAG,OAAO,CAAC,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AACrD,MAAM,QAAQ,GAAG,OAAO,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,CAAC;AAEvD,SAAS,UAAU,CAAC,YAAoB;IACtC,OAAO,YAAY,CAAC,OAAO,CAAC,QAAQ,EAAE,YAAY,CAAC,EAAE,OAAO,CAAC,CAAC;AAChE,CAAC;AAED,QAAQ,CAAC,oCAAoC,EAAE,GAAG,EAAE;IAClD,MAAM,UAAU,GAAG,UAAU,CAC3B,sGAAsG,CACvG,CAAC;IACF,MAAM,MAAM,GAAG,UAAU,CAAC,oBAAoB,CAAC,CAAC;IAEhD,EAAE,CAAC,iFAAiF,EAAE,GAAG,EAAE;QACzF,MAAM,CAAC,UAAU,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,cAAc,CAAC,CAAC;QAC/C,MAAM,CAAC,UAAU,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,iBAAiB,CAAC,CAAC;QAClD,MAAM,CAAC,UAAU,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,aAAa,CAAC,CAAC;IAChD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+EAA+E,EAAE,GAAG,EAAE;QACvF,MAAM,CAAC,UAAU,CAAC,CAAC,SAAS,CAAC,sBAAsB,CAAC,CAAC;IACvD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8EAA8E,EAAE,GAAG,EAAE;QACtF,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,qBAAqB,CAAC,CAAC;QAClD,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,iBAAiB,CAAC,CAAC;QAC9C,MAAM,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,aAAa,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;QACvE,MAAM,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,8BAA8B,CAAC,CAAC;IAC3D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"transportGuardConfig.test.d.ts","sourceRoot":"","sources":["../../../../src/tests/units/security/transportGuardConfig.test.ts"],"names":[],"mappings":""}
|
|
@@ -0,0 +1,38 @@
|
|
|
1
|
+
import { describe, it, expect, afterEach } from 'vitest';
|
|
2
|
+
import { DEFAULT_LOOPBACK_HOP, resolveTrustedHopAddress, resolveAllowedCidrRanges, transportTrustProxyValue, } from '../../../security/transportGuardConfig.js';
|
|
3
|
+
const HOP_KEY = 'WEBHOOK_TRUSTED_HOP';
|
|
4
|
+
const CIDR_KEY = 'WEBHOOK_ALLOWED_CIDR_RANGES';
|
|
5
|
+
describe('transportGuardConfig (AC8)', () => {
|
|
6
|
+
const originalHop = process.env[HOP_KEY];
|
|
7
|
+
const originalCidr = process.env[CIDR_KEY];
|
|
8
|
+
afterEach(() => {
|
|
9
|
+
if (originalHop === undefined)
|
|
10
|
+
Reflect.deleteProperty(process.env, HOP_KEY);
|
|
11
|
+
else
|
|
12
|
+
process.env[HOP_KEY] = originalHop;
|
|
13
|
+
if (originalCidr === undefined)
|
|
14
|
+
Reflect.deleteProperty(process.env, CIDR_KEY);
|
|
15
|
+
else
|
|
16
|
+
process.env[CIDR_KEY] = originalCidr;
|
|
17
|
+
});
|
|
18
|
+
it('defaults the trusted hop to the loopback address', () => {
|
|
19
|
+
Reflect.deleteProperty(process.env, HOP_KEY);
|
|
20
|
+
expect(resolveTrustedHopAddress()).toBe(DEFAULT_LOOPBACK_HOP);
|
|
21
|
+
});
|
|
22
|
+
it('the trust proxy value equals the configured hop and is never the boolean true', () => {
|
|
23
|
+
process.env[HOP_KEY] = '127.0.0.1';
|
|
24
|
+
const value = transportTrustProxyValue();
|
|
25
|
+
expect(value).toBe('127.0.0.1');
|
|
26
|
+
expect(typeof value).toBe('string');
|
|
27
|
+
expect(value).not.toBe(true);
|
|
28
|
+
});
|
|
29
|
+
it('parses a comma-separated CIDR allowlist into trimmed entries', () => {
|
|
30
|
+
process.env[CIDR_KEY] = ' 10.0.0.0/8 , 172.16.0.0/12 ';
|
|
31
|
+
expect(resolveAllowedCidrRanges()).toEqual(['10.0.0.0/8', '172.16.0.0/12']);
|
|
32
|
+
});
|
|
33
|
+
it('returns an empty allowlist when none is configured', () => {
|
|
34
|
+
Reflect.deleteProperty(process.env, CIDR_KEY);
|
|
35
|
+
expect(resolveAllowedCidrRanges()).toEqual([]);
|
|
36
|
+
});
|
|
37
|
+
});
|
|
38
|
+
//# sourceMappingURL=transportGuardConfig.test.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"transportGuardConfig.test.js","sourceRoot":"","sources":["../../../../src/tests/units/security/transportGuardConfig.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACzD,OAAO,EACL,oBAAoB,EACpB,wBAAwB,EACxB,wBAAwB,EACxB,wBAAwB,GACzB,MAAM,oCAAoC,CAAC;AAE5C,MAAM,OAAO,GAAG,qBAAqB,CAAC;AACtC,MAAM,QAAQ,GAAG,6BAA6B,CAAC;AAE/C,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;IAC1C,MAAM,WAAW,GAAG,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;IACzC,MAAM,YAAY,GAAG,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC;IAE3C,SAAS,CAAC,GAAG,EAAE;QACb,IAAI,WAAW,KAAK,SAAS;YAAE,OAAO,CAAC,cAAc,CAAC,OAAO,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;;YACvE,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,GAAG,WAAW,CAAC;QACxC,IAAI,YAAY,KAAK,SAAS;YAAE,OAAO,CAAC,cAAc,CAAC,OAAO,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC;;YACzE,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,GAAG,YAAY,CAAC;IAC5C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kDAAkD,EAAE,GAAG,EAAE;QAC1D,OAAO,CAAC,cAAc,CAAC,OAAO,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC;QAC7C,MAAM,CAAC,wBAAwB,EAAE,CAAC,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAC;IAChE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+EAA+E,EAAE,GAAG,EAAE;QACvF,OAAO,CAAC,GAAG,CAAC,OAAO,CAAC,GAAG,WAAW,CAAC;QACnC,MAAM,KAAK,GAAG,wBAAwB,EAAE,CAAC;QAEzC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;QAChC,MAAM,CAAC,OAAO,KAAK,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QACpC,MAAM,CAAC,KAAK,CAAC,CAAC,GAAG,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,GAAG,EAAE;QACtE,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,GAAG,8BAA8B,CAAC;QACvD,MAAM,CAAC,wBAAwB,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,YAAY,EAAE,eAAe,CAAC,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,OAAO,CAAC,cAAc,CAAC,OAAO,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC;QAC9C,MAAM,CAAC,wBAAwB,EAAE,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IACjD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
import { vi } from 'vitest';
|
|
1
|
+
import { vi, beforeAll, afterAll } from 'vitest';
|
|
2
2
|
import { createHmac } from 'node:crypto';
|
|
3
3
|
import { createFastifyRequestStub } from '../../stubs/fastifyRequest.stub.js';
|
|
4
4
|
const TEST_GITLAB_TOKEN = 'gitlab-secret-token-123';
|
|
@@ -9,8 +9,21 @@ vi.mock('../../../config/loader.js', () => ({
|
|
|
9
9
|
githubWebhookSecret: TEST_GITHUB_SECRET,
|
|
10
10
|
})),
|
|
11
11
|
}));
|
|
12
|
-
import { verifyGitLabSignature, verifyGitHubSignature, getGitLabEventType, getGitHubEventType, } from '../../../security/verifier.js';
|
|
12
|
+
import { verifyGitLabSignature, verifyGitHubSignature, getGitLabEventType, getGitLabEventUuid, getGitHubEventType, } from '../../../security/verifier.js';
|
|
13
13
|
describe('verifyGitLabSignature', () => {
|
|
14
|
+
let originalToken;
|
|
15
|
+
beforeAll(() => {
|
|
16
|
+
originalToken = process.env.GITLAB_WEBHOOK_TOKEN;
|
|
17
|
+
process.env.GITLAB_WEBHOOK_TOKEN = TEST_GITLAB_TOKEN;
|
|
18
|
+
});
|
|
19
|
+
afterAll(() => {
|
|
20
|
+
if (originalToken === undefined) {
|
|
21
|
+
Reflect.deleteProperty(process.env, 'GITLAB_WEBHOOK_TOKEN');
|
|
22
|
+
}
|
|
23
|
+
else {
|
|
24
|
+
process.env.GITLAB_WEBHOOK_TOKEN = originalToken;
|
|
25
|
+
}
|
|
26
|
+
});
|
|
14
27
|
describe('when token is valid', () => {
|
|
15
28
|
it('should return valid: true', () => {
|
|
16
29
|
const request = createFastifyRequestStub({
|
|
@@ -179,6 +192,24 @@ describe('getGitLabEventType', () => {
|
|
|
179
192
|
expect(result).toBeUndefined();
|
|
180
193
|
});
|
|
181
194
|
});
|
|
195
|
+
describe('getGitLabEventUuid', () => {
|
|
196
|
+
it('should extract the event UUID from the header', () => {
|
|
197
|
+
const request = createFastifyRequestStub({
|
|
198
|
+
headers: {
|
|
199
|
+
'x-gitlab-event-uuid': '13be3e1e-1d3f-4c2a-9b1a-0f0e0d0c0b0a',
|
|
200
|
+
},
|
|
201
|
+
});
|
|
202
|
+
const result = getGitLabEventUuid(request);
|
|
203
|
+
expect(result).toBe('13be3e1e-1d3f-4c2a-9b1a-0f0e0d0c0b0a');
|
|
204
|
+
});
|
|
205
|
+
it('should return undefined when the header is missing', () => {
|
|
206
|
+
const request = createFastifyRequestStub({
|
|
207
|
+
headers: {},
|
|
208
|
+
});
|
|
209
|
+
const result = getGitLabEventUuid(request);
|
|
210
|
+
expect(result).toBeUndefined();
|
|
211
|
+
});
|
|
212
|
+
});
|
|
182
213
|
describe('getGitHubEventType', () => {
|
|
183
214
|
it('should extract event type from header', () => {
|
|
184
215
|
const request = createFastifyRequestStub({
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"verifier.test.js","sourceRoot":"","sources":["../../../../src/tests/units/security/verifier.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;
|
|
1
|
+
{"version":3,"file":"verifier.test.js","sourceRoot":"","sources":["../../../../src/tests/units/security/verifier.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,EAAE,EAAE,SAAS,EAAE,QAAQ,EAAE,MAAM,QAAQ,CAAA;AAChD,OAAO,EAAE,UAAU,EAAE,MAAM,aAAa,CAAA;AACxC,OAAO,EAAE,wBAAwB,EAAE,MAAM,oCAAoC,CAAA;AAE7E,MAAM,iBAAiB,GAAG,yBAAyB,CAAA;AACnD,MAAM,kBAAkB,GAAG,2BAA2B,CAAA;AAEtD,EAAE,CAAC,IAAI,CAAC,2BAA2B,EAAE,GAAG,EAAE,CAAC,CAAC;IAC1C,cAAc,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC;QAC3B,kBAAkB,EAAE,iBAAiB;QACrC,mBAAmB,EAAE,kBAAkB;KACxC,CAAC,CAAC;CACJ,CAAC,CAAC,CAAA;AAEH,OAAO,EACL,qBAAqB,EACrB,qBAAqB,EACrB,kBAAkB,EAClB,kBAAkB,EAClB,kBAAkB,GACnB,MAAM,+BAA+B,CAAA;AAEtC,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;IACrC,IAAI,aAAiC,CAAA;IAErC,SAAS,CAAC,GAAG,EAAE;QACb,aAAa,GAAG,OAAO,CAAC,GAAG,CAAC,oBAAoB,CAAA;QAChD,OAAO,CAAC,GAAG,CAAC,oBAAoB,GAAG,iBAAiB,CAAA;IACtD,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,GAAG,EAAE;QACZ,IAAI,aAAa,KAAK,SAAS,EAAE,CAAC;YAChC,OAAO,CAAC,cAAc,CAAC,OAAO,CAAC,GAAG,EAAE,sBAAsB,CAAC,CAAA;QAC7D,CAAC;aAAM,CAAC;YACN,OAAO,CAAC,GAAG,CAAC,oBAAoB,GAAG,aAAa,CAAA;QAClD,CAAC;IACH,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,qBAAqB,EAAE,GAAG,EAAE;QACnC,EAAE,CAAC,2BAA2B,EAAE,GAAG,EAAE;YACnC,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE;oBACP,gBAAgB,EAAE,iBAAiB;iBACpC;aACF,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;YAC/B,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,aAAa,EAAE,CAAA;QACtC,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;QACrC,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;YAC/C,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE;oBACP,gBAAgB,EAAE,aAAa;iBAChC;aACF,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;YAChC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,CAAA;QAC5C,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,8BAA8B,EAAE,GAAG,EAAE;QAC5C,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;YACvD,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE,EAAE;aACZ,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;YAChC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,CAAA;QAC5C,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;QAC1C,EAAE,CAAC,4BAA4B,EAAE,GAAG,EAAE;YACpC,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE;oBACP,gBAAgB,EAAE,EAAE;iBACrB;aACF,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,iCAAiC,EAAE,GAAG,EAAE;QAC/C,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;YACxD,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE;oBACP,gBAAgB,EAAE,OAAO;iBAC1B;aACF,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;YAChC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,CAAA;QAC5C,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;IACrC,SAAS,WAAW,CAAC,IAAY,EAAE,MAAc;QAC/C,MAAM,IAAI,GAAG,UAAU,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAA;QACzC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAA;QAC9B,OAAO,UAAU,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,EAAE,CAAA;IACvC,CAAC;IAED,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;QACvC,EAAE,CAAC,2BAA2B,EAAE,GAAG,EAAE;YACnC,MAAM,IAAI,GAAG,gBAAgB,CAAA;YAC7B,MAAM,SAAS,GAAG,WAAW,CAAC,IAAI,EAAE,kBAAkB,CAAC,CAAA;YAEvD,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE;oBACP,qBAAqB,EAAE,SAAS;iBACjC;gBACD,OAAO,EAAE,IAAI;aACd,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;YAC/B,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,aAAa,EAAE,CAAA;QACtC,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,2BAA2B,EAAE,GAAG,EAAE;QACzC,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;YAC/C,MAAM,IAAI,GAAG,gBAAgB,CAAA;YAC7B,MAAM,cAAc,GAAG,WAAW,CAAC,IAAI,EAAE,cAAc,CAAC,CAAA;YAExD,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE;oBACP,qBAAqB,EAAE,cAAc;iBACtC;gBACD,OAAO,EAAE,IAAI;aACd,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;YAChC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,CAAA;QAC5C,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,kCAAkC,EAAE,GAAG,EAAE;QAChD,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;YACvD,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE,EAAE;gBACX,OAAO,EAAE,gBAAgB;aAC1B,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;YAChC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,UAAU,CAAC,CAAA;QAC5C,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,yBAAyB,EAAE,GAAG,EAAE;QACvC,EAAE,CAAC,4CAA4C,EAAE,GAAG,EAAE;YACpD,MAAM,SAAS,GAAG,WAAW,CAAC,IAAI,EAAE,kBAAkB,CAAC,CAAA;YAEvD,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE;oBACP,qBAAqB,EAAE,SAAS;iBACjC;aACF,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;YAChC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,SAAS,CAAC,OAAO,CAAC,CAAA;QACzC,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,2BAA2B,EAAE,GAAG,EAAE;QACzC,EAAE,CAAC,4BAA4B,EAAE,GAAG,EAAE;YACpC,MAAM,YAAY,GAAG,oBAAoB,CAAA;YACzC,MAAM,YAAY,GAAG,oBAAoB,CAAA;YACzC,MAAM,SAAS,GAAG,WAAW,CAAC,YAAY,EAAE,kBAAkB,CAAC,CAAA;YAE/D,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE;oBACP,qBAAqB,EAAE,SAAS;iBACjC;gBACD,OAAO,EAAE,YAAY;aACtB,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,QAAQ,CAAC,iCAAiC,EAAE,GAAG,EAAE;QAC/C,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;YACvD,MAAM,IAAI,GAAG,gBAAgB,CAAA;YAC7B,MAAM,IAAI,GAAG,UAAU,CAAC,QAAQ,EAAE,kBAAkB,CAAC,CAAA;YACrD,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAA;YAC9B,MAAM,sBAAsB,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC,CAAA;YAEjD,MAAM,OAAO,GAAG,wBAAwB,CAAC;gBACvC,OAAO,EAAE;oBACP,qBAAqB,EAAE,sBAAsB;iBAC9C;gBACD,OAAO,EAAE,IAAI;aACd,CAAC,CAAA;YAEF,MAAM,MAAM,GAAG,qBAAqB,CAAC,OAAO,CAAC,CAAA;YAE7C,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,oBAAoB,EAAE,GAAG,EAAE;IAClC,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;QAC/C,MAAM,OAAO,GAAG,wBAAwB,CAAC;YACvC,OAAO,EAAE;gBACP,gBAAgB,EAAE,oBAAoB;aACvC;SACF,CAAC,CAAA;QAEF,MAAM,MAAM,GAAG,kBAAkB,CAAC,OAAO,CAAC,CAAA;QAE1C,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,oBAAoB,CAAC,CAAA;IAC3C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;QACxD,MAAM,OAAO,GAAG,wBAAwB,CAAC;YACvC,OAAO,EAAE,EAAE;SACZ,CAAC,CAAA;QAEF,MAAM,MAAM,GAAG,kBAAkB,CAAC,OAAO,CAAC,CAAA;QAE1C,MAAM,CAAC,MAAM,CAAC,CAAC,aAAa,EAAE,CAAA;IAChC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,oBAAoB,EAAE,GAAG,EAAE;IAClC,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,MAAM,OAAO,GAAG,wBAAwB,CAAC;YACvC,OAAO,EAAE;gBACP,qBAAqB,EAAE,sCAAsC;aAC9D;SACF,CAAC,CAAA;QAEF,MAAM,MAAM,GAAG,kBAAkB,CAAC,OAAO,CAAC,CAAA;QAE1C,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,sCAAsC,CAAC,CAAA;IAC7D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oDAAoD,EAAE,GAAG,EAAE;QAC5D,MAAM,OAAO,GAAG,wBAAwB,CAAC;YACvC,OAAO,EAAE,EAAE;SACZ,CAAC,CAAA;QAEF,MAAM,MAAM,GAAG,kBAAkB,CAAC,OAAO,CAAC,CAAA;QAE1C,MAAM,CAAC,MAAM,CAAC,CAAC,aAAa,EAAE,CAAA;IAChC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,oBAAoB,EAAE,GAAG,EAAE;IAClC,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;QAC/C,MAAM,OAAO,GAAG,wBAAwB,CAAC;YACvC,OAAO,EAAE;gBACP,gBAAgB,EAAE,cAAc;aACjC;SACF,CAAC,CAAA;QAEF,MAAM,MAAM,GAAG,kBAAkB,CAAC,OAAO,CAAC,CAAA;QAE1C,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,cAAc,CAAC,CAAA;IACrC,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;QACxD,MAAM,OAAO,GAAG,wBAAwB,CAAC;YACvC,OAAO,EAAE,EAAE;SACZ,CAAC,CAAA;QAEF,MAAM,MAAM,GAAG,kBAAkB,CAAC,OAAO,CAAC,CAAA;QAE1C,MAAM,CAAC,MAAM,CAAC,CAAC,aAAa,EAAE,CAAA;IAChC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"contextActionsExecutor.egress.test.d.ts","sourceRoot":"","sources":["../../../../src/tests/units/services/contextActionsExecutor.egress.test.ts"],"names":[],"mappings":""}
|
|
@@ -0,0 +1,117 @@
|
|
|
1
|
+
import { describe, it, expect } from 'vitest';
|
|
2
|
+
import { executeActionsFromContext } from '../../../modules/review-execution/services/contextActionsExecutor.js';
|
|
3
|
+
import { EgressScannedNoteCommentPostGateway } from '../../../modules/platform-integration/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.js';
|
|
4
|
+
import { createEgressScanner } from '../../../modules/platform-integration/entities/egressScan/egressScan.scanner.js';
|
|
5
|
+
import { StubNoteCommentPostGateway } from '../../../tests/stubs/noteCommentPost.stub.js';
|
|
6
|
+
import { StubEgressTraceGateway } from '../../../tests/stubs/egressScan.stub.js';
|
|
7
|
+
const SECRET = 'glpat-abcdefghij1234567890';
|
|
8
|
+
const redactConfig = {
|
|
9
|
+
secretShapeMode: 'redact',
|
|
10
|
+
lengthMode: 'redact',
|
|
11
|
+
outOfScopeMode: 'redact',
|
|
12
|
+
maxBodyLength: 10000,
|
|
13
|
+
redactionMarker: '[REDACTED]',
|
|
14
|
+
truncationMarker: '…[TRUNCATED]',
|
|
15
|
+
};
|
|
16
|
+
const silentLogger = {
|
|
17
|
+
info: () => { },
|
|
18
|
+
warn: () => { },
|
|
19
|
+
error: () => { },
|
|
20
|
+
debug: () => { },
|
|
21
|
+
};
|
|
22
|
+
function buildDecoratedSink() {
|
|
23
|
+
const sink = new StubNoteCommentPostGateway();
|
|
24
|
+
const trace = new StubEgressTraceGateway();
|
|
25
|
+
const scanner = createEgressScanner(redactConfig);
|
|
26
|
+
const gateway = new EgressScannedNoteCommentPostGateway(sink, scanner, trace);
|
|
27
|
+
return { sink, gateway };
|
|
28
|
+
}
|
|
29
|
+
const baseContext = {
|
|
30
|
+
version: '1.0',
|
|
31
|
+
mergeRequestId: 'gitlab-group/app-7',
|
|
32
|
+
platform: 'gitlab',
|
|
33
|
+
projectPath: 'group/app',
|
|
34
|
+
mergeRequestNumber: 7,
|
|
35
|
+
createdAt: '2026-02-02T10:00:00Z',
|
|
36
|
+
threads: [],
|
|
37
|
+
actions: [],
|
|
38
|
+
progress: { phase: 'completed', currentStep: null },
|
|
39
|
+
};
|
|
40
|
+
describe('executeActionsFromContext — egress routing (pentest amendment AC7/AC9)', () => {
|
|
41
|
+
it('routes a POST_COMMENT body through the decorated sink, never the raw CLI primitive', async () => {
|
|
42
|
+
const { sink, gateway } = buildDecoratedSink();
|
|
43
|
+
const rawCalls = [];
|
|
44
|
+
const recordingExecutor = (_command, args) => {
|
|
45
|
+
rawCalls.push(args);
|
|
46
|
+
};
|
|
47
|
+
const context = {
|
|
48
|
+
...baseContext,
|
|
49
|
+
actions: [{ type: 'POST_COMMENT', body: `## Review\ntoken ${SECRET}` }],
|
|
50
|
+
};
|
|
51
|
+
await executeActionsFromContext(context, '/tmp/repo', silentLogger, recordingExecutor, null, gateway);
|
|
52
|
+
expect(sink.calls).toHaveLength(1);
|
|
53
|
+
expect(sink.calls[0].body).toContain('[REDACTED]');
|
|
54
|
+
expect(sink.calls[0].body).not.toContain(SECRET);
|
|
55
|
+
const rawSecretCalls = rawCalls.filter((args) => args.some((arg) => arg.includes(SECRET)));
|
|
56
|
+
expect(rawSecretCalls).toHaveLength(0);
|
|
57
|
+
});
|
|
58
|
+
it('routes a THREAD_REPLY body through the decorated sink, never the raw CLI primitive', async () => {
|
|
59
|
+
const { sink, gateway } = buildDecoratedSink();
|
|
60
|
+
const rawCalls = [];
|
|
61
|
+
const recordingExecutor = (_command, args) => {
|
|
62
|
+
rawCalls.push(args);
|
|
63
|
+
};
|
|
64
|
+
const context = {
|
|
65
|
+
...baseContext,
|
|
66
|
+
actions: [{ type: 'THREAD_REPLY', threadId: 'abc', message: `fixed ${SECRET}` }],
|
|
67
|
+
};
|
|
68
|
+
await executeActionsFromContext(context, '/tmp/repo', silentLogger, recordingExecutor, null, gateway);
|
|
69
|
+
expect(sink.calls).toHaveLength(1);
|
|
70
|
+
expect(sink.calls[0].body).not.toContain(SECRET);
|
|
71
|
+
const rawSecretCalls = rawCalls.filter((args) => args.some((arg) => arg.includes(SECRET)));
|
|
72
|
+
expect(rawSecretCalls).toHaveLength(0);
|
|
73
|
+
});
|
|
74
|
+
it('AC9 — public-output verbs reach the decorated sink while other allowed verbs use the CLI primitive', async () => {
|
|
75
|
+
const { sink, gateway } = buildDecoratedSink();
|
|
76
|
+
const rawCalls = [];
|
|
77
|
+
const recordingExecutor = (_command, args) => {
|
|
78
|
+
rawCalls.push(args);
|
|
79
|
+
};
|
|
80
|
+
const context = {
|
|
81
|
+
...baseContext,
|
|
82
|
+
diffMetadata: { baseSha: 'base', headSha: 'head', startSha: 'start' },
|
|
83
|
+
actions: [
|
|
84
|
+
{ type: 'POST_COMMENT', body: `comment ${SECRET}` },
|
|
85
|
+
{ type: 'THREAD_REPLY', threadId: 't1', message: `reply ${SECRET}` },
|
|
86
|
+
{ type: 'POST_INLINE_COMMENT', filePath: 'src/a.ts', line: 3, body: 'inline note' },
|
|
87
|
+
],
|
|
88
|
+
};
|
|
89
|
+
await executeActionsFromContext(context, '/tmp/repo', silentLogger, recordingExecutor, null, gateway);
|
|
90
|
+
expect(sink.calls).toHaveLength(2);
|
|
91
|
+
for (const call of sink.calls) {
|
|
92
|
+
expect(call.body).not.toContain(SECRET);
|
|
93
|
+
}
|
|
94
|
+
const rawSecretCalls = rawCalls.filter((args) => args.some((arg) => arg.includes(SECRET)));
|
|
95
|
+
expect(rawSecretCalls).toHaveLength(0);
|
|
96
|
+
expect(rawCalls.some((args) => args.some((arg) => arg.includes('/discussions')))).toBe(true);
|
|
97
|
+
});
|
|
98
|
+
it('SPEC-196 unwire: THREAD_RESOLVE / ADD_LABEL are dropped from the sinked auto path', async () => {
|
|
99
|
+
const { sink, gateway } = buildDecoratedSink();
|
|
100
|
+
const rawCalls = [];
|
|
101
|
+
const recordingExecutor = (_command, args) => {
|
|
102
|
+
rawCalls.push(args);
|
|
103
|
+
};
|
|
104
|
+
const context = {
|
|
105
|
+
...baseContext,
|
|
106
|
+
actions: [
|
|
107
|
+
{ type: 'POST_COMMENT', body: 'comment' },
|
|
108
|
+
{ type: 'THREAD_RESOLVE', threadId: 't1' },
|
|
109
|
+
{ type: 'ADD_LABEL', label: 'approved' },
|
|
110
|
+
],
|
|
111
|
+
};
|
|
112
|
+
await executeActionsFromContext(context, '/tmp/repo', silentLogger, recordingExecutor, null, gateway);
|
|
113
|
+
expect(sink.calls).toHaveLength(1);
|
|
114
|
+
expect(rawCalls.some((args) => args.includes('resolved=true'))).toBe(false);
|
|
115
|
+
});
|
|
116
|
+
});
|
|
117
|
+
//# sourceMappingURL=contextActionsExecutor.egress.test.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"contextActionsExecutor.egress.test.js","sourceRoot":"","sources":["../../../../src/tests/units/services/contextActionsExecutor.egress.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,yBAAyB,EAAE,MAAM,+DAA+D,CAAC;AAG1G,OAAO,EAAE,mCAAmC,EAAE,MAAM,qGAAqG,CAAC;AAC1J,OAAO,EAAE,mBAAmB,EAAE,MAAM,0EAA0E,CAAC;AAE/G,OAAO,EAAE,0BAA0B,EAAE,MAAM,uCAAuC,CAAC;AACnF,OAAO,EAAE,sBAAsB,EAAE,MAAM,kCAAkC,CAAC;AAE1E,MAAM,MAAM,GAAG,4BAA4B,CAAC;AAE5C,MAAM,YAAY,GAAqB;IACrC,eAAe,EAAE,QAAQ;IACzB,UAAU,EAAE,QAAQ;IACpB,cAAc,EAAE,QAAQ;IACxB,aAAa,EAAE,KAAK;IACpB,eAAe,EAAE,YAAY;IAC7B,gBAAgB,EAAE,cAAc;CACjC,CAAC;AAEF,MAAM,YAAY,GAAG;IACnB,IAAI,EAAE,GAAG,EAAE,GAAE,CAAC;IACd,IAAI,EAAE,GAAG,EAAE,GAAE,CAAC;IACd,KAAK,EAAE,GAAG,EAAE,GAAE,CAAC;IACf,KAAK,EAAE,GAAG,EAAE,GAAE,CAAC;CAChB,CAAC;AAEF,SAAS,kBAAkB;IACzB,MAAM,IAAI,GAAG,IAAI,0BAA0B,EAAE,CAAC;IAC9C,MAAM,KAAK,GAAG,IAAI,sBAAsB,EAAE,CAAC;IAC3C,MAAM,OAAO,GAAG,mBAAmB,CAAC,YAAY,CAAC,CAAC;IAClD,MAAM,OAAO,GAAG,IAAI,mCAAmC,CAAC,IAAI,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC;IAC9E,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC;AAC3B,CAAC;AAED,MAAM,WAAW,GAAkB;IACjC,OAAO,EAAE,KAAK;IACd,cAAc,EAAE,oBAAoB;IACpC,QAAQ,EAAE,QAAQ;IAClB,WAAW,EAAE,WAAW;IACxB,kBAAkB,EAAE,CAAC;IACrB,SAAS,EAAE,sBAAsB;IACjC,OAAO,EAAE,EAAE;IACX,OAAO,EAAE,EAAE;IACX,QAAQ,EAAE,EAAE,KAAK,EAAE,WAAW,EAAE,WAAW,EAAE,IAAI,EAAE;CACpD,CAAC;AAEF,QAAQ,CAAC,wEAAwE,EAAE,GAAG,EAAE;IACtF,EAAE,CAAC,oFAAoF,EAAE,KAAK,IAAI,EAAE;QAClG,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,kBAAkB,EAAE,CAAC;QAC/C,MAAM,QAAQ,GAAe,EAAE,CAAC;QAChC,MAAM,iBAAiB,GAAoB,CAAC,QAAQ,EAAE,IAAI,EAAE,EAAE;YAC5D,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACtB,CAAC,CAAC;QACF,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,oBAAoB,MAAM,EAAE,EAAE,CAAC;SACxE,CAAC;QAEF,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,YAAY,EAAE,iBAAiB,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC;QAEtG,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACnC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QACnD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAEjD,MAAM,cAAc,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;QAC3F,MAAM,CAAC,cAAc,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IACzC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oFAAoF,EAAE,KAAK,IAAI,EAAE;QAClG,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,kBAAkB,EAAE,CAAC;QAC/C,MAAM,QAAQ,GAAe,EAAE,CAAC;QAChC,MAAM,iBAAiB,GAAoB,CAAC,QAAQ,EAAE,IAAI,EAAE,EAAE;YAC5D,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACtB,CAAC,CAAC;QACF,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,cAAc,EAAE,QAAQ,EAAE,KAAK,EAAE,OAAO,EAAE,SAAS,MAAM,EAAE,EAAE,CAAC;SACjF,CAAC;QAEF,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,YAAY,EAAE,iBAAiB,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC;QAEtG,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACnC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAEjD,MAAM,cAAc,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;QAC3F,MAAM,CAAC,cAAc,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IACzC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oGAAoG,EAAE,KAAK,IAAI,EAAE;QAClH,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,kBAAkB,EAAE,CAAC;QAC/C,MAAM,QAAQ,GAAe,EAAE,CAAC;QAChC,MAAM,iBAAiB,GAAoB,CAAC,QAAQ,EAAE,IAAI,EAAE,EAAE;YAC5D,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACtB,CAAC,CAAC;QACF,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,YAAY,EAAE,EAAE,OAAO,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,EAAE,QAAQ,EAAE,OAAO,EAAE;YACrE,OAAO,EAAE;gBACP,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,WAAW,MAAM,EAAE,EAAE;gBACnD,EAAE,IAAI,EAAE,cAAc,EAAE,QAAQ,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,MAAM,EAAE,EAAE;gBACpE,EAAE,IAAI,EAAE,qBAAqB,EAAE,QAAQ,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE;aACpF;SACF,CAAC;QAEF,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,YAAY,EAAE,iBAAiB,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC;QAEtG,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACnC,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;YAC9B,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QAC1C,CAAC;QACD,MAAM,cAAc,GAAG,QAAQ,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;QAC3F,MAAM,CAAC,cAAc,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACvC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC/F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mFAAmF,EAAE,KAAK,IAAI,EAAE;QACjG,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,kBAAkB,EAAE,CAAC;QAC/C,MAAM,QAAQ,GAAe,EAAE,CAAC;QAChC,MAAM,iBAAiB,GAAoB,CAAC,QAAQ,EAAE,IAAI,EAAE,EAAE;YAC5D,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACtB,CAAC,CAAC;QACF,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,OAAO,EAAE;gBACP,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,SAAS,EAAE;gBACzC,EAAE,IAAI,EAAE,gBAAgB,EAAE,QAAQ,EAAE,IAAI,EAAE;gBAC1C,EAAE,IAAI,EAAE,WAAW,EAAE,KAAK,EAAE,UAAU,EAAE;aACzC;SACF,CAAC;QAEF,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,YAAY,EAAE,iBAAiB,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC;QAEtG,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACnC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,QAAQ,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
|
|
@@ -1,6 +1,8 @@
|
|
|
1
1
|
import { describe, it, expect, vi, beforeEach } from 'vitest';
|
|
2
2
|
import { executeActionsFromContext } from '../../../modules/review-execution/services/contextActionsExecutor.js';
|
|
3
|
-
|
|
3
|
+
// AC6/AC7: the context auto-path executor is bounded to read + postComment.
|
|
4
|
+
// THREAD_RESOLVE / ADD_LABEL are dropped (no-op, logged), POST_COMMENT executes.
|
|
5
|
+
describe('executeActionsFromContext (auto path, capability-bounded)', () => {
|
|
4
6
|
const mockLogger = {
|
|
5
7
|
info: vi.fn(),
|
|
6
8
|
warn: vi.fn(),
|
|
@@ -22,50 +24,42 @@ describe('executeActionsFromContext', () => {
|
|
|
22
24
|
beforeEach(() => {
|
|
23
25
|
vi.clearAllMocks();
|
|
24
26
|
});
|
|
25
|
-
it('
|
|
27
|
+
it('returns an empty result when no actions are present', async () => {
|
|
26
28
|
const context = { ...baseContext, actions: [] };
|
|
27
29
|
const result = await executeActionsFromContext(context, '/tmp/repo', mockLogger, mockExecutor);
|
|
28
30
|
expect(result.total).toBe(0);
|
|
29
31
|
expect(result.succeeded).toBe(0);
|
|
30
32
|
expect(mockExecutor).not.toHaveBeenCalled();
|
|
31
33
|
});
|
|
32
|
-
it('
|
|
34
|
+
it('drops THREAD_RESOLVE without invoking the executor', async () => {
|
|
33
35
|
const context = {
|
|
34
36
|
...baseContext,
|
|
35
|
-
actions: [
|
|
36
|
-
{ type: 'THREAD_RESOLVE', threadId: 'PRRT_kwDONxxx' },
|
|
37
|
-
],
|
|
37
|
+
actions: [{ type: 'THREAD_RESOLVE', threadId: 'PRRT_kwDONxxx' }],
|
|
38
38
|
};
|
|
39
39
|
const result = await executeActionsFromContext(context, '/tmp/repo', mockLogger, mockExecutor);
|
|
40
|
-
expect(result.total).toBe(
|
|
41
|
-
expect(
|
|
42
|
-
expect(mockExecutor).toHaveBeenCalledWith('gh', expect.arrayContaining(['api', 'graphql']), '/tmp/repo');
|
|
40
|
+
expect(result.total).toBe(0);
|
|
41
|
+
expect(mockExecutor).not.toHaveBeenCalled();
|
|
43
42
|
});
|
|
44
|
-
it('
|
|
43
|
+
it('executes POST_COMMENT action', async () => {
|
|
45
44
|
const context = {
|
|
46
45
|
...baseContext,
|
|
47
|
-
actions: [
|
|
48
|
-
{ type: 'POST_COMMENT', body: '## Follow-up Review\n\nAll fixed.' },
|
|
49
|
-
],
|
|
46
|
+
actions: [{ type: 'POST_COMMENT', body: '## Follow-up Review\n\nAll fixed.' }],
|
|
50
47
|
};
|
|
51
48
|
const result = await executeActionsFromContext(context, '/tmp/repo', mockLogger, mockExecutor);
|
|
52
49
|
expect(result.total).toBe(1);
|
|
53
50
|
expect(result.succeeded).toBe(1);
|
|
54
51
|
expect(mockExecutor).toHaveBeenCalledWith('gh', expect.arrayContaining(['repos/owner/repo/issues/42/comments']), '/tmp/repo');
|
|
55
52
|
});
|
|
56
|
-
it('
|
|
53
|
+
it('drops ADD_LABEL without invoking the executor', async () => {
|
|
57
54
|
const context = {
|
|
58
55
|
...baseContext,
|
|
59
|
-
actions: [
|
|
60
|
-
{ type: 'ADD_LABEL', label: 'needs_approve' },
|
|
61
|
-
],
|
|
56
|
+
actions: [{ type: 'ADD_LABEL', label: 'needs_approve' }],
|
|
62
57
|
};
|
|
63
58
|
const result = await executeActionsFromContext(context, '/tmp/repo', mockLogger, mockExecutor);
|
|
64
|
-
expect(result.total).toBe(
|
|
65
|
-
expect(
|
|
66
|
-
expect(mockExecutor).toHaveBeenCalledWith('gh', expect.arrayContaining(['repos/owner/repo/issues/42/labels']), '/tmp/repo');
|
|
59
|
+
expect(result.total).toBe(0);
|
|
60
|
+
expect(mockExecutor).not.toHaveBeenCalled();
|
|
67
61
|
});
|
|
68
|
-
it('
|
|
62
|
+
it('keeps only allowed verbs in a mixed stream', async () => {
|
|
69
63
|
const context = {
|
|
70
64
|
...baseContext,
|
|
71
65
|
actions: [
|
|
@@ -76,31 +70,30 @@ describe('executeActionsFromContext', () => {
|
|
|
76
70
|
],
|
|
77
71
|
};
|
|
78
72
|
const result = await executeActionsFromContext(context, '/tmp/repo', mockLogger, mockExecutor);
|
|
79
|
-
|
|
80
|
-
expect(result.
|
|
81
|
-
expect(
|
|
73
|
+
// Only the single POST_COMMENT survives the capability filter.
|
|
74
|
+
expect(result.total).toBe(1);
|
|
75
|
+
expect(result.succeeded).toBe(1);
|
|
76
|
+
expect(mockExecutor).toHaveBeenCalledTimes(1);
|
|
82
77
|
});
|
|
83
|
-
it('
|
|
78
|
+
it('handles GitLab platform postComment', async () => {
|
|
84
79
|
const context = {
|
|
85
80
|
...baseContext,
|
|
86
81
|
platform: 'gitlab',
|
|
87
|
-
actions: [
|
|
88
|
-
{ type: 'THREAD_RESOLVE', threadId: 'abc123' },
|
|
89
|
-
],
|
|
82
|
+
actions: [{ type: 'POST_COMMENT', body: 'note' }],
|
|
90
83
|
};
|
|
91
84
|
const result = await executeActionsFromContext(context, '/tmp/repo', mockLogger, mockExecutor);
|
|
92
85
|
expect(result.succeeded).toBe(1);
|
|
93
86
|
expect(mockExecutor).toHaveBeenCalledWith('glab', expect.arrayContaining(['api']), '/tmp/repo');
|
|
94
87
|
});
|
|
95
|
-
it('
|
|
88
|
+
it('continues executing when one allowed action fails', async () => {
|
|
96
89
|
mockExecutor.mockImplementationOnce(() => {
|
|
97
90
|
throw new Error('API error');
|
|
98
91
|
});
|
|
99
92
|
const context = {
|
|
100
93
|
...baseContext,
|
|
101
94
|
actions: [
|
|
102
|
-
{ type: '
|
|
103
|
-
{ type: 'POST_COMMENT', body: '
|
|
95
|
+
{ type: 'POST_COMMENT', body: 'first' },
|
|
96
|
+
{ type: 'POST_COMMENT', body: 'second' },
|
|
104
97
|
],
|
|
105
98
|
};
|
|
106
99
|
const result = await executeActionsFromContext(context, '/tmp/repo', mockLogger, mockExecutor);
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"contextActionsExecutor.test.js","sourceRoot":"","sources":["../../../../src/tests/units/services/contextActionsExecutor.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAA;AAC7D,OAAO,EAAE,yBAAyB,EAAE,MAAM,+DAA+D,CAAA;AAGzG,QAAQ,CAAC,
|
|
1
|
+
{"version":3,"file":"contextActionsExecutor.test.js","sourceRoot":"","sources":["../../../../src/tests/units/services/contextActionsExecutor.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAA;AAC7D,OAAO,EAAE,yBAAyB,EAAE,MAAM,+DAA+D,CAAA;AAGzG,4EAA4E;AAC5E,iFAAiF;AACjF,QAAQ,CAAC,2DAA2D,EAAE,GAAG,EAAE;IACzE,MAAM,UAAU,GAAG;QACjB,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;QACb,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;QACb,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE;QACd,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE;KACf,CAAA;IAED,MAAM,YAAY,GAAG,EAAE,CAAC,EAAE,EAAE,CAAA;IAE5B,MAAM,WAAW,GAAkB;QACjC,OAAO,EAAE,KAAK;QACd,cAAc,EAAE,sBAAsB;QACtC,QAAQ,EAAE,QAAQ;QAClB,WAAW,EAAE,YAAY;QACzB,kBAAkB,EAAE,EAAE;QACtB,SAAS,EAAE,sBAAsB;QACjC,OAAO,EAAE,EAAE;QACX,OAAO,EAAE,EAAE;QACX,QAAQ,EAAE,EAAE,KAAK,EAAE,WAAW,EAAE,WAAW,EAAE,IAAI,EAAE;KACpD,CAAA;IAED,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAA;IACpB,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qDAAqD,EAAE,KAAK,IAAI,EAAE;QACnE,MAAM,OAAO,GAAG,EAAE,GAAG,WAAW,EAAE,OAAO,EAAE,EAAE,EAAE,CAAA;QAE/C,MAAM,MAAM,GAAG,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,UAAU,EAAE,YAAY,CAAC,CAAA;QAE9F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC5B,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAChC,MAAM,CAAC,YAAY,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAA;IAC7C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,oDAAoD,EAAE,KAAK,IAAI,EAAE;QAClE,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,gBAAgB,EAAE,QAAQ,EAAE,eAAe,EAAE,CAAC;SACjE,CAAA;QAED,MAAM,MAAM,GAAG,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,UAAU,EAAE,YAAY,CAAC,CAAA;QAE9F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC5B,MAAM,CAAC,YAAY,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAA;IAC7C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,8BAA8B,EAAE,KAAK,IAAI,EAAE;QAC5C,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,mCAAmC,EAAE,CAAC;SAC/E,CAAA;QAED,MAAM,MAAM,GAAG,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,UAAU,EAAE,YAAY,CAAC,CAAA;QAE9F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC5B,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAChC,MAAM,CAAC,YAAY,CAAC,CAAC,oBAAoB,CACvC,IAAI,EACJ,MAAM,CAAC,eAAe,CAAC,CAAC,qCAAqC,CAAC,CAAC,EAC/D,WAAW,CACZ,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;QAC7D,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,WAAW,EAAE,KAAK,EAAE,eAAe,EAAE,CAAC;SACzD,CAAA;QAED,MAAM,MAAM,GAAG,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,UAAU,EAAE,YAAY,CAAC,CAAA;QAE9F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC5B,MAAM,CAAC,YAAY,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAA;IAC7C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;QAC1D,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,OAAO,EAAE;gBACP,EAAE,IAAI,EAAE,gBAAgB,EAAE,QAAQ,EAAE,UAAU,EAAE;gBAChD,EAAE,IAAI,EAAE,gBAAgB,EAAE,QAAQ,EAAE,UAAU,EAAE;gBAChD,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,MAAM,EAAE;gBACtC,EAAE,IAAI,EAAE,WAAW,EAAE,KAAK,EAAE,UAAU,EAAE;aACzC;SACF,CAAA;QAED,MAAM,MAAM,GAAG,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,UAAU,EAAE,YAAY,CAAC,CAAA;QAE9F,+DAA+D;QAC/D,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC5B,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAChC,MAAM,CAAC,YAAY,CAAC,CAAC,qBAAqB,CAAC,CAAC,CAAC,CAAA;IAC/C,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qCAAqC,EAAE,KAAK,IAAI,EAAE;QACnD,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,QAAQ,EAAE,QAAQ;YAClB,OAAO,EAAE,CAAC,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC;SAClD,CAAA;QAED,MAAM,MAAM,GAAG,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,UAAU,EAAE,YAAY,CAAC,CAAA;QAE9F,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAChC,MAAM,CAAC,YAAY,CAAC,CAAC,oBAAoB,CACvC,MAAM,EACN,MAAM,CAAC,eAAe,CAAC,CAAC,KAAK,CAAC,CAAC,EAC/B,WAAW,CACZ,CAAA;IACH,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,mDAAmD,EAAE,KAAK,IAAI,EAAE;QACjE,YAAY,CAAC,sBAAsB,CAAC,GAAG,EAAE;YACvC,MAAM,IAAI,KAAK,CAAC,WAAW,CAAC,CAAA;QAC9B,CAAC,CAAC,CAAA;QAEF,MAAM,OAAO,GAAkB;YAC7B,GAAG,WAAW;YACd,OAAO,EAAE;gBACP,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,OAAO,EAAE;gBACvC,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,QAAQ,EAAE;aACzC;SACF,CAAA;QAED,MAAM,MAAM,GAAG,MAAM,yBAAyB,CAAC,OAAO,EAAE,WAAW,EAAE,UAAU,EAAE,YAAY,CAAC,CAAA;QAE9F,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC5B,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC7B,MAAM,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;IAClC,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"publicOutputExecutor.test.d.ts","sourceRoot":"","sources":["../../../../src/tests/units/services/publicOutputExecutor.test.ts"],"names":[],"mappings":""}
|
|
@@ -0,0 +1,72 @@
|
|
|
1
|
+
import { executePublicOutput } from '../../../modules/review-execution/services/publicOutputExecutor.js';
|
|
2
|
+
import { EgressScannedNoteCommentPostGateway } from '../../../modules/platform-integration/interface-adapters/gateways/egressScanned.noteCommentPost.gateway.js';
|
|
3
|
+
import { createEgressScanner } from '../../../modules/platform-integration/entities/egressScan/egressScan.scanner.js';
|
|
4
|
+
import { StubNoteCommentPostGateway } from '../../../tests/stubs/noteCommentPost.stub.js';
|
|
5
|
+
import { StubEgressTraceGateway } from '../../../tests/stubs/egressScan.stub.js';
|
|
6
|
+
const SECRET = 'glpat-abcdefghij1234567890';
|
|
7
|
+
const redactConfig = {
|
|
8
|
+
secretShapeMode: 'redact',
|
|
9
|
+
lengthMode: 'redact',
|
|
10
|
+
outOfScopeMode: 'redact',
|
|
11
|
+
maxBodyLength: 10000,
|
|
12
|
+
redactionMarker: '[REDACTED]',
|
|
13
|
+
truncationMarker: '…[TRUNCATED]',
|
|
14
|
+
};
|
|
15
|
+
function buildDecoratedGateway() {
|
|
16
|
+
const sink = new StubNoteCommentPostGateway();
|
|
17
|
+
const trace = new StubEgressTraceGateway();
|
|
18
|
+
const scanner = createEgressScanner(redactConfig);
|
|
19
|
+
const gateway = new EgressScannedNoteCommentPostGateway(sink, scanner, trace);
|
|
20
|
+
return { sink, gateway };
|
|
21
|
+
}
|
|
22
|
+
const context = { projectPath: 'group/project', mrNumber: 42 };
|
|
23
|
+
describe('executePublicOutput', () => {
|
|
24
|
+
describe('AC7 — THREAD_REPLY egress is scanned', () => {
|
|
25
|
+
it('routes a THREAD_REPLY body through the decorated sink with redaction', async () => {
|
|
26
|
+
const { sink, gateway } = buildDecoratedGateway();
|
|
27
|
+
const actions = [
|
|
28
|
+
{ type: 'THREAD_REPLY', threadId: 'abc', message: `fixed, token ${SECRET}` },
|
|
29
|
+
];
|
|
30
|
+
await executePublicOutput(actions, context, gateway);
|
|
31
|
+
expect(sink.calls).toHaveLength(1);
|
|
32
|
+
expect(sink.calls[0].body).toContain('[REDACTED]');
|
|
33
|
+
expect(sink.calls[0].body).not.toContain(SECRET);
|
|
34
|
+
});
|
|
35
|
+
});
|
|
36
|
+
describe('AC9 — channel exhaustiveness', () => {
|
|
37
|
+
const verbCases = [
|
|
38
|
+
{ label: 'THREAD_REPLY', action: { type: 'THREAD_REPLY', threadId: 'abc', message: `m ${SECRET}` } },
|
|
39
|
+
{ label: 'POST_COMMENT', action: { type: 'POST_COMMENT', body: `c ${SECRET}` } },
|
|
40
|
+
];
|
|
41
|
+
it.each(verbCases)('routes %s through the same decorated sink', async ({ action }) => {
|
|
42
|
+
const { sink, gateway } = buildDecoratedGateway();
|
|
43
|
+
await executePublicOutput([action], context, gateway);
|
|
44
|
+
expect(sink.calls).toHaveLength(1);
|
|
45
|
+
expect(sink.calls[0].body).not.toContain(SECRET);
|
|
46
|
+
expect(sink.calls[0].body).toContain('[REDACTED]');
|
|
47
|
+
});
|
|
48
|
+
it('every auto-path public-output verb resolves to one shared decorated sink', async () => {
|
|
49
|
+
const { sink, gateway } = buildDecoratedGateway();
|
|
50
|
+
const actions = [
|
|
51
|
+
{ type: 'POST_COMMENT', body: `comment ${SECRET}` },
|
|
52
|
+
{ type: 'THREAD_REPLY', threadId: 't1', message: `reply ${SECRET}` },
|
|
53
|
+
];
|
|
54
|
+
await executePublicOutput(actions, context, gateway);
|
|
55
|
+
expect(sink.calls).toHaveLength(2);
|
|
56
|
+
for (const call of sink.calls) {
|
|
57
|
+
expect(call.body).not.toContain(SECRET);
|
|
58
|
+
expect(call.body).toContain('[REDACTED]');
|
|
59
|
+
}
|
|
60
|
+
});
|
|
61
|
+
it('ignores non-public-output verbs (no body leaves the system)', async () => {
|
|
62
|
+
const { sink, gateway } = buildDecoratedGateway();
|
|
63
|
+
const actions = [
|
|
64
|
+
{ type: 'THREAD_RESOLVE', threadId: 't1' },
|
|
65
|
+
{ type: 'FETCH_THREADS' },
|
|
66
|
+
];
|
|
67
|
+
await executePublicOutput(actions, context, gateway);
|
|
68
|
+
expect(sink.calls).toHaveLength(0);
|
|
69
|
+
});
|
|
70
|
+
});
|
|
71
|
+
});
|
|
72
|
+
//# sourceMappingURL=publicOutputExecutor.test.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"publicOutputExecutor.test.js","sourceRoot":"","sources":["../../../../src/tests/units/services/publicOutputExecutor.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,mBAAmB,EAAE,MAAM,6DAA6D,CAAC;AAElG,OAAO,EAAE,mCAAmC,EAAE,MAAM,qGAAqG,CAAC;AAC1J,OAAO,EAAE,mBAAmB,EAAE,MAAM,0EAA0E,CAAC;AAE/G,OAAO,EAAE,0BAA0B,EAAE,MAAM,uCAAuC,CAAC;AACnF,OAAO,EAAE,sBAAsB,EAAE,MAAM,kCAAkC,CAAC;AAE1E,MAAM,MAAM,GAAG,4BAA4B,CAAC;AAE5C,MAAM,YAAY,GAAqB;IACrC,eAAe,EAAE,QAAQ;IACzB,UAAU,EAAE,QAAQ;IACpB,cAAc,EAAE,QAAQ;IACxB,aAAa,EAAE,KAAK;IACpB,eAAe,EAAE,YAAY;IAC7B,gBAAgB,EAAE,cAAc;CACjC,CAAC;AAEF,SAAS,qBAAqB;IAC5B,MAAM,IAAI,GAAG,IAAI,0BAA0B,EAAE,CAAC;IAC9C,MAAM,KAAK,GAAG,IAAI,sBAAsB,EAAE,CAAC;IAC3C,MAAM,OAAO,GAAG,mBAAmB,CAAC,YAAY,CAAC,CAAC;IAClD,MAAM,OAAO,GAAG,IAAI,mCAAmC,CAAC,IAAI,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC;IAC9E,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC;AAC3B,CAAC;AAED,MAAM,OAAO,GAAG,EAAE,WAAW,EAAE,eAAe,EAAE,QAAQ,EAAE,EAAE,EAAE,CAAC;AAE/D,QAAQ,CAAC,qBAAqB,EAAE,GAAG,EAAE;IACnC,QAAQ,CAAC,sCAAsC,EAAE,GAAG,EAAE;QACpD,EAAE,CAAC,sEAAsE,EAAE,KAAK,IAAI,EAAE;YACpF,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,qBAAqB,EAAE,CAAC;YAClD,MAAM,OAAO,GAAyB;gBACpC,EAAE,IAAI,EAAE,cAAc,EAAE,QAAQ,EAAE,KAAK,EAAE,OAAO,EAAE,gBAAgB,MAAM,EAAE,EAAE;aAC7E,CAAC;YAEF,MAAM,mBAAmB,CAAC,OAAO,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;YAErD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;YACnC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;YACnD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;QACnD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,8BAA8B,EAAE,GAAG,EAAE;QAC5C,MAAM,SAAS,GAAoD;YACjE,EAAE,KAAK,EAAE,cAAc,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,cAAc,EAAE,QAAQ,EAAE,KAAK,EAAE,OAAO,EAAE,KAAK,MAAM,EAAE,EAAE,EAAE;YACpG,EAAE,KAAK,EAAE,cAAc,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,KAAK,MAAM,EAAE,EAAE,EAAE;SACjF,CAAC;QAEF,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,2CAA2C,EAAE,KAAK,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE;YACnF,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,qBAAqB,EAAE,CAAC;YAElD,MAAM,mBAAmB,CAAC,CAAC,MAAM,CAAC,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;YAEtD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;YACnC,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;YACjD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;QACrD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,0EAA0E,EAAE,KAAK,IAAI,EAAE;YACxF,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,qBAAqB,EAAE,CAAC;YAClD,MAAM,OAAO,GAAyB;gBACpC,EAAE,IAAI,EAAE,cAAc,EAAE,IAAI,EAAE,WAAW,MAAM,EAAE,EAAE;gBACnD,EAAE,IAAI,EAAE,cAAc,EAAE,QAAQ,EAAE,IAAI,EAAE,OAAO,EAAE,SAAS,MAAM,EAAE,EAAE;aACrE,CAAC;YAEF,MAAM,mBAAmB,CAAC,OAAO,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;YAErD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;YACnC,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;gBAC9B,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC;gBACxC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAC;YAC5C,CAAC;QACH,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,6DAA6D,EAAE,KAAK,IAAI,EAAE;YAC3E,MAAM,EAAE,IAAI,EAAE,OAAO,EAAE,GAAG,qBAAqB,EAAE,CAAC;YAClD,MAAM,OAAO,GAAyB;gBACpC,EAAE,IAAI,EAAE,gBAAgB,EAAE,QAAQ,EAAE,IAAI,EAAE;gBAC1C,EAAE,IAAI,EAAE,eAAe,EAAE;aAC1B,CAAC;YAEF,MAAM,mBAAmB,CAAC,OAAO,EAAE,OAAO,EAAE,OAAO,CAAC,CAAC;YAErD,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACrC,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"threadActionsExecutor.egress.test.d.ts","sourceRoot":"","sources":["../../../../src/tests/units/services/threadActionsExecutor.egress.test.ts"],"names":[],"mappings":""}
|