reviewable-enterprise-tools 3.0.0 → 3.1.0

package/.github/workflows/publish.yaml

@@ -0,0 +1,13 @@
+name: Publish to npm
+on:
+  push:
+    branches:
+      - release
+
+permissions:
+  id-token: write
+  contents: read
+
+jobs:
+  publish:
+    uses: reviewable/actions/.github/workflows/publish.yaml@master

package/cleanup_refs.js

@@ -81,7 +81,7 @@ async function main() {
     process.exit(1);
   }
   if (args.validateOnly) return;
-  const pace = Pace(refs.length);
+  const pace = Pace(refs.length);  // eslint-disable-line new-cap
   const maxDelay = ms(args.maxDelay);
   let saved = 0;
   await eachLimit(_.chunk(refs, UPDATE_SIZE), MAX_PARALLEL_UPDATES, async refsBatch => {

package/eslint.config.mjs

@@ -0,0 +1,18 @@
+import reviewableConfigBaseline from 'reviewable-configs/eslint-config/baseline.js';
+import reviewableConfigLodash from 'reviewable-configs/eslint-config/lodash.js';
+import globals from 'globals';
+
+export default [
+  ...reviewableConfigBaseline,
+  ...reviewableConfigLodash,
+  {
+    languageOptions: {
+      ecmaVersion: 'latest',
+      sourceType: 'module',
+      globals: {
+        ...globals.node,
+        db: false
+      }
+    }
+  }
+];

package/extract_data.js

@@ -82,7 +82,8 @@ const out = new PromiseWritable(fs.createWriteStream(args.output));
 out.stream.setMaxListeners(Infinity);
 
 const pace = args.logging ?
-  {op() {}, total: 0} :
+  {op: _.noop, total: 0} :
+  // eslint-disable-next-line new-cap
   Pace(1 + 2 + orgNames.length + 2 * repoNames.length + _.size(userMap));
 
 let reviewKeys = [];
@@ -420,7 +421,7 @@ async function extractUsers() {
 }
 
 async function writeItem(key, value, flags) {
-  if (value === undefined || value === null) return;
+  if (_.isNil(value)) return;
   value = mapAllUserKeys(value, key);
   if (flags) {
     await out.write(

package/load_data.js

@@ -74,7 +74,7 @@ async function load() {
   let sizeRead = 0;
   let fatalError;
 
-  const pace = Pace(fs.statSync(args.input).size);
+  const pace = Pace(fs.statSync(args.input).size);  // eslint-disable-line new-cap
   const reader = fs.createReadStream(args.input)
     .pipe(new Throttle({rate: 200000, chunksize: 50000}))
     .pipe(es.mapSync(chunk => {
@@ -84,7 +84,7 @@ async function load() {
     }))
     .pipe(es.split())
     .pipe(es.parse({error: true}))
-    .pipe(es.map(async (item, callback) => {
+    .pipe(es.map(async (item, callback) => {  // eslint-disable-line lodash/prefer-lodash-method
       await processLine(item);
       callback();
     }))
@@ -129,7 +129,7 @@ async function processLine([key, value, flags]) {
         await db.child(key).update(value);
       }
     } catch (e) {
-      e.message + ` (at ${key})`;
+      e.message += ` (at ${key})`;
       throw e;
     }
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "reviewable-enterprise-tools",
-  "version": "3.0.0",
+  "version": "3.1.0",
   "type": "module",
   "description": "Admin tools for Reviewable Enterprise",
   "bin": {
@@ -11,26 +11,23 @@
   "scripts": {
     "extract_data": "node ./extract_data.js",
     "load_data": "node ./load_data.js",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "lint": "eslint *.js lib/*.js"
   },
   "engines": {
     "node": ">=20"
   },
-  "repository": {
-    "type": "git",
-    "url": "git://github.com/reviewable/enterprise-tools.git"
-  },
+  "repository": "https://github.com/Reviewable/enterprise-tools",
   "keywords": [
     "firebase",
     "encryption",
     "reviewable"
   ],
-  "author": "Piotr Kaminski <piotr@ideanest.com>",
+  "author": "Piotr Kaminski <piotr@reviewable.io>",
   "license": "MIT",
   "bugs": {
-    "url": "https://github.com/reviewable/enterprise-tools/issues"
+    "url": "https://github.com/Reviewable/enterprise-tools/issues"
   },
-  "homepage": "https://github.com/reviewable/enterprise-tools#readme",
+  "homepage": "https://github.com/Reviewable/enterprise-tools#readme",
   "dependencies": {
     "@types/async": "^3.2.18",
     "agentkeepalive": "^4.1.3",
@@ -42,8 +39,8 @@
     "download": "^8.0.0",
     "event-stream": "^4.0.1",
     "firebase-admin": "^12.0.0",
-    "firecrypt": "^4.0.0",
-    "hubkit": "^5.2.0",
+    "firecrypt": "^5.0.0",
+    "hubkit": "^6.0.0",
     "lodash": "^4.17.20",
     "ms": "^2.1.2",
     "nodefire": "^3.0.0",
@@ -51,12 +48,13 @@
     "promise-readable": "^6.0.0",
     "promise-writable": "^6.0.0",
     "request": "^2.88.2",
-    "serialized-lru-cache": "^3.1.0",
     "stream-throttle": "^0.1.3",
     "yargs": "^17.7.2"
   },
   "devDependencies": {
-    "eslint": "^8.10.0",
-    "eslint-plugin-lodash": "^7.1.0"
+    "eslint": "^9.39.1",
+    "eslint-plugin-lodash": "^7.1.0",
+    "globals": "^16.5.0",
+    "reviewable-configs": "Reviewable/reviewable-configs"
   }
 }

package/read.js

@@ -3,7 +3,7 @@
 import commandLineArgs from 'command-line-args';
 import getUsage from 'command-line-usage';
 import {writeFileSync} from 'fs';
-import {inspect} from 'util';
+// import {inspect} from 'util';
 
 const commandLineOptions = [
   {name: 'path', alias: 'p', type: String, defaultOption: true,

package/rules_firecrypt.json

@@ -33,6 +33,11 @@
     "queues": {
       "github": {
         "$eventKey": {
+          "payload": {
+            ".encrypt": {
+              "value": "#"
+            }
+          },
           "statusSyncKey": {
             ".encrypt": {
               "value": "#"

package/.eslintrc.js

@@ -1,144 +0,0 @@
-'use strict';
-
-module.exports = {
-  env: {
-    node: true,
-    es6: true
-  },
-  parserOptions: {
-    ecmaVersion: 2020
-  },
-  plugins: ['lodash'],
-  extends: ['eslint:recommended', 'plugin:lodash/canonical'],
-  globals: {
-    db: false,
-  },
-  rules: {
-    'accessor-pairs': 'error',
-    'array-bracket-spacing': 'warn',
-    'arrow-spacing': 'warn',
-    'block-spacing': ['warn', 'never'],
-    'brace-style': ['warn', '1tbs', {allowSingleLine: true}],
-    'camelcase': 'error',
-    'comma-spacing': 'warn',
-    'comma-style': 'warn',
-    'computed-property-spacing': 'warn',
-    'curly': ['error', 'multi-line'],
-    'dot-location': ['warn', 'property'],
-    'dot-notation': 'warn',
-    'eol-last': 'warn',
-    'eqeqeq': 'error',
-    'func-call-spacing': 'warn',
-    'generator-star-spacing': ['warn', {before: true, after: false, anonymous: 'neither'}],
-    'indent': ['warn', 2, {
-      SwitchCase: 1,
-      MemberExpression: 'off',
-      FunctionDeclaration: {parameters: 'off'},
-      FunctionExpression: {parameters: 'off'}
-    }],
-    'key-spacing': ['warn', {mode: 'minimum'}],
-    'keyword-spacing': 'warn',
-    'linebreak-style': 'warn',
-    'lines-between-class-members': 'warn',
-    'lodash/chaining': ['error', 'implicit'],
-    'lodash/prefer-filter': 'off',
-    'lodash/prefer-invoke-map': 'off',
-    'lodash/prop-shorthand': 'off',
-    'lodash/matches-prop-shorthand': 'off',
-    'lodash/prefer-immutable-method': 'off',
-    'lodash/prefer-lodash-method': ['error', {ignoreMethods: ['split', 'replace']}],
-    'lodash/prefer-map': 'off',
-    'max-len': ['warn', {code: 100, ignoreUrls: true, ignoreRegExpLiterals: true}],
-    'new-cap': 'error',
-    'new-parens': 'error',
-    'no-alert': 'error',
-    'no-array-constructor': 'error',
-    'no-bitwise': ['error', {allow: ['~']}],
-    'no-buffer-constructor': 'error',
-    'no-caller': 'error',
-    'no-console': 'off',
-    'no-constant-condition': ['error', {checkLoops: false}],
-    'no-duplicate-imports': 'error',
-    'no-else-return': 'error',
-    'no-empty-function': 'error',
-    'no-eval': 'error',
-    'no-extend-native': 'error',
-    'no-extra-bind': 'error',
-    'no-extra-label': 'error',
-    'no-floating-decimal': 'error',
-    'no-implicit-globals': 'error',
-    'no-implied-eval': 'error',
-    'no-invalid-this': 'error',
-    'no-iterator': 'error',
-    'no-lone-blocks': 'error',
-    'no-lonely-if': 'error',
-    'no-loop-func': 'error',
-    'no-multi-spaces': ['warn', {ignoreEOLComments: true}],
-    'no-multi-str': 'warn',
-    'no-multiple-empty-lines': 'warn',
-    'no-negated-condition': 'error',
-    'no-new': 'error',
-    'no-new-func': 'error',
-    'no-new-object': 'error',
-    'no-new-require': 'error',
-    'no-new-wrappers': 'error',
-    'no-octal-escape': 'error',
-    'no-path-concat': 'error',
-    'no-proto': 'error',
-    'no-script-url': 'error',
-    'no-self-compare': 'error',
-    'no-sequences': 'error',
-    'no-shadow': 'error',
-    'no-shadow-restricted-names': 'error',
-    'no-tabs': 'warn',
-    'no-template-curly-in-string': 'error',
-    'no-throw-literal': 'error',
-    'no-trailing-spaces': 'warn',
-    'no-undef-init': 'error',
-    'no-unexpected-multiline': 'off',
-    'no-unmodified-loop-condition': 'error',
-    'no-unneeded-ternary': 'error',
-    'no-unused-expressions': 'error',
-    'no-unused-vars': ['error', {args: 'none'}],
-    'no-use-before-define': ['error', {functions: false}],
-    'no-useless-call': 'error',
-    'no-useless-computed-key': 'error',
-    'no-useless-concat': 'error',
-    'no-useless-constructor': 'error',
-    'no-useless-rename': 'error',
-    'no-useless-return': 'error',
-    'no-var': 'error',
-    'no-whitespace-before-property': 'warn',
-    'no-with': 'error',
-    'nonblock-statement-body-position': 'error',
-    'object-curly-spacing': 'warn',
-    'object-shorthand': 'error',
-    'operator-linebreak': ['warn', 'after'],
-    'prefer-arrow-callback': 'error',
-    'prefer-const': 'error',
-    'prefer-numeric-literals': 'error',
-    'prefer-promise-reject-errors': 'error',
-    'quotes': ['error', 'single', {allowTemplateLiterals: true}],
-    'radix': 'error',
-    'require-atomic-updates': 'off',
-    'rest-spread-spacing': 'warn',
-    'semi': 'error',
-    'semi-spacing': 'warn',
-    'semi-style': 'warn',
-    'space-before-blocks': 'warn',
-    'space-before-function-paren': [
-      'warn', {anonymous: 'never', named: 'never', asyncArrow: 'always'}
-    ],
-    'space-in-parens': 'warn',
-    'space-infix-ops': 'warn',
-    'space-unary-ops': ['warn', {words: true, nonwords: false}],
-    'spaced-comment': 'warn',
-    'strict': ['error'],
-    'switch-colon-spacing': 'warn',
-    'template-curly-spacing': 'warn',
-    'template-tag-spacing': 'warn',
-    'unicode-bom': 'error',
-    'yoda': 'error',
-  }
-};
-