review-workspace 1.9.0 → 1.10.2

package/dist/bundle/resolve-diagnostics.js

@@ -68,6 +68,19 @@ export function resolveTarget(target, patch) {
     }
     return undefined;
 }
+// A Verification item's targetIds may name an Annotation id, an Evidence id, or a file
+// path directly (see render.ts's buildVerificationByTargetId) — none of which is itself
+// a guarantee of a concrete place. An Evidence id only anchors if that Evidence's own
+// targetIds resolve to an Annotation or a file in turn; anything else (a Behavioral Group
+// id, a dangling id) resolves to nowhere the reviewer can be sent.
+function isConcreteAnchor(id, annotationIds, evidenceById, filePaths) {
+    if (annotationIds.has(id) || filePaths.has(id))
+        return true;
+    const evidence = evidenceById.get(id);
+    if (!evidence)
+        return false;
+    return (evidence.targetIds ?? []).some((innerId) => annotationIds.has(innerId) || filePaths.has(innerId));
+}
 export function collectDiagnostics(document, patch, bundlePath, limits = DEFAULT_LIMITS) {
     const diagnostics = [];
     const schemaResult = validateReviewDocumentSchema(document);
@@ -110,5 +123,20 @@ export function collectDiagnostics(document, patch, bundlePath, limits = DEFAULT
             }
         }
     }
+    if (document.verification?.length) {
+        const annotationIds = new Set((document.annotations ?? []).map((a) => a.id));
+        const evidenceById = new Map((document.evidence ?? []).map((e) => [e.id, e]));
+        const filePaths = new Set(patch.files.map((f) => f.path));
+        for (const item of document.verification) {
+            if (item.status !== 'gap' || item.diffuse)
+                continue;
+            const ids = item.targetIds ?? [];
+            const anchored = ids.some((id) => isConcreteAnchor(id, annotationIds, evidenceById, filePaths));
+            if (!anchored) {
+                const detail = ids.length === 0 ? 'targetIds is empty' : `targetIds ${JSON.stringify(ids)} resolve to no Annotation, Evidence, or file`;
+                diagnostics.push({ kind: 'unanchored-verification-gap', verificationId: item.id, detail });
+            }
+        }
+    }
     return diagnostics;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "review-workspace",
-  "version": "1.9.0",
+  "version": "1.10.2",
   "description": "A local, offline decision surface for reviewing a code Comparison — evidence-linked map of intent, behavior, risk, and observable effects.",
   "license": "MIT",
   "author": "Salih Sayer",

package/schemas/review-document.schema.json

@@ -154,7 +154,8 @@
         "id": { "type": "string", "minLength": 1 },
         "description": { "type": "string", "minLength": 1 },
         "status": { "enum": ["unverified", "verified", "gap"] },
-        "targetIds": { "type": "array", "items": { "type": "string" } }
+        "targetIds": { "type": "array", "items": { "type": "string" } },
+        "diffuse": { "type": "boolean" }
       }
     },
     "answer": {