review-workspace 1.6.0 → 1.7.1

package/README.md

@@ -32,6 +32,20 @@ npx review-workspace serve .bundles/<name> --port 4317
 
 Opens the UI at `http://127.0.0.1:4317` (prints a write token too — needed only to raise/answer Questions, not to view). One process, no separate dev server.
 
+## Addressing review feedback in the target repo
+
+When a bundle has open change-request Comments, publishing it exports a self-describing hand-off file (`.review-feedback/<mr-number>-round<N>.md`) into the *target* repo's own working tree. A second skill, `skills/address-review-feedback/`, reads that file there, implements or explicitly skips each change-request against the target repo's own conventions, runs the target repo's own verification, writes a structured response file next to the hand-off file, and commits and pushes — then asks whether to spawn a background `review-workspace` agent for the next round.
+
+It installs the same way as the Generator skill above — no separate step:
+
+```sh
+npx skills add sabasayer/review-workspace --global --agent claude-code -y
+```
+
+(`npx skills add`/`update sabasayer/review-workspace` installs every directory under `skills/`, so this second skill comes along with the Generator.)
+
+**Use it**: in the target repo, ask Claude Code to address the review feedback, e.g. "Address the review feedback using the address-review-feedback skill" — with or without pointing at a specific `.review-feedback/*.md` path; it finds the latest unaddressed one on its own otherwise.
+
 ## Development
 
 ```sh

package/dist/bundle/round.js

@@ -1,5 +1,5 @@
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from 'node:fs';
-import { basename, dirname, join, relative } from 'node:path';
+import { basename, dirname, join, relative, resolve } from 'node:path';
 /**
  * A stable cross-round identity for one MR: repo slug + number, e.g.
  * "founda/application/xds-viewer-ui!367".
@@ -33,8 +33,13 @@ function parseBundleDirName(dirName) {
 }
 /** The sibling bundle path a new round for `bundlePath` would scaffold into. */
 export function nextRoundBundlePath(bundlePath) {
-    const { baseName, round } = parseBundleDirName(basename(bundlePath));
-    return join(dirname(bundlePath), `${baseName}-r${round + 1}`);
+    // Resolve first: basename/dirname on "." or ".." (a bundle path relative to
+    // cwd, e.g. when invoked as `round .`) otherwise collapse to "." for both,
+    // producing a literal "-r{N}" sibling nested inside the bundle itself
+    // instead of a real sibling directory next to it.
+    const resolved = resolve(bundlePath);
+    const { baseName, round } = parseBundleDirName(basename(resolved));
+    return join(dirname(resolved), `${baseName}-r${round + 1}`);
 }
 /**
  * Detects, purely from what's on disk plus a supplied live head, whether a
@@ -56,7 +61,8 @@ export function scaffoldNextRound(bundlePath, liveHead, options) {
     if (document.comparison.head === liveHead) {
         throw new Error(`Live head ${liveHead} matches the bundle's recorded head; no new round is needed`);
     }
-    const { round: currentRound } = parseBundleDirName(basename(bundlePath));
+    const resolvedBundlePath = resolve(bundlePath);
+    const { round: currentRound } = parseBundleDirName(basename(resolvedBundlePath));
     const newBundlePath = nextRoundBundlePath(bundlePath);
     if (existsSync(newBundlePath)) {
         throw new Error(`Round bundle already exists at ${newBundlePath}`);
@@ -64,7 +70,7 @@ export function scaffoldNextRound(bundlePath, liveHead, options) {
     const chain = {
         mrKey: mrKeyFor(document.comparison),
         round: currentRound + 1,
-        previousBundle: relative(newBundlePath, bundlePath),
+        previousBundle: relative(newBundlePath, resolvedBundlePath),
         previousHead: document.comparison.head,
     };
     mkdirSync(newBundlePath, { recursive: true });

package/dist/handoff/parse-handoff-metadata.js

@@ -0,0 +1,27 @@
+const METADATA_BLOCK = /<!--\s*review-workspace-handoff\s*([\s\S]*?)-->/;
+function field(block, key) {
+    const match = block.match(new RegExp(`^${key}:[ \\t]*(.*)$`, 'm'));
+    return match?.[1]?.trim();
+}
+/**
+ * Parses the `<!-- review-workspace-handoff ... -->` metadata block a hand-off
+ * Markdown file carries (written by `buildHandoffMarkdown`) back into its
+ * structured fields. Returns `undefined` for a missing block or a block
+ * missing any required field, rather than a partially-filled result.
+ */
+export function parseHandoffMetadata(markdown) {
+    const blockMatch = markdown.match(METADATA_BLOCK);
+    if (!blockMatch)
+        return undefined;
+    const block = blockMatch[1];
+    const bundlePath = field(block, 'bundlePath');
+    const repository = field(block, 'repository');
+    const mrNumber = field(block, 'mrNumber');
+    const roundText = field(block, 'round');
+    if (!bundlePath || !repository || !mrNumber || !roundText)
+        return undefined;
+    const round = Number(roundText);
+    if (!Number.isInteger(round))
+        return undefined;
+    return { bundlePath, repository, mrNumber, round };
+}

package/dist/handoff/write-handoff-response.js

@@ -0,0 +1,13 @@
+import { writeFileSync } from 'node:fs';
+import { dirname, join } from 'node:path';
+/**
+ * Writes an implementer's per-comment response as `<mr-number>-round<N>.response.json`
+ * next to the hand-off file it corresponds to (same `.review-feedback/` directory).
+ * Pure serialization — no git or LLM behavior lives here.
+ */
+export function writeHandoffResponse(options) {
+    const { handoffFilePath, mrNumber, round, responses } = options;
+    const filePath = join(dirname(handoffFilePath), `${mrNumber}-round${round}.response.json`);
+    writeFileSync(filePath, JSON.stringify(responses, null, 2) + '\n');
+    return filePath;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "review-workspace",
-  "version": "1.6.0",
+  "version": "1.7.1",
   "description": "A local, offline decision surface for reviewing a code Comparison — evidence-linked map of intent, behavior, risk, and observable effects.",
   "license": "MIT",
   "author": "Salih Sayer",