resplite 1.4.16 → 1.4.18

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "resplite",
-  "version": "1.4.16",
+  "version": "1.4.18",
   "description": "A RESP2 server with practical Redis compatibility, backed by SQLite",
   "type": "module",
   "main": "src/index.js",

package/src/storage/sqlite/schema.js

@@ -72,6 +72,10 @@ CREATE TABLE IF NOT EXISTS search_indices (
   created_at INTEGER NOT NULL,
   updated_at INTEGER NOT NULL
 );
+
+CREATE TABLE IF NOT EXISTS search_rowid_allocator (
+  id INTEGER PRIMARY KEY AUTOINCREMENT
+);
 `;
 
 /** Type enum: 1=string, 2=hash, 3=set, 4=list, 5=zset */

package/src/storage/sqlite/search.js

@@ -68,6 +68,17 @@ function deleteFtsRow(db, ftsTableName, ftsRowid, fieldNames, fields) {
   );
 }
 
+/**
+ * Allocate a monotonic FTS rowid that is never reused, even after deletes.
+ * This prevents legacy stale tokens from being remapped to a new document.
+ * @param {import('better-sqlite3').Database} db
+ * @returns {number}
+ */
+function allocateFtsRowid(db) {
+  const info = db.prepare('INSERT INTO search_rowid_allocator DEFAULT VALUES').run();
+  return Number(info.lastInsertRowid);
+}
+
 /**
  * Build canonical schema JSON (fields sorted by name). D.12.2
  * @param {{ name: string, type: string }[]} fields
@@ -194,15 +205,16 @@ export function addDocument(db, idx, docId, score, replace, fields) {
     let ftsRowid;
     if (existing) {
       if (!replace) throw new Error('ERR document exists');
-      ftsRowid = existing.fts_rowid;
+      const previousRowid = existing.fts_rowid;
+      ftsRowid = allocateFtsRowid(db);
+      db.prepare(`UPDATE ${docmapT} SET fts_rowid = ? WHERE doc_id = ?`).run(ftsRowid, docId);
       const oldDoc = db.prepare(`SELECT fields_json FROM ${docsT} WHERE doc_id = ?`).get(docId);
       if (oldDoc?.fields_json) {
         const oldFields = JSON.parse(oldDoc.fields_json);
-        deleteFtsRow(db, ftsT, ftsRowid, fieldNames, oldFields);
+        deleteFtsRow(db, ftsT, previousRowid, fieldNames, oldFields);
       }
     } else {
-      const maxRow = db.prepare(`SELECT COALESCE(MAX(rowid), 0) AS m FROM ${ftsT}`).get();
-      ftsRowid = maxRow.m + 1;
+      ftsRowid = allocateFtsRowid(db);
       db.prepare(`INSERT INTO ${docmapT}(doc_id, fts_rowid) VALUES (?, ?)`).run(docId, ftsRowid);
     }
 

package/test/unit/search.test.js

@@ -88,6 +88,31 @@ describe('Search layer', () => {
     assert.equal(deleteDocument(db, 'names', 'nonexistent'), 0);
   });
 
+  it('delete + re-add never remaps legacy stale tokens', () => {
+    createIndex(db, 'legacy_stale', [{ name: 'payload', type: 'TEXT' }]);
+    addDocument(db, 'legacy_stale', 'doc1', 1, true, { payload: 'gorrion' });
+
+    const mapped = db
+      .prepare('SELECT fts_rowid FROM search_docmap__legacy_stale WHERE doc_id = ?')
+      .get('doc1');
+    const oldRowid = mapped.fts_rowid;
+
+    // Simulate a legacy-polluted index row where stale term postings exist for the same rowid.
+    db.prepare('INSERT INTO search_fts__legacy_stale(rowid, payload) VALUES (?, ?)').run(oldRowid, 'bicho');
+
+    assert.equal(search(db, 'legacy_stale', 'bicho*', { noContent: true }).total, 1);
+    assert.equal(deleteDocument(db, 'legacy_stale', 'doc1'), 1);
+
+    addDocument(db, 'legacy_stale', 'doc1', 1, true, { payload: 'gorrion' });
+    const remapped = db
+      .prepare('SELECT fts_rowid FROM search_docmap__legacy_stale WHERE doc_id = ?')
+      .get('doc1');
+    assert.notEqual(remapped.fts_rowid, oldRowid);
+
+    assert.equal(search(db, 'legacy_stale', 'gorrion*', { noContent: true }).total, 1);
+    assert.equal(search(db, 'legacy_stale', 'bicho*', { noContent: true }).total, 0);
+  });
+
   it('search with NOCONTENT returns total and doc ids', () => {
     const r = search(db, 'names', 'hello', { noContent: true, offset: 0, count: 10 });
     assert.equal(typeof r.total, 'number');