rerobe-js-orm 3.0.31 → 3.0.32

package/lib/constants/product-constants.js

@@ -73,4 +73,5 @@ exports.MEASUREMENT_FIELDS_DICT = {
     innerLeg: 'Inner Leg',
     outerLeg: 'Outer Leg',
     footCircumference: 'Foot Circumference',
+    sleeveLength: 'Sleeve Length',
 };

package/lib/helpers/ReRobeProductHelpers.d.ts

@@ -9,7 +9,7 @@ export default class ReRobeProductHelpers {
     static buildReRobeEarnings(arrayLike: CompleteProduct | CompleteProduct[]): number[];
     static buildReRobeEarningsV2(arrayLike: CompleteProduct | CompleteProduct[], isCanonicalMerchant?: boolean): number[];
     static materialCompJoinedString(materialComposition?: MaterialComposition): string;
-    static measurementsJoinedString(measurementsObj?: Measurements): string;
+    static measurementsJoinedString(measurementsObj: Measurements): string;
     static sizeCommentPretty(sizeComment: string): string;
     static getSizeLabel(clothingSize: string[], shoeSize: string, jeanSize: string): string;
     static generateArrForDetailsBulletList(productObj: CompleteProduct): string[];

package/lib/helpers/ReRobeProductHelpers.js

@@ -111,23 +111,20 @@ class ReRobeProductHelpers {
         }
         return '';
     }
-    static measurementsJoinedString(measurementsObj = {}) {
-        if (measurementsObj && Object.values(measurementsObj).filter((e) => e).length > 0) {
-            const measurementStr = Object.keys(measurementsObj).reduce((acc, cur) => {
-                let result = acc;
-                if (cur !== 'unit') {
-                    if (measurementsObj[cur]) {
-                        if (acc === '') {
-                            return (result = `${measurementsObj[cur]} ${measurementsObj.unit} ${cur}`);
-                        }
-                        return (result = `${measurementsObj[cur]} ${measurementsObj.unit} ${cur} x ${acc}`);
-                    }
-                }
-                return result;
-            }, '');
-            return measurementStr;
+    static measurementsJoinedString(measurementsObj) {
+        if (typeof measurementsObj !== 'object' || measurementsObj == null) {
+            return '';
         }
-        return '';
+        if (Object.keys(measurementsObj).length === 0) {
+            return '';
+        }
+        return Object.keys(measurementsObj)
+            .filter((key) => key !== 'unit' && !!measurementsObj[key])
+            .map((key) => {
+            const label = product_constants_1.MEASUREMENT_FIELDS_DICT[key] || lodash_1.startCase(key);
+            return `${measurementsObj[key]} ${measurementsObj.unit} ${label}`;
+        })
+            .join(' x ');
     }
     static sizeCommentPretty(sizeComment) {
         const scO = options_1.sizeCommentOptions.filter((o) => o.value === sizeComment);

package/lib/models/Product.js

@@ -843,13 +843,11 @@ class Product extends Base_1.default {
             return '';
         }
         return Object.keys(measurementsObj)
-            .filter((key) => key !== 'unit')
+            .filter((key) => key !== 'unit' && !!measurementsObj[key])
             .map((key) => {
-            // @ts-ignore
-            const label = product_constants_1.MEASUREMENT_FIELDS_DICT[key] || key;
+            const label = product_constants_1.MEASUREMENT_FIELDS_DICT[key] || this.utilities.startCase(key);
             return `${measurementsObj[key]} ${measurementsObj.unit} ${label}`;
         })
-            .reverse()
             .join(' x ');
     }
     convertMaterialCompJoinedStrToObj(materialCompJoinedString) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "rerobe-js-orm",
-  "version": "3.0.31",
+  "version": "3.0.32",
   "description": "ReRobe's Javascript ORM Framework",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",