repzo-sap-absjo 1.0.36 → 1.0.37

package/lib/actions/create_invoice.js

@@ -312,14 +312,14 @@ export const create_invoice = async (event, options) => {
         Quantity: item.qty,
         TaxCode: repzo_tax.integration_meta.TaxCode,
         UnitPrice: (item.price * repzo_measureunit.factor) / 1000,
-        DiscountPerc: "0",
+        DiscountPerc: "0", // ??
         //@ts-ignore
         LineTotal: item.total_before_tax / 1000,
         UomCode: repzo_measureunit.integration_meta.ALTUOMID,
         Brand:
           (_o = repzo_product.integration_meta) === null || _o === void 0
             ? void 0
-            : _o.BRAND,
+            : _o.BRAND, // "B1", // ??
         Department:
           ((_p =
             repzo_rep === null || repzo_rep === void 0

package/lib/actions/create_proforma.js

@@ -3,7 +3,7 @@ import { _create, getUniqueConcatenatedValues } from "../util.js";
 import { v4 as uuid } from "uuid";
 import moment from "moment-timezone";
 export const create_proforma = async (event, options) => {
-  var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r;
+  var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p, _q, _r, _s, _t;
   const repzo = new Repzo(
     (_a = options.data) === null || _a === void 0 ? void 0 : _a.repzoApiKey,
     { env: options.env }
@@ -62,11 +62,29 @@ export const create_proforma = async (event, options) => {
             ? void 0
             : repzo_proforma.creator) === null || _e === void 0
           ? void 0
-          : _e._id
+          : _e._id,
+        {
+          populatedKeys: ["warehouse"],
+        }
       );
       if (!repzo_rep)
         throw `Rep with _id: ${repzo_proforma.creator._id} not found in Repzo`;
     }
+    let rep_warehouse_code;
+    if (
+      repzo_rep &&
+      (repzo_rep === null || repzo_rep === void 0
+        ? void 0
+        : repzo_rep.assigned_warehouse)
+    ) {
+      rep_warehouse_code =
+        (_f =
+          repzo_rep === null || repzo_rep === void 0
+            ? void 0
+            : repzo_rep.assigned_warehouse) === null || _f === void 0
+          ? void 0
+          : _f.code;
+    }
     // Get Repzo Client
     const repzo_client = await repzo.client.get(
       repzo_proforma === null || repzo_proforma === void 0
@@ -78,9 +96,9 @@ export const create_proforma = async (event, options) => {
     const repzo_tax_ids = {};
     const repzo_measureunit_ids = {};
     const repzo_product_ids = {};
-    (_f = repzo_proforma.items) === null || _f === void 0
+    (_g = repzo_proforma.items) === null || _g === void 0
       ? void 0
-      : _f.forEach((item) => {
+      : _g.forEach((item) => {
           var _a, _b, _c;
           if (item) {
             repzo_tax_ids[
@@ -138,12 +156,12 @@ export const create_proforma = async (event, options) => {
       { per_page: 50000 }
     );
     const all_promotions = {};
-    (_g =
+    (_h =
       repzo_proforma === null || repzo_proforma === void 0
         ? void 0
-        : repzo_proforma.promotions) === null || _g === void 0
+        : repzo_proforma.promotions) === null || _h === void 0
       ? void 0
-      : _g.forEach((promo) => {
+      : _h.forEach((promo) => {
           if (!promo) return;
           all_promotions[promo._id] = {
             _id: promo._id,
@@ -156,23 +174,23 @@ export const create_proforma = async (event, options) => {
     for (
       let i = 0;
       i <
-      ((_h =
+      ((_j =
         repzo_proforma === null || repzo_proforma === void 0
           ? void 0
-          : repzo_proforma.items) === null || _h === void 0
+          : repzo_proforma.items) === null || _j === void 0
         ? void 0
-        : _h.length);
+        : _j.length);
       i++
     ) {
       const item = repzo_proforma.items[i];
       // Get Repzo Tax
       const repzo_tax =
-        (_j =
+        (_k =
           repzo_taxes === null || repzo_taxes === void 0
             ? void 0
-            : repzo_taxes.data) === null || _j === void 0
+            : repzo_taxes.data) === null || _k === void 0
           ? void 0
-          : _j.find((t) => {
+          : _k.find((t) => {
               var _a, _b, _c;
               return (
                 ((_a = t._id) === null || _a === void 0
@@ -189,12 +207,12 @@ export const create_proforma = async (event, options) => {
       if (!repzo_tax) throw `Tax with _id: ${item.tax._id} not found in Repzo`;
       // Get Repzo UoM
       const repzo_measureunit =
-        (_k =
+        (_l =
           repzo_measureunits === null || repzo_measureunits === void 0
             ? void 0
-            : repzo_measureunits.data) === null || _k === void 0
+            : repzo_measureunits.data) === null || _l === void 0
           ? void 0
-          : _k.find((m) => {
+          : _l.find((m) => {
               var _a, _b, _c;
               return (
                 ((_a = m._id) === null || _a === void 0
@@ -210,16 +228,16 @@ export const create_proforma = async (event, options) => {
             });
       if (!repzo_measureunit)
         throw `Uom with _id: ${
-          (_l = item.measureunit) === null || _l === void 0 ? void 0 : _l._id
+          (_m = item.measureunit) === null || _m === void 0 ? void 0 : _m._id
         } not found in Repzo`;
       // Get Repzo Product
       const repzo_product =
-        (_m =
+        (_o =
           repzo_products === null || repzo_products === void 0
             ? void 0
-            : repzo_products.data) === null || _m === void 0
+            : repzo_products.data) === null || _o === void 0
           ? void 0
-          : _m.find((p) => {
+          : _o.find((p) => {
               var _a, _b, _c;
               return (
                 ((_a = p._id) === null || _a === void 0
@@ -257,28 +275,28 @@ export const create_proforma = async (event, options) => {
         LineTotal: item.total_before_tax / 1000,
         UomCode: repzo_measureunit.integration_meta.ALTUOMID,
         Brand:
-          (_o = repzo_product.integration_meta) === null || _o === void 0
+          (_p = repzo_product.integration_meta) === null || _p === void 0
             ? void 0
-            : _o.BRAND,
+            : _p.BRAND,
         Department:
-          ((_p =
+          ((_q =
             repzo_rep === null || repzo_rep === void 0
               ? void 0
-              : repzo_rep.integration_meta) === null || _p === void 0
+              : repzo_rep.integration_meta) === null || _q === void 0
             ? void 0
-            : _p.DEPARTMENTCODE) ||
-          ((_q = options.data) === null || _q === void 0
+            : _q.DEPARTMENTCODE) ||
+          ((_r = options.data) === null || _r === void 0
             ? void 0
-            : _q.DepartmentCode), // "D2"
+            : _r.DepartmentCode), // "D2"
       });
     }
     const sap_invoice = {
       RefNum: repzo_proforma.serial_number.formatted,
       SalPersCode: repzo_rep
         ? repzo_rep.integration_id
-        : (_r = options.data) === null || _r === void 0
+        : (_s = options.data) === null || _s === void 0
         ? void 0
-        : _r.SalPersCode,
+        : _s.SalPersCode, // "111",
       DocDate: moment(repzo_proforma.issue_date, "YYYY-MM-DD").format(
         "YYYYMMDD"
       ),
@@ -288,7 +306,11 @@ export const create_proforma = async (event, options) => {
       ClientCode: repzo_client.client_code,
       DiscountPerc: "0",
       Note: repzo_proforma.comment,
-      // WarehouseCode: "1",
+      WarehouseCode:
+        rep_warehouse_code ||
+        ((_t = options.data) === null || _t === void 0
+          ? void 0
+          : _t.defaultWarehouseForSalesOrder), // "1",
       LinesDetails: items,
     };
     // console.dir(sap_invoice, { depth: null });

package/lib/actions/create_return_invoice.js

@@ -253,7 +253,7 @@ export const create_return_invoice = async (event, options) => {
         Brand:
           (_o = repzo_product.integration_meta) === null || _o === void 0
             ? void 0
-            : _o.BRAND,
+            : _o.BRAND, // "B1",
         Department:
           ((_p =
             repzo_rep === null || repzo_rep === void 0
@@ -263,7 +263,7 @@ export const create_return_invoice = async (event, options) => {
             : _p.DEPARTMENTCODE) ||
           ((_q = options.data) === null || _q === void 0
             ? void 0
-            : _q.DepartmentCode),
+            : _q.DepartmentCode), // "D2"
         Return_Reason:
           item_return_reason === null || item_return_reason === void 0
             ? void 0

package/lib/actions/create_transfer.js

@@ -171,7 +171,7 @@ export const create_transfer = async (event, options) => {
         ? repzo_rep.integration_id
         : (_o = options.data) === null || _o === void 0
         ? void 0
-        : _o.SalesPersonCode,
+        : _o.SalesPersonCode, // "111"
       FromWarehouse: body.from.code,
       ToWarehouse: body.to.code,
       RepzoStockTransferLines: variants,

package/lib/commands/client.js

@@ -219,9 +219,9 @@ export const sync_client = async (commandEvent) => {
         comment: sap_client.CLIENTNOTE,
         formatted_address: sap_client.CLIENTADDRESSID,
         tags: tag ? [tag._id] : [],
-        credit_limit: sap_client.PAYMENTTERM // sap_client.CLIENTGROUP == "Cash Van"
-          ? credit_limit && Math.round(credit_limit * 1000)
-          : 1000000000,
+        // credit_limit: sap_client.PAYMENTTERM // sap_client.CLIENTGROUP == "Cash Van"
+        //   ? credit_limit && Math.round(credit_limit * 1000)
+        //   : 1000000000,
         financials: {
           credit_limit: sap_client.PAYMENTTERM // sap_client.CLIENTGROUP == "Cash Van"
             ? credit_limit && Math.round(credit_limit * 1000)
@@ -231,9 +231,10 @@ export const sync_client = async (commandEvent) => {
         paymentTerm: paymentTerm ? paymentTerm._id : undefined,
         sv_priceList: priceList ? priceList._id : undefined,
         disabled: sap_client.ACTIVE == "Y" ? false : true,
-        payment_type: sap_client.PAYMENTTERM ? "credit" : "cash",
+        payment_type: sap_client.PAYMENTTERM ? "credit" : "cash", // sap_client.CLIENTGROUP == "Cash Van"
         integrated_client_balance:
           client_credit_consumed && Math.round(client_credit_consumed * 1000),
+        company_namespace: [nameSpace],
       };
       if (!repzo_client) {
         // Create

package/lib/commands/measureunit.js

@@ -207,7 +207,7 @@ export const sync_measureunit = async (commandEvent) => {
       const body = {
         parent: repzo_parent_id,
         name: sap_UoM.ALTUOMCODE,
-        factor: sap_UoM.repzo_factor || 0,
+        factor: sap_UoM.repzo_factor || 0, // ??????
         disabled: false,
         integration_meta: {
           id: `${nameSpace}_${sap_UoM.ITEMCODE}_${sap_UoM.UOMGROUPENTRY}_${sap_UoM.ALTUOMID}`,

package/lib/commands/product.js

@@ -300,7 +300,7 @@ export const sync_product = async (commandEvent) => {
             {
               disabled: false,
               name: sap_product.ITEMCODE,
-              price: 0,
+              price: 0, // Math.round(sap_product.PRICE * 1000),
               integration_meta: {
                 id: `${nameSpace}_${sap_product.ITEMCODE}`,
                 ITEMCODE: sap_product.ITEMCODE,

package/lib/commands/tax.js

@@ -96,7 +96,7 @@ export const sync_tax = async (commandEvent) => {
       const body = {
         name: sap_tax.TaxName,
         rate: Number(sap_tax.TaxRate / 100),
-        type: "additive",
+        type: "additive", // hardcode
         disabled: sap_tax.Inactive === "N" ? false : true,
         integration_meta: {
           id: `${nameSpace}_${sap_tax.TaxCode}`,

package/lib/test/actions/create_invoice.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_invoice",
     headers: {
-      action_sync_id: "Actions-0000001",
+      action_sync_id: "Actions-0000001", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",

package/lib/test/actions/create_payment.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_payment",
     headers: {
-      action_sync_id: "Actions-0000004",
+      action_sync_id: "Actions-0000004", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",

package/lib/test/actions/create_proforma.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_proforma",
     headers: {
-      action_sync_id: "Actions-0000003",
+      action_sync_id: "Actions-0000003", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",
@@ -238,6 +238,7 @@ Actions(
         '[{sap_id:1,sap_name:"BarcodeIssue",repzo_name:"Barcodeissue",repzo_id:"62b074972b332895edf114fc"},{sap_id:2,sap_name:"Damaged",repzo_name:"Damaged",repzo_id:"62b074ace96258fb745982e4"},{sap_id:3,sap_name:"Nearexpiry",repzo_name:"Nearexpiry",repzo_id:"62b074c0a066173bd1c1ea0d"},{sap_id:4,sap_name:"Wrongprinting",repzo_name:"Wrongprinting",repzo_id:"62b074d79e7f41f306a4cb42"},{sap_id:5,sap_name:"experied",repzo_name:"Experied",repzo_id:"62b074faa066173bd1c1eec0"}]',
       SalPersCode: "111",
       SalesPersonCode: "111",
+      defaultWarehouseForSalesOrder: "1",
     },
   }
 );

package/lib/test/actions/create_return_invoice.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_return_invoice",
     headers: {
-      action_sync_id: "Actions-0000002",
+      action_sync_id: "Actions-0000002", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",

package/lib/test/actions/create_transfer.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_transfer",
     headers: {
-      action_sync_id: "Actions-0000005",
+      action_sync_id: "Actions-0000005", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",

package/lib/test/commands/brand.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/test/commands/category.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/test/commands/channel.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/test/commands/payment_term.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/test/commands/price_list.js

@@ -341,7 +341,7 @@ let commandEvent = {
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",
-  sync_id: "9811c42a-d26e-41e0-bee5-e75260c04767",
+  sync_id: "9811c42a-d26e-41e0-bee5-e75260c04767", // should change
   command: "price_list",
 };
 Commands(commandEvent);

package/lib/test/commands/price_list_disabled.js

@@ -353,7 +353,7 @@ let commandEvent = {
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",
-  sync_id: "a7e620b6-c5a2-44f7-b44b-3599b3ea1b54",
+  sync_id: "a7e620b6-c5a2-44f7-b44b-3599b3ea1b54", // should change
   command: "price_list_disabled",
 };
 Commands(commandEvent);

package/lib/test/commands/warehouse.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/util.d.ts

@@ -51,7 +51,7 @@ export declare const updateAt_query: (
 ) => string;
 export declare const get_data_from_sap: (
   _path: string,
-  default_res: any,
+  default_res: any, // if no data was found
   serviceEndPoint: string,
   serviceApiKey: string,
   query?: string
@@ -88,7 +88,7 @@ export declare const getUniqueConcatenatedValues: (
     [promo_id: string]: {
       _id: string;
       name: string;
-      ref?: string | undefined;
+      ref?: string;
     };
   }
 ) => string;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "repzo-sap-absjo",
   "description": "repzo SAP ABS jo integration",
-  "version": "1.0.36",
+  "version": "1.0.37",
   "homepage": "",
   "keywords": [],
   "author": {
@@ -18,16 +18,16 @@
   "directories": {},
   "engines": {},
   "scripts": {
-    "lint": "npx prettier --write .",
+    "lint": "npx --yes prettier --write .",
     "build": "tsc && npm run lint",
     "test": "mocha",
-    "mac": "npm run build && node ./lib/test/commands/***.js"
+    "mac": "npm run build && node ./lib/test/commands/***.js",
+    "prepublishOnly": "npm run build"
   },
   "repository": {
     "type": "git",
     "url": ""
   },
-  "build": "tsc",
   "devDependencies": {
     "@babel/parser": "^7.16.6",
     "@types/lodash": "^4.14.191",
@@ -35,7 +35,7 @@
     "@types/uuid": "^8.3.4",
     "mocha": "^9.1.3",
     "prettier": "^2.5.1",
-    "typescript": "^4.8.4"
+    "typescript": "^5.3.3"
   },
   "dependencies": {
     "@types/aws-lambda": "^8.10.93",
@@ -45,7 +45,7 @@
     "jsonwebtoken": "^8.5.1",
     "lodash": "^4.17.21",
     "moment-timezone": "^0.5.34",
-    "repzo": "^1.0.109",
+    "repzo": "^1.0.152",
     "uuid": "^8.3.2"
   }
 }

package/src/actions/create_invoice.ts

@@ -173,7 +173,7 @@ export const create_invoice = async (event: EVENT, options: Config) => {
       if (item) {
         repzo_tax_ids[item.tax?._id] = true;
         repzo_measureunit_ids[item.measureunit?._id] = true;
-        repzo_product_ids[item.variant?.product_id] = true;
+        repzo_product_ids[item.variant?.product_id as string] = true;
       }
     });
 

package/src/actions/create_proforma.ts

@@ -78,12 +78,25 @@ export const create_proforma = async (event: EVENT, options: Config) => {
     const repzo_proforma: Service.Proforma.ProformaSchema = body;
 
     // Get Repzo Rep
-    let repzo_rep;
+    let repzo_rep: Service.Rep.Get.Result | undefined;
     if (repzo_proforma.creator.type == "rep") {
-      repzo_rep = await repzo.rep.get(repzo_proforma?.creator?._id);
+      repzo_rep = await repzo.rep.get(repzo_proforma?.creator?._id, {
+        populatedKeys: ["warehouse"],
+      });
       if (!repzo_rep)
         throw `Rep with _id: ${repzo_proforma.creator._id} not found in Repzo`;
     }
+    let rep_warehouse_code:
+      | Service.Warehouse.WarehouseSchema["code"]
+      | undefined;
+    if (repzo_rep && repzo_rep?.assigned_warehouse) {
+      rep_warehouse_code = (
+        repzo_rep?.assigned_warehouse as Pick<
+          Service.Warehouse.WarehouseSchema,
+          "_id" | "code"
+        >
+      )?.code;
+    }
 
     // Get Repzo Client
     const repzo_client = await repzo.client.get(repzo_proforma?.client_id);
@@ -98,7 +111,7 @@ export const create_proforma = async (event: EVENT, options: Config) => {
       if (item) {
         repzo_tax_ids[item.tax?._id] = true;
         repzo_measureunit_ids[item.measureunit?._id] = true;
-        repzo_product_ids[item.variant?.product_id] = true;
+        repzo_product_ids[item.variant?.product_id as string] = true;
       }
     });
 
@@ -223,7 +236,8 @@ export const create_proforma = async (event: EVENT, options: Config) => {
       ClientCode: repzo_client.client_code,
       DiscountPerc: "0",
       Note: repzo_proforma.comment,
-      // WarehouseCode: "1",
+      WarehouseCode:
+        rep_warehouse_code || options.data?.defaultWarehouseForSalesOrder, // "1",
       LinesDetails: items,
     };
 

package/src/actions/create_return_invoice.ts

@@ -114,7 +114,7 @@ export const create_return_invoice = async (event: EVENT, options: Config) => {
       if (item) {
         repzo_tax_ids[item.tax?._id] = true;
         repzo_measureunit_ids[item.measureunit?._id] = true;
-        repzo_product_ids[item.variant?.product_id] = true;
+        repzo_product_ids[item.variant?.product_id as string] = true;
       }
     });
 

package/src/commands/client.ts

@@ -204,9 +204,9 @@ export const sync_client = async (commandEvent: CommandEvent) => {
         comment: sap_client.CLIENTNOTE,
         formatted_address: sap_client.CLIENTADDRESSID,
         tags: tag ? [tag._id] : [],
-        credit_limit: sap_client.PAYMENTTERM // sap_client.CLIENTGROUP == "Cash Van"
-          ? credit_limit && Math.round(credit_limit * 1000)
-          : 1000000000,
+        // credit_limit: sap_client.PAYMENTTERM // sap_client.CLIENTGROUP == "Cash Van"
+        //   ? credit_limit && Math.round(credit_limit * 1000)
+        //   : 1000000000,
         financials: {
           credit_limit: sap_client.PAYMENTTERM // sap_client.CLIENTGROUP == "Cash Van"
             ? credit_limit && Math.round(credit_limit * 1000)
@@ -219,6 +219,7 @@ export const sync_client = async (commandEvent: CommandEvent) => {
         payment_type: sap_client.PAYMENTTERM ? "credit" : "cash", // sap_client.CLIENTGROUP == "Cash Van"
         integrated_client_balance:
           client_credit_consumed && Math.round(client_credit_consumed * 1000),
+        company_namespace: [nameSpace],
       };
 
       if (!repzo_client) {

package/src/test/actions/create_proforma.ts

@@ -238,6 +238,7 @@ Actions(
         '[{sap_id:1,sap_name:"BarcodeIssue",repzo_name:"Barcodeissue",repzo_id:"62b074972b332895edf114fc"},{sap_id:2,sap_name:"Damaged",repzo_name:"Damaged",repzo_id:"62b074ace96258fb745982e4"},{sap_id:3,sap_name:"Nearexpiry",repzo_name:"Nearexpiry",repzo_id:"62b074c0a066173bd1c1ea0d"},{sap_id:4,sap_name:"Wrongprinting",repzo_name:"Wrongprinting",repzo_id:"62b074d79e7f41f306a4cb42"},{sap_id:5,sap_name:"experied",repzo_name:"Experied",repzo_id:"62b074faa066173bd1c1eec0"}]',
       SalPersCode: "111",
       SalesPersonCode: "111",
+      defaultWarehouseForSalesOrder: "1",
     },
   }
 );