repzo-sap-absjo 1.0.21 → 1.0.22

package/lib/actions/create_invoice.js

@@ -1,5 +1,5 @@
 import Repzo from "repzo";
-import { _create } from "../util.js";
+import { _create, getUniqueConcatenatedValues } from "../util.js";
 import { v4 as uuid } from "uuid";
 import moment from "moment-timezone";
 export const create_invoice = async (event, options) => {
@@ -288,14 +288,14 @@ export const create_invoice = async (event, options) => {
         Quantity: item.qty,
         TaxCode: repzo_tax.integration_meta.TaxCode,
         UnitPrice: (item.price * repzo_measureunit.factor) / 1000,
-        DiscountPerc: "0",
+        DiscountPerc: "0", // ??
         //@ts-ignore
         LineTotal: item.total_before_tax / 1000,
         UomCode: repzo_measureunit.integration_meta.ALTUOMID,
         Brand:
           (_m = repzo_product.integration_meta) === null || _m === void 0
             ? void 0
-            : _m.BRAND,
+            : _m.BRAND, // "B1", // ??
         Department:
           ((_o =
             repzo_rep === null || repzo_rep === void 0
@@ -369,12 +369,3 @@ export const get_invoice_from_sap = async (serviceEndPoint, query) => {
     throw e;
   }
 };
-function getUniqueConcatenatedValues(item, key, delimiter) {
-  item.general_promotions = item.general_promotions || [];
-  item.used_promotions = item.used_promotions || [];
-  const allPromotions = [...item.general_promotions, ...item.used_promotions];
-  const uniqueValues = new Set(
-    allPromotions.map((promotion) => promotion[key]).filter((value) => value)
-  );
-  return [...uniqueValues].join(delimiter);
-}

package/lib/actions/create_proforma.js

@@ -1,5 +1,5 @@
 import Repzo from "repzo";
-import { _create } from "../util.js";
+import { _create, getUniqueConcatenatedValues } from "../util.js";
 import { v4 as uuid } from "uuid";
 import moment from "moment-timezone";
 export const create_proforma = async (event, options) => {
@@ -222,6 +222,8 @@ export const create_proforma = async (event, options) => {
       if (!repzo_product)
         throw `Product with _id: ${item.measureunit._id} not found in Repzo`;
       items.push({
+        MEO_Serial: getUniqueConcatenatedValues(item, "ref", " | "),
+        Promotion_Name: getUniqueConcatenatedValues(item, "name", " | "),
         ItemCode: item.variant.variant_name,
         Quantity: item.qty,
         TaxCode: repzo_tax.integration_meta.TaxCode,
@@ -252,7 +254,7 @@ export const create_proforma = async (event, options) => {
         ? repzo_rep.integration_id
         : (_q = options.data) === null || _q === void 0
         ? void 0
-        : _q.SalPersCode,
+        : _q.SalPersCode, // "111",
       DocDate: moment(repzo_proforma.issue_date, "YYYY-MM-DD").format(
         "YYYYMMDD"
       ),

package/lib/actions/create_return_invoice.js

@@ -253,7 +253,7 @@ export const create_return_invoice = async (event, options) => {
         Brand:
           (_o = repzo_product.integration_meta) === null || _o === void 0
             ? void 0
-            : _o.BRAND,
+            : _o.BRAND, // "B1",
         Department:
           ((_p =
             repzo_rep === null || repzo_rep === void 0
@@ -263,7 +263,7 @@ export const create_return_invoice = async (event, options) => {
             : _p.DEPARTMENTCODE) ||
           ((_q = options.data) === null || _q === void 0
             ? void 0
-            : _q.DepartmentCode),
+            : _q.DepartmentCode), // "D2"
         Return_Reason:
           item_return_reason === null || item_return_reason === void 0
             ? void 0

package/lib/actions/create_transfer.js

@@ -171,7 +171,7 @@ export const create_transfer = async (event, options) => {
         ? repzo_rep.integration_id
         : (_o = options.data) === null || _o === void 0
         ? void 0
-        : _o.SalesPersonCode,
+        : _o.SalesPersonCode, // "111"
       FromWarehouse: body.from.code,
       ToWarehouse: body.to.code,
       RepzoStockTransferLines: variants,

package/lib/commands/client.js

@@ -231,7 +231,7 @@ export const sync_client = async (commandEvent) => {
         paymentTerm: paymentTerm ? paymentTerm._id : undefined,
         sv_priceList: priceList ? priceList._id : undefined,
         disabled: sap_client.ACTIVE == "Y" ? false : true,
-        payment_type: sap_client.PAYMENTTERM ? "credit" : "cash",
+        payment_type: sap_client.PAYMENTTERM ? "credit" : "cash", // sap_client.CLIENTGROUP == "Cash Van"
         integrated_client_balance:
           client_credit_consumed && Math.round(client_credit_consumed * 1000),
       };

package/lib/commands/measureunit.js

@@ -197,7 +197,7 @@ export const sync_measureunit = async (commandEvent) => {
       const body = {
         parent: repzo_parent_id,
         name: sap_UoM.ALTUOMCODE,
-        factor: sap_UoM.repzo_factor || 0,
+        factor: sap_UoM.repzo_factor || 0, // ??????
         disabled: false,
         integration_meta: {
           id: `${nameSpace}_${sap_UoM.UOMGROUPENTRY}_${sap_UoM.ALTUOMID}`,

package/lib/commands/product.js

@@ -299,7 +299,7 @@ export const sync_product = async (commandEvent) => {
             {
               disabled: false,
               name: sap_product.ITEMCODE,
-              price: 0,
+              price: 0, // Math.round(sap_product.PRICE * 1000),
               integration_meta: {
                 id: `${nameSpace}_${sap_product.ITEMCODE}`,
                 ITEMCODE: sap_product.ITEMCODE,

package/lib/commands/tax.js

@@ -96,7 +96,7 @@ export const sync_tax = async (commandEvent) => {
       const body = {
         name: sap_tax.TaxName,
         rate: Number(sap_tax.TaxRate / 100),
-        type: "additive",
+        type: "additive", // hardcode
         disabled: sap_tax.Inactive === "N" ? false : true,
         integration_meta: {
           id: `${nameSpace}_${sap_tax.TaxCode}`,

package/lib/test/actions/create_invoice.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_invoice",
     headers: {
-      action_sync_id: "Actions-0000001",
+      action_sync_id: "Actions-0000001", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",

package/lib/test/actions/create_payment.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_payment",
     headers: {
-      action_sync_id: "Actions-0000004",
+      action_sync_id: "Actions-0000004", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",

package/lib/test/actions/create_proforma.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_proforma",
     headers: {
-      action_sync_id: "Actions-0000003",
+      action_sync_id: "Actions-0000003", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",

package/lib/test/actions/create_return_invoice.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_return_invoice",
     headers: {
-      action_sync_id: "Actions-0000002",
+      action_sync_id: "Actions-0000002", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",

package/lib/test/actions/create_transfer.js

@@ -6,7 +6,7 @@ Actions(
     rawPath: "/actions",
     rawQueryString: "app=repzo-sap-absjo&action=create_transfer",
     headers: {
-      action_sync_id: "Actions-0000005",
+      action_sync_id: "Actions-0000005", // SYNC_ID
       accept: "*/*",
       "accept-encoding": "gzip, deflate",
       "content-length": "3658",

package/lib/test/commands/brand.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/test/commands/category.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/test/commands/channel.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/test/commands/payment_term.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/test/commands/price_list.js

@@ -341,7 +341,7 @@ let commandEvent = {
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",
-  sync_id: "9811c42a-d26e-41e0-bee5-e75260c04767",
+  sync_id: "9811c42a-d26e-41e0-bee5-e75260c04767", // should change
   command: "price_list",
 };
 Commands(commandEvent);

package/lib/test/commands/price_list_disabled.js

@@ -353,7 +353,7 @@ let commandEvent = {
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",
-  sync_id: "a7e620b6-c5a2-44f7-b44b-3599b3ea1b54",
+  sync_id: "a7e620b6-c5a2-44f7-b44b-3599b3ea1b54", // should change
   command: "price_list_disabled",
 };
 Commands(commandEvent);

package/lib/test/commands/warehouse.js

@@ -87,7 +87,7 @@ let commandEvent = {
     __v: 0,
   },
   end_of_day: "04:00",
-  nameSpace: ["unisap"],
+  nameSpace: ["unisap"], // demosv
   timezone: "Asia/Amman",
   meta: "",
   env: "staging",

package/lib/util.d.ts

@@ -1,5 +1,6 @@
 import Repzo from "repzo";
 import { CommandType } from "./types";
+import { Service } from "repzo/src/types";
 interface Params {
   [key: string]: any;
 }
@@ -79,4 +80,9 @@ export declare const send_command_to_marketplace: ({
   env: "production" | "staging" | "local";
   repzoApiKey: string;
 }) => Promise<void>;
+export declare const getUniqueConcatenatedValues: (
+  item: Service.Item.Schema,
+  key: "name" | "ref",
+  delimiter: string
+) => string;
 export {};

package/lib/util.js

@@ -192,3 +192,12 @@ export const send_command_to_marketplace = async ({
     throw e;
   }
 };
+export const getUniqueConcatenatedValues = function (item, key, delimiter) {
+  item.general_promotions = item.general_promotions || [];
+  item.used_promotions = item.used_promotions || [];
+  const allPromotions = [...item.general_promotions, ...item.used_promotions];
+  const uniqueValues = new Set(
+    allPromotions.map((promotion) => promotion[key]).filter((value) => value)
+  );
+  return [...uniqueValues].join(delimiter);
+};

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "repzo-sap-absjo",
   "description": "repzo SAP ABS jo integration",
-  "version": "1.0.21",
+  "version": "1.0.22",
   "homepage": "",
   "keywords": [],
   "author": {

package/src/actions/create_invoice.ts

@@ -1,6 +1,12 @@
 import Repzo from "repzo";
 import { EVENT, Config } from "../types";
-import { _fetch, _create, _update, _delete } from "../util.js";
+import {
+  _fetch,
+  _create,
+  _update,
+  _delete,
+  getUniqueConcatenatedValues,
+} from "../util.js";
 import { Service } from "repzo/src/types";
 import { v4 as uuid } from "uuid";
 import moment from "moment-timezone";
@@ -325,20 +331,3 @@ export const get_invoice_from_sap = async (
     throw e;
   }
 };
-
-function getUniqueConcatenatedValues(
-  item: Service.Item.Schema,
-  key: "name" | "ref",
-  delimiter: string
-): string {
-  item.general_promotions = item.general_promotions || [];
-  item.used_promotions = item.used_promotions || [];
-  const allPromotions: { name: string; ref?: string; [key: string]: any }[] = [
-    ...item.general_promotions,
-    ...item.used_promotions,
-  ];
-  const uniqueValues = new Set(
-    allPromotions.map((promotion) => promotion[key]).filter((value) => value)
-  );
-  return [...uniqueValues].join(delimiter);
-}

package/src/actions/create_proforma.ts

@@ -1,11 +1,19 @@
 import Repzo from "repzo";
 import { EVENT, Config } from "../types";
-import { _fetch, _create, _update, _delete } from "../util.js";
+import {
+  _fetch,
+  _create,
+  _update,
+  _delete,
+  getUniqueConcatenatedValues,
+} from "../util.js";
 import { Service } from "repzo/src/types";
 import { v4 as uuid } from "uuid";
 import moment from "moment-timezone";
 
 interface SAPProformaItem {
+  MEO_Serial: string; // "INV-1021-4 | 010-LAG-PO0002";
+  Promotion_Name: string; // "INV-1021-4 | 010-LAG-PO0002";
   ItemCode: string; // "010-LAG-PO0002";
   Quantity: number; // 10;
   TaxCode: string; // "S16";
@@ -162,6 +170,8 @@ export const create_proforma = async (event: EVENT, options: Config) => {
         throw `Product with _id: ${item.measureunit._id} not found in Repzo`;
 
       items.push({
+        MEO_Serial: getUniqueConcatenatedValues(item, "ref", " | "),
+        Promotion_Name: getUniqueConcatenatedValues(item, "name", " | "),
         ItemCode: item.variant.variant_name,
         Quantity: item.qty,
         TaxCode: repzo_tax.integration_meta.TaxCode,

package/src/commands/basic.ts

@@ -11,7 +11,7 @@ export const basic = async (commandEvent: CommandEvent) => {
   const commandLog = new Repzo.CommandLog(
     repzo,
     commandEvent.app,
-    commandEvent.command,
+    commandEvent.command
   );
   try {
     // console.log("basic sync");

package/src/commands/price_list_disabled.ts

@@ -35,7 +35,7 @@ export const sync_price_list_disabled = async (commandEvent: CommandEvent) => {
   const commandLog = new Repzo.CommandLog(
     repzo,
     commandEvent.app,
-    commandEvent.command,
+    commandEvent.command
   );
 
   try {
@@ -66,7 +66,7 @@ export const sync_price_list_disabled = async (commandEvent: CommandEvent) => {
     result.repzo_PL_total = repzo_price_lists?.data?.length;
     await commandLog
       .addDetail(
-        `${repzo_price_lists?.data?.length} Active Price Lists in Repzo`,
+        `${repzo_price_lists?.data?.length} Active Price Lists in Repzo`
       )
       .commit();
 
@@ -89,7 +89,7 @@ export const sync_price_list_disabled = async (commandEvent: CommandEvent) => {
         {
           updateAt: "20000101:000000",
           PLDID: sap_price_list_id,
-        },
+        }
       );
 
       result.sap_PL_items_total += sap_price_list_items?.length || 0;
@@ -140,7 +140,7 @@ export const sync_price_list_disabled = async (commandEvent: CommandEvent) => {
           console.log(
             "Disable Price List Item Failed >> ",
             e?.response?.data,
-            repzo_item,
+            repzo_item
           );
           failed_docs_report.push({
             method: "update",
@@ -159,12 +159,12 @@ export const sync_price_list_disabled = async (commandEvent: CommandEvent) => {
       repzo,
       commandEvent.app._id,
       bench_time_key,
-      new_bench_time,
+      new_bench_time
     );
     await commandLog
       .setStatus(
         "success",
-        failed_docs_report.length ? failed_docs_report : null,
+        failed_docs_report.length ? failed_docs_report : null
       )
       .setBody(result)
       .commit();
@@ -179,13 +179,13 @@ export const sync_price_list_disabled = async (commandEvent: CommandEvent) => {
 
 const get_sap_price_list = async (
   serviceEndPoint: string,
-  query?: { updateAt?: string; PLDID?: string },
+  query?: { updateAt?: string; PLDID?: string }
 ): Promise<SAPPriceListItem[]> => {
   try {
     const sap_price_lists: SAPPriceListItems = await _create(
       serviceEndPoint,
       "/PriceList",
-      { UpdateAt: query?.updateAt, PLDID: query?.PLDID },
+      { UpdateAt: query?.updateAt, PLDID: query?.PLDID }
     );
     return sap_price_lists.PriceList;
   } catch (e: any) {

package/src/util.ts

@@ -2,7 +2,7 @@ import axios from "axios";
 import Repzo from "repzo";
 import moment from "moment-timezone";
 import { CommandType } from "./types";
-
+import { Service } from "repzo/src/types";
 interface Params {
   [key: string]: any;
 }
@@ -241,3 +241,20 @@ export const send_command_to_marketplace = async ({
     throw e;
   }
 };
+
+export const getUniqueConcatenatedValues = function (
+  item: Service.Item.Schema,
+  key: "name" | "ref",
+  delimiter: string
+): string {
+  item.general_promotions = item.general_promotions || [];
+  item.used_promotions = item.used_promotions || [];
+  const allPromotions: { name: string; ref?: string; [key: string]: any }[] = [
+    ...item.general_promotions,
+    ...item.used_promotions,
+  ];
+  const uniqueValues = new Set(
+    allPromotions.map((promotion) => promotion[key]).filter((value) => value)
+  );
+  return [...uniqueValues].join(delimiter);
+};