repository-provider 35.5.16 → 35.6.1

package/package.json

@@ -1,10 +1,11 @@
 {
   "name": "repository-provider",
-  "version": "35.5.16",
+  "version": "35.6.1",
   "publishConfig": {
     "access": "public",
     "provenance": true
   },
+  "packageManager": "npm@11.6.0+sha512.77f3fb0dbbd881835d7bd1217deabdf7ed77fc4ec4f363df64fc3cb986404abf6c437661041080f5c5d225103508e7c9ea30cb2742b7e942675d05a10af2d7b9",
   "types": "./types/index.d.mts",
   "exports": {
     ".": {
@@ -37,21 +38,21 @@
     "lint:typescript": "tsc --allowJs --checkJs --noEmit --resolveJsonModule --target esnext -m esnext --module nodenext --moduleResolution nodenext ./src**/*.mjs"
   },
   "dependencies": {
-    "content-entry": "^14.2.4",
+    "content-entry": "^14.2.5",
     "matching-iterator": "^2.1.4",
-    "pacc": "^4.9.1"
+    "pacc": "^4.39.0"
   },
   "devDependencies": {
     "ava": "^6.4.1",
-    "browser-ava": "^2.3.31",
+    "browser-ava": "^2.3.34",
     "c8": "^10.1.3",
     "documentation": "^14.0.3",
-    "repository-provider-test-support": "^3.1.52",
-    "semantic-release": "^24.2.7",
+    "repository-provider-test-support": "^4.0.0",
+    "semantic-release": "^24.2.9",
     "typescript": "^5.9.2"
   },
   "engines": {
-    "node": ">=22.18.0"
+    "node": ">=22.19.5"
   },
   "repository": {
     "type": "git",

package/src/base-object.mjs

@@ -1,8 +1,8 @@
 import {
-  definePropertiesFromOptions,
-  mapAttributes
-} from "./attribute-extras.mjs";
-import { description_attribute, id_attribute } from "pacc";
+  definePropertiesFromAttributes,
+  description_attribute,
+  id_attribute
+} from "pacc";
 
 /**
  * Creates an instance of BaseObject.
@@ -52,12 +52,6 @@ export class BaseObject {
     );
   }
 
-  /**
-   * Map attributes between external and internal representation.
-   * @return {Object}
-   */
-  static attributeMapping = {};
-
   /** @type {string} */ id;
   /** @type {string} */ description;
 
@@ -66,10 +60,9 @@ export class BaseObject {
    * @param {Object} [options]
    * @param {string} [options.id]
    * @param {string} [options.description]
-   * @param {Object} [additionalProperties]
    */
-  constructor(options, additionalProperties) {
-    this.updateAttributes(options, additionalProperties);
+  constructor(options) {
+    this.updateAttributes(options);
   }
 
   /**
@@ -77,13 +70,8 @@ export class BaseObject {
    * @param {Object} [options]
    * @param {Object} [additionalProperties]
    */
-  updateAttributes(options, additionalProperties) {
-    definePropertiesFromOptions(
-      this,
-      // @ts-ignore
-      mapAttributes(options, this.constructor.attributeMapping),
-      additionalProperties
-    );
+  updateAttributes(options) {
+    definePropertiesFromAttributes(this, this.constructor.attributes, options);
   }
 
   /**

package/src/base-provider.mjs

@@ -1,8 +1,10 @@
 import {
+  manadatoryAttributesPresent,
+  environmentValues,
   url_attribute,
-  name_attribute,
+  name_attribute_writable,
   priority_attribute,
-  default_attribute
+  object_attribute
 } from "pacc";
 import { asArray, stripBaseName } from "./util.mjs";
 import { PullRequest } from "./pull-request.mjs";
@@ -58,65 +60,6 @@ export class BaseProvider extends BaseObject {
     return "";
   }
 
-  /**
-   * Extract options suitable for the constructor.
-   * Form the given set of environment variables.
-   * Object with the detected key value pairs is delivered.
-   * @param {Object} [env] as from process.env
-   * @param {string} instanceIdentifier part of variable name.
-   * @return {Object|undefined} undefined if no suitable environment variables have been found
-   */
-  static optionsFromEnvironment(
-    env,
-    instanceIdentifier = this.instanceIdentifier
-  ) {
-    let options;
-
-    if (env !== undefined) {
-      const attributes = this.attributes;
-
-      for (let [envName, value] of Object.entries(env)) {
-        for (const [name, attribute] of Object.entries(attributes)) {
-          if (
-            asArray(attribute.env).find(
-              e =>
-                e.replace(
-                  "{{instanceIdentifier}}",
-                  () => instanceIdentifier
-                ) === envName
-            )
-          ) {
-            options ??= {};
-
-            if (options[name] === undefined) {
-              options[name] = value;
-              Object.assign(options, attribute.additionalAttributes);
-            }
-            break;
-          }
-        }
-      }
-    }
-    return options;
-  }
-
-  /**
-   * Check if given options are sufficient to create a provider.
-   * @param {Object} options
-   * @return {boolean} true if options ar sufficient to construct a provider
-   */
-  static areOptionsSufficcient(options) {
-    for (const [name, attribute] of Object.entries(this.attributes).filter(
-      ([name, attribute]) => attribute.mandatory
-    )) {
-      if (options[name] === undefined) {
-        return false;
-      }
-    }
-
-    return true;
-  }
-
   static attributes = {
     ...BaseObject.attributes,
 
@@ -124,7 +67,7 @@ export class BaseProvider extends BaseObject {
      * Name of the provider.
      */
     name: {
-      ...name_attribute,
+      ...name_attribute_writable,
       env: "{{instanceIdentifier}}NAME"
     },
 
@@ -135,8 +78,7 @@ export class BaseProvider extends BaseObject {
      * To forward info/warn and error messages to
      */
     messageDestination: {
-      ...default_attribute,
-      type: "object",
+      ...object_attribute,
       default: console,
       writable: true,
       private: true
@@ -163,10 +105,14 @@ export class BaseProvider extends BaseObject {
   static initialize(options, env) {
     options = {
       ...options,
-      ...this.optionsFromEnvironment(env, options?.instanceIdentifier)
+      ...environmentValues(
+        env,
+        this.attributes,
+        options?.instanceIdentifier ?? this.instanceIdentifier
+      )
     };
 
-    if (this.areOptionsSufficcient(options)) {
+    if (manadatoryAttributesPresent(options, this.attributes)) {
       return new this(options);
     }
   }

package/src/hook.mjs

@@ -2,8 +2,9 @@ import {
   secret_attribute,
   boolean_attribute,
   active_attribute,
-  url_attribute,
-  string_attribute
+  url_attribute_writable,
+  string_attribute_writable,
+  string_collection_attribute_writable
 } from "pacc";
 import { OwnedObject } from "./owned-object.mjs";
 
@@ -17,12 +18,23 @@ export class Hook extends OwnedObject {
     ...super.attributes,
     active: active_attribute,
     secret: secret_attribute,
-    url: { ...url_attribute, description: "target url", writable: true },
-    content_type: { ...string_attribute, default: "json", writable: true },
+    url: { ...url_attribute_writable, description: "target url" },
+    content_type: { ...string_attribute_writable, default: "json" },
     insecure_ssl: boolean_attribute,
-    events: { type: "set", default: this.defaultEvents }
+    events: {
+      ...string_collection_attribute_writable,
+      default: this.defaultEvents
+    }
   };
 
+  set events(value) {
+    this._events = new Set(value);
+  }
+
+  get events() {
+    return this._events;
+  }
+
   static get addMethodName() {
     return "_addHook";
   }

package/src/index.mjs

@@ -18,5 +18,4 @@ export * from "./hook.mjs";
 export * from "./milestone.mjs";
 export * from "./review.mjs";
 export * from "./application.mjs";
-export * from "./attribute-extras.mjs";
 export * from "./util.mjs";

package/src/milestone.mjs

@@ -1,4 +1,4 @@
-import { state_attribute } from "pacc";
+import { state_attribute_writable } from "pacc";
 import { OwnedObject } from "./owned-object.mjs";
 
 /**
@@ -6,7 +6,7 @@ import { OwnedObject } from "./owned-object.mjs";
 export class Milestone extends OwnedObject {
   static attributes = {
     ...super.attributes,
-    state: state_attribute
+    state: state_attribute_writable
   };
 
   async *issues() {}

package/src/named-object.mjs

@@ -1,5 +1,4 @@
-import { name_attribute } from "pacc";
-import { optionJSON } from "./attribute-extras.mjs";
+import { getAttributesJSON, name_attribute_writable } from "pacc";
 import { BaseObject } from "./base-object.mjs";
 
 /**
@@ -16,24 +15,15 @@ import { BaseObject } from "./base-object.mjs";
 export class NamedObject extends BaseObject {
   static attributes = {
     ...BaseObject.attributes,
-    name: name_attribute
+    name: name_attribute_writable
   };
 
-  constructor(name, options, additionalProperties) {
-    super(options, {
-      name: { value: name },
-      ...additionalProperties
-    });
-  }
-
-  /** @type {string} */ #name;
-
-  get name() {
-    return this.#name;
-  }
+  name;
 
-  set name(name) {
-    this.#name = name;
+  constructor(name, options) {
+    delete options?.name; // TODO
+    super(options);
+    this.name = name;
   }
 
   /**
@@ -77,9 +67,7 @@ export class NamedObject extends BaseObject {
   /**
    * Provided name and all defined attributes.
    */
-  toJSON() {
-    return optionJSON(this, {
-      name: this.name
-    });
+  toJSON(filter) {
+    return { ...getAttributesJSON(this, this.constructor.attributes, filter), name: this.name };
   }
 }

package/src/owned-object.mjs

@@ -29,8 +29,8 @@ export class OwnedObject extends NamedObject {
 
   owner;
 
-  constructor(owner, name, options, additionalProperties) {
-    super(name, options, additionalProperties);
+  constructor(owner, name, options) {
+    super(name, options);
     this.owner = owner;
     // @ts-ignore
     owner[this.constructor.addMethodName](this);

package/src/pull-request.mjs

@@ -1,12 +1,15 @@
 import {
+  getAttributesJSON,
+  attributeIterator,
   url_attribute,
-  state_attribute,
-  body_attribute,
-  title_attribute,
+  state_attribute_writable,
+  body_attribute_writable,
+  title_attribute_writable,
   boolean_attribute_false,
-  empty_attribute
+  boolean_attribute_writable_false,
+  empty_attribute,
+  types
 } from "pacc";
-import { optionJSON } from "./attribute-extras.mjs";
 import { OwnedObject } from "./owned-object.mjs";
 import { Branch } from "./branch.mjs";
 import { Repository } from "./repository.mjs";
@@ -94,8 +97,8 @@ export class PullRequest extends OwnedObject {
 
   static attributes = {
     ...super.attributes,
-    body: body_attribute,
-    title: title_attribute,
+    body: body_attribute_writable,
+    title: title_attribute_writable,
     url: url_attribute,
 
     /**
@@ -106,7 +109,7 @@ export class PullRequest extends OwnedObject {
      * @return {string}
      */
     state: {
-      ...state_attribute,
+      ...state_attribute_writable,
       default: "OPEN",
       values: this.states
     },
@@ -115,7 +118,7 @@ export class PullRequest extends OwnedObject {
      * Locked state of the pull request.
      * @return {boolean}
      */
-    locked: boolean_attribute_false,
+    locked: boolean_attribute_writable_false,
 
     /**
      * Merged state of the pull request.
@@ -127,44 +130,41 @@ export class PullRequest extends OwnedObject {
      * Draft state of the pull request.
      * @return {boolean}
      */
-    draft: boolean_attribute_false,
+    draft: boolean_attribute_writable_false,
     dry: boolean_attribute_false,
     empty: empty_attribute
   };
 
   /** @type {Branch} */ source;
 
-  constructor(source, owner, name, options) {
-    let state = "OPEN";
-
-    super(owner, name, options, {
-      state: {
-        set(value) {
-          value = value.toUpperCase();
-          // @ts-ignore
-          if (this.constructor.attributes.state.values.has(value)) {
-            state = value;
-          } else throw new Error(`Invalid Pull Request state ${value}`);
-        },
-        get() {
-          return state;
-        }
-      },
-      merged: {
-        set(value) {
-          if (value) {
-            state = "MERGED";
-          }
-        },
-        get() {
-          return state === "MERGED";
-        }
-      }
-    });
+  _state = "OPEN";
 
+  constructor(source, owner, name, options) {
+    super(owner, name, options);
     this.source = source;
   }
 
+  set state(value) {
+    value = value.toUpperCase();
+    if (this.constructor.attributes.state.values.has(value)) {
+      this._state = value;
+    } else throw new Error(`Invalid Pull Request state ${value}`);
+  }
+
+  get state() {
+    return this._state;
+  }
+
+  set merged(value) {
+    if (value) {
+      this.state = "MERGED";
+    }
+  }
+
+  get merged() {
+    return this.state === "MERGED";
+  }
+
   get destination() {
     return this.owner;
   }
@@ -237,31 +237,34 @@ export class PullRequest extends OwnedObject {
 
   toString() {
     return [
-      // @ts-ignore
       [this.name, this.title],
       ["source", this.source?.identifier],
       ["destination", this.owner.identifier],
-      // @ts-ignore
-      ...Object.entries(this.constructor.attributes)
-        .filter(
-          ([k, v]) =>
-            !v.isKey &&
-            v.type !== "url" &&
-            k !== "title" &&
-            k !== "body" &&
-            this[k] !== undefined
+      ...[
+        ...attributeIterator(
+          this.constructor.attributes,
+          (name, attribute) =>
+            !attribute.isKey &&
+            attribute.type !== types.url &&
+            name !== "title" &&
+            name !== "body" &&
+            this[name] !== undefined
         )
-        .map(([k]) => [k, this[k]])
+      ].map(([path, attribute]) => {
+        const name = path.join(".");
+        return [name, this[name]];
+      })
     ]
-      .map(([k, v]) => `${k}: ${v}`)
-      .join(", ");
+      .map(([name, value]) => `${name}:${value}`)
+      .join(",");
   }
 
-  toJSON() {
-    return optionJSON(this, {
+  toJSON(filter) {
+    return {
+      ...getAttributesJSON(this, this.constructor.attributes, filter),
       source: this.source,
       destination: this.owner
-    });
+    };
   }
 
   /**

package/src/ref.mjs

@@ -1,4 +1,4 @@
-import { name_attribute, boolean_attribute_writable_false } from "pacc";
+import { name_attribute_writable, boolean_attribute_writable_false } from "pacc";
 import { ContentEntry } from "content-entry";
 import { OwnedObject } from "./owned-object.mjs";
 
@@ -16,17 +16,13 @@ export class Ref extends OwnedObject {
    * @type {Object}
    */
   static attributes = {
-    name: name_attribute,
+    name: name_attribute_writable,
 
     /**
      * Can the ref be modified.
      * @return {boolean}
      */
-    isProtected: boolean_attribute_writable_false
-  };
-
-  static attributeMapping = {
-    protected: "isProtected"
+    isProtected: {...boolean_attribute_writable_false, externalName: "protected" }
   };
 
   get refType() {

package/src/repository-group.mjs

@@ -1,4 +1,4 @@
-import { url_attribute, url_attribute_writble, boolean_attribute, type_attribute } from "pacc";
+import { url_attribute, url_attribute_writable, boolean_attribute, type_attribute } from "pacc";
 import { RepositoryOwner } from "./repository-owner.mjs";
 import { OwnedObject } from "./owned-object.mjs";
 import { BaseProvider } from "./base-provider.mjs";
@@ -46,14 +46,9 @@ export class RepositoryGroup extends RepositoryOwner(OwnedObject) {
      * The url of home page.
      * @return {string}
      */
-    homePageURL: url_attribute_writble
+    homePageURL: url_attribute_writable
   };
 
-  /**
-   * Map attributes between external and internal representation.
-   */
-  static attributeMapping() {}
-
   get isAdmin() {
     return false;
   }

package/src/repository.mjs

@@ -1,8 +1,8 @@
 import {
-  string_attribute,
+  string_attribute_writable,
   url_attribute,
-  boolean_attribute,
-  boolean_attribute_false
+  boolean_attribute_false,
+  boolean_attribute_writable_false
 } from "pacc";
 import { matcher } from "matching-iterator";
 import { ContentEntry } from "content-entry";
@@ -56,16 +56,18 @@ export class Repository extends OwnedObject {
      * @return {string}
      */
     defaultBranchName: {
-      ...string_attribute,
-      default: Repository.defaultBranchName
+      ...string_attribute_writable,
+      default: this.defaultBranchName,
+      externalName: "default_branch"
     },
 
     cloneURL: url_attribute,
-    isArchived: boolean_attribute,
-    isLocked: boolean_attribute,
-    isDisabled: boolean_attribute,
-    isTemplate: boolean_attribute,
-    isFork: boolean_attribute_false
+    isArchived: { ...boolean_attribute_writable_false, externalName: "archived" },
+    isLocked: { ...boolean_attribute_writable_false, externalName: "locked" },
+    isDisabled: { ...boolean_attribute_writable_false, externalName: "disabled" },
+    isTemplate: { ...boolean_attribute_writable_false, externalName: "template" },
+    isFork: { ...boolean_attribute_false, externalName: "fork" },
+    isPrivate: { ...boolean_attribute_writable_false, externalName: "private" }
   };
 
   /** @type {Map<string,Branch>} */ #branches = new Map();
@@ -85,14 +87,12 @@ export class Repository extends OwnedObject {
    * @param {Object} [options]
    * @param {string} [options.id]
    * @param {string} [options.description]
-   * @param {Object} [additionalProperties]
    */
-  constructor(owner, name, options, additionalProperties) {
+  constructor(owner, name, options) {
     super(
       owner,
       owner.normalizeRepositoryName(name, false),
-      options,
-      additionalProperties
+      options
     );
   }
 
@@ -113,7 +113,7 @@ export class Repository extends OwnedObject {
   }
 
   get defaultBranchName() {
-    return Repository.defaultBranchName;
+    return this.constructor.defaultBranchName;
   }
 
   /**

package/types/base-object.d.mts

@@ -34,22 +34,16 @@ export class BaseObject {
      * @return {Object} writable attributes
      */
     static get writableAttributes(): any;
-    /**
-     * Map attributes between external and internal representation.
-     * @return {Object}
-     */
-    static attributeMapping: {};
     /**
      * Creates an instance of BaseObject.
      * @param {Object} [options]
      * @param {string} [options.id]
      * @param {string} [options.description]
-     * @param {Object} [additionalProperties]
      */
     constructor(options?: {
         id?: string;
         description?: string;
-    }, additionalProperties?: any);
+    });
     /** @type {string} */ id: string;
     /** @type {string} */ description: string;
     /**
@@ -57,7 +51,7 @@ export class BaseObject {
      * @param {Object} [options]
      * @param {Object} [additionalProperties]
      */
-    updateAttributes(options?: any, additionalProperties?: any): void;
+    updateAttributes(options?: any): void;
     /**
      * Save object attributes in the backing store.
      */